{"id":2216037,"url":"http://patchwork.ozlabs.org/api/patches/2216037/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260325165431.1027591-13-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325165431.1027591-13-sjg@chromium.org>","list_archive_url":null,"date":"2026-03-25T16:54:21","name":"[12/13] boot: Drop unnecessary data variable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d2646cff1b6f022ca4deef43f066256955d38a95","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260325165431.1027591-13-sjg@chromium.org/mbox/","series":[{"id":497475,"url":"http://patchwork.ozlabs.org/api/series/497475/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=497475","date":"2026-03-25T16:54:09","name":"boot: Make fit_image_load() easier to maintain","version":1,"mbox":"http://patchwork.ozlabs.org/series/497475/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216037/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216037/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=P+78WT/T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"P+78WT/T\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgtPM3SbQz1y1K\n\tfor ; Thu, 26 Mar 2026 03:57:27 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1413683F60;\n\tWed, 25 Mar 2026 17:56:01 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 0D942840A9; Wed, 25 Mar 2026 17:56:00 +0100 (CET)","from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com\n [IPv6:2607:f8b0:4864:20::22f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id DDC7083F14\n for ; Wed, 25 Mar 2026 17:55:57 +0100 (CET)","by mail-oi1-x22f.google.com with SMTP id\n 5614622812f47-4670676ba03so4154b6e.1\n for ; Wed, 25 Mar 2026 09:55:57 -0700 (PDT)","from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-46a7099df08sm30481b6e.15.2026.03.25.09.55.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 09:55:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1774457756; x=1775062556; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YPZrYSxXbZ+OmQTMVIZsw9ndLdvsZe1NNg3On48OkS8=;\n b=P+78WT/Tei/iI2ketJKVgTApfSUqGflvqomNlusVuLzKt4uKrMZspdkkGbhER3DkhI\n ecb2l/KCKNi61tfv2HljvvbXUdvf/JVrkWeufAnmfmP2nq05xmdrfgNXmHHyM1wKCxQN\n sYmUi+vm1O1EEDVmhUebrbv7KF22obFhw3Y5Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774457756; x=1775062556;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=YPZrYSxXbZ+OmQTMVIZsw9ndLdvsZe1NNg3On48OkS8=;\n b=ljoFNHDm6m6sBfct7HkzvXE33eMALVdT1YdcPRNkjfl2LnuiN0SE/q4NFZDQGbBasr\n 0YLwbstgSWButBF3GFm4xedeMA7E/phZV+4DzKB8Xnjq04ma1MIBZ69EmR+1Ujc8u5wI\n 96J6FWg/7AQnFCZY6Nf3NeVpamE59c+qIbePVBaYTKaS/DsRKg8SmujQghkqf73cZBDW\n sj8dTpwvFvVlnhTQfvPXJTHDKcfL/6UMV3zl9lDLucFj4zix0ffx3QH+ORtsowCraV02\n oJRWDKbRT8GR4+ErbjX9rmkhFyMkXJebj24FetFy5Is2uROHeuiwoU5OoFui/ZpVcXMo\n Z1pA==","X-Gm-Message-State":"AOJu0Yyc3NP4HWVEGF+EHyMJQMmX1chVkk6L/ggfbtutfdRRPSMFp9FI\n 076nvlt2HWdfYEuOplK0QrkkZ/LCbV2cYP2YtmLxVuXrXAflpPFi/zm79wAxEsfRiZMhx4qmhe/\n YtOWx7g==","X-Gm-Gg":"ATEYQzwNcXaPN77Nw4fclALgEU9EIJymFQRaNrNODBRxo/gg7Qh9vjjoteOJkKWwis+\n jr3gUwUE2NLTC+qBLdbld22x2wkjIPep5KcHAymaNQhKFr22wF9K3UCGCYdsiUva0VwyxudXwRf\n b0CwUzlqe4kaAI6+v7TjdqfZs8lI+M0N2QkuLaOKOUuuMV59vE93+rcZaMzlm9dzYdgUTm7xRrU\n kCp0Al4KW4IfntYfN+TuiIuaODjUS+G6PDcTDoEfK4XbBp+ZFmTPNbuL/QKm78BK5P9GFLSdGRm\n 3BdFYml003zHgG8ItIL9IwU+7Gig6xp3d0rV+UMhJn2OsvcwrvTu/wEB3igyRab56JqAD3M2qMp\n OxffGGB/WSMYG8nceMB2ixhMIsp6xig/JRaPYSS5VS6Jgi0COuo7UmrQ6CClQbdBZZryjJt/MxB\n LUVwIHz3g8Ng6stjLaKw==","X-Received":"by 2002:a05:6808:8897:b0:46a:6d33:65a8 with SMTP id\n 5614622812f47-46a6d3365ccmr367368b6e.32.1774457755548;\n Wed, 25 Mar 2026 09:55:55 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Simon Glass ,\n James Hilliard ,\n Marek Vasut ,\n Quentin Schulz , Tom Rini ","Subject":"[PATCH 12/13] boot: Drop unnecessary data variable","Date":"Wed, 25 Mar 2026 10:54:21 -0600","Message-ID":"<20260325165431.1027591-13-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260325165431.1027591-1-sjg@chromium.org>","References":"<20260325165431.1027591-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"This is always the same as 'buf' and is not needed by the caller. Drop\nthe return of this value from handle_load_op().\n\nSigned-off-by: Simon Glass \n---\n\n boot/image-fit.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/boot/image-fit.c b/boot/image-fit.c\nindex 749cbe19ade..34876b66fa0 100644\n--- a/boot/image-fit.c\n+++ b/boot/image-fit.c\n@@ -2407,7 +2407,6 @@ static int decomp_image(const void *fit, int noffset, const char *prop_name,\n * @image_type: Type of the image\n * @load_op: Load operation to process\n * @bootstage_id: ID of starting bootstage to use for progress updates\n- * @datap: Returns buf\n * @loadp: Returns the address where the data was loaded\n * @sizep: On entry, the size of the image in bytes. Updated if decompressed\n * Return: 0 if OK, -ve on error\n@@ -2415,7 +2414,7 @@ static int decomp_image(const void *fit, int noffset, const char *prop_name,\n static int handle_load_op(const void *fit, int noffset, const char *prop_name,\n \t\t\t void *buf, ulong size, enum image_type_t image_type,\n \t\t\t enum fit_load_op load_op, int bootstage_id,\n-\t\t\t ulong *datap, ulong *loadp, ulong *sizep)\n+\t\t\t ulong *loadp, ulong *sizep)\n {\n \tulong data, load, load_end;\n \tint ret;\n@@ -2462,7 +2461,6 @@ static int handle_load_op(const void *fit, int noffset, const char *prop_name,\n \tif (ret)\n \t\treturn ret;\n \n-\t*datap = data;\n \t*loadp = load;\n \n \treturn 0;\n@@ -2480,7 +2478,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n \tconst char *fit_base_uname_config;\n \tconst void *fit;\n \tvoid *buf;\n-\tulong load, data, len;\n+\tulong load, len;\n \tconst char *prop_name;\n \tint ret;\n \n@@ -2507,7 +2505,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n \t\treturn ret;\n \n \tret = handle_load_op(fit, noffset, prop_name, buf, len, image_type,\n-\t\t\t load_op, bootstage_id, &data, &load, &len);\n+\t\t\t load_op, bootstage_id, &load, &len);\n \tif (ret)\n \t\treturn ret;\n \n","prefixes":["12/13"]}