{"id":2216036,"url":"http://patchwork.ozlabs.org/api/patches/2216036/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260325164130.29060-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325164130.29060-1-fw@strlen.de>","list_archive_url":null,"date":"2026-03-25T16:41:27","name":"[nf] netfilter: nf_tables: reject requests exceeding NF_FLOW_RULE_ACTION_MAX actions","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"6cd6e9f5fec6c767bad6054f7c26ac38e7553e00","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260325164130.29060-1-fw@strlen.de/mbox/","series":[{"id":497476,"url":"http://patchwork.ozlabs.org/api/series/497476/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497476","date":"2026-03-25T16:41:27","name":"[nf] netfilter: nf_tables: reject requests exceeding NF_FLOW_RULE_ACTION_MAX actions","version":1,"mbox":"http://patchwork.ozlabs.org/series/497476/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216036/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216036/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11411-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgtPH6NK2z1y1K\n\tfor ; Thu, 26 Mar 2026 03:57:23 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id CA584318D82E\n\tfor ; Wed, 25 Mar 2026 16:42:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 258513F788E;\n\tWed, 25 Mar 2026 16:42:00 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 52A0C3BED0C\n\tfor ; Wed, 25 Mar 2026 16:41:58 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 0A5716080C; Wed, 25 Mar 2026 17:41:56 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774456919; cv=none;\n b=kIvn30I7UL/rRvlNX+Nmp7TX8sOfJFw8mYL9NbzM8V54ndpxxgOit7HC3bCjfxxuOdL3In84m9BzDddo+9dhppI3wnOlRZzKkNvinA6+Eqk2GioBqliKR++NYr6BLOb0SFaT6jGXJAltqpJj9bMgcysBTiv/AX8pLH4fkE4Pbe0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774456919; c=relaxed/simple;\n\tbh=JY2glMILN4+/CG1ObBikjiO/jIVgnDBytAotRygH+Oo=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Dkc5F5OHh1hvQgUxrmzkk6sf4TFc8qO7/0Nj0z0NqmmjRNX/xQjq6PGR3QXnPWFggvWv9YMEnclaphUmUPezNlNhAj7mGk1k1zhegM1GBUg2VgrNO7r7TRM//NWY4+wFzes8OmoJgD4ZR0JvsSLJVEOfQbenpWMd6FDAp7NxIOc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Florian Westphal ,\n\tHyunwoo Kim ","Subject":"[PATCH nf] netfilter: nf_tables: reject requests exceeding\n NF_FLOW_RULE_ACTION_MAX actions","Date":"Wed, 25 Mar 2026 17:41:27 +0100","Message-ID":"<20260325164130.29060-1-fw@strlen.de>","X-Mailer":"git-send-email 2.52.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"nf_flow_offload_rule_alloc() allocates space for NF_FLOW_RULE_ACTION_MAX\nentries. Make sure userspace passes more entries to us.\n\nReported-by: Hyunwoo Kim \nSigned-off-by: Florian Westphal \n---\n Can also route via nf-next if thats deemed the better tree.\n\n include/net/netfilter/nf_flow_table.h | 2 ++\n net/netfilter/nf_flow_table_offload.c | 2 --\n net/netfilter/nf_tables_offload.c | 5 +++--\n 3 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/include/net/netfilter/nf_flow_table.h b/include/net/netfilter/nf_flow_table.h\nindex b09c11c048d5..0b2fb1467b3f 100644\n--- a/include/net/netfilter/nf_flow_table.h\n+++ b/include/net/netfilter/nf_flow_table.h\n@@ -13,6 +13,8 @@\n #include \n #include \n \n+#define NF_FLOW_RULE_ACTION_MAX\t16\n+\n struct nf_flowtable;\n struct nf_flow_rule;\n struct flow_offload;\ndiff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c\nindex 9b677e116487..11463682bbfa 100644\n--- a/net/netfilter/nf_flow_table_offload.c\n+++ b/net/netfilter/nf_flow_table_offload.c\n@@ -727,8 +727,6 @@ int nf_flow_rule_route_ipv6(struct net *net, struct flow_offload *flow,\n }\n EXPORT_SYMBOL_GPL(nf_flow_rule_route_ipv6);\n \n-#define NF_FLOW_RULE_ACTION_MAX\t16\n-\n static struct nf_flow_rule *\n nf_flow_offload_rule_alloc(struct net *net,\n \t\t\t const struct flow_offload_work *offload,\ndiff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c\nindex 9101b1703b52..a2f7966bc201 100644\n--- a/net/netfilter/nf_tables_offload.c\n+++ b/net/netfilter/nf_tables_offload.c\n@@ -88,10 +88,11 @@ static void nft_flow_rule_transfer_vlan(struct nft_offload_ctx *ctx,\n struct nft_flow_rule *nft_flow_rule_create(struct net *net,\n \t\t\t\t\t const struct nft_rule *rule)\n {\n+\tunsigned int num_actions = 0;\n \tstruct nft_offload_ctx *ctx;\n \tstruct nft_flow_rule *flow;\n-\tint num_actions = 0, err;\n \tstruct nft_expr *expr;\n+\tint err;\n \n \texpr = nft_expr_first(rule);\n \twhile (nft_expr_more(rule, expr)) {\n@@ -102,7 +103,7 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net,\n \t\texpr = nft_expr_next(expr);\n \t}\n \n-\tif (num_actions == 0)\n+\tif (num_actions == 0 || num_actions > NF_FLOW_RULE_ACTION_MAX)\n \t\treturn ERR_PTR(-EOPNOTSUPP);\n \n \tflow = nft_flow_rule_alloc(num_actions);\n","prefixes":["nf"]}