{"id":2216022,"url":"http://patchwork.ozlabs.org/api/patches/2216022/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325164453.72127-15-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325164453.72127-15-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-03-25T16:44:48","name":"[PULL,14/19] whpx: i386: fetch segments on-demand","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"41fab9c5edcc5b33c7840783a84484a6aefbf7da","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325164453.72127-15-pbonzini@redhat.com/mbox/","series":[{"id":497473,"url":"http://patchwork.ozlabs.org/api/series/497473/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497473","date":"2026-03-25T16:44:34","name":"[PULL,01/19] tests/functional: preserve PYTHONPATH entries","version":1,"mbox":"http://patchwork.ozlabs.org/series/497473/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216022/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216022/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=T3e+dMX0;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=a4O+iwd+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgt9W4HxXz1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 03:47:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5RMP-0005A3-CY; Wed, 25 Mar 2026 12:45:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w5RML-00050Q-0l\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:45:33 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1w5RMF-0004fw-Lj\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:45:30 -0400","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-509-PETlQdw2OXCRUONf7NU0aA-1; Wed, 25 Mar 2026 12:45:24 -0400","by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-48553fdd03dso420885e9.0\n for <qemu-devel@nongnu.org>; Wed, 25 Mar 2026 09:45:24 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4871e6aeef4sm6495635e9.9.2026.03.25.09.45.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 09:45:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774457125;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=n6sdL1vsVWO3ZuG6mgc20dg8BLq/JVi1oEu7UYtVDpI=;\n b=T3e+dMX0z0mBp1nF3MSq2/Cl0CtlXbX0N5sVssDfHJECTIMDCu5BpV9VIrbkppGKiegZXy\n XhqOIlUqX2PAYgQGbJHTdBRQ18Zmhk9+WGDfXG95c4kPccQBSVfVSEBWBkV8EgChFnFrms\n ooIUREMGeUECnnk/7XlDWFxiby1Zd20=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774457122; x=1775061922; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=n6sdL1vsVWO3ZuG6mgc20dg8BLq/JVi1oEu7UYtVDpI=;\n b=a4O+iwd+UT8pQlSnOoe7hDZJ2b26MdKzkl7K6cN+24R8PxBJNo3PQ+qbeug7WwKxsh\n Noe6W2Ram1Gg5Uu+qsJtChR4VBZn17F4Nd12MH/M9xz9sJjonIf3MH7a3nH0oYnK5oiV\n XdRqMoG63wvpT7TTSCXqrgqug5iFDArzzwEo0dWE97ff/kZCY4ME1qVS8vwLdbB77u3/\n TB6Ak1P8hkwyG2sRtFFnH+Q5vTffuPOAElES6bhpcMgNFqPgGAhc9XauYaXO7kxG5sZh\n H3yCv0HtFwU7wD7nbEDiOdn5RuotxkipVEQEFQcJvXnvLjv6Omr1HoYUZBH+QtIQ1HWe\n eqOw=="],"X-MC-Unique":"PETlQdw2OXCRUONf7NU0aA-1","X-Mimecast-MFC-AGG-ID":"PETlQdw2OXCRUONf7NU0aA_1774457123","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774457122; x=1775061922;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=n6sdL1vsVWO3ZuG6mgc20dg8BLq/JVi1oEu7UYtVDpI=;\n b=Mil2yJyVoxkHAN8CyoO6jK1KPVWAxObSLqlCL9IXHdjFVTxk05qPmS3vlAXyMrT64I\n TB/4UQV6qgMc/RU59tpbVHNxeVcbwHrHr7QCgJ3boY0YrCdV39OCNoZqyir4+1XAPLRR\n YV+kiCOYd0DwxLKkM+0UC4bu8y6Qb/bfo4kM6hAWwauMm3zmO6V6SsUGgbkdjuswxzY8\n 5KrAQpIHdYpvx7s+Xy/4oDauIGenDuQ5USt1emGDpvZiTHAWnXK2X/eSi3gjNny0VgKr\n dZAuAKR7Shk3ETfngNAsWuFUAM6PV//Rsz0JZV3qul5dJAV4xtK2lKfB7Zeb1DU0MaCB\n DBTA==","X-Gm-Message-State":"AOJu0YxhwKNbJznrsYCAt80HZn6twzQDZryUFx6wOQIsUEgOEsyuW+jN\n AYP+1Ya5CDeRg655BxsOoxItYAgB05LYIQBF7celxTEIcsPFEHhbIfxp5Oc59jeHoernQUdDiS9\n n3lv3IZf9wqJ3fI032B7WTYetAPxI2MmCeHNMWMKd4e9iK/nR40FUCrBrYkl0r7hJQmlQq6sK6D\n b7z1xP13vyVzT+66Q6PepfdmwlNNf8FaVfovgCEBGR","X-Gm-Gg":"ATEYQzxMMTR4dr1X4ap8RJZ8v2HosukdGn+UortMapsVNnfqcREuC+MnHv/fvSvgBfX\n xWU6bZlsBB36m2b8wkQJ0/UsHEHD1STOLPg854s6NgFGKFSP9RlLqjHcEQ8xOknVqvdxyBNrrjr\n A5ujjG7SCMHQ6BqQ9p6GklN38Jn1X7PysecrVjkKSbmNfBR2vtv4n5x4hZ6nz4tsMohIldugJxP\n a3ABII3OtWnxE28GC0RGsVfasCzP2PjcdIYm/4IzJRVf4WCvctsu6riX4jrUpWXXE8nfcR6UtO7\n Qnw1llAM09GWvIU5UIwJNWDOFrZTSbyyTWfiiFEJLNu4kWHb4NZ4nq3NgG6ULjsHJ0dueE2Up0x\n Rkjgts1ADn4F7iFuQ3TGNCka+fPqt6FOm/+d833E0JFDeM7RYsN4NxZ4xNjdPz2WuuBLmSfGukG\n onRgnsBknf51PXOKfnRAdpYygY","X-Received":["by 2002:a05:600c:8489:b0:485:6e40:5584 with SMTP id\n 5b1f17b1804b1-48715fc38femr60002615e9.6.1774457121826;\n Wed, 25 Mar 2026 09:45:21 -0700 (PDT)","by 2002:a05:600c:8489:b0:485:6e40:5584 with SMTP id\n 5b1f17b1804b1-48715fc38femr60002095e9.6.1774457121265;\n Wed, 25 Mar 2026 09:45:21 -0700 (PDT)"],"From":"Paolo Bonzini <pbonzini@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Mohamed Mediouni <mohamed@unpredictable.fr>","Subject":"[PULL 14/19] whpx: i386: fetch segments on-demand","Date":"Wed, 25 Mar 2026 17:44:48 +0100","Message-ID":"<20260325164453.72127-15-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260325164453.72127-1-pbonzini@redhat.com>","References":"<20260325164453.72127-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Mohamed Mediouni <mohamed@unpredictable.fr>\n\nInstead of save/restore, fetch segments dynamically.\n\nRely on the fetched state instead of loading from memory.\n\nOr, if available, on the VM exit context.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\nLink: https://lore.kernel.org/r/20260324151323.74473-12-mohamed@unpredictable.fr\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n target/i386/whpx/whpx-all.c | 71 +++++++++++++++++++++++++++++++------\n 1 file changed, 60 insertions(+), 11 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 71b33a632ac..6f232786422 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -868,21 +868,70 @@ static int whpx_handle_portio(CPUState *cpu,\n     return 0;\n }\n \n+static void whpx_segment_to_x86_descriptor(CPUState *cpu, WHV_X64_SEGMENT_REGISTER* reg,\n+                                   struct x86_segment_descriptor *desc)\n+{\n+    uint32_t limit;\n+    desc->g = reg->Granularity;\n+\n+    /*\n+     * Hyper-V can return reg->Granularity == 0\n+     * with a higher limit than 0xfffff.\n+     *\n+     * Detect that case and set desc->g\n+     * with shifting the limit properly.\n+     */\n+    if (!desc->g && reg->Limit <= 0xfffff) {\n+        limit = reg->Limit;\n+    } else {\n+        limit = (reg->Limit >> 12);\n+        desc->g = 1;\n+    }\n+\n+    x86_set_segment_limit(desc, limit);\n+    x86_set_segment_base(desc, reg->Base);\n+\n+    desc->type = reg->SegmentType;\n+    desc->s = reg->NonSystemSegment;\n+    desc->dpl = reg->DescriptorPrivilegeLevel;\n+    desc->p = reg->Present;\n+    desc->avl = reg->Available;\n+    desc->l = reg->Long;\n+    desc->db = reg->Default;\n+}\n+\n+static void whpx_read_segment_descriptor(CPUState *cpu, WHV_X64_SEGMENT_REGISTER* reg,\n+                                    X86Seg seg)\n+{\n+    AccelCPUState *vcpu = cpu->accel;\n+    WHV_REGISTER_NAME reg_name = WHvX64RegisterEs + seg;\n+    WHV_REGISTER_VALUE val;\n+\n+    if (seg == R_CS) {\n+        *reg = vcpu->exit_ctx.VpContext.Cs;\n+        return;\n+    }\n+    if (vcpu->exit_ctx.ExitReason == WHvRunVpExitReasonX64IoPortAccess) {\n+        if (seg == R_DS) {\n+            *reg = vcpu->exit_ctx.IoPortAccess.Ds;\n+            return;\n+        } else if (seg == R_ES) {\n+            *reg = vcpu->exit_ctx.IoPortAccess.Es;\n+            return;\n+        }\n+    }\n+\n+    whpx_get_reg(cpu, reg_name, &val);\n+    *reg = val.Segment;\n+}\n+\n static void read_segment_descriptor(CPUState *cpu,\n                                     struct x86_segment_descriptor *desc,\n                                     enum X86Seg seg_idx)\n {\n-    bool ret;\n-    X86CPU *x86_cpu = X86_CPU(cpu);\n-    CPUX86State *env = &x86_cpu->env;\n-    SegmentCache *seg = &env->segs[seg_idx];\n-    x86_segment_selector sel = { .sel = seg->selector & 0xFFFF };\n-\n-    ret = x86_read_segment_descriptor(cpu, desc, sel);\n-    if (ret == false) {\n-        error_report(\"failed to read segment descriptor\");\n-        abort();\n-    }\n+    WHV_X64_SEGMENT_REGISTER reg;\n+    whpx_read_segment_descriptor(cpu, &reg, seg_idx);\n+    whpx_segment_to_x86_descriptor(cpu, &reg, desc);\n }\n \n static bool is_protected_mode(CPUState *cpu)\n","prefixes":["PULL","14/19"]}