{"id":2216015,"url":"http://patchwork.ozlabs.org/api/patches/2216015/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325164453.72127-17-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325164453.72127-17-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-03-25T16:44:50","name":"[PULL,16/19] hw/audio/sb16: validate VMState fields in post_load","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"86d060bb68585ed289880dc869a8504f8803731d","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325164453.72127-17-pbonzini@redhat.com/mbox/","series":[{"id":497473,"url":"http://patchwork.ozlabs.org/api/series/497473/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497473","date":"2026-03-25T16:44:34","name":"[PULL,01/19] tests/functional: preserve PYTHONPATH entries","version":1,"mbox":"http://patchwork.ozlabs.org/series/497473/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216015/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216015/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=D2WnCvSb;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=QsUI1zNf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgt8s43MZz1xy3\n\tfor ; Thu, 26 Mar 2026 03:46:37 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5RMQ-0005AW-7n; Wed, 25 Mar 2026 12:45:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5RMO-00059c-UZ\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:45:36 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5RMK-0004gP-Pq\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:45:35 -0400","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-695-E_4u33v2NtGe4cU8-qnNSQ-1; Wed, 25 Mar 2026 12:45:28 -0400","by mail-wr1-f71.google.com with SMTP id\n ffacd0b85a97d-43b8cb800f5so1256319f8f.1\n for ; Wed, 25 Mar 2026 09:45:28 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b91942f24sm1174717f8f.11.2026.03.25.09.45.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 09:45:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774457130;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=3AkzjVoFkHIfZOrj/YsNsJ8NaWzRuqCtr/53yzsJlxY=;\n b=D2WnCvSbZjtAb3/3zZnLlat6kElGjbMdM2uE9v4piQVBILTHeqX77SYq7RbRT9KjhMClOb\n RqLpHs+Z0L1S5tZ2uVPDOUGUvY3xYu7k68dqjObRBcdPFzO8qRwBWZmKhzptHmI87lqDgg\n Fzwp9ahx0gvkqPZPZ/+E1+5GLAHP030=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774457126; x=1775061926; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3AkzjVoFkHIfZOrj/YsNsJ8NaWzRuqCtr/53yzsJlxY=;\n b=QsUI1zNfu3cBX+PnthXGfW4/p6zFQS/xtkZy47l9NFUSN/PcA6htYW6Rk7nLL90a17\n UcUpJT1FwJpLo61+Tsd7VxCsmWnWjR/p2mCrlgvWDymr8H/KftFPgAO5dPKtrGPqz7vh\n IiwwjxeINYjJNEBnkB9LMZKOOVF2rE3zt6mCVHI8a78cv9e6sNMSbDE9AyNLrLNi9u5h\n +AI6cm/6p2tPuDC7RHfY0xyL/zkZUUEUjK9cTs7atKoynE9OnA6x6uyF0xuDjuWyKt6U\n pVUijYvG25jyOopjGqHKCmGKCw7jwmOFm8tB2sNi1Sa8Ok63YGA2bjv5B43ZrDzszhoE\n 0u/w=="],"X-MC-Unique":"E_4u33v2NtGe4cU8-qnNSQ-1","X-Mimecast-MFC-AGG-ID":"E_4u33v2NtGe4cU8-qnNSQ_1774457127","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774457126; x=1775061926;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=3AkzjVoFkHIfZOrj/YsNsJ8NaWzRuqCtr/53yzsJlxY=;\n b=kevnAihXvUN5/SSE67dpKBI3J1LnBkV5jCgxoEpEzDAwEcozOxaORM2ODNSmM2Xk4U\n GMdLES34f7F7QDR7D/xT2zUpIbT4tM62q1nDS8T7RP88JzRb/fPkylAFfKnDjd4p2YSw\n MZhLSlNYfsiWxjQQbtTWz38kRvRZ7+ee4DDOSNoGeh3mzKDrfbpUNny2fSrX9MIDt2/Z\n KErUiWZZFV7KXlVUjtycYjao+2dGCSQa7b5xax1+qZGbf6teu2VXi9x2oIsXuXf0WDMh\n R0SZocpjfAZfhmIDCcC6yfmuUN6HHzJikcctPaeD5BZ2KNk9f4I8ucyJlM0H6FgQT1M1\n dJrQ==","X-Gm-Message-State":"AOJu0YxS1eslxi3N+z0gnavGfPgQSHogn2dboTw3OTAzzioB/VRDsR6p\n iyrHDFV8l+7++woPpqgoAqoauVwHI/k/PAqhliBf8KIfsCKR8QppWOE5vYOvIc5cinW4RIhFO6w\n R76924Y9UNkBjabI2aOpqpxEUXylO7HP1B/DRzCCoSW8d93QILajdAqo/gqfy9Ugv9VvLv2JGzV\n AN/wXDqFOOtLQUmk7ecuM8ndAoWqcXZUjDs74XO6hO","X-Gm-Gg":"ATEYQzwC4ilWCTrPljq14gWhLXiCYYbt8C8WLxif8+XNxOdzzioUbhobd3j6wHo+EjP\n qv3WcMg+cM3fOhlNFVhHdkIBfSoRg9fYnL0IMok0rTeuohtuBrzKcC3k6R5HnTVRO0c1bh5CMl4\n eABIPhZWvXp1pMu8wQiXcKJggUrH14R4izblS8WgbefMLMrlwZjPgC4Gr4ndyVqW+X6GZ6Odk1A\n s5pxw5QVLdlh72NiPIn3EiGPw28tDcf8NLffrIIORNYUwSnnoYDf36LUD2LkZ49aXrGRUlmG8oU\n RWL/nqwpiSNAop1ajLfy415swA4Z2H+r952fThabG1YQYUsJnxqFMAMzBy8EJVZouKCMWazNhvp\n eXU3IIt5/k1S5czIYlp99aSXl7/qIAxuOXYk2622KXskSYib4Ljo43Rra8rlTP9NuHBDgcGJwdr\n AHYlrZ4yiDDMR/IDcg5rk7iZB0","X-Received":["by 2002:a05:6000:2c06:b0:43b:633b:da88 with SMTP id\n ffacd0b85a97d-43b88a1aa65mr5929264f8f.36.1774457126224;\n Wed, 25 Mar 2026 09:45:26 -0700 (PDT)","by 2002:a05:6000:2c06:b0:43b:633b:da88 with SMTP id\n ffacd0b85a97d-43b88a1aa65mr5929207f8f.36.1774457125545;\n Wed, 25 Mar 2026 09:45:25 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"Jenny Guanni Qu ,\n\tqemu-stable@nongnu.org","Subject":"[PULL 16/19] hw/audio/sb16: validate VMState fields in post_load","Date":"Wed, 25 Mar 2026 17:44:50 +0100","Message-ID":"<20260325164453.72127-17-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260325164453.72127-1-pbonzini@redhat.com>","References":"<20260325164453.72127-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Jenny Guanni Qu \n\nThe SB16 VMState loads in_index and out_data_len as raw INT32\nvalues with no bounds validation. A crafted migration stream or\nVM snapshot can set these to values exceeding their respective\nbuffer sizes (in2_data[10] and out_data[50]), causing heap OOB\nwrite in dsp_write() and heap OOB read in dsp_read().\n\nAdd bounds checks in sb16_post_load() to reject invalid values\nbefore they can be used as array indices.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/3326\nReported-by: Jenny Guanni Qu \nSigned-off-by: Jenny Guanni Qu \nLink: https://lore.kernel.org/r/20260318192918.65481-1-qguanni@gmail.com\nCc: qemu-stable@nongnu.org\nSigned-off-by: Paolo Bonzini \n---\n hw/audio/sb16.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c\nindex 1b5e452a29b..1838d3ef7bd 100644\n--- a/hw/audio/sb16.c\n+++ b/hw/audio/sb16.c\n@@ -1286,6 +1286,13 @@ static int sb16_post_load (void *opaque, int version_id)\n {\n SB16State *s = opaque;\n \n+\n+ if (s->in_index < 0 || s->in_index > (int)sizeof(s->in2_data)) {\n+ return -1;\n+ }\n+ if (s->out_data_len < 0 || s->out_data_len > (int)sizeof(s->out_data)) {\n+ return -1;\n+ }\n if (s->voice) {\n audio_be_close_out(s->audio_be, s->voice);\n s->voice = NULL;\n","prefixes":["PULL","16/19"]}