{"id":2215996,"url":"http://patchwork.ozlabs.org/api/patches/2215996/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260325154714.102467-1-rbranco@suse.de/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325154714.102467-1-rbranco@suse.de>","list_archive_url":null,"date":"2026-03-25T15:47:13","name":"[v2] userfaultfd: Minor fixes","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"48e4937668c89e4243b8176c75b28605a2c80766","submitter":{"id":92484,"url":"http://patchwork.ozlabs.org/api/people/92484/?format=json","name":"Ricardo Branco","email":"rbranco@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260325154714.102467-1-rbranco@suse.de/mbox/","series":[{"id":497468,"url":"http://patchwork.ozlabs.org/api/series/497468/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=497468","date":"2026-03-25T15:47:13","name":"[v2] userfaultfd: Minor fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/497468/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215996/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2215996/checks/","tags":{},"related":[],"headers":{"Return-Path":"<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=ddYT2mLy;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.de\n header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=/fAvgy7p;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa\n header.b=cRyPinCS;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=QGytza/j;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgrrf67X9z1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:47:30 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 671D73E3000\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 16:47:28 +0100 (CET)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 36EEE3C2C33\n for <ltp@lists.linux.it>; Wed, 25 Mar 2026 16:47:25 +0100 (CET)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 929F91A007E3\n for <ltp@lists.linux.it>; Wed, 25 Mar 2026 16:47:24 +0100 (CET)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id ED3894D22F;\n Wed, 25 Mar 2026 15:47:16 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C893A44496;\n Wed, 25 Mar 2026 15:47:16 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 1r+UL4QDxGnnGwAAD6G6ig\n (envelope-from <rbranco@suse.de>); Wed, 25 Mar 2026 15:47:16 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774453638;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=Dga3VmpTQwCPm/YGGkK558jVz3od1j5R/JKwFuLUMwM=;\n b=ddYT2mLyRc87p8lpGmc/Iz7/CBD9jhAvE2ZsGgW/FsuEQov9JMINTbuLTj0ZtJ3AKJGGCT\n 4cQTUk1jc6oqc2xGgOWm+mi+NeC7Ra3qgjbp2tRgU8dRKmDq/mzNhtlYm9zzjViH0+doYz\n tSl4SrZOR3ruFDdnjpsQ9XhARtNpEEg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774453638;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=Dga3VmpTQwCPm/YGGkK558jVz3od1j5R/JKwFuLUMwM=;\n b=/fAvgy7pv/L3rBlQsuGauLohCTWA+QUujL24AeFd4V9lTW0WS0GOvM+MVE5ESWojUEbjvN\n 6eYkZI4XWmXWAWCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774453636;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=Dga3VmpTQwCPm/YGGkK558jVz3od1j5R/JKwFuLUMwM=;\n b=cRyPinCS1q/HmbHIuKDvKzXOWkCGtkxo/m5FgJPcKWGM0tB+uUcj//aHgYDzoKO8SwSFKv\n CUgblZ3t23pr6ihjS03lZ9f6vKMMXif7kDRr7HWE+DF0NCDv0pKbvNDWCXdWQjCTGWOJ49\n h8lOqhawy1e4Mb8qYRZuyrxdIL7cxyA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774453636;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=Dga3VmpTQwCPm/YGGkK558jVz3od1j5R/JKwFuLUMwM=;\n b=QGytza/j1JUHN3/5gCAUAf0Evspy70/umVeG1/ehfKkBzAaI96LISwBhURfgqaxokGpXoZ\n uBBL+yDfSiBGRBCw=="],"From":"Ricardo Branco <rbranco@suse.de>","To":"ltp@lists.linux.it","Date":"Wed, 25 Mar 2026 16:47:13 +0100","Message-ID":"<20260325154714.102467-1-rbranco@suse.de>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email,\n imap1.dmz-prg2.suse.org:helo, suse.cz:email]","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v2] userfaultfd: Minor fixes","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project <ltp.lists.linux.it>","List-Unsubscribe":"<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>","List-Archive":"<http://lists.linux.it/pipermail/ltp/>","List-Post":"<mailto:ltp@lists.linux.it>","List-Help":"<mailto:ltp-request@lists.linux.it?subject=help>","List-Subscribe":"<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>"},"content":"- Use POSIX semantics for thread function\n- Set cleanup to call reset_pages\n\nSigned-off-by: Ricardo Branco <rbranco@suse.de>\nReviewed-by: Petr Vorel <pvorel@suse.cz>\n---\n .../kernel/syscalls/userfaultfd/userfaultfd01.c      | 10 +++++++---\n .../kernel/syscalls/userfaultfd/userfaultfd02.c      | 10 +++++++---\n .../kernel/syscalls/userfaultfd/userfaultfd03.c      | 12 ++++++++----\n .../kernel/syscalls/userfaultfd/userfaultfd04.c      |  8 ++++++--\n .../kernel/syscalls/userfaultfd/userfaultfd05.c      | 10 +++++++---\n .../kernel/syscalls/userfaultfd/userfaultfd06.c      |  2 +-\n 6 files changed, 36 insertions(+), 16 deletions(-)","diff":"diff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd01.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd01.c\nindex 7368d3863..b481e5a15 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd01.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd01.c\n@@ -53,11 +53,14 @@ static void set_pages(void)\n \n static void reset_pages(void)\n {\n-\tSAFE_MUNMAP(page, page_size);\n-\tSAFE_MUNMAP(copy_page, page_size);\n+\tif (page) {\n+\t\tSAFE_MUNMAP(page, page_size);\n+\t\tSAFE_MUNMAP(copy_page, page_size);\n+\t\tpage = NULL;\n+\t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_copy uffdio_copy = {};\n@@ -129,4 +132,5 @@ static struct tst_test test = {\n \t.setup = setup,\n \t.test = run,\n \t.tcnt = ARRAY_SIZE(tcases),\n+\t.cleanup = reset_pages,\n };\ndiff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c\nindex 2fd5ba5d8..bedb5d080 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c\n@@ -32,11 +32,14 @@ static void set_pages(void)\n \n static void reset_pages(void)\n {\n-\tSAFE_MUNMAP(page, page_size);\n-\tSAFE_MUNMAP(move_page, page_size);\n+\tif (page) {\n+\t\tSAFE_MUNMAP(page, page_size);\n+\t\tSAFE_MUNMAP(move_page, page_size);\n+\t\tpage = NULL;\n+\t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_move uffdio_move = {};\n@@ -94,4 +97,5 @@ static void run(void)\n static struct tst_test test = {\n \t.test_all = run,\n \t.min_kver = \"6.8\",\n+\t.cleanup = reset_pages,\n };\ndiff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd03.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd03.c\nindex b65f39eca..463dfba0b 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd03.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd03.c\n@@ -57,11 +57,14 @@ static void set_pages(void)\n \n static void reset_pages(void)\n {\n-\tSAFE_MUNMAP(page, page_size);\n-\tSAFE_MUNMAP(copy_page, page_size);\n+\tif (page) {\n+\t\tSAFE_MUNMAP(page, page_size);\n+\t\tSAFE_MUNMAP(copy_page, page_size);\n+\t\tpage = NULL;\n+\t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_copy uffdio_copy = {};\n@@ -132,5 +135,6 @@ static struct tst_test test = {\n \t.needs_kconfigs = (const char *[]) {\n \t\t\"CONFIG_USERFAULTFD=y\",\n \t\tNULL\n-\t}\n+\t},\n+\t.cleanup = reset_pages,\n };\ndiff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd04.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd04.c\nindex 4eb811e45..3273d20cb 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd04.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd04.c\n@@ -30,10 +30,13 @@ static void set_pages(void)\n \n static void reset_pages(void)\n {\n-\tSAFE_MUNMAP(page, page_size);\n+\tif (page) {\n+\t\tSAFE_MUNMAP(page, page_size);\n+\t\tpage = NULL;\n+\t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_zeropage uffdio_zeropage = {};\n@@ -98,4 +101,5 @@ static void run(void)\n \n static struct tst_test test = {\n \t.test_all = run,\n+\t.cleanup = reset_pages,\n };\ndiff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd05.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd05.c\nindex e25a227cf..4434f9b9f 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd05.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd05.c\n@@ -33,10 +33,13 @@ static void set_pages(void)\n \n static void reset_pages(void)\n {\n-\tSAFE_MUNMAP(page, page_size);\n+\tif (page) {\n+\t\tSAFE_MUNMAP(page, page_size);\n+\t\tpage = NULL;\n+\t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_writeprotect uffdio_writeprotect = {};\n@@ -127,5 +130,6 @@ static struct tst_test test = {\n \t.needs_kconfigs = (const char *[]) {\n \t\t\"CONFIG_HAVE_ARCH_USERFAULTFD_WP=y\",\n \t\tNULL\n-\t}\n+\t},\n+\t.cleanup = reset_pages,\n };\ndiff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd06.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd06.c\nindex 5b1252c35..238556ba4 100644\n--- a/testcases/kernel/syscalls/userfaultfd/userfaultfd06.c\n+++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd06.c\n@@ -58,7 +58,7 @@ static void reset_pages(void)\n \t}\n }\n \n-static void *handle_thread(void)\n+static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n \tstatic struct uffd_msg msg;\n \tstruct uffdio_poison uffdio_poison = {};\n","prefixes":["v2"]}