{"id":2215980,"url":"http://patchwork.ozlabs.org/api/patches/2215980/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260325143555.451852-14-herve.codina@bootlin.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325143555.451852-14-herve.codina@bootlin.com>","list_archive_url":null,"date":"2026-03-25T14:35:40","name":"[v6,13/27] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dc7eca1192d6ac00aca7c685b2c2cd32c83a4037","submitter":{"id":81983,"url":"http://patchwork.ozlabs.org/api/people/81983/?format=json","name":"Herve Codina","email":"herve.codina@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260325143555.451852-14-herve.codina@bootlin.com/mbox/","series":[{"id":497454,"url":"http://patchwork.ozlabs.org/api/series/497454/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=497454","date":"2026-03-25T14:35:29","name":"lan966x pci device: Add support for SFPs","version":6,"mbox":"http://patchwork.ozlabs.org/series/497454/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215980/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215980/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=MrK9dIcM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34149-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"MrK9dIcM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.171.202.116","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgrXL0Gv0z1xy3\n\tfor ; Thu, 26 Mar 2026 02:33:22 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 99462318C672\n\tfor ; Wed, 25 Mar 2026 14:41:39 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4E63C3E6DF7;\n\tWed, 25 Mar 2026 14:40:14 +0000 (UTC)","from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 676A53DE43F;\n\tWed, 25 Mar 2026 14:40:12 +0000 (UTC)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id 0CA0DC580B1;\n\tWed, 25 Mar 2026 14:40:39 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 439E0601E2;\n\tWed, 25 Mar 2026 14:40:11 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 0FB7610451411;\n\tWed, 25 Mar 2026 15:39:50 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774449614; cv=none;\n b=Yf5V3Flo4nP0L3A1h2eG8+4kzG7cfcEFOvQX8GthGApydjHgR4JJ4/QKiYlph8st+TT5oG/6fKCGpBK3/gUvxlY8NRop2XpYYFx94Z4lwszlXQYIBHWJR8SQEu4etrJqFhJuS60EI4CAxkzjykfOrVrMoF1GTg8ZLjcPIgLTIRQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774449614; c=relaxed/simple;\n\tbh=4h2yYuYVfm6Oq6yHMs3qtFJ1/EsJ3+lJviBvaZ2hC1s=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=L25C0Zt9jdmNNhNioneoUA/Go/EAp2PI93Hge+kic8aWQ+09W4i+x5hehTUkZ9Ec5xfjqFs0xmvjwg12/cYGnUnzs+h9zxKbrS5eMBSezE8vXCEQWHbeLDT1gbEgU3K+Xz4jvvIBUqWQJfjOxI0nQzCrENVIAnniStY4eM0HSm8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=MrK9dIcM; arc=none smtp.client-ip=185.171.202.116","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1774449608; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=mvCVCaNxt5yWvSG+f0bAkdIRx8+iR7I3Ow45RsOxmKI=;\n\tb=MrK9dIcMrVe+4aMbBhoK26i9Myy9Bd30M/z/mLvQ5EbG2m6o9Cmv+XowQedso0iQ6bu4Mc\n\t8R5AvdQurBVRcZxr4ogmaBzdiL+i2sRquAbr8x8/tsYtgIZDHTWoGMNjhgOvJyleRe9S5S\n\tHBiRuE92Eb+gADSZrfDFw/43cO2zuO4h79wJkelLVfb1mM7v7mXwBKiaPMKmpWv+xON9Nt\n\thiLOXACUxLPoUbMk77U3hBM21cXykPj4GVit0F/fHea1FYnRi7GlUtcYersOVq5Y2wwFW4\n\tG66y5Vyp4OxdMIOKkSaYmkVJ+5RNI6/JC367WikuDduX2NCCsqpPsH1lMWL8Hw==","From":"Herve Codina ","To":"Andrew Lunn ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley ,\n\tGeert Uytterhoeven ,\n\tKalle Niemi ,\n\tMatti Vaittinen ,\n\tGreg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich ,\n\tFrank Li ,\n\tSascha Hauer ,\n\tPengutronix Kernel Team ,\n\tFabio Estevam ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tAndi Shyti ,\n\tWolfram Sang ,\n\tPeter Rosin ,\n\tArnd Bergmann ,\n\tHerve Codina ,\n\tSaravana Kannan ,\n\tBjorn Helgaas ,\n\tCharles Keepax ,\n\tRichard Fitzgerald ,\n\tDavid Rhodes ,\n\tLinus Walleij ,\n\tUlf Hansson ,\n\tMark Brown ,\n\tLen Brown ,\n\tAndy Shevchenko ,\n\tDaniel Scally ,\n\tHeikki Krogerus ,\n\tSakari Ailus ,\n\tDavidlohr Bueso ,\n\tJonathan Cameron ,\n\tDave Jiang ,\n\tAlison Schofield ,\n\tVishal Verma ,\n\tIra Weiny ,\n\tDan Williams ,\n\tShawn Guo ","Cc":"Wolfram Sang ,\n\tlinux-kernel@vger.kernel.org,\n\tdriver-core@lists.linux.dev,\n\timx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-clk@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-sound@vger.kernel.org,\n\tpatches@opensource.cirrus.com,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-pm@vger.kernel.org,\n\tlinux-spi@vger.kernel.org,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-cxl@vger.kernel.org,\n\tAllan Nielsen ,\n\tHoratiu Vultur ,\n\tSteen Hegelund ,\n\tLuca Ceresoli ,\n\tThomas Petazzoni ","Subject":"[PATCH v6 13/27] PCI: of: Remove fwnode_dev_initialized() call for a\n PCI root bridge node","Date":"Wed, 25 Mar 2026 15:35:40 +0100","Message-ID":"<20260325143555.451852-14-herve.codina@bootlin.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260325143555.451852-1-herve.codina@bootlin.com>","References":"<20260325143555.451852-1-herve.codina@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3"},"content":"During the instantiation of devices described by a device-tree overlay\napplied on a PCI device, devlink displays the following kind of debug\nmessages instead of creating the expected links:\n 'Not linking xxxx - might never become dev'\n\nWithout those expected links, the device removal order cannot be\ncorrect.\n\nThose debug traces are printed by fw_devlink_create_devlink(). In our\nuse case, they are all printed because the supplier of the link has at\nleast one of its ancestor with its fwnode flag FWNODE_FLAG_INITIALIZED\nset.\n\nThe culprit ancestor is the PCI root bridge.\n\nThe fwnode related to the PCI root bridge is created dynamically by the\nof_pci_make_host_bridge_node() function. During this creation\nfwnode_dev_initialized() is called which set the FWNODE_FLAG_INITIALIZED\nflag.\n\nCalling fwnode_dev_initialized() tells devlink that the device related\nto this node is handled out of the driver core. This is not correct in\nour case. Indeed the device related to this firmware node is handled\nusing driver core mechanisms and is fully compliant devlink\nexpectations.\n\nSimply remove the fwnode_dev_initialized() call. With that done, the\ndevlink debug messages are no more displayed and links that were missing\nare correctly created.\n\nSigned-off-by: Herve Codina \n---\n drivers/pci/of.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/drivers/pci/of.c b/drivers/pci/of.c\nindex b694fcda16b1..0993257fe025 100644\n--- a/drivers/pci/of.c\n+++ b/drivers/pci/of.c\n@@ -811,7 +811,6 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)\n \t */\n \tof_node_set_flag(np, OF_POPULATED);\n \tfw_devlink_set_device(&np->fwnode, &bridge->dev);\n-\tfwnode_dev_initialized(&np->fwnode, true);\n \n \tret = of_changeset_apply(cset);\n \tif (ret)\n","prefixes":["v6","13/27"]}