{"id":2215905,"url":"http://patchwork.ozlabs.org/api/patches/2215905/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260325144445.3100-1-gerris.rs@gmail.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325144445.3100-1-gerris.rs@gmail.com>","list_archive_url":null,"date":"2026-03-25T14:44:44","name":"[gccrs,COMMIT] Remove redundant expand visitor overloads","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7061b2f230f93c7cc5c2350963ef61f5d93f90db","submitter":{"id":92092,"url":"http://patchwork.ozlabs.org/api/people/92092/?format=json","name":null,"email":"gerris.rs@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260325144445.3100-1-gerris.rs@gmail.com/mbox/","series":[{"id":497457,"url":"http://patchwork.ozlabs.org/api/series/497457/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=497457","date":"2026-03-25T14:44:44","name":"[gccrs,COMMIT] Remove redundant expand visitor overloads","version":1,"mbox":"http://patchwork.ozlabs.org/series/497457/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215905/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215905/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=nLaG7/lX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=nLaG7/lX","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.160.176"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgqVG403bz1xy3\n\tfor ; Thu, 26 Mar 2026 01:46:30 +1100 (AEDT)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 93D284BB5889\n\tfor ; Wed, 25 Mar 2026 14:46:28 +0000 (GMT)","from mail-qt1-f176.google.com (mail-qt1-f176.google.com\n [209.85.160.176])\n by sourceware.org (Postfix) with ESMTPS id A2BDE4BB58E3\n for ; Wed, 25 Mar 2026 14:44:47 +0000 (GMT)","by mail-qt1-f176.google.com with SMTP id\n d75a77b69052e-5091d71aa11so12305951cf.1\n for ; Wed, 25 Mar 2026 07:44:47 -0700 (PDT)","from\n runnervm46oaq.waqj2igf0bnehavxy3b4j2vbqa.ex.internal.cloudapp.net\n ([64.236.135.7]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50b9215ad1bsm242071cf.11.2026.03.25.07.44.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 07:44:46 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 93D284BB5889","OpenDKIM Filter v2.11.0 sourceware.org A2BDE4BB58E3"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org A2BDE4BB58E3","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org A2BDE4BB58E3","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774449887; cv=none;\n b=SIsfMHIOwr9ySdCu7nyx5BVxrVNf7G44oaV6/412wC/C0dGmFminVMLtbDOr4X0OFN2UZyPTgH6bzUVHAaR0NKrFHAUXDHkMZ7mhY2EGUOxyNjWXTdmxbRckI/dXST5XQbf9sk6sR4CiPntogm2YnXn0SSPD/7qrFBd7tKOaT6o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774449887; c=relaxed/simple;\n bh=WAYaDlKAGEvgeY1x3sNws3pjW+ILQ9SDEA0YYnbA/f0=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=DZpY2TNnmh3i4hwlYwGpDn3mbQv+W+jpyDhlAQVBEeTIvKyNojE3rvkeI2NW9F+tViUheSbphWU61ubIuVomd/fu+ifHlf/tSwTw37MOE2aj174pAaJFgmnVjSzbJW1JJUOCRnk6kpzIjzkvoNhe3NiDeDxoQqFY8pzEyPfsF/0=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774449887; x=1775054687; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=8KTolxFhqKE3llXw2wPlg/bv3X/6bKxly7DkwaZHnFY=;\n b=nLaG7/lXF3E8OqBuZzBpObchNEo63oEQVsXNgxxaOpbDfWOzIF7xZoTgp+wRL6u5lW\n VT4seij1L9k82fAGRxQAQFu9bq9I9ckIjRrcXTYb4SFKBSuqqoKy3NCPgXFe4ViSBefU\n OI52a8nhuTX4qNiasQw5PFlMph0X4NuaOsdBuq1v9IZ0U14UnwVLmFFVqWYy611TMZ+n\n A9pBhHWRQbY5H9uuPPLT+Kjbiqnc/ksRAFgS1S1H0vXS63fGIMqj+xuMTxa7jrBcjQgT\n 10yd6TGwqPuXLVJBhHLdP/9FzzQk/vB5+RfmU6ukvk6I44gTbxeruLg2UXe17+g3kfOo\n E4DQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774449887; x=1775054687;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8KTolxFhqKE3llXw2wPlg/bv3X/6bKxly7DkwaZHnFY=;\n b=D+8ogzJNMd9mY8PYx6VpLxwNlW8MFVryUz8Mr8J1Y4WQPm6y/TXkFaa5Zl/ggZSXUt\n hPICPzHBxx/CA89NwME0EKec0IX5Zz/RmpYGRxplrZ79AUAfn07kSL5ac1lSy/k0ZM4e\n QULjsYGaK6TQjPb6e1WrVi+PI+i4232KNbPMcc88NKCSR35KTjbfporj+Mafle7koYC0\n u7clJyQdS2zgTHGigL0tEa5KBRjoJSaoWdDeLt7maJu89Kmc1cTIlcg+AKaBXBaVPxuX\n ++bwqyMlTJJD4uKPCWz2YUK+R688b+gDJYs2bzMxM45zi1iUNq4lWm25fTDRnwQ7VinD\n 7LQg==","X-Gm-Message-State":"AOJu0YwBI2Z27bXjl/sG2oP/E21hgMCqupMlLoUGTxIKZngj+TGYhsmr\n UesN1ODV6fdi/1SPnWiA/i/d+WZ4TcNfDmrPBM7707hgVOuq4B+aakqPqx+DDzIJ","X-Gm-Gg":"ATEYQzxuhe3BzZDXVAKMAkF8Jq+osh+zlPqPyuwM6RG0gkpLCnNLLUarHevS6YWrrE7\n /H81c787Gkd/U/ok46+y23aHfG7VKy8cIVOFdoZHJsm/W2ozGstzJUlK+kPooGYjuwhxEW/3zqK\n EitAjUTkLQ0xL7I7DWQs5uw/j2Zhm7Fs+U8zvzXeryknICvKyY7N8rkZbCRKt3u+NPyk3SrEqSB\n g/x/uxr3NYcVti5l/TRzMWpR8Ys/ihCmzc8Lnn78J9/Bzg6xQMv9M1kNQPBf/4EHQmFVJBLB+K0\n 0BjjTsUmQiq3uOFfOMHNi/1JQ4cgCBwSoreZf47JnRoIHZ3Jl3SRu0W4D2X0QbaoA4TqPvcYRjP\n LmOTk/mo6oTH6lboyhuTpppA8lbYi0702UZ3em31NGQVhF/Dgb5WJeQWYEeZHne1vQQ0AtLVWW8\n usA7rZMEzUKINNZtYdhpizumRzrRimgKzcotbzmTK1y7Ur1O6HWBa6rAuIcmhOiraPhOy2uYnxj\n d/Lf2zQfxEosfhb/3DbmzCEcXXg9w==","X-Received":"by 2002:a05:622a:7285:b0:50b:6d63:6a32 with SMTP id\n d75a77b69052e-50b807f2c47mr34027031cf.20.1774449886883;\n Wed, 25 Mar 2026 07:44:46 -0700 (PDT)","From":"gerris.rs@gmail.com","To":"gcc-patches@gcc.gnu.org,\n\tgcc-rust@gcc.gnu.org","Cc":"pierre-emmanuel.patry@embecosm.com, arthur.cohen@embecosm.com,\n dkm+gccrs@kataplop.net, Owen Avery ","Subject":"[gccrs COMMIT] Remove redundant expand visitor overloads","Date":"Wed, 25 Mar 2026 14:44:44 +0000","Message-ID":"<20260325144445.3100-1-gerris.rs@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Owen Avery \n\ngcc/rust/ChangeLog:\n\n\t* expand/rust-expand-visitor.cc (ExpandVisitor::visit): Remove\n\tsome redundant function overloads.\n\t* expand/rust-expand-visitor.h (ExpandVisitor::visit): Likewise.\n\nSigned-off-by: Owen Avery \n---\nThis change was merged into the gccrs repository and is posted here for\nupstream visibility and potential drive-by review, as requested by GCC\nrelease managers.\nEach commit email contains a link to its details on github from where you can\nfind the Pull-Request and associated discussions.\n\n\nCommit on github: https://github.com/Rust-GCC/gccrs/commit/bd8aef0b558d313cb05c17a47340c657c4bf1580\n\nThe commit has been mentioned in the following pull-request(s):\n - https://github.com/Rust-GCC/gccrs/pull/4497\n\n gcc/rust/expand/rust-expand-visitor.cc | 166 -------------------------\n gcc/rust/expand/rust-expand-visitor.h | 23 ----\n 2 files changed, 189 deletions(-)\n\n\nbase-commit: e3c82fdd89bd044e9ba2a0830de23957932f34fe","diff":"diff --git a/gcc/rust/expand/rust-expand-visitor.cc b/gcc/rust/expand/rust-expand-visitor.cc\nindex 5fed8b52f..690c74bee 100644\n--- a/gcc/rust/expand/rust-expand-visitor.cc\n+++ b/gcc/rust/expand/rust-expand-visitor.cc\n@@ -597,67 +597,10 @@ void\n ExpandVisitor::visit (AST::MetaItemPathExpr &)\n {}\n \n-void\n-ExpandVisitor::visit (AST::ArithmeticOrLogicalExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::ComparisonExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::LazyBooleanExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TypeCastExpr &expr)\n-{\n- maybe_expand_expr (expr.get_casted_expr_ptr ());\n- maybe_expand_type (expr.get_type_to_cast_to_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::AssignmentExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::CompoundAssignmentExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::GroupedExpr &expr)\n-{\n- maybe_expand_expr (expr.get_expr_in_parens_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::StructExprStruct &expr)\n {}\n \n-void\n-ExpandVisitor::visit (AST::CallExpr &expr)\n-{\n- visit (expr.get_function_expr ());\n-\n- for (auto ¶m : expr.get_params ())\n- maybe_expand_expr (param);\n-}\n-\n void\n ExpandVisitor::visit (AST::ClosureExprInner &expr)\n {\n@@ -686,10 +629,6 @@ ExpandVisitor::visit (AST::ClosureExprInnerTyped &expr)\n visit (expr.get_definition_expr ());\n }\n \n-void\n-ExpandVisitor::visit (AST::ContinueExpr &expr)\n-{}\n-\n void\n ExpandVisitor::visit (AST::IfExpr &expr)\n {\n@@ -724,13 +663,6 @@ ExpandVisitor::visit (AST::IfLetExprConseqElse &expr)\n visit (expr.get_else_block ());\n }\n \n-void\n-ExpandVisitor::visit (AST::TupleExpr &expr)\n-{\n- for (auto &sub : expr.get_tuple_elems ())\n- maybe_expand_expr (sub);\n-}\n-\n void\n ExpandVisitor::visit (AST::TypeParam ¶m)\n {\n@@ -856,23 +788,6 @@ ExpandVisitor::visit (AST::Union &union_item)\n expand_struct_fields (union_item.get_variants ());\n }\n \n-void\n-ExpandVisitor::visit (AST::ConstantItem &const_item)\n-{\n- maybe_expand_type (const_item.get_type_ptr ());\n-\n- if (const_item.has_expr ())\n- maybe_expand_expr (const_item.get_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::StaticItem &static_item)\n-{\n- maybe_expand_type (static_item.get_type_ptr ());\n-\n- maybe_expand_expr (static_item.get_expr_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::Trait &trait)\n {\n@@ -994,87 +909,6 @@ void\n ExpandVisitor::visit (AST::StructPatternFieldIdent &field)\n {}\n \n-void\n-ExpandVisitor::visit (AST::GroupedPattern &pattern)\n-{\n- maybe_expand_pattern (pattern.get_pattern_in_parens_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::SlicePatternItemsNoRest &items)\n-{\n- for (auto &sub : items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::SlicePatternItemsHasRest &items)\n-{\n- for (auto &sub : items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n- for (auto &sub : items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::AltPattern &pattern)\n-{\n- for (auto &alt : pattern.get_alts ())\n- maybe_expand_pattern (alt);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TupleStructItemsNoRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TupleStructItemsHasRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n-\n- for (auto &sub : tuple_items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TuplePatternItemsNoRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TuplePatternItemsHasRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n-\n- for (auto &sub : tuple_items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::LetStmt &stmt)\n-{\n- maybe_expand_pattern (stmt.get_pattern_ptr ());\n-\n- if (stmt.has_type ())\n- maybe_expand_type (stmt.get_type_ptr ());\n-\n- if (stmt.has_init_expr ())\n- maybe_expand_expr (stmt.get_init_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::ExprStmt &stmt)\n-{\n- maybe_expand_expr (stmt.get_expr_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::BareFunctionType &type)\n {\ndiff --git a/gcc/rust/expand/rust-expand-visitor.h b/gcc/rust/expand/rust-expand-visitor.h\nindex 08de64e02..2a3938afe 100644\n--- a/gcc/rust/expand/rust-expand-visitor.h\n+++ b/gcc/rust/expand/rust-expand-visitor.h\n@@ -234,27 +234,17 @@ public:\n void visit (AST::AttrInputMacro &) override;\n void visit (AST::MetaItemLitExpr &) override;\n void visit (AST::MetaItemPathExpr &) override;\n- void visit (AST::ArithmeticOrLogicalExpr &expr) override;\n- void visit (AST::ComparisonExpr &expr) override;\n- void visit (AST::LazyBooleanExpr &expr) override;\n- void visit (AST::TypeCastExpr &expr) override;\n- void visit (AST::AssignmentExpr &expr) override;\n- void visit (AST::CompoundAssignmentExpr &expr) override;\n- void visit (AST::GroupedExpr &expr) override;\n void visit (AST::StructExprStruct &expr) override;\n \n- void visit (AST::CallExpr &expr) override;\n void visit (AST::ClosureExprInner &expr) override;\n \n void visit (AST::BlockExpr &expr) override;\n \n void visit (AST::ClosureExprInnerTyped &expr) override;\n- void visit (AST::ContinueExpr &expr) override;\n void visit (AST::IfExpr &expr) override;\n void visit (AST::IfExprConseqElse &expr) override;\n void visit (AST::IfLetExpr &expr) override;\n void visit (AST::IfLetExprConseqElse &expr) override;\n- void visit (AST::TupleExpr &expr) override;\n void visit (AST::TypeParam ¶m) override;\n void visit (AST::LifetimeWhereClauseItem &) override;\n void visit (AST::TypeBoundWhereClauseItem &item) override;\n@@ -272,8 +262,6 @@ public:\n void visit (AST::EnumItemStruct &item) override;\n void visit (AST::EnumItemDiscriminant &item) override;\n void visit (AST::Union &union_item) override;\n- void visit (AST::ConstantItem &const_item) override;\n- void visit (AST::StaticItem &static_item) override;\n void visit (AST::Trait &trait) override;\n void visit (AST::InherentImpl &impl) override;\n void visit (AST::TraitImpl &impl) override;\n@@ -290,17 +278,6 @@ public:\n void visit (AST::MetaListPaths &) override;\n void visit (AST::MetaListNameValueStr &) override;\n void visit (AST::StructPatternFieldIdent &field) override;\n- void visit (AST::GroupedPattern &pattern) override;\n- void visit (AST::SlicePatternItemsNoRest &items) override;\n- void visit (AST::SlicePatternItemsHasRest &items) override;\n- void visit (AST::AltPattern &pattern) override;\n- void visit (AST::TupleStructItemsNoRest &tuple_items) override;\n- void visit (AST::TupleStructItemsHasRest &tuple_items) override;\n- void visit (AST::TuplePatternItemsNoRest &tuple_items) override;\n- void visit (AST::TuplePatternItemsHasRest &tuple_items) override;\n-\n- void visit (AST::LetStmt &stmt) override;\n- void visit (AST::ExprStmt &stmt) override;\n \n void visit (AST::BareFunctionType &type) override;\n void visit (AST::FunctionParam ¶m) override;\n","prefixes":["gccrs","COMMIT"]}