{"id":2215897,"url":"http://patchwork.ozlabs.org/api/patches/2215897/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260325143555.451852-2-herve.codina@bootlin.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325143555.451852-2-herve.codina@bootlin.com>","list_archive_url":null,"date":"2026-03-25T14:35:28","name":"[v6,01/27] Revert \"treewide: Fix probing of devices in DT overlays\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"526475c390b3f4549c2c09a808f5d7cafc210189","submitter":{"id":81983,"url":"http://patchwork.ozlabs.org/api/people/81983/?format=json","name":"Herve Codina","email":"herve.codina@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260325143555.451852-2-herve.codina@bootlin.com/mbox/","series":[{"id":497453,"url":"http://patchwork.ozlabs.org/api/series/497453/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=497453","date":"2026-03-25T14:35:27","name":"lan966x pci device: Add support for SFPs","version":6,"mbox":"http://patchwork.ozlabs.org/series/497453/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215897/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215897/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=vTPsCQ0O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-51072-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"vTPsCQ0O\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.246.84.56","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgqS4469Sz1y1K\n\tfor ; Thu, 26 Mar 2026 01:44:36 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 4D9EB30576B1\n\tfor ; Wed, 25 Mar 2026 14:36:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A0A7C3E316B;\n\tWed, 25 Mar 2026 14:36:44 +0000 (UTC)","from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4FE3E314F;\n\tWed, 25 Mar 2026 14:36:41 +0000 (UTC)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-02.galae.net (Postfix) with ESMTPS id 3C9A71A2FE3;\n\tWed, 25 Mar 2026 14:36:40 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 06E2A601FA;\n\tWed, 25 Mar 2026 14:36:40 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 8BAD4104513C1;\n\tWed, 25 Mar 2026 15:36:23 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774449404; cv=none;\n b=u5Plrm+vQaiUpKlqVdkQFyJZvRpG0/vXVL44bxyzKY6G8jDBkQ7yIA17XK2YDvs2Ol2XrH9a1+JbBGtqRDaYXA3wLlQZ/A4yky3BexF1YLxKH/eC9Wk6b0aqBjAsrHxc7dVbNiuAeiw3ISX3/K3G9vffceCz4Ie2JGjfCv8BGW0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774449404; c=relaxed/simple;\n\tbh=FArXeehyZTW3N0bt5Bcb/H3S/Bs4a13KfFNQGV+ZYDY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=kCYqgIYh7I6utXKuG3l5D0A1VGIgHXGMaMm0168OIYoYucPE6V7TCZVQHZNNFHybCNerdPAnFhh44I5+FfEUY0h+wFIsR22dpt7vFjs+FdiWCVkrtKlMqQhKdBvOXoE0jYIKtDK4iQnsYJcOyGHLEOA/Voa3hos+qngTGod+15I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=vTPsCQ0O; arc=none smtp.client-ip=185.246.84.56","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1774449396; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=udl87NYHrbG5beYr+sj6tRLtpueqBaBik+Z+B4KV8SY=;\n\tb=vTPsCQ0OXGCOjFNQKGFCHfcsVlmP8F5muE1qprMIH7KqRdt5RtvV9lSR0G9oClrERWD7ka\n\tsG+buxOuzeQ9qYnnck+CnS9RbkMQFieTw3xJO1ixkw4ob2MZ/VIzPHom7nLmNYCc863rru\n\t2D6BYhvh03S0ms+Fdhnd9KMH4RY5G3luwYHvAgTenvyqp5mbiZpqS6vKJslt4oAGCpHJgi\n\tSargWsR4V8zAfmXCf/bEy1Eor6i7ivHIOpunI8GA7DFXONdIhqNue5SDG/aUSVRzQJvPMr\n\tAt40NnKGsahrmofS/xGpJAX4HOs1Sx6i1yzcSK0nyW/LQoQwgSddwdj78duGGA==","From":"Herve Codina ","To":"Andrew Lunn ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley ,\n\tGeert Uytterhoeven ,\n\tKalle Niemi ,\n\tMatti Vaittinen ,\n\tGreg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich ,\n\tFrank Li ,\n\tSascha Hauer ,\n\tPengutronix Kernel Team ,\n\tFabio Estevam ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tAndi Shyti ,\n\tWolfram Sang ,\n\tPeter Rosin ,\n\tArnd Bergmann ,\n\tHerve Codina ,\n\tSaravana Kannan ,\n\tBjorn Helgaas ,\n\tCharles Keepax ,\n\tRichard Fitzgerald ,\n\tDavid Rhodes ,\n\tLinus Walleij ,\n\tUlf Hansson ,\n\tMark Brown ,\n\tLen Brown ,\n\tAndy Shevchenko ,\n\tDaniel Scally ,\n\tHeikki Krogerus ,\n\tSakari Ailus ,\n\tDavidlohr Bueso ,\n\tJonathan Cameron ,\n\tDave Jiang ,\n\tAlison Schofield ,\n\tVishal Verma ,\n\tIra Weiny ,\n\tDan Williams ,\n\tShawn Guo ","Cc":"Wolfram Sang ,\n\tlinux-kernel@vger.kernel.org,\n\tdriver-core@lists.linux.dev,\n\timx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-clk@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-sound@vger.kernel.org,\n\tpatches@opensource.cirrus.com,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-pm@vger.kernel.org,\n\tlinux-spi@vger.kernel.org,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-cxl@vger.kernel.org,\n\tAllan Nielsen ,\n\tHoratiu Vultur ,\n\tSteen Hegelund ,\n\tLuca Ceresoli ,\n\tThomas Petazzoni ,\n\tSaravana Kannan ","Subject":"[PATCH v6 01/27] Revert \"treewide: Fix probing of devices in DT\n overlays\"","Date":"Wed, 25 Mar 2026 15:35:28 +0100","Message-ID":"<20260325143555.451852-2-herve.codina@bootlin.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260325143555.451852-1-herve.codina@bootlin.com>","References":"<20260325143555.451852-1-herve.codina@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3"},"content":"From: Saravana Kannan \n\nThis reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924.\n\nWhile the commit fixed fw_devlink overlay handling for one case, it\nbroke it for another case. So revert it and redo the fix in a separate\npatch.\n\nFixes: 1a50d9403fb9 (\"treewide: Fix probing of devices in DT overlays\")\nReported-by: Herve Codina \nCloses: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/\nCloses: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/\nCloses: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/\nSigned-off-by: Saravana Kannan \nLink: https://lore.kernel.org/lkml/20240411235623.1260061-2-saravanak@google.com/\nSigned-off-by: Herve Codina \nAcked-by: Mark Brown \n---\n drivers/bus/imx-weim.c | 6 ------\n drivers/i2c/i2c-core-of.c | 5 -----\n drivers/of/dynamic.c | 1 -\n drivers/of/platform.c | 5 -----\n drivers/spi/spi.c | 5 -----\n 5 files changed, 22 deletions(-)","diff":"diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c\nindex 83d623d97f5f..87070155b057 100644\n--- a/drivers/bus/imx-weim.c\n+++ b/drivers/bus/imx-weim.c\n@@ -327,12 +327,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,\n \t\t\t\t \"Failed to setup timing for '%pOF'\\n\", rd->dn);\n \n \t\tif (!of_node_check_flag(rd->dn, OF_POPULATED)) {\n-\t\t\t/*\n-\t\t\t * Clear the flag before adding the device so that\n-\t\t\t * fw_devlink doesn't skip adding consumers to this\n-\t\t\t * device.\n-\t\t\t */\n-\t\t\trd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE;\n \t\t\tif (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) {\n \t\t\t\tdev_err(&pdev->dev,\n \t\t\t\t\t\"Failed to create child device '%pOF'\\n\",\ndiff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c\nindex eb7fb202355f..30b48a428c0b 100644\n--- a/drivers/i2c/i2c-core-of.c\n+++ b/drivers/i2c/i2c-core-of.c\n@@ -176,11 +176,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action,\n \t\t\treturn NOTIFY_OK;\n \t\t}\n \n-\t\t/*\n-\t\t * Clear the flag before adding the device so that fw_devlink\n-\t\t * doesn't skip adding consumers to this device.\n-\t\t */\n-\t\trd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE;\n \t\tclient = of_i2c_register_device(adap, rd->dn);\n \t\tif (IS_ERR(client)) {\n \t\t\tdev_err(&adap->dev, \"failed to create client for '%pOF'\\n\",\ndiff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c\nindex 1a06175def37..aa450425ec1e 100644\n--- a/drivers/of/dynamic.c\n+++ b/drivers/of/dynamic.c\n@@ -225,7 +225,6 @@ static void __of_attach_node(struct device_node *np)\n \tnp->sibling = np->parent->child;\n \tnp->parent->child = np;\n \tof_node_clear_flag(np, OF_DETACHED);\n-\tnp->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE;\n \n \traw_spin_unlock_irqrestore(&devtree_lock, flags);\n \ndiff --git a/drivers/of/platform.c b/drivers/of/platform.c\nindex ba591fbceb56..2037c0b3880d 100644\n--- a/drivers/of/platform.c\n+++ b/drivers/of/platform.c\n@@ -738,11 +738,6 @@ static int of_platform_notify(struct notifier_block *nb,\n \t\tif (of_node_check_flag(rd->dn, OF_POPULATED))\n \t\t\treturn NOTIFY_OK;\n \n-\t\t/*\n-\t\t * Clear the flag before adding the device so that fw_devlink\n-\t\t * doesn't skip adding consumers to this device.\n-\t\t */\n-\t\trd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE;\n \t\t/* pdev_parent may be NULL when no bus platform device */\n \t\tpdev_parent = of_find_device_by_node(parent);\n \t\tpdev = of_platform_device_create(rd->dn, NULL,\ndiff --git a/drivers/spi/spi.c b/drivers/spi/spi.c\nindex 61f7bde8c7fb..749d306ce1cc 100644\n--- a/drivers/spi/spi.c\n+++ b/drivers/spi/spi.c\n@@ -4934,11 +4934,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action,\n \t\t\treturn NOTIFY_OK;\n \t\t}\n \n-\t\t/*\n-\t\t * Clear the flag before adding the device so that fw_devlink\n-\t\t * doesn't skip adding consumers to this device.\n-\t\t */\n-\t\trd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE;\n \t\tspi = of_register_spi_device(ctlr, rd->dn);\n \t\tput_device(&ctlr->dev);\n \n","prefixes":["v6","01/27"]}