{"id":2215885,"url":"http://patchwork.ozlabs.org/api/patches/2215885/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260325135811.148480-2-jonathanh@nvidia.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325135811.148480-2-jonathanh@nvidia.com>","list_archive_url":null,"date":"2026-03-25T13:58:09","name":"[V3,1/3] net: stmmac: Fix PTP ref clock for Tegra234","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d003fdea041183117c6d1c72ed7ec468344c39f4","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/?format=json","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260325135811.148480-2-jonathanh@nvidia.com/mbox/","series":[{"id":497451,"url":"http://patchwork.ozlabs.org/api/series/497451/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=497451","date":"2026-03-25T13:58:11","name":"net: stmmac: Fix Tegra234 MGBE clock","version":3,"mbox":"http://patchwork.ozlabs.org/series/497451/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215885/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215885/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=BWY5ggMI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13232-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"BWY5ggMI\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.52.56","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgppZ5TFNz1yG1\n\tfor ; Thu, 26 Mar 2026 01:15:34 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CA7EE302E42E\n\tfor ; Wed, 25 Mar 2026 13:59:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AC15D3DD507;\n\tWed, 25 Mar 2026 13:59:01 +0000 (UTC)","from BL2PR02CU003.outbound.protection.outlook.com\n (mail-eastusazon11011056.outbound.protection.outlook.com [52.101.52.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E2053BD24A;\n\tWed, 25 Mar 2026 13:58:59 +0000 (UTC)","from SA1PR02CA0023.namprd02.prod.outlook.com (2603:10b6:806:2cf::25)\n by PH7PR12MB6489.namprd12.prod.outlook.com (2603:10b6:510:1f7::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Wed, 25 Mar\n 2026 13:58:53 +0000","from SN1PEPF0002BA4B.namprd03.prod.outlook.com\n (2603:10b6:806:2cf:cafe::6b) by SA1PR02CA0023.outlook.office365.com\n (2603:10b6:806:2cf::25) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.32 via Frontend Transport; Wed,\n 25 Mar 2026 13:58:48 +0000","from mail.nvidia.com (216.228.118.233) by\n SN1PEPF0002BA4B.mail.protection.outlook.com (10.167.242.68) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.21 via Frontend Transport; Wed, 25 Mar 2026 13:58:52 +0000","from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com\n (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 25 Mar\n 2026 06:58:37 -0700","from drhqmail201.nvidia.com (10.126.190.180) by\n drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.20; Wed, 25 Mar 2026 06:58:37 -0700","from moonraker.home (10.127.8.14) by mail.nvidia.com\n (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend\n Transport; Wed, 25 Mar 2026 06:58:34 -0700"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774447141; cv=fail;\n b=aXzsCu+/zxoYmaSyX5WExeXxjqUs8phVXAP/4T+lDkx18pJzPWTNOwmLsuG3G00GxCSrijwvGU4TS60VGwf7o+vsgAPqp6sQGuAuyNwrIjMe4QlXT1i0jj/U/sI5DSmW1Ce+bJcNBT/DrK2p3wxGmgXHuzx5KW71wd1JaGFxAhg=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=W3583rFcNJw8MT5ytT+NYh3HojcX1y43Dd0U+oIIq6DcEkuPPa26w2HEq105eFpiqwc6CW7ouKrIFk/40IxR10IM0IZnpO69tFRj++tLPudjRfs5ZiTkpEMJv/0ThvxYUcTGPSdt0uBvg46jBK4SCyomFjsA0qkM1RQUMF8KoCAzV0mfAWI37cAKndeJNryNJyU1Sov32fZozJzO2Q0e7NhctthguNR0QiOEd95isO47GkrFgkS5MX/OdIBqSTSnWlrB5LlNFCU0eNfSTYgC3YAmazujpyooyqvoei1TDbdrULuPd1stjabHc4KrCFMGJe1iWAb8nKsTLwZpEA0FRA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774447141; c=relaxed/simple;\n\tbh=SWfdVeOwUj1T9DFpvrS2q8pYu8MhZ+9qVZ78RbgVy5I=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Mn07m4jQl06wdaNuKe/OCDZ9ZIf0cTSrocjtJSi/ujRFf3ghZX+TdUIEtA+fX9Ov1AcR6eMgeB+cCIhVNO4PqXtkIMItd5W5masE//4BjChEQuDiAYBPA+llLUV/BaIZx4PT1k5RVy/wWPlvJPVZZoLzDJlih00VZUt1qc4f5q8=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=8SP2R54JL0uxmAu60benfau+Y2UTCJ548fhxkZikuY8=;\n b=Ea2sbHfPXkHptTXxQaUIGRHniZun3kHlFJhhZZCXE8PBgiheB1peX0YtR5u8OZvt8v6PCK8UjNlC/51JhpUtKwFZbHkRj10TNwcb+S7ZIW6TmcidLjBYxZM3OCKkb4W0gtFGPHWLpHN0mgzRbSqBRsB6jf9P5cFtg4fO02BW9Q+tHM0xbJyUc2zb6fOgk1iRKU9rCNAthtwVLNCY9Uwx118w2GF9ojuPwgeFGaI2BCjbQNV15sjbqcMwZxkHYhgnvnk5jJZfqtERzmjQSpqrM5r4SfuuQOfxfSsFpXqUh1tkpKRHGRARCpTc/dUa0StQPeKxKWP+71rxZoypWqj2Rg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=BWY5ggMI; arc=fail smtp.client-ip=52.101.52.56","i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8SP2R54JL0uxmAu60benfau+Y2UTCJ548fhxkZikuY8=;\n b=BWY5ggMIcQGp6Cq7cREvI37LfB5ylBEC6+n9JpYpvAxEq7MwmiaXodUVFvsvwvmX5GNqjF45C4iM/gG09u0gifHVDqqA54wAYYg3sQx90aXRd7avRyG+el880xrM1crOE6wnJl3PsMVMmO+KSmXQMhFGowmbViNjaZDEvhFQNjmYIlI/DE9tMRhn2TA0NAGMrMa+jQF7lUJo/X3MjmmmR2+5FIEQ3KxF0/KzIBFxIe9phJ8HEoi9EVEOgePdj8gH5W4yOustWej3B2kUYhW8DPiBwF5nMRCeeO5HoCMU7oEfVs5A4v8P6eyATYkEF0wZQvFndJeFxyWn+8UpBhzqGg==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 216.228.118.233)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;","Received-SPF":"Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.233 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C","From":"Jon Hunter ","To":"Andrew Lunn , \"David S . Miller\"\n\t, Eric Dumazet , Jakub Kicinski\n\t, Paolo Abeni , Rob Herring\n\t, Krzysztof Kozlowski , Conor Dooley\n\t, Thierry Reding ","CC":", ,\n\t, Jon Hunter ","Subject":"[PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","Date":"Wed, 25 Mar 2026 13:58:09 +0000","Message-ID":"<20260325135811.148480-2-jonathanh@nvidia.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260325135811.148480-1-jonathanh@nvidia.com>","References":"<20260325135811.148480-1-jonathanh@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-NVConfidentiality":"public","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-NV-OnPremToCloud":"ExternallySecured","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SN1PEPF0002BA4B:EE_|PH7PR12MB6489:EE_","X-MS-Office365-Filtering-Correlation-Id":"aa319923-5a69-49a3-01d1-08de8a76a604","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|7416014|36860700016|82310400026|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tYwBnwLO81ABC4GORwzkXAL5G21gZzOTVuCg1rEh+FvAsBysktm6rcyj3UoOF5oIiVhF8B2HdRP6E57aB3vA5PaIPfY0pXzgQoaMX/6Wdwaow7Bi9bAJCJ3rVyge3v9N/osVPmJfO5h1h+8LXYHao1BIGLOGcjHp1dX4+MPQ6KuR7Xe+xqQ4GT6BjYC+FUNQBWFjN5MBpuyi+byS0qJ/xSAZ7QUY/WP7+uxLgQGlbZqbw6tNsOPHBW75znYO/OYQP5iWRGXNW5BvgBqwa0ZIv7UXXlBZBNrsr6Kpe9QpTVT+GQTkPwRAvLL56YIzbT6xSgfLMKpNT18YNSNGuUj5PrMstQklWLkt8IhHXLjNa5yvIlOrddaEnMoaxzxG9t92Jxiue+XSY7DCeqt3PNgyHV3D+SdGAmwpducwD7+BPKX4sfNclj3GUJjczPm/KrqiBzfFcWDivY1S3Bt9gg71BXfZpWxU5t8LEFnVrsyIKOEHdUi1gxwJp5bDTs5NRwRAf2q1t3QQ/th8rjYtvDY2WwCvv3zGunHy+akcIuWYHR3UV9D2MsIVl0b9LVkgYJfPEezcpPwcT9rm4eXY8FGUwmn8woON4UY8QocbIpIgVvQWyr6+/fX7Fh87oaKJ+l/9pKJ8QvvedMA/X1kEk/IKCQQwN40747Giwtsj7n7vwCfKxhGygNiVr0fx8cjgZTEWw6bkDF6efnMbRF6GeV+UuHtL8lQt2BbkprsczFvNfdbo6JCK+aY+GGTOTIa+PmRN8wG2z+3N8sd6XoinrwlIEvw==","X-Forefront-Antispam-Report":"\n\tCIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(36860700016)(82310400026)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n\tql90/7TSBlEz2ccLwds9/dZ/bGs/zjnxRpJC/K3U6riGjRoFN/7d0x4OjJqfeXCRvp1UWMC/KQyaNLxe1fHtqQjn4zqhXhtbHcvnSc+v4euP/4Rna/RXWslx1gF6JC5WMQ0qYH2ZIyHh8N24GZOnvVPFnFMboymkifeHMPeXryCXaPiNvMY4k4NO74lcg6MYfOqbTphhmzomh+S6qr+esv44A1GCpYMz7zALXfvpjgHg4GyhK8g6/TxKf1ZYTUEjOrp4NygvCjJzEojGETJ+JjxQZFOps+3ZOWSO45JZFFH+iOhHZkLygjAeocYi1vGQ656zRNF+0RtnBLn1LwghnRGld226D9IdTC7JFK6G7UGRZoK7AiaFGn6Fr3oHb/R2Y4nLAvybZgwBeB77JzU1Oc73RQvtOfbRomHokoxmGglUA5s/jg1kvn7DKX84XQrt","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Mar 2026 13:58:52.8200\n (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n aa319923-5a69-49a3-01d1-08de8a76a604","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n\tSN1PEPF0002BA4B.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH7PR12MB6489"},"content":"Since commit 030ce919e114 (\"net: stmmac: make sure that ptp_rate is not\n0 before configuring timestamping\") was added the following error is\nobserved on Tegra234:\n\n ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n\nIt turns out that the Tegra234 device-tree binding defines the PTP ref\nclock name as 'ptp-ref' and not 'ptp_ref' and the above commit now\nexposes this and that the PTP clock is not configured correctly.\n\nIn order to update device-tree to use the correct 'ptp_ref' name, update\nthe Tegra MGBE driver to use 'ptp_ref' by default and fallback to using\n'ptp-ref' if 'ptp_ref' is not found.\n\nFixes: d8ca113724e7 (\"net: stmmac: tegra: Add MGBE support\")\nSigned-off-by: Jon Hunter \n---\n .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\nindex b4b39e6a169e..ec18ee46889f 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\n@@ -9,7 +9,7 @@\n #include \"stmmac_platform.h\"\n \n static const char *const mgbe_clks[] = {\n-\t\"rx-pcs\", \"tx\", \"tx-pcs\", \"mac-divider\", \"mac\", \"mgbe\", \"ptp-ref\", \"mac\"\n+\t\"rx-pcs\", \"tx\", \"tx-pcs\", \"mac-divider\", \"mac\", \"mgbe\", \"ptp_ref\", \"mac\"\n };\n \n struct tegra_mgbe {\n@@ -216,6 +216,7 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n \tstruct plat_stmmacenet_data *plat;\n \tstruct stmmac_resources res;\n \tstruct tegra_mgbe *mgbe;\n+\tbool use_legacy_ptp;\n \tint irq, err, i;\n \tu32 value;\n \n@@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n \tif (!mgbe->clks)\n \t\treturn -ENOMEM;\n \n-\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++)\n+\t/*\n+\t * Older device-trees use 'ptp-ref' rather than 'ptp_ref'.\n+\t * Fall back to the legacy name when 'ptp_ref' is absent.\n+\t */\n+\tuse_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n+\t\t\t\t\t\t \"clock-names\", \"ptp_ref\") < 0;\n+\n+\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) {\n \t\tmgbe->clks[i].id = mgbe_clks[i];\n \n+\t\tif (use_legacy_ptp && !strcmp(mgbe_clks[i], \"ptp_ref\")) {\n+\t\t\tdev_warn(mgbe->dev,\n+\t\t\t\t \"Device-tree update needed for PTP clock!\\n\");\n+\t\t\tmgbe->clks[i].id = \"ptp-ref\";\n+\t\t}\n+\t}\n+\n \terr = devm_clk_bulk_get(mgbe->dev, ARRAY_SIZE(mgbe_clks), mgbe->clks);\n \tif (err < 0)\n \t\treturn err;\n","prefixes":["V3","1/3"]}