{"id":2215816,"url":"http://patchwork.ozlabs.org/api/patches/2215816/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325111140.347421-3-f.ebner@proxmox.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325111140.347421-3-f.ebner@proxmox.com>","list_archive_url":null,"date":"2026-03-25T11:11:04","name":"[v3,2/2] iotests/041: add test for duplicate job-complete with throttled target","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a10106dde4bbcc8de92643ac615103c0df750390","submitter":{"id":82206,"url":"http://patchwork.ozlabs.org/api/people/82206/?format=json","name":"Fiona Ebner","email":"f.ebner@proxmox.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325111140.347421-3-f.ebner@proxmox.com/mbox/","series":[{"id":497423,"url":"http://patchwork.ozlabs.org/api/series/497423/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497423","date":"2026-03-25T11:11:02","name":"block/mirror: fix assertion failure upon duplicate complete for job using 'replaces'","version":3,"mbox":"http://patchwork.ozlabs.org/series/497423/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215816/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215816/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgklf2nf7z1xy3\n\tfor ; Wed, 25 Mar 2026 22:12:46 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5M9j-0002Rr-8n; Wed, 25 Mar 2026 07:12:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5M9R-0002Mf-AV; Wed, 25 Mar 2026 07:11:54 -0400","from proxmox-new.maurer-it.com ([94.136.29.106])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5M9O-0003OY-SL; Wed, 25 Mar 2026 07:11:52 -0400","from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])\n by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5081249081;\n Wed, 25 Mar 2026 12:11:48 +0100 (CET)"],"From":"Fiona Ebner ","To":"qemu-devel@nongnu.org","Cc":"qemu-block@nongnu.org,\n\threitz@redhat.com,\n\tkwolf@redhat.com","Subject":"[PATCH v3 2/2] iotests/041: add test for duplicate job-complete with\n throttled target","Date":"Wed, 25 Mar 2026 12:11:04 +0100","Message-ID":"<20260325111140.347421-3-f.ebner@proxmox.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260325111140.347421-1-f.ebner@proxmox.com>","References":"<20260325111140.347421-1-f.ebner@proxmox.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Bm-Milter-Handled":"55990f41-d878-4baa-be0a-ee34c49e34d2","X-Bm-Transport-Timestamp":"1774437060166","Received-SPF":"pass client-ip=94.136.29.106; envelope-from=f.ebner@proxmox.com;\n helo=proxmox-new.maurer-it.com","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This would fail without commit 9ac85f4cc7 (\"block/mirror: fix\nassertion failure upon duplicate complete for job using 'replaces'\").\n\nSigned-off-by: Fiona Ebner \nReviewed-by: Hanna Czenczek \n---\n\nNo changes in v3.\n\n tests/qemu-iotests/041 | 31 +++++++++++++++++++++++++++++++\n tests/qemu-iotests/041.out | 4 ++--\n 2 files changed, 33 insertions(+), 2 deletions(-)","diff":"diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041\nindex 976a12a6f2..17b415aebf 100755\n--- a/tests/qemu-iotests/041\n+++ b/tests/qemu-iotests/041\n@@ -1520,6 +1520,37 @@ class TestThrottledNBDTarget(iotests.QMPTestCase):\n self.assertTrue(iotests.compare_images(test_img, target_img),\n 'target image does not match source after mirroring')\n \n+ def test_duplicate_complete_with_replaces(self):\n+ self.vm.cmd('blockdev-mirror',\n+ job_id='mirror',\n+ device='source',\n+ target='target',\n+ replaces='source',\n+ sync='full')\n+\n+ self.wait_ready(drive='mirror')\n+\n+ self.set_throttle_limits({'iops-write': 1})\n+\n+ # Issue requests that will be throttled.\n+ for i in range(0, self.reqs):\n+ req = f'aio_write -P 7 {i}M {self.req_len}'\n+ self.vm.hmp_qemu_io(self.drive_qdev, req, qdev=True)\n+\n+ self.vm.cmd('job-complete', id='mirror')\n+ # The fact that the target is externally throttled ensures that the job\n+ # won't be finished yet when the second command is issued.\n+ self.vm.cmd('job-complete', id='mirror')\n+\n+ self.disable_throttling()\n+\n+ self.wait_until_completed('mirror')\n+\n+ self.target_vm.shutdown()\n+ self.vm.shutdown()\n+ self.assertTrue(iotests.compare_images(test_img, target_img),\n+ 'target image does not match source after mirroring')\n+\n if __name__ == '__main__':\n iotests.main(supported_fmts=['qcow2', 'qed'],\n supported_protocols=['file'],\ndiff --git a/tests/qemu-iotests/041.out b/tests/qemu-iotests/041.out\nindex 5273ce86c3..96a0752f44 100644\n--- a/tests/qemu-iotests/041.out\n+++ b/tests/qemu-iotests/041.out\n@@ -1,5 +1,5 @@\n-............................................................................................................\n+.............................................................................................................\n ----------------------------------------------------------------------\n-Ran 108 tests\n+Ran 109 tests\n \n OK\n","prefixes":["v3","2/2"]}