{"id":2215746,"url":"http://patchwork.ozlabs.org/api/patches/2215746/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260325093118.684142-1-fra.schnyder@gmail.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325093118.684142-1-fra.schnyder@gmail.com>","list_archive_url":null,"date":"2026-03-25T09:31:16","name":"[v1] PCI: imx6: Fix reference clock source selection","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d5b9a0afcff4353bea4619b31cdb5d576ed33172","submitter":{"id":92056,"url":"http://patchwork.ozlabs.org/api/people/92056/?format=json","name":"Franz Schnyder","email":"fra.schnyder@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260325093118.684142-1-fra.schnyder@gmail.com/mbox/","series":[{"id":497403,"url":"http://patchwork.ozlabs.org/api/series/497403/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=497403","date":"2026-03-25T09:31:16","name":"[v1] PCI: imx6: Fix reference clock source selection","version":1,"mbox":"http://patchwork.ozlabs.org/series/497403/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215746/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215746/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hckSUcy8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51033-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"hckSUcy8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.43","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fghgR5s8Xz1xy1\n\tfor ; Wed, 25 Mar 2026 20:38:59 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DA692300878F\n\tfor ; Wed, 25 Mar 2026 09:32:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4237F34A77D;\n\tWed, 25 Mar 2026 09:32:07 +0000 (UTC)","from mail-wm1-f43.google.com (mail-wm1-f43.google.com\n [209.85.128.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DA8350A1F\n\tfor ; Wed, 25 Mar 2026 09:32:05 +0000 (UTC)","by mail-wm1-f43.google.com with SMTP id\n 5b1f17b1804b1-48702d51cd0so49231895e9.2\n for ; Wed, 25 Mar 2026 02:32:05 -0700 (PDT)","from franzs-nb.corp.toradex.com\n (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch. [83.173.201.248])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48711764625sm120724195e9.14.2026.03.25.02.32.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 02:32:03 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774431127; cv=none;\n b=Gx9wm4twDdfyAvlyReVoOp0uPdt3pDJ2WmRXWMGWAagpeOSpwGtLx+++SWV6kR3HRrQFV688Xu3gTK0EZxK4J+FeWWQBO49qHxY2ia8RHuewaDOQqAjzN8SoIv5n4y2Ay/PHM+ul1v0dxKrZpcvi1pBV+pmDkfNlCswRPjtdzAE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774431127; c=relaxed/simple;\n\tbh=UV41qUpbXMbPJ8oKt5RHwR1kOG1v2llCMlZ+SAex9to=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=nMjpbQ03VV/5CIr9j4SNca1Mg0G96z1wnp/HET8iHZR5O3x6YNEaut1EaxmxsvLO85jjCOnOWcDpnIAeI3sl7Vcl6tPtcJtt2ntRAvqB6JKoL4oKAZD4cHA5KAoBe51brl21tPtabeE6OCHqpyBBkx92TzReBGvIhBVOm3Q8Dxs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=hckSUcy8; arc=none smtp.client-ip=209.85.128.43","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774431124; x=1775035924;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=aIsbSfS605Q4eTkbTgnxZvgMorhnFDaqZxn3f2tTBFI=;\n b=hckSUcy80k8ckKuBdK6VOzqEbGcMty/9LRQEs2EJn7ojDc3iadZIRb4LYlRhtK/2j9\n S/Y8Oj4wbausnRL5Ptk2ci6ebqMeJhZoBfwxwy7SX5stXT/O5IrC3BlUqiVtDDrvq/vS\n IGzSWAZ6JPnNmmi065AjwZhnhrY5e3zF7MlREy/mg/9akHM+SagJJGdJanABwxwAuXcQ\n MfU+hgXRASNstGarHJOV6bj9pJ/eNr9vVvhwoTkuN7wE1L3JBwfjhass8fHz1VDANsUi\n gLyPXu+anZK/44SkPVhHqYX985T/75sAPqNnMkAMvn9cY5+BzHQaQyXPXWEySBEu1V3x\n i3/w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774431124; x=1775035924;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aIsbSfS605Q4eTkbTgnxZvgMorhnFDaqZxn3f2tTBFI=;\n b=WEu3rkWAL50c3ay9F0YMhBVqJBCqKWxjjGNZMWYCb3ukDcbxYwfbQbF+CQbueGJ94B\n AZeGRMXgsTMgxGbEdLV7QhB3a7e0TZKvL2ybxhbBdmsYNERMM+C6zGVPY8hn0KtLBcEv\n xDhD3qTVpLFEvtKliK6dG90N/V+AMpsac60WgvvLSgVYIYYEiJFGVxaepfpqoci93fPB\n JjgMZuEPX7psEqpp8/LyPr6H1p5vHVHpnAysRLS39XXJsPv0FAvcNIq8L5Q5iRo5fQbB\n TTkq4eVqHQ8NLAnOGik89YB6MWo2NzhvydqQobG/6sUuP4DD6Rcm7tXuiXvWcNcVN0hS\n 9UTg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWPBKXo5VLP6d0qB0jTwpBp1tOBaLbFBWW8Aj2rbXkIRyfMfHCUM+ohW5MxPyG4rhA+pZmtVg3vU6U=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzokSlXd3KMVXnqf4Vej/fizBSmT7zDyz2nUEn2BoGy1/gdmtWN\n\tBoMw57Xx2128PARHZCPMhS06dxEnOAPiec+x5BVJXloW+AwmrEMoMFEG","X-Gm-Gg":"ATEYQzxfm0bcAK1tObOCjCqtDdezW1MyesgTpnVcPTxYvf1T16LCdOoXVF5SGO2dOst\n\tcDYc/k2SKejuXhToFBW1fvGGQ8Ucl+Jp8DtJrvb9AGKtBRoKv+quQmU/g10V5YFcP9EjyXl4PP/\n\tWrG/53cOupelWR73F1zcfCZiU/P/xPdQDwZCcbYGRklcCiTfc03al6ubLVsfWCL1rQivbRq/ZWT\n\tZc+O/Ki2r4Ao4KHeCTI2XmtWLdTDyIPaiRGvmxKElKQfqXaShbFnYRlYvgga01vghLhs8RJyutA\n\t00dIOuFtAu9NyTpbrkhBy8F7JKY7z/AQO/jf1gLFUxbKizIa02OhRrTDEs5aUUvRhPOpTfK4Rk2\n\tbI0norJteHl1YUs4Ad5R8gRUIJjCybaxvghul2Q7G5lf/lpV7h3NudEbMZdfZM3zVVaA4qNr1kt\n\tf8M/gQjKJoDNJL+VFYiMTBoiy/GMWIw7JJlTsUCQ3T45Rc4Cul+QqBmO5kZ4LtBq5IcMAK2Zzy3\n\tZlKdKrCgDvHzHO86e7SBtXhB8Le0tXtkqI0x9LeZNVVYokNZASx+dvrh0wlZDXVVI6FkNsrrRcw\n\tFLlPTQ+Kxnv5QkDbG3cH","X-Received":"by 2002:a05:600c:8b88:b0:487:1c2:6a4c with SMTP id\n 5b1f17b1804b1-48715fbf6a6mr44191015e9.4.1774431123985;\n Wed, 25 Mar 2026 02:32:03 -0700 (PDT)","From":"Franz Schnyder ","To":"Richard Zhu , Lucas Stach ,\n Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Frank Li ,\n Sascha Hauer ,\n Pengutronix Kernel Team ,\n Fabio Estevam ","Cc":"Franz Schnyder ,\n\tlinux-pci@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\timx@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org,\n\tFrancesco Dolcini ,\n\tstable@vger.kernel.org","Subject":"[PATCH v1] PCI: imx6: Fix reference clock source selection","Date":"Wed, 25 Mar 2026 10:31:16 +0100","Message-ID":"<20260325093118.684142-1-fra.schnyder@gmail.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Franz Schnyder \n\nIn the PCIe PHY init for the iMX95, the reference clock source selection\nuses a conditional instead of always passing the mask. This currently\nbreaks functionality if the internal refclk is used.\n\nPass always IMX95_PCIE_REF_USE_PAD as the mask and clear the bit if\nexternal refclk is not used.\n\nFixes: d8574ce57d76 (\"PCI: imx6: Add external reference clock input mode support\")\nCc: stable@vger.kernel.org\nSigned-off-by: Franz Schnyder \n---\n drivers/pci/controller/dwc/pci-imx6.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c\nindex 81a7093494c8..e0580d6efa57 100644\n--- a/drivers/pci/controller/dwc/pci-imx6.c\n+++ b/drivers/pci/controller/dwc/pci-imx6.c\n@@ -268,8 +268,8 @@ static int imx95_pcie_init_phy(struct imx_pcie *imx_pcie)\n \t\t\tIMX95_PCIE_PHY_CR_PARA_SEL);\n \n \tregmap_update_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_PHY_GEN_CTRL,\n-\t\t\t ext ? IMX95_PCIE_REF_USE_PAD : 0,\n-\t\t\t IMX95_PCIE_REF_USE_PAD);\n+\t\t\t IMX95_PCIE_REF_USE_PAD,\n+\t\t\t ext ? IMX95_PCIE_REF_USE_PAD : 0);\n \tregmap_update_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_SS_RW_REG_0,\n \t\t\t IMX95_PCIE_REF_CLKEN,\n \t\t\t ext ? 0 : IMX95_PCIE_REF_CLKEN);\n","prefixes":["v1"]}