{"id":2215735,"url":"http://patchwork.ozlabs.org/api/patches/2215735/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325085450.126595-1-zhaoguohan@kylinos.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","list_archive_url":null,"date":"2026-03-25T08:54:50","name":"hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"db81b256346115b52514d90a6f27c5444d854b75","submitter":{"id":92952,"url":"http://patchwork.ozlabs.org/api/people/92952/?format=json","name":"GuoHan Zhao","email":"zhaoguohan@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325085450.126595-1-zhaoguohan@kylinos.cn/mbox/","series":[{"id":497397,"url":"http://patchwork.ozlabs.org/api/series/497397/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497397","date":"2026-03-25T08:54:50","name":"hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","version":1,"mbox":"http://patchwork.ozlabs.org/series/497397/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215735/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215735/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fggjt1WJJz1xy3\n\tfor ; Wed, 25 Mar 2026 19:56:02 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5K1I-0007wx-Dq; Wed, 25 Mar 2026 04:55:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5K1F-0007wk-5s; Wed, 25 Mar 2026 04:55:17 -0400","from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5K1C-0006oc-L9; Wed, 25 Mar 2026 04:55:16 -0400","from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 1648777527; Wed, 25 Mar 2026 16:54:53 +0800"],"X-UUID":["4a012f24282811f1a21c59e7364eecb8-20260325","4a012f24282811f1a21c59e7364eecb8-20260325"],"X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.11, REQID:ee45a32f-ffaf-4bcd-9921-75d2f085acbc,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:\n release,TS:0","X-CID-META":"VersionHash:89c9d04, CLOUDID:33daf92fbfd1b051932e3f78995da9a0,\n BulkI\n D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:-\n 3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,A\n V:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"zhaoguohan@kylinos.cn","From":"GuoHan Zhao ","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ","Cc":"Steven Lee , Troy Lee ,\n Jamin Lin ,\n Andrew Jeffery ,\n Joel Stanley , qemu-arm@nongnu.org, qemu-devel@nongnu.org,\n GuoHan Zhao ","Subject":"[PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","Date":"Wed, 25 Mar 2026 16:54:50 +0800","Message-ID":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=124.126.103.232;\n envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Commit 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on\nback-to-back commands\") introduced pending_intr_sts to preserve\ninterrupt bits that collide with already pending status bits.\n\nThat deferred interrupt state is consumed later when the guest clears\nINTR_STS, but it is not reset in aspeed_i2c_bus_reset() and it is not\npart of the bus migration state. A reset can therefore leave stale\ndeferred bits behind, and migration can silently drop them.\n\nClear pending_intr_sts on reset and include it in VMState while keeping\ncompatibility with older migration streams.\n\nFixes: 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on back-to-back commands\")\nSigned-off-by: GuoHan Zhao \n---\n hw/i2c/aspeed_i2c.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c\nindex 5d18f8d49ea4..90f83a03fd4f 100644\n--- a/hw/i2c/aspeed_i2c.c\n+++ b/hw/i2c/aspeed_i2c.c\n@@ -1134,10 +1134,11 @@ static const MemoryRegionOps aspeed_i2c_bus_pool_ops = {\n \n static const VMStateDescription aspeed_i2c_bus_vmstate = {\n .name = TYPE_ASPEED_I2C,\n- .version_id = 6,\n+ .version_id = 7,\n .minimum_version_id = 6,\n .fields = (const VMStateField[]) {\n VMSTATE_UINT32_ARRAY(regs, AspeedI2CBus, ASPEED_I2C_NEW_NUM_REG),\n+ VMSTATE_UINT32_V(pending_intr_sts, AspeedI2CBus, 7),\n VMSTATE_UINT8_ARRAY(pool, AspeedI2CBus, ASPEED_I2C_BUS_POOL_SIZE),\n VMSTATE_UINT64(dma_dram_offset, AspeedI2CBus),\n VMSTATE_END_OF_LIST()\n@@ -1510,6 +1511,7 @@ static void aspeed_i2c_bus_reset(DeviceState *dev)\n AspeedI2CBus *s = ASPEED_I2C_BUS(dev);\n \n memset(s->regs, 0, sizeof(s->regs));\n+ s->pending_intr_sts = 0;\n i2c_end_transfer(s->bus);\n }\n \n","prefixes":[]}