{"id":2215680,"url":"http://patchwork.ozlabs.org/api/patches/2215680/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260325031743.371728-1-marek.vasut+renesas@mailbox.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325031743.371728-1-marek.vasut+renesas@mailbox.org>","list_archive_url":null,"date":"2026-03-25T03:17:04","name":"[RFC,1/3] fdtdec: Deduplicate iterator function","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"d1a40044450425c15601a235255fb5a8dd70bb5a","submitter":{"id":85650,"url":"http://patchwork.ozlabs.org/api/people/85650/?format=json","name":"Marek Vasut","email":"marek.vasut+renesas@mailbox.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260325031743.371728-1-marek.vasut+renesas@mailbox.org/mbox/","series":[{"id":497379,"url":"http://patchwork.ozlabs.org/api/series/497379/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=497379","date":"2026-03-25T03:17:04","name":"[RFC,1/3] fdtdec: Deduplicate iterator function","version":1,"mbox":"http://patchwork.ozlabs.org/series/497379/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215680/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215680/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.a=rsa-sha256\n header.s=mail20150812 header.b=j6BRYRTE;\n\tdkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org\n header.a=rsa-sha256 header.s=mail20150812 header.b=hKzn7mQH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.b=\"j6BRYRTE\";\n\tdkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org\n header.b=\"hKzn7mQH\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=marek.vasut+renesas@mailbox.org","outgoing_mbo_mout;\n dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=hKzn7mQH;\n spf=pass (outgoing_mbo_mout: domain of marek.vasut+renesas@mailbox.org\n designates 2001:67c:2050:b231:465::202 as permitted sender)\n smtp.mailfrom=marek.vasut+renesas@mailbox.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgXCt3b3Rz1xy3\n\tfor ; Wed, 25 Mar 2026 14:18:02 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 009B18352B;\n\tWed, 25 Mar 2026 04:17:57 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id AB9D183CE3; Wed, 25 Mar 2026 04:17:55 +0100 (CET)","from mout-p-103.mailbox.org (mout-p-103.mailbox.org\n [IPv6:2001:67c:2050:0:465::103])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 20F5481E18\n for ; Wed, 25 Mar 2026 04:17:53 +0100 (CET)","from smtp202.mailbox.org (smtp202.mailbox.org\n [IPv6:2001:67c:2050:b231:465::202])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4fgXCh6Y8lz9tth;\n Wed, 25 Mar 2026 04:17:52 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;\n s=mail20150812; t=1774408672;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=/Ytvmdv5PRqOC9Da4OUQH/n9C1GMXzDDsUfJGrTftKQ=;\n b=j6BRYRTE8lKhSBRJ8b34Nen3QyWLK2ErKnpMwvI2ZaY8z8qCCMaSwgk7DwUr9QceQnYzmj\n CQs0dNCo67zShkDXUyL8ATH6p4kqsw7jij3ap0v+2FyHdWhSWbmyy0cq1GZp1LmSQcYmrz\n 8fNges5PX6V8s90pzoq6ZabtqcEGmbjZ0N1LGidLv0FT8Fg6Q+vvcUn7ztRcLN1JpP9X1z\n 0b+HE0nZ8p4inVTiGeWbecTPu34Pec2ANHBGqKCMevYR9QRKq5QMpY9NvYYD/bkKstHbRd\n QgfGZMa+MtugWmSSqj9DAlGe41MRfV3QI4d+7vMfIMdvSqa8pUcOeo8rTrQfzA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;\n s=mail20150812; t=1774408671;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=/Ytvmdv5PRqOC9Da4OUQH/n9C1GMXzDDsUfJGrTftKQ=;\n b=hKzn7mQH8ehdPqz0JDBPBo7/nAyp3c1FBCWSqkbP0+G2j0NZafS7Ia8A4qydPZR4vt/uba\n 2Dt4wkQ2yv3lVj89RcgKPkd3gfsprqnY5560DiQrQvoJGVwhCPiWWkKttTRWLGlfHqiLXh\n n9K8ZisIn2GieWxNkknaYJqYootiZJNMZUvHzoeLKAWsqpCD3bmCCrCyGtXgiXwMQtRdq5\n 4RGnayozCDqRi9byGZ/8YEDE02wofOJn2UKEYKQNKJrlsuheH8viVd+cWKvPaik5Qj/eUg\n p6mKhl4MZb2DGtCgjsyVM4fFGR8a72sYMuZMeCWWaKlCjQFQ2bEhuDIO6Z4LQw=="],"From":"Marek Vasut ","To":"u-boot@lists.denx.de","Cc":"Marek Vasut ,\n Casey Connolly ,\n Ilias Apalodimas ,\n Nobuhiro Iwamatsu ,\n Raymond Mao , Simon Glass ,\n Tom Rini ","Subject":"[RFC][PATCH 1/3] fdtdec: Deduplicate iterator function","Date":"Wed, 25 Mar 2026 04:17:04 +0100","Message-ID":"<20260325031743.371728-1-marek.vasut+renesas@mailbox.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-MBO-RS-ID":"247c217c94a959497e6","X-MBO-RS-META":"wu81gi5ywtn1hb5zwmdhwzqdmguokjzx","X-Rspamd-Queue-Id":"4fgXCh6Y8lz9tth","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Both fdtdec_setup_memory_banksize() and fdtdec_setup_mem_size_base_lowest()\nimplement the exact same iterator over all memory banks, the only difference\nis the body that is executed for each bank. Deduplicate the functionality\ninto iterator function fdtdec_setup_mem_for_each_bank(), which takes a\nfunction pointer to a function which implements the body as a parameter.\nNo functional change.\n\nSigned-off-by: Marek Vasut \n---\nCc: Casey Connolly \nCc: Ilias Apalodimas \nCc: Nobuhiro Iwamatsu \nCc: Raymond Mao \nCc: Simon Glass \nCc: Tom Rini \nCc: u-boot@lists.denx.de\n---\n lib/fdtdec.c | 77 ++++++++++++++++++++--------------------------------\n 1 file changed, 30 insertions(+), 47 deletions(-)","diff":"diff --git a/lib/fdtdec.c b/lib/fdtdec.c\nindex c38738b48c7..d820f75b031 100644\n--- a/lib/fdtdec.c\n+++ b/lib/fdtdec.c\n@@ -1092,7 +1092,7 @@ ofnode get_next_memory_node(ofnode mem)\n \treturn mem;\n }\n \n-int fdtdec_setup_memory_banksize(void)\n+static int fdtdec_setup_mem_for_each_bank(void (*bankfn)(struct resource *res, int bank))\n {\n \tint bank, ret, reg = 0;\n \tstruct resource res;\n@@ -1120,63 +1120,46 @@ int fdtdec_setup_memory_banksize(void)\n \t\tif (ret != 0)\n \t\t\treturn -EINVAL;\n \n-\t\tgd->bd->bi_dram[bank].start = (phys_addr_t)res.start;\n-\t\tgd->bd->bi_dram[bank].size =\n-\t\t\t(phys_size_t)(res.end - res.start + 1);\n-\n-\t\tdebug(\"%s: DRAM Bank #%d: start = 0x%llx, size = 0x%llx\\n\",\n-\t\t __func__, bank,\n-\t\t (unsigned long long)gd->bd->bi_dram[bank].start,\n-\t\t (unsigned long long)gd->bd->bi_dram[bank].size);\n+\t\tbankfn(&res, bank);\n \t}\n \n \treturn 0;\n }\n \n-int fdtdec_setup_mem_size_base_lowest(void)\n+static void fdtdec_setup_memory_banksize_bankfn(struct resource *res, int bank)\n {\n-\tint bank, ret, reg = 0;\n-\tstruct resource res;\n-\tunsigned long base;\n-\tphys_size_t size;\n-\tofnode mem = ofnode_null();\n+\tgd->bd->bi_dram[bank].start = (phys_addr_t)res->start;\n+\tgd->bd->bi_dram[bank].size = (phys_size_t)(res->end - res->start + 1);\n \n-\tgd->ram_base = (unsigned long)~0;\n-\n-\tmem = get_next_memory_node(mem);\n-\tif (!ofnode_valid(mem)) {\n-\t\tdebug(\"%s: Missing /memory node\\n\", __func__);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tfor (bank = 0; bank < CONFIG_NR_DRAM_BANKS; bank++) {\n-\t\tret = ofnode_read_resource(mem, reg++, &res);\n-\t\tif (ret < 0) {\n-\t\t\treg = 0;\n-\t\t\tmem = get_next_memory_node(mem);\n-\t\t\tif (!ofnode_valid(mem))\n-\t\t\t\tbreak;\n-\n-\t\t\tret = ofnode_read_resource(mem, reg++, &res);\n-\t\t\tif (ret < 0)\n-\t\t\t\tbreak;\n-\t\t}\n-\n-\t\tif (ret != 0)\n-\t\t\treturn -EINVAL;\n+\tdebug(\"%s: DRAM Bank #%d: start = 0x%llx, size = 0x%llx\\n\",\n+\t __func__, bank,\n+\t (unsigned long long)gd->bd->bi_dram[bank].start,\n+\t (unsigned long long)gd->bd->bi_dram[bank].size);\n+}\n \n-\t\tbase = (unsigned long)res.start;\n-\t\tsize = (phys_size_t)(res.end - res.start + 1);\n+int fdtdec_setup_memory_banksize(void)\n+{\n+\treturn fdtdec_setup_mem_for_each_bank(fdtdec_setup_memory_banksize_bankfn);\n+}\n \n-\t\tif (gd->ram_base > base && size) {\n-\t\t\tgd->ram_base = base;\n-\t\t\tgd->ram_size = size;\n-\t\t\tdebug(\"%s: Initial DRAM base %lx size %lx\\n\",\n-\t\t\t __func__, base, (unsigned long)size);\n-\t\t}\n+static void fdtdec_setup_mem_size_base_lowest_bankfn(struct resource *res, int bank)\n+{\n+\tunsigned long base = (unsigned long)res->start;\n+\tphys_size_t size = (phys_size_t)(res->end - res->start + 1);\n+\n+\tif (gd->ram_base > base && size) {\n+\t\tgd->ram_base = base;\n+\t\tgd->ram_size = size;\n+\t\tdebug(\"%s: Initial DRAM base %lx size %lx\\n\",\n+\t\t __func__, base, (unsigned long)size);\n \t}\n+}\n \n-\treturn 0;\n+int fdtdec_setup_mem_size_base_lowest(void)\n+{\n+\tgd->ram_base = (unsigned long)~0;\n+\n+\treturn fdtdec_setup_mem_for_each_bank(fdtdec_setup_mem_size_base_lowest_bankfn);\n }\n \n static int uncompress_blob(const void *src, ulong sz_src, void **dstp)\n","prefixes":["RFC","1/3"]}