{"id":2215610,"url":"http://patchwork.ozlabs.org/api/patches/2215610/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/patch/20260324202358.977930-1-james.hilliard1@gmail.com/","project":{"id":58,"url":"http://patchwork.ozlabs.org/api/projects/58/?format=json","name":"swupdate development","link_name":"swupdate","list_id":"swupdate.googlegroups.com","list_email":"swupdate@googlegroups.com","web_url":"https://github.com/sbabic/swupdate","scm_url":"git://github.com/sbabic/swupdate","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324202358.977930-1-james.hilliard1@gmail.com>","list_archive_url":null,"date":"2026-03-24T20:23:58","name":"[1/1] build: fix no-crypto configuration link failure","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ee9c2013d281e55652a28526069f484cbcf4ad5e","submitter":{"id":66301,"url":"http://patchwork.ozlabs.org/api/people/66301/?format=json","name":"James Hilliard","email":"james.hilliard1@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/swupdate/patch/20260324202358.977930-1-james.hilliard1@gmail.com/mbox/","series":[{"id":497345,"url":"http://patchwork.ozlabs.org/api/series/497345/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/list/?series=497345","date":"2026-03-24T20:23:58","name":"[1/1] build: fix no-crypto configuration link failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/497345/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215610/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215610/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=googlegroups.com header.i=@googlegroups.com\n header.a=rsa-sha256 header.s=20251104 header.b=YoMwoYEH;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mAPTtV7o;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com\n (client-ip=2607:f8b0:4864:20::c40; helo=mail-oo1-xc40.google.com;\n envelope-from=swupdate+bncbcl4hcw73qcbb4hfrphamgqeepcwdnq@googlegroups.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from mail-oo1-xc40.google.com (mail-oo1-xc40.google.com\n [IPv6:2607:f8b0:4864:20::c40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgM2f08lsz1y1K\n\tfor ; Wed, 25 Mar 2026 07:24:24 +1100 (AEDT)","by mail-oo1-xc40.google.com with SMTP id\n 006d021491bc7-67de822ddeesf35179321eaf.2\n for ;\n Tue, 24 Mar 2026 13:24:24 -0700 (PDT)","by 2002:a05:6820:2212:b0:67c:25be:7576 with SMTP id\n 006d021491bc7-67c25be7656ls3502439eaf.2.-pod-prod-05-us; Tue, 24 Mar 2026\n 13:24:15 -0700 (PDT)","from mail-ot1-x332.google.com (mail-ot1-x332.google.com.\n [2607:f8b0:4864:20::332])\n by gmr-mx.google.com with ESMTPS id\n 46e09a7af769-7d9d785db17si11091a34.7.2026.03.24.13.24.15\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 24 Mar 2026 13:24:15 -0700 (PDT)","by mail-ot1-x332.google.com with SMTP id\n 46e09a7af769-7d7ebe11bffso3947508a34.0\n for ; Tue, 24 Mar 2026 13:24:15 -0700 (PDT)","from james-x399.localdomain (71-33-128-58.hlrn.qwest.net.\n [71.33.128.58])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7d9b3f4fb2esm6685565a34.20.2026.03.24.13.24.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 13:24:14 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1774383857; cv=pass;\n d=google.com; s=arc-20240605;\n b=jh13e3t4HYGe09O4G2mCN+0ayVY7tPFMk1HoOns9WGhmu1m5IdkxSWiRKwWxd6c4yd\n aAjffoU0F1Ic+XSz5q0wzxrto/3I1W0hFd8t/EIAoLZdh4o5yb5nSiZfny3Yhazf8CHH\n Aoyl9v05xFyEuAOqfqfB2N1gVt8MC9IR3VWPVC+Dtv2fbrIHirK4bXIBpLiIr+rMFO74\n I+tI+5tt2dugB2TUGFixZ4dZQC6oiiwrA8cG2bwiW7zP/Rk1AAMTfBSaJARr2LR9qsWT\n XDjNbBsoymoK5kMbn3clhSMPLeLpAOQHUJt+Jxf3poZMLZBG5hn0oA/GdeWLcOleCOBG\n ZVVA==","i=1; a=rsa-sha256; t=1774383855; cv=none;\n d=google.com; s=arc-20240605;\n b=foiI5cI/c3nLnefEhiF7Dsnifh32PnBXVXbhXezfudRJ9LOSlL/h/kNHJWBXyHMhIg\n QSZO2N7RFcJuk6WmlKfYbgWyxZ2foUwcy3ieHb6fe6fSZS2mQAOS2s/7y6bxiNssaRWp\n aQDmy7GcwqCv+y4JwYba4MfoUrs6ygJeG0TrndOtok/Iejbcefk0ttMvRzc1oUJnTkC3\n 0oPAXEFsfuyR2Hq6iTau+vua1POrAP1n+MLNa6PwN45gCZ2Sl3IyObojLl4jL/8QiE7t\n 2SIm9b2DaTm5EYM9HV8XMqAqe1rO42CV8qaZ+LCHAeXRY1BM678AQ7x/ObHoV8YxvwoZ\n G8UQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:mime-version:message-id:date\n :subject:cc:to:from:sender:dkim-signature:dkim-signature;\n bh=D6U8U5aHaH/P2N64BL/7FhJOYql4ajhLAWbGWl+GBxk=;\n fh=8OxlSkKINBAZKMhFz++e2EnxK1UlGh6kNc3si4cFgxk=;\n b=kavy/UcgRFSPEYGD/W7bMiGYsVkf/hBpW6QKP14yoq/c2BQ3XAq91OzdjsMoH8szsh\n pVJJy9bNPLEe0ngxR5rWc+fStcc/RMovNHUfvSr+SQZ+aD2OqYobBXCl/yrrda4qsjkg\n nmwZSHtfPWrGuhy6SOc78Uto0TkmNPyeVZZVXAN3uaw0huAbLy9ezgbHcPQYQqlJMdsb\n kGvBwKytA8mKDFCcjgPKfw0xD0UunhgJy8Xcd9kACY8jXiOBtulvzNEdI5NfuGrbxShF\n r87yuZDFniArRad8GaxijFDK7fHYL1at3I0wHvUc+rH/vgj6J1Xz37kOiae2c/W/Zh3B\n v8Qw==;\n darn=patchwork.ozlabs.org","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature;\n bh=VmaV2X7sOO2p6yV1S9Hiv28WraumzgC/16Hsexmm4tY=;\n fh=P26i9j5aM5uB9AP5ZgYoipDQivhAqoPtbveeIsiHlHY=;\n b=bkq+FXkeK63UP9IeT6DK6vC+Th9x0snblbhqpIKb602A4jbfDh4CXm6Qdjzs0NCN1W\n 5AjI09k8pojhDQdsQ4rirc3wH0SzkymEYrCEFsQ7bOBrax+4E9jDsKZ1CldWa9qfPkib\n eapeRn+54MoRNQC03E07bwYYyzFcz+uEpZtey25LuyDP02jFKBZhn+duFGPvHzCLZK9o\n sK23mb2knOiIWke3X3/cxhaXE+YJWFXmQY8xuwtOaC8ypFHO8Ex+bKZ4Dfd/Cxwf/fQ3\n 0TWfeSAPFLriQT+5An2uPgIdko/kok/UEBfc9uPzuTO0Z0SXl9cQNRlNJliGwEOULclG\n 7vaA==;\n dara=google.com"],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n dkim=pass header.i=@gmail.com header.s=20251104 header.b=kuUO6MWw;\n spf=pass (google.com: domain of james.hilliard1@gmail.com designates\n 2607:f8b0:4864:20::332 as permitted sender)\n smtp.mailfrom=james.hilliard1@gmail.com;\n dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com;\n dara=pass header.i=@googlegroups.com","i=1; gmr-mx.google.com;\n dkim=pass header.i=@gmail.com header.s=20251104 header.b=kuUO6MWw;\n spf=pass (google.com: domain of james.hilliard1@gmail.com designates\n 2607:f8b0:4864:20::332 as permitted sender)\n smtp.mailfrom=james.hilliard1@gmail.com;\n dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com;\n dara=pass header.i=@googlegroups.com"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=googlegroups.com; s=20251104; t=1774383857; x=1774988657;\n darn=patchwork.ozlabs.org;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:x-original-authentication-results\n :x-original-sender:mime-version:message-id:date:subject:cc:to:from\n :sender:from:to:cc:subject:date:message-id:reply-to;\n bh=D6U8U5aHaH/P2N64BL/7FhJOYql4ajhLAWbGWl+GBxk=;\n b=YoMwoYEHug1o2ekvoAEUtgp7kGMrIMwonHiAR1KpARe9sWiR7Ibcb046hOOgGxbUZ7\n sR61PNnY/wBq5V6Y73O31tdLqa52P2MFuZYyzqRkuA4k1Od+UM/FfBOKENYjSsgkFCKF\n BN/hK0HTXq9LFXTJixeznBX0snrKr/uiUdPMMszwMuJws4nqv9wRuRVtdVFr/n2Lg97f\n jIzUMvPRH+Bk2JhbbEfS9Ozz16kDrFbxLbicP9ckWfvOcuyU09s7GS5A9FlbS/qzpkvx\n XzgVInMEXr5w9aDqaOJnzz3+7eYfRJSSpgy7EAhYIF2jDS8VO8IPxKzIHnjfG6ohos6o\n rwMw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774383857; x=1774988657;\n darn=patchwork.ozlabs.org;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:x-original-authentication-results\n :x-original-sender:mime-version:message-id:date:subject:cc:to:from\n :from:to:cc:subject:date:message-id:reply-to;\n bh=D6U8U5aHaH/P2N64BL/7FhJOYql4ajhLAWbGWl+GBxk=;\n b=mAPTtV7oGN3mxX7UC9KLa3uRy1VhJAvIfufl/sfZO7meo9YpVxYqzNNYaedKhebWdC\n BaCcjK2yZSH1/P1PsswPhueXHwfWRmJggn2+iA3lO38ozYCtEI4sv8evvHagNexuszy4\n nV7Z0gZ2yEWSVZXIV1FGjpWMi7FjmzrsxI4AcgpnpdOFhFmJai7VR8tVHjl4dbWdw2ho\n 4YR56ranHtp7nC95ByCpI1JlEmuZz4O2DJJCd+vJRSVcIyQ41FO4IdQy4uIf5xbBzJd2\n PEvHrhG3fQlkkGylCWyYUSsdPlkTEKIshYoEByPalhI3YrswRzGcBn7OimxOz+96iHGb\n lpOQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774383857; x=1774988657;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :x-spam-checked-in-group:list-id:mailing-list:precedence\n :x-original-authentication-results:x-original-sender:mime-version\n :message-id:date:subject:cc:to:from:x-gm-gg:x-beenthere\n :x-gm-message-state:sender:from:to:cc:subject:date:message-id\n :reply-to;\n bh=D6U8U5aHaH/P2N64BL/7FhJOYql4ajhLAWbGWl+GBxk=;\n b=dEKxAQNIZtMAOJxI5gHBeJpPAZ1QidnEG1NvHTBRu8ZKigSp64nvOGTlCLbxhWO3q3\n fEzz7lwjKrHCsRmE6cB7OMX/NuX55zPrecsvMq0TNkxdwD1njAuH6qnQsneLxOva9AqA\n 72NVRu8BP7G5i1vcOAouhOf5pNmZWyS21oS3n4JSZF+FUhtxIgI6xHSZDpcXDPw90dNE\n /JyflmP7ZnVx8VPqOa6iwb9+6hW0Bhvb3cU8pYRJqk/58jWecd/NcT7miekRAnvbb1he\n eX8JcAHCwvCAGNX/aefr1iYR9xIdpbbwvAU1X5iOOFowV5LWdBCBMwJWziZFX8xM9fRu\n Sfuw==","Sender":"swupdate@googlegroups.com","X-Forwarded-Encrypted":"i=2;\n AJvYcCVTaa/mZEWQb8rOxDhJ98Zua+9/MYfLTAtL1lnfgn0p4ddzttO0JTtFLfEc194ni0aHs4K3zrKSXA==@patchwork.ozlabs.org","X-Gm-Message-State":"AOJu0YwjWq088U9eZ0Tx01zBcBUMSfe5+/5DVb0erb1vRYnZDMn+kw5A\n\te0uPEqN25kBl/gbbnIeiuHKFRb7RFM3gwCUqe/Pvgrri3u/g1Ue+UPBa","X-Received":["by 2002:a05:6820:6ae2:b0:67b:c368:1374 with SMTP id\n 006d021491bc7-67dff5159f6mr648339eaf.34.1774383857564;\n Tue, 24 Mar 2026 13:24:17 -0700 (PDT)","by 2002:a05:6830:6d08:b0:7d7:3b11:467f with SMTP id\n 46e09a7af769-7d9d69f16b8mr447744a34.32.1774383855546;\n Tue, 24 Mar 2026 13:24:15 -0700 (PDT)","by 2002:a05:6830:6d08:b0:7d7:3b11:467f with SMTP id\n 46e09a7af769-7d9d69f16b8mr447726a34.32.1774383854995;\n Tue, 24 Mar 2026 13:24:14 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com;\n h=\"AV1CL+E3wWKBlIeW2Gmv/ViWTxYdX2zleGvUshyEWNlCkuo01Q==\"","Received-SPF":"pass (google.com: domain of james.hilliard1@gmail.com designates\n 2607:f8b0:4864:20::332 as permitted sender) client-ip=2607:f8b0:4864:20::332;","X-Gm-Gg":"ATEYQzzJLkjJuQzKd+2YXdX/pNzWdlaSkmoqmBKrIF369oxyFkTYTZSMV6X/i0+zjrm\n\tINcfVUpWm2Rkn4N31IF4LDlyHujZfBl+RF/5nwvmE3i8f3w609OOmtmw0b49MEd9Ttbkfn9kMXk\n\tiVaFdlud0EyghtOZphO4NiZqO2jnVUe1b4nb2qjHV+C3oB1t7yQJiag6MY7gwrmqqGD2Xe1ebQu\n\tIKeH+h4wS+ql7wwTDYiEJUCtL0jy3TQngYWqD+lqSbb6EXIhfUYinuWGXYEtaM9ze9MMDtZcfsF\n\tYvTWfBtn12mjxg//nMd50EU6LTGRfIU5lmQ8fV35XUpvMnv7d6ZVBsMtoeUBsyY85ZoV7Hx0uIa\n\tr3edaoA2se4iY3k0DUVeEzkaTLWdKBFqeUbIQJX2ZHBTcJ/74XV11PBL8EgzggWtPzC7cuIoAFf\n\tu3IM/Ew+KCPGVa94UYRjXwyRiR3iK5e712/J01BLAwBdBx1Qvh6p5DkHBY5wHYK5w9PCjUzFN0R\n\t47IXiXiGGOlTG+8wZLQAtvK0SqiTAPC1R0dbl9Pyzr8DoFcuHUj6PIIXq3XO4267LEtn80=","From":"James Hilliard ","To":"swupdate@googlegroups.com","Cc":"Giulio Benetti ,\n\tJames Hilliard ","Subject":"[swupdate] [PATCH 1/1] build: fix no-crypto configuration link\n failure","Date":"Tue, 24 Mar 2026 14:23:58 -0600","Message-ID":"<20260324202358.977930-1-james.hilliard1@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","X-Original-Sender":"james.hilliard1@gmail.com","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n header.i=@gmail.com header.s=20251104 header.b=kuUO6MWw; spf=pass\n (google.com: domain of james.hilliard1@gmail.com designates\n 2607:f8b0:4864:20::332 as permitted sender)\n smtp.mailfrom=james.hilliard1@gmail.com;\n dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com;\n dara=pass header.i=@googlegroups.com","Content-Type":"text/plain; charset=\"UTF-8\"","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n contact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n ","List-Help":",\n ","List-Archive":",\n ","List-Unsubscribe":"\n ,\n "},"content":"When no crypto backend is selected, the crypto directory contributes\nno objects, so this kbuild variant does not generate\ncrypto/built-in.o.\n\nThe top-level build still linked that file unconditionally, causing\nthe final link to fail.\n\nIntroduce a hidden SWUPDATE_CRYPTO helper selected by the Kconfig\noptions that actually populate crypto/, and only descend into the\ncrypto directory when that helper is enabled.\n\nSigned-off-by: James Hilliard \n---\n Makefile | 3 ++-\n crypto/Kconfig | 5 +++++\n 2 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/Makefile b/Makefile\nindex aa9604aa..759fd191 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -369,7 +369,8 @@ include $(srctree)/Makefile.flags\n # This allow a user to issue only 'make' to build a kernel including modules\n # Defaults to vmlinux, but the arch makefile usually adds further targets\n \n-objs-y\t\t:= core handlers crypto bootloader suricatta\n+objs-y\t\t:= core handlers bootloader suricatta\n+objs-$(CONFIG_SWUPDATE_CRYPTO) += crypto\n libs-y\t\t:= corelib mongoose parser fs containers\n bindings-y\t:= bindings\n tools-y\t\t:= tools\ndiff --git a/crypto/Kconfig b/crypto/Kconfig\nindex 1e2b4fe5..ee512456 100644\n--- a/crypto/Kconfig\n+++ b/crypto/Kconfig\n@@ -27,9 +27,13 @@ menu \"Crypto libraries\"\n \t\tdepends on HAVE_P11KIT\n endmenu\n \n+config SWUPDATE_CRYPTO\n+\tbool\n+\n config HASH_VERIFY\n \tbool \"Allow to add sha256 hash to each image\"\n \tdepends on SSL_IMPL_OPENSSL || SSL_IMPL_WOLFSSL || SSL_IMPL_MBEDTLS\n+\tselect SWUPDATE_CRYPTO\n \thelp\n \t Allow to add a sha256 hash to an artifact.\n \t This is automatically set in case of Signed Image\n@@ -91,6 +95,7 @@ menu \"Encryption\"\n config ENCRYPTED_IMAGES\n \tbool \"Images can be encrypted with a symmetric key\"\n \tdepends on SSL_IMPL_OPENSSL || SSL_IMPL_WOLFSSL || SSL_IMPL_MBEDTLS || PKCS11\n+\tselect SWUPDATE_CRYPTO\n comment \"Image encryption needs an SSL implementation\"\n \tdepends on !SSL_IMPL_OPENSSL && !SSL_IMPL_WOLFSSL && !SSL_IMPL_MBEDTLS && !PKCS11\n \n","prefixes":["1/1"]}