{"id":2215595,"url":"http://patchwork.ozlabs.org/api/patches/2215595/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-6-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324194333.30004-6-farosas@suse.de>","list_archive_url":null,"date":"2026-03-24T19:43:20","name":"[RFC,v1,05/17] vmstate: Remove vmdesc_loop","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fb5602eee0875fc129fff3d00ce07b47e4b75914","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-6-farosas@suse.de/mbox/","series":[{"id":497339,"url":"http://patchwork.ozlabs.org/api/series/497339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497339","date":"2026-03-24T19:43:16","name":"migration: vmstate_save|load changes for peterx","version":1,"mbox":"http://patchwork.ozlabs.org/series/497339/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215595/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215595/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=n031Bixc;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=PEFEgJDw;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=n031Bixc;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=PEFEgJDw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=n031Bixc;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PEFEgJDw"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgL9K1LDWz1y1G\n\tfor ; Wed, 25 Mar 2026 06:45:09 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w57fj-0003IM-AS; Tue, 24 Mar 2026 15:44:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w57fd-0003G6-CP\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:09 -0400","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w57fb-0008EN-Nj\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:09 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 867D15BD56;\n Tue, 24 Mar 2026 19:43:44 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5F42B43FE4;\n Tue, 24 Mar 2026 19:43:43 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id kJjuC2/pwmlkMQAAD6G6ig\n (envelope-from ); Tue, 24 Mar 2026 19:43:43 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381424;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mqFU08QiemyHMKmACwXdYM3VqArmk1wjvFdrAmao4JI=;\n b=n031BixcOB1TXteDcoVZ0zbAOgEnVYA9yBNrBF9//Ev/k7dvhh11GAeHyZq2PX8Zrsl81Y\n pqPMlrZlYyQC0tN3jiXmf/ew84dYU1N37QzNUjxa5trVusqQyjxQz2RNEMYo/EPUeKzc9Q\n H/60EoGNytkvxwTGCYGIfqrdrursXHM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381424;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mqFU08QiemyHMKmACwXdYM3VqArmk1wjvFdrAmao4JI=;\n b=PEFEgJDwPPJ0lriYoNtNuwkSsyPzRUce5oP2DiM0gTJvRSIQwRGUw9YED0fgOFOTkUK8yu\n rjCHXmEVn9cPuDBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381424;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mqFU08QiemyHMKmACwXdYM3VqArmk1wjvFdrAmao4JI=;\n b=n031BixcOB1TXteDcoVZ0zbAOgEnVYA9yBNrBF9//Ev/k7dvhh11GAeHyZq2PX8Zrsl81Y\n pqPMlrZlYyQC0tN3jiXmf/ew84dYU1N37QzNUjxa5trVusqQyjxQz2RNEMYo/EPUeKzc9Q\n H/60EoGNytkvxwTGCYGIfqrdrursXHM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381424;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mqFU08QiemyHMKmACwXdYM3VqArmk1wjvFdrAmao4JI=;\n b=PEFEgJDwPPJ0lriYoNtNuwkSsyPzRUce5oP2DiM0gTJvRSIQwRGUw9YED0fgOFOTkUK8yu\n rjCHXmEVn9cPuDBA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"[RFC PATCH v1 05/17] vmstate: Remove vmdesc_loop","Date":"Tue, 24 Mar 2026 16:43:20 -0300","Message-ID":"<20260324194333.30004-6-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260324194333.30004-1-farosas@suse.de>","References":"<20260324194333.30004-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"867D15BD56","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The vmdesc_loop variable is being used as a hacky way of writing the\nJSON description only for the first element of a compressed\narray. There are also a few implicit uses, such as writing the JSON\nfor the first non-compressed element after a compressed portion.\n\nFuture work will have trouble with this. Use a simple boolean to be\nexplicit now.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 25 ++++++++++++++-----------\n 1 file changed, 14 insertions(+), 11 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex dec9cf920b..7a12245d36 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -622,8 +622,9 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *first_elem = opaque + field->offset;\n int i, n_elems = vmstate_n_elems(opaque, field);\n int size = vmstate_size(opaque, field);\n- JSONWriter *vmdesc_loop = vmdesc;\n bool is_null_prev = false;\n+ bool use_vmdesc = true;\n+\n /*\n * When this is enabled, it means we will always push a ptr\n * marker first for each element saying if it's populated.\n@@ -673,7 +674,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n is_null != is_null_prev) {\n \n is_null_prev = is_null;\n- vmdesc_loop = vmdesc;\n+ use_vmdesc = true;\n \n for (int j = i + 1; j < n_elems; j++) {\n void *elem = *(void **)(first_elem + size * j);\n@@ -686,8 +687,13 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n }\n \n+ if (use_dynamic_array) {\n+ use_vmdesc = true;\n+ }\n+\n ok = vmstate_save_field_with_vmdesc(f, curr_elem, size, vmsd,\n- inner_field, vmdesc_loop,\n+ inner_field,\n+ use_vmdesc ? vmdesc : NULL,\n i, max_elems, errp);\n \n /* If we used a fake temp field.. free it now */\n@@ -708,19 +714,16 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n * NOTE: do not use vmstate_size() here because we want\n * to dump the real VMSD object now.\n */\n- ok = vmstate_save_field_with_vmdesc(f, curr_elem,\n- field->size, vmsd,\n- field, vmdesc_loop,\n- i, max_elems, errp);\n+ ok = vmstate_save_field_with_vmdesc(\n+ f, curr_elem, field->size, vmsd, field,\n+ use_vmdesc ? vmdesc : NULL, i, max_elems, errp);\n+\n if (!ok) {\n goto out;\n }\n }\n \n- /* Compressed arrays only care about the first element */\n- if (vmdesc_loop && vmsd_can_compress(field)) {\n- vmdesc_loop = NULL;\n- }\n+ use_vmdesc = false;\n }\n } else {\n if (field->flags & VMS_MUST_EXIST) {\n","prefixes":["RFC","v1","05/17"]}