{"id":2215589,"url":"http://patchwork.ozlabs.org/api/patches/2215589/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-9-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324194333.30004-9-farosas@suse.de>","list_archive_url":null,"date":"2026-03-24T19:43:23","name":"[RFC,v1,08/17] vmstate: Don't recompute size and n_elems in vmstate_size","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ac8907c0ae5551354694244145c1559dfad4a4bf","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-9-farosas@suse.de/mbox/","series":[{"id":497339,"url":"http://patchwork.ozlabs.org/api/series/497339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497339","date":"2026-03-24T19:43:16","name":"migration: vmstate_save|load changes for peterx","version":1,"mbox":"http://patchwork.ozlabs.org/series/497339/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215589/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215589/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=MOWOSWiH;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=5GiRSDis;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=MOWOSWiH;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=5GiRSDis;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgL8X523Zz1xy1\n\tfor ; Wed, 25 Mar 2026 06:44:28 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w57fY-0003FI-Dt; Tue, 24 Mar 2026 15:44:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w57fW-0003E2-5V\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:02 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w57fU-0008AH-M9\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:01 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 350414D258;\n Tue, 24 Mar 2026 19:43:49 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E46E43FE4;\n Tue, 24 Mar 2026 19:43:47 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 0EjMM3PpwmlkMQAAD6G6ig\n (envelope-from ); Tue, 24 Mar 2026 19:43:47 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381429;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=;\n b=MOWOSWiHG05+qmxDk1TXjZlVm7pMV3BCTPmOTwkiiS3r1vEn87sCbVmSVIdE1xxRM6hjVr\n WrcGhJ2Pi7I3JwnurhsT1GPMDfyCz6XD5MvpJ6Mngn8/cebjhsThPLYa/y8i0S+26ZGzL7\n 4oelo8AxOhUEao6jA1VdWQgFTi6xxko=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381429;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=;\n b=5GiRSDis07n3YgaHMeUJqGr8XLWyNjDiEvVCkoQ9kPulT2swhrIxg9utKx3Xe26hFZZzmQ\n Kegr6vVwh831dWBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381429;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=;\n b=MOWOSWiHG05+qmxDk1TXjZlVm7pMV3BCTPmOTwkiiS3r1vEn87sCbVmSVIdE1xxRM6hjVr\n WrcGhJ2Pi7I3JwnurhsT1GPMDfyCz6XD5MvpJ6Mngn8/cebjhsThPLYa/y8i0S+26ZGzL7\n 4oelo8AxOhUEao6jA1VdWQgFTi6xxko=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381429;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=;\n b=5GiRSDis07n3YgaHMeUJqGr8XLWyNjDiEvVCkoQ9kPulT2swhrIxg9utKx3Xe26hFZZzmQ\n Kegr6vVwh831dWBA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"[RFC PATCH v1 08/17] vmstate: Don't recompute size and n_elems in\n vmstate_size","Date":"Tue, 24 Mar 2026 16:43:23 -0300","Message-ID":"<20260324194333.30004-9-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260324194333.30004-1-farosas@suse.de>","References":"<20260324194333.30004-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-2.80","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The caller already has the size and number of elements available. Pass\nthem in. Subsequent commits will add other callers.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 0975d10793..8437b5ef3e 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -101,11 +101,10 @@ static int vmstate_size(void *opaque, const VMStateField *field)\n }\n \n static void vmstate_handle_alloc(void *ptr, const VMStateField *field,\n- void *opaque)\n+ int size, int n_elems)\n {\n if (field->flags & VMS_POINTER && field->flags & VMS_ALLOC) {\n- gsize size = vmstate_size(opaque, field);\n- size *= vmstate_n_elems(opaque, field);\n+ size *= n_elems;\n if (size) {\n *(void **)ptr = g_malloc(size);\n }\n@@ -248,7 +247,7 @@ bool vmstate_load_vmsd(QEMUFile *f, const VMStateDescription *vmsd,\n int i, n_elems = vmstate_n_elems(opaque, field);\n int size = vmstate_size(opaque, field);\n \n- vmstate_handle_alloc(first_elem, field, opaque);\n+ vmstate_handle_alloc(first_elem, field, size, n_elems);\n if (field->flags & VMS_POINTER) {\n first_elem = *(void **)first_elem;\n assert(first_elem || !n_elems || !size);\n","prefixes":["RFC","v1","08/17"]}