{"id":2215588,"url":"http://patchwork.ozlabs.org/api/patches/2215588/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-8-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324194333.30004-8-farosas@suse.de>","list_archive_url":null,"date":"2026-03-24T19:43:22","name":"[RFC,v1,07/17] vmstate: Create and save ptr marker in same function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c22609192794da89d97fd79861bdfa672277b081","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-8-farosas@suse.de/mbox/","series":[{"id":497339,"url":"http://patchwork.ozlabs.org/api/series/497339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497339","date":"2026-03-24T19:43:16","name":"migration: vmstate_save|load changes for peterx","version":1,"mbox":"http://patchwork.ozlabs.org/series/497339/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215588/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215588/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=TABpM8iw;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/8a1gdHF;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=TABpM8iw;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/8a1gdHF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TABpM8iw;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=\"/8a1gdHF\""],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgL8V5zmTz1xy1\n\tfor ; Wed, 25 Mar 2026 06:44:26 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w57fU-0003DA-SG; Tue, 24 Mar 2026 15:44:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w57fN-0003CD-FQ\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:43:55 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w57fI-00085S-SE\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:43:52 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id A2A6B4D217;\n Tue, 24 Mar 2026 19:43:47 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B8C343FE4;\n Tue, 24 Mar 2026 19:43:46 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id OPnZEnLpwmlkMQAAD6G6ig\n (envelope-from ); Tue, 24 Mar 2026 19:43:46 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381427;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DYM15ZCEzaavHO8mCOfxSzn/Gfj4uM9ceO5chRfQkKE=;\n b=TABpM8iwc2H4gQwKsgCPnGx/irZo567NFpkHyMvvphLCZJ30PC9cDzs1ZvaAL7Gi4hle4m\n zZTuRQUe+msMk17u0FXKQ12uH+nIxBbzAhnzX1VabFs6RPDoFTvnYK3zI2BLmrsUGeeH2h\n 9oZ9+N5w60XrLhaG6z0kjXMvtMrnP8E=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381427;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DYM15ZCEzaavHO8mCOfxSzn/Gfj4uM9ceO5chRfQkKE=;\n b=/8a1gdHFNDnUXPkzAKbp5tKs18MeYli+pR3dwqvDcJ2Sn3OxgcdfCYa9e9O55DbQxq0cAe\n VhCvi5YnEcTEK0Dw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381427;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DYM15ZCEzaavHO8mCOfxSzn/Gfj4uM9ceO5chRfQkKE=;\n b=TABpM8iwc2H4gQwKsgCPnGx/irZo567NFpkHyMvvphLCZJ30PC9cDzs1ZvaAL7Gi4hle4m\n zZTuRQUe+msMk17u0FXKQ12uH+nIxBbzAhnzX1VabFs6RPDoFTvnYK3zI2BLmrsUGeeH2h\n 9oZ9+N5w60XrLhaG6z0kjXMvtMrnP8E=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381427;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DYM15ZCEzaavHO8mCOfxSzn/Gfj4uM9ceO5chRfQkKE=;\n b=/8a1gdHFNDnUXPkzAKbp5tKs18MeYli+pR3dwqvDcJ2Sn3OxgcdfCYa9e9O55DbQxq0cAe\n VhCvi5YnEcTEK0Dw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"[RFC PATCH v1 07/17] vmstate: Create and save ptr marker in same\n function","Date":"Tue, 24 Mar 2026 16:43:22 -0300","Message-ID":"<20260324194333.30004-8-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260324194333.30004-1-farosas@suse.de>","References":"<20260324194333.30004-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"A2A6B4D217","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move the creation of the pointer marker along with the vmstate_save\ncall that writes it to the stream.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 78 ++++++++++++++++++++++-----------------------\n 1 file changed, 39 insertions(+), 39 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex a190c3f63f..0975d10793 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -54,36 +54,6 @@ vmstate_field_exists(const VMStateDescription *vmsd, const VMStateField *field,\n return result;\n }\n \n-/*\n- * Create a ptr marker field when there's a NULL pointer detected in the\n- * array of a VMS_ARRAY_OF_POINTER VMSD field. It's needed because we\n- * can't dereference the NULL pointer.\n- */\n-static const VMStateField *\n-vmsd_create_ptr_marker_field(const VMStateField *field)\n-{\n- VMStateField *fake = g_new0(VMStateField, 1);\n-\n- /* It can only happen on an array of pointers! */\n- assert(field->flags & VMS_ARRAY_OF_POINTER);\n-\n- /* Some of fake's properties should match the original's */\n- fake->name = field->name;\n- fake->version_id = field->version_id;\n-\n- /* Do not need \"field_exists\" check as it always exists (which is null) */\n- fake->field_exists = NULL;\n-\n- /* See vmstate_info_nullptr - use 1 byte to represent nullptr */\n- fake->size = 1;\n- fake->info = &vmstate_info_ptr_marker;\n- fake->flags = VMS_SINGLE;\n-\n- /* All the rest fields shouldn't matter.. */\n-\n- return (const VMStateField *)fake;\n-}\n-\n static int vmstate_n_elems(void *opaque, const VMStateField *field)\n {\n int n_elems = 1;\n@@ -592,6 +562,42 @@ vmstate_save_field_with_vmdesc(QEMUFile *f, void *pv, size_t size,\n return ok;\n }\n \n+/*\n+ * Create a ptr marker field to precede an element of a\n+ * VMS_ARRAY_OF_POINTER VMSD field. This indicates whether the\n+ * following element is a NULL pointer or a valid pointer. This is\n+ * used to know whether a pointer needs to be followed when loading\n+ * the data.\n+ */\n+static bool vmstate_ptr_marker_save(QEMUFile *f, void *opaque,\n+ const VMStateDescription *vmsd,\n+ const VMStateField *field,\n+ JSONWriter *vmdesc,\n+ int i, int max, Error **errp)\n+{\n+ g_autofree VMStateField *fake = g_new0(VMStateField, 1);\n+\n+ /* It can only happen on an array of pointers! */\n+ assert(field->flags & VMS_ARRAY_OF_POINTER);\n+\n+ /* Some of fake's properties should match the original's */\n+ fake->name = field->name;\n+ fake->version_id = field->version_id;\n+\n+ /* Do not need \"field_exists\" check as it always exists */\n+ fake->field_exists = NULL;\n+\n+ /* use 1 byte for the marker */\n+ fake->size = 1;\n+ fake->info = &vmstate_info_ptr_marker;\n+ fake->flags = VMS_SINGLE;\n+\n+ /* All the rest fields shouldn't matter.. */\n+\n+ return vmstate_save_field_with_vmdesc(f, opaque, field->size, vmsd, fake,\n+ vmdesc, i, max, errp);\n+}\n+\n static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, JSONWriter *vmdesc,\n int version_id, Error **errp)\n@@ -635,7 +641,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n int max_elems = n_elems - i;\n \n if (field->flags & VMS_ARRAY_OF_POINTER) {\n- const VMStateField *inner_field;\n bool use_marker_field, is_null, use_dynamic_array;\n \n assert(curr_elem);\n@@ -688,14 +693,9 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n \n if (use_marker_field) {\n- inner_field = vmsd_create_ptr_marker_field(field);\n-\n- ok = vmstate_save_field_with_vmdesc(\n- f, curr_elem, 1, vmsd, inner_field,\n- use_vmdesc ? vmdesc : NULL, i, max_elems, errp);\n-\n- g_clear_pointer((gpointer *)&inner_field, g_free);\n-\n+ ok = vmstate_ptr_marker_save(f, curr_elem, vmsd, field,\n+ use_vmdesc ? vmdesc : NULL,\n+ i, max_elems, errp);\n if (!ok) {\n goto out;\n }\n","prefixes":["RFC","v1","07/17"]}