{"id":2215586,"url":"http://patchwork.ozlabs.org/api/patches/2215586/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-3-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324194333.30004-3-farosas@suse.de>","list_archive_url":null,"date":"2026-03-24T19:43:17","name":"[RFC,v1,02/17] vmstate: Remove vmstate_use_marker_field","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cef67c2f954ee7220a918362b5719be73babb229","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324194333.30004-3-farosas@suse.de/mbox/","series":[{"id":497339,"url":"http://patchwork.ozlabs.org/api/series/497339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497339","date":"2026-03-24T19:43:16","name":"migration: vmstate_save|load changes for peterx","version":1,"mbox":"http://patchwork.ozlabs.org/series/497339/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215586/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215586/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=DRINr/ce;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=9v1oANsG;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=DRINr/ce;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=9v1oANsG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=\"DRINr/ce\";\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9v1oANsG"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgL8M2F14z1xy1\n\tfor ; Wed, 25 Mar 2026 06:44:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w57fU-0003DK-W8; Tue, 24 Mar 2026 15:44:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w57fH-0003BO-Cb\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:43:48 -0400","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w57fF-00083V-Q9\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:43:47 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id D94A95BE1D;\n Tue, 24 Mar 2026 19:43:39 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B19C943FE4;\n Tue, 24 Mar 2026 19:43:38 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id qKsEIGrpwmlkMQAAD6G6ig\n (envelope-from ); Tue, 24 Mar 2026 19:43:38 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381419;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mOj3zMUeBqO9nHYs5Dx7oYii7b7IiXytgZof79LgWPU=;\n b=DRINr/cehm+I6s678RRyGv01dVLI6BZPjlBucnhosyw/zsx7O5Q+fMjsV0xhdNOnkzIlI2\n OkXeL9ppvpFWNeS30JmYSPcI+VcFawtIr1hmIaH+DvAkZiJecWU3HZDrDk2ivuvI4csWLa\n ifca4sJJavwjXX+BbFm10Q0KyOXIDNc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381419;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mOj3zMUeBqO9nHYs5Dx7oYii7b7IiXytgZof79LgWPU=;\n b=9v1oANsGkUrZshmbXwD/jmO1O0RZgxYt3J2FAMX5H8s4UVDBUG7MBs8vnQUtyqqIXhK6VG\n FZxRZGNCPOALbrCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774381419;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mOj3zMUeBqO9nHYs5Dx7oYii7b7IiXytgZof79LgWPU=;\n b=DRINr/cehm+I6s678RRyGv01dVLI6BZPjlBucnhosyw/zsx7O5Q+fMjsV0xhdNOnkzIlI2\n OkXeL9ppvpFWNeS30JmYSPcI+VcFawtIr1hmIaH+DvAkZiJecWU3HZDrDk2ivuvI4csWLa\n ifca4sJJavwjXX+BbFm10Q0KyOXIDNc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774381419;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mOj3zMUeBqO9nHYs5Dx7oYii7b7IiXytgZof79LgWPU=;\n b=9v1oANsGkUrZshmbXwD/jmO1O0RZgxYt3J2FAMX5H8s4UVDBUG7MBs8vnQUtyqqIXhK6VG\n FZxRZGNCPOALbrCQ=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"[RFC PATCH v1 02/17] vmstate: Remove vmstate_use_marker_field","Date":"Tue, 24 Mar 2026 16:43:17 -0300","Message-ID":"<20260324194333.30004-3-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260324194333.30004-1-farosas@suse.de>","References":"<20260324194333.30004-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"D94A95BE1D","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Bring back is_null, but set use_marker_field based on it. This makes\nit clear that the compression logic is only because of the null\nmarker. When the marker is not null, it doesn't make sense to\ncompress.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 36 ++++++++++--------------------------\n 1 file changed, 10 insertions(+), 26 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 7d7d9c7e18..7edfa3d990 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -240,22 +240,6 @@ static bool vmstate_post_load(const VMStateDescription *vmsd,\n return true;\n }\n \n-\n-/*\n- * If we will use a ptr marker in the stream for a field? Two use cases:\n- *\n- * (1) When used with VMS_ARRAY_OF_POINTER_ALLOW_NULL, it must always be\n- * present to imply the population status of the pointer.\n- *\n- * (2) When used with normal VMSD array fields, only emit a null ptr marker\n- * if the pointer is NULL.\n- */\n-static inline bool\n-vmstate_use_marker_field(void *ptr, int size, bool dynamic_array)\n-{\n- return (!ptr && size) || dynamic_array;\n-}\n-\n bool vmstate_load_vmsd(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, int version_id, Error **errp)\n {\n@@ -318,8 +302,8 @@ bool vmstate_load_vmsd(QEMUFile *f, const VMStateDescription *vmsd,\n curr_elem = *(void **)curr_elem_p;\n }\n \n- use_marker_field = vmstate_use_marker_field(curr_elem, size,\n- use_dynamic_array);\n+ use_marker_field = use_dynamic_array || (!curr_elem && size);\n+\n if (use_marker_field) {\n /* Read the marker instead of VMSD first */\n if (!vmstate_ptr_marker_load(f, &load_field, errp)) {\n@@ -634,7 +618,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n int i, n_elems = vmstate_n_elems(opaque, field);\n int size = vmstate_size(opaque, field);\n JSONWriter *vmdesc_loop = vmdesc;\n- bool use_marker_field_prev = false;\n+ bool is_null_prev = false;\n /*\n * When this is enabled, it means we will always push a ptr\n * marker first for each element saying if it's populated.\n@@ -651,7 +635,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n for (i = 0; i < n_elems; i++) {\n void *curr_elem = first_elem + size * i;\n const VMStateField *inner_field;\n- bool use_marker_field;\n+ bool use_marker_field, is_null;\n int max_elems = n_elems - i;\n \n if (field->flags & VMS_ARRAY_OF_POINTER) {\n@@ -659,8 +643,8 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n curr_elem = *(void **)curr_elem;\n }\n \n- use_marker_field = vmstate_use_marker_field(curr_elem, size,\n- use_dynamic_array);\n+ is_null = (!curr_elem && size);\n+ use_marker_field = use_dynamic_array || is_null;\n \n if (use_marker_field) {\n inner_field = vmsd_create_ptr_marker_field(field);\n@@ -681,16 +665,16 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n */\n if (vmdesc && vmsd_can_compress(field) &&\n (field->flags & VMS_ARRAY_OF_POINTER) &&\n- use_marker_field != use_marker_field_prev) {\n+ is_null != is_null_prev) {\n \n- use_marker_field_prev = use_marker_field;\n+ is_null_prev = is_null;\n vmdesc_loop = vmdesc;\n \n for (int j = i + 1; j < n_elems; j++) {\n void *elem = *(void **)(first_elem + size * j);\n- bool elem_use_marker_field = !elem && size;\n+ bool elem_is_null = !elem && size;\n \n- if (use_marker_field != elem_use_marker_field) {\n+ if (is_null != elem_is_null) {\n max_elems = j - i;\n break;\n }\n","prefixes":["RFC","v1","02/17"]}