{"id":2215575,"url":"http://patchwork.ozlabs.org/api/patches/2215575/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260324192129.2797237-1-shenwei.wang@nxp.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324192129.2797237-1-shenwei.wang@nxp.com>","list_archive_url":null,"date":"2026-03-24T19:21:29","name":"[v3] gpio: mxc: map Both Edge pad wakeup to Rising Edge","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eafa64ab67f54bdee15e6fb1e936c301bd1e3d04","submitter":{"id":74153,"url":"http://patchwork.ozlabs.org/api/people/74153/?format=json","name":"Shenwei Wang","email":"shenwei.wang@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260324192129.2797237-1-shenwei.wang@nxp.com/mbox/","series":[{"id":497336,"url":"http://patchwork.ozlabs.org/api/series/497336/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=497336","date":"2026-03-24T19:21:29","name":"[v3] gpio: mxc: map Both Edge pad wakeup to Rising Edge","version":3,"mbox":"http://patchwork.ozlabs.org/series/497336/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215575/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215575/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=NVSu/sj5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34099-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=\"NVSu/sj5\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.162.58","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgKwP15Z4z1y1K\n\tfor ; Wed, 25 Mar 2026 06:33:57 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A19AB311C725\n\tfor ; Tue, 24 Mar 2026 19:21:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 09E962E091E;\n\tTue, 24 Mar 2026 19:21:53 +0000 (UTC)","from PA4PR04CU001.outbound.protection.outlook.com\n (mail-francecentralazon11013058.outbound.protection.outlook.com\n [40.107.162.58])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE762DEA98;\n\tTue, 24 Mar 2026 19:21:51 +0000 (UTC)","from PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11)\n by AM9PR04MB8908.eurprd04.prod.outlook.com (2603:10a6:20b:40b::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Tue, 24 Mar\n 2026 19:21:25 +0000","from PAXPR04MB9185.eurprd04.prod.outlook.com\n ([fe80::b4c0:6119:2228:2ceb]) by PAXPR04MB9185.eurprd04.prod.outlook.com\n ([fe80::b4c0:6119:2228:2ceb%4]) with mapi id 15.20.9723.030; Tue, 24 Mar 2026\n 19:21:49 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774380112; cv=fail;\n b=cx1cXGZQLiaZcfI888S0QKwMzl7IMAUDrUMn22ms2CZfIuteFiG2W9qwUhxTf6P1IfkM68kE1MPP9bKJI/xSZAaqiSXtb4DBk2jo+DseMLNspNgQApl3eQn2tYPzlOhAxO4nD9D0CtMCfZ6yZquYrTbdMfV9oqG0W+JVef1g32A=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=T5wgZYxbJIQCfCxub/xDvfaW/34Z4xv5E5XFX3GFpOul6PfxUYcdA4/+LIvPF/Mmxf/82EDspXebT7sdioBBh/VkvzT+Xcua5NllytsNCTRU8EtJrUUPWH6Ne2Oa2xjhRg569/BAU9+tCjbjCRlt1twDUvyDSLaVzjLHBMosropmqbIFN8DmNVHEn6lt06wKwkdcdxq0BBrpZ8uqUfONPzK6V6brGn5s5Lmk/v3W0KcazVpCzzyiTAGw4yIJ2MSG2ixR9jel4Mhua1FVyuYewR4nd39okgqaylglD3nv/eUTKjKWXa7WEsEbugQz4n4OyfdxnlD4siJi5aK358F3Ig=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774380112; c=relaxed/simple;\n\tbh=J5E6PHqdYeC1dHVYvfY2xrCvm5G/tylAlW0P4G5r4Is=;\n\th=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version;\n b=rnF2PNObmhUF4PhND6837xzjBmeO2jydgXqA76BEBzbYeBeX3+Zt7NGmOgVY5W5HDIHYVu8i51OZltcNJJxA55g+ZFL8qUyxn8gMSCo/WXLPr9Y8lSV0EMD9Ka4yUtmjd2cwa/hnmcjg4A1Lz6AgLU3ErNx9GMVNgDVrUSVaXs0=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ncgPICka/hsIzvDlFphj2U07gKf2fO15DNOFdXnkCQk=;\n b=H4HCglR/ibGQ7dGmWtGec31Fykt7REn1yxXmqmHF11HNOFBRRoUfPcKNj5AfPVjIhRsaVxepXH+Hxfo7lWR+ZfpTLjHuF2dpY1SpZ4+yV/BUjiZZBqUCFZvGs238dZEzULELQDBr9afGhD0dLOnhtEoWyDYGanLuSS89KuBnyuxqqF7febyIwW4vm1viOs+hR2oI/D+g+t7nsZmC7zUUluhledaCeftJVxsxxUf/lbhfBJ+vysOG9O7yxBs7bJ+YJyl2htckRh66c7ofbSBQQvG93c/G9LcQ8FLyacsUapbtxi5S252GdvnbfrGzYj3sUPPI8rLUTj4bYJHTcpWWbg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com;\n spf=pass smtp.mailfrom=nxp.com;\n dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=NVSu/sj5; arc=fail smtp.client-ip=40.107.162.58","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ncgPICka/hsIzvDlFphj2U07gKf2fO15DNOFdXnkCQk=;\n b=NVSu/sj52AJV8VDExQ9ye0p/O1u75Dcf1/ebRmjVAFSTT7NBcYho/ylaeu8byubq9IdFfS5UNFH0IoBRWRNLuCup6Jm+On+I0vat/XkzhTywzvRxCUvMIKyQgmDlhJgp5Wx20rKWOxyHpby8/4PLuUZFyhwsUsDlinnE2t7mvbXqrt6YNUSHQewIoZvjGS9mWTnVA//WExyZSlcj+bUOI34q8HaoK+EovkYzQPJUgB/i+OCMCU9sAgTY6D00GLO0IZNPFojuVejTqxyQMcDhOY3tcm9FXGqIziHGvKyqfCVsyKD+YqRE64p6naVjMr9LBvRyAAlUTCgwiPf0enaB0Q==","From":"Shenwei Wang ","To":"Linus Walleij ,\n\tBartosz Golaszewski ,\n\tFrank Li ,\n\tSascha Hauer ","Cc":"Pengutronix Kernel Team ,\n\tFabio Estevam ,\n\tShenwei Wang ,\n\tPeng Fan ,\n\tlinux-gpio@vger.kernel.org,\n\timx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-imx@nxp.com,\n\tstable@vger.kernel.org","Subject":"[PATCH v3] gpio: mxc: map Both Edge pad wakeup to Rising Edge","Date":"Tue, 24 Mar 2026 14:21:29 -0500","Message-ID":"<20260324192129.2797237-1-shenwei.wang@nxp.com>","X-Mailer":"git-send-email 2.43.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"PH7P220CA0087.NAMP220.PROD.OUTLOOK.COM\n (2603:10b6:510:32c::35) To PAXPR04MB9185.eurprd04.prod.outlook.com\n (2603:10a6:102:231::11)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PAXPR04MB9185:EE_|AM9PR04MB8908:EE_","X-MS-Office365-Filtering-Correlation-Id":"cc286008-e2c3-48bc-a122-08de89da98b5","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|52116014|376014|7416014|1800799024|19092799006|366016|38350700014|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tre+hW3roJbRXdKecy/VCoZnrOdy4O2KPBU5K1PI9GL8BhhMLzIUS3n/tU0aEnBuH76MD3ZaFiW/ivVIkksR+MUUz9Uzx9bPGz8CNZ1TCbouROE57Cs9fntODCT8+Y4I1Go0++Ceof3LnBDtMwf/aN+Ohb/bMGYjiJ2ofmCzai7yPpNzzCCQNYFw7Ptu1SZEhF1njOJ0UfKjgHGgZye+Ajx90Lt0brai1ZBxPS0zCEcECt98qrErgBNCbB+s3lWPtQTWgqjTxaMvP5+dW049BsaIpFnnnPb/4DFSgsATpvuvYvF7DxX56blUnJOUaGUEacrEXTLhlRfD206re8h/pM+rBGOs+oqXyHzFqBppR4kPIE2a0rPRGrTcGzd9hKgIa14MGIpzJ+INQdYwUrKzeltBor3Tt9M4IjGnvasUah1N3xm6V9GS/3Y0U4zxaFNRJcJm94KIa8Ous9jllDAv3I0YGIG2nFTvQLq8GNrM3K0dCRl5a4I4Ae22eBWuRWBoBnZOg1wSXPEQow0vSIeFiOasmmtaMSAffso5izo4lgELY8oexL6qb1PrxRQjImRaUnRys1BeMlymTNuuAnu+dKM+F4Fw8Rj9pJJovu8hQ2KFiCSS4NYGqKqodtd8jMH1f7L9oSMlpnIuVkAkoC9VyDMZP/DyoGDqMBb61whyaf7dZD3poDSUtmkFSlg5v/WH92EI5b1optT9taMlazs7tZVq5KXFN0v8q7ZD6jmKYgDSYuO/hJJU4sKHT72A1Oo5inLw2MgpozgGB99yF9ZTsXBJoCL/dcjgu4m9kG8eibGk=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9185.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(7416014)(1800799024)(19092799006)(366016)(38350700014)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n QMW+RN01qX98JrkxG7ZyQpbI6+7lgbI7N6VRiUgJIqQ9TB5dGN5yizM03XD5+fiGBdiHaazhgmx39CDrAbbl6l2RVTE6abMDup8+jqEva2REUCSjojGv0HP0rkrRJpcOy4ReflkVNjibUX5+vALciGGY1QAXmu8WLJ7zD/WhazhjFnTYWMYwIFsG3wY93NkmODqdmz5Mnkss98vjqQ82WJRJ5wN39Dc1x4eJrHBNVS6DdSN9GGKoe7yizlm07h8vfb/+MmWq9MebBjksQAP7xLFp6nqDVLtCl5q4Lw3IBbL/TlwpyUsg37jZYmoQOzPrdrjxluHwbKz59LjbWXiIucA4WX6twpG5ZI98vFZNrIV+srcGb75m6nea9DH7oYQo2UD6fIFR8tj830BPXxT8rYx4blnnkaKKUHwq31SpQ/tcfjMKPQOxCv9DtKnoM/UgbrfXrWmbE5HR2nxQD0SvLZjSxydhpl0VOWdM8NgWNTNF3Q9Ht8yEhtonAx0HHhTISrycO3cwDXml+IfDo0fzOa/uTWYq+NSK40ljWURSQgVB8c8EoRm2TSOEKBZCx47i6pJvsNSK3muPHbDxQ0dT60IrCRQfkHC22CQ3oj680JpHigprw74ibbza9pnWWHzoaZJlRBsW7FqBIWYSihiga1Fuz3CB8o1HCpyqs3YrWB0btWWFYDqPM0HwzFNlXG6XvqDr1uf1Fuh8mDVaWmiHOfD4WNZHq6mVlQazNFc/VwZLP9tnHXnR3FqRTyyoeMDRNJV+6vDkKTz3J9cAejiboyA4YBgPbYhduHvrjZMckhNR4wkZTgH32VtEsSHq6cTxkJPgs/wu3tvbsHlevGQ1CnLQazMZRkdeOK6zHKcRgin8ktuPyFTGAuBEQAwHSjZEwH0mu+HDagQmVLWrFQ1P/ZV+duz5XF6Kz7MWCKly+WoCkwMNKbX/bz/tGG+kIZcpQtQMnHguzl/5fHvKVxX02+mF+34WyFU/632+4WlCa9jREVpNzs+I9EamVJ3o4bpzwz2Gj1XXkSNscLLFj0fE7ab2/JlFLGqku5I0ZZpbLmVTOwOP+jAkMqxF1faN/w08RUYXBAERgz2AQ8IalMQPFT1G5JhaMk/+KQfcWNdmfT1x7/1qqWXtVKyhgZ4adrUpdBOGzbwvM+vAQM9/bVik5u7Y5s9w3g9ghhPIlc67qJG4spYAX9BOWN4yfT4142M8cLg9VETP+FTVKUWvjZ2aIJjQzX3fXRWnqihT16H6oWilECKMDB6TT69YpgnDquQIKwpxVkO/cMutl6kab6TYqx3j3D0xMGon10LASqFrMU/KT2tcCOsCr3+UKLTYlkAjcYLF3ACwr+ym96jkxfBQQSbc1VE3XsjCGrKAHp7DfKXU57QmLhgrVXQVfNBPe9Cm+kZUmxS8dADXxlTEjTzuKy0ObUg30JydFd0u9CYLLKu7iOKWwXSA+8IE6KIdbM11soWlMIEDUzg+SoQt5Vs3xw8WGNC9UuxgRFJirJkmXlnzYPXV+NvLdp5i/JP63xI5SqJsmNfMy+h331Ru+qA/XjRCuqLjbT/Rsz6+ozbImiCTP8BFH212RV6GvjZ43QO6FJRQe1w7yAqUebB1XjJMQmdtgU/ljW8hUUjJOkWT28K+smPvPXucbVpat3TCALz8DcwAjh2rfjsNRXZY9qlDnCzOO7HtkyOfWJzSi0NGfs/qSwCjAyEwbBkUz9cv3nRR3cQRBz0tG38XHLOZrTjqTg==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n cc286008-e2c3-48bc-a122-08de89da98b5","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB9185.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Mar 2026 19:21:49.3379\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n mMX2U/voD9AinS13BgHiYAGE4BqrjVbVgTqeObRzvDeSpBi0fnslg+2s4VuCZhn4tRf35PhqYwmCp/GC3zStLw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM9PR04MB8908"},"content":"Suspend may fail on i.MX8QM when Falling Edge is used as a pad wakeup\ntrigger due to a hardware bug in the detection logic. Since the hardware\ndoes not support Both Edge wakeup, remap requests for Both Edge to Rising\nEdge by default to avoid hitting this issue.\n\nA warning is emitted when Falling Edge is selected on i.MX8QM.\n\nFixes: f60c9eac54af (\"gpio: mxc: enable pad wakeup on i.MX8x platforms\")\ncc: stable@vger.kernel.org\nReviewed-by: Peng Fan \nSigned-off-by: Shenwei Wang \n---\n Changes in V3:\n - improve the warning message per Alexander's feedback.\n\n Changes in V2:\n - add a check for i.mx8qm and emit a warning when Falling Edge is\n selected.\n\n drivers/gpio/gpio-mxc.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)\n\n--\n2.43.0","diff":"diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c\nindex d7666fe9dbf8..647b6f4861b7 100644\n--- a/drivers/gpio/gpio-mxc.c\n+++ b/drivers/gpio/gpio-mxc.c\n@@ -584,12 +584,13 @@ static bool mxc_gpio_set_pad_wakeup(struct mxc_gpio_port *port, bool enable)\n \tunsigned long config;\n \tbool ret = false;\n \tint i, type;\n+\tbool is_imx8qm = of_device_is_compatible(port->dev->of_node, \"fsl,imx8qm-gpio\");\n\n \tstatic const u32 pad_type_map[] = {\n \t\tIMX_SCU_WAKEUP_OFF,\t\t/* 0 */\n \t\tIMX_SCU_WAKEUP_RISE_EDGE,\t/* IRQ_TYPE_EDGE_RISING */\n \t\tIMX_SCU_WAKEUP_FALL_EDGE,\t/* IRQ_TYPE_EDGE_FALLING */\n-\t\tIMX_SCU_WAKEUP_FALL_EDGE,\t/* IRQ_TYPE_EDGE_BOTH */\n+\t\tIMX_SCU_WAKEUP_RISE_EDGE,\t/* IRQ_TYPE_EDGE_BOTH */\n \t\tIMX_SCU_WAKEUP_HIGH_LVL,\t/* IRQ_TYPE_LEVEL_HIGH */\n \t\tIMX_SCU_WAKEUP_OFF,\t\t/* 5 */\n \t\tIMX_SCU_WAKEUP_OFF,\t\t/* 6 */\n@@ -604,6 +605,13 @@ static bool mxc_gpio_set_pad_wakeup(struct mxc_gpio_port *port, bool enable)\n \t\t\t\tconfig = pad_type_map[type];\n \t\t\telse\n \t\t\t\tconfig = IMX_SCU_WAKEUP_OFF;\n+\n+\t\t\tif (is_imx8qm && config == IMX_SCU_WAKEUP_FALL_EDGE) {\n+\t\t\t\tdev_warn_once(port->dev,\n+\t\t\t\t\t \"No falling-edge support for wakeup on i.MX8QM\\n\");\n+\t\t\t\tconfig = IMX_SCU_WAKEUP_OFF;\n+\t\t\t}\n+\n \t\t\tret |= mxc_gpio_generic_config(port, i, config);\n \t\t}\n \t}\n","prefixes":["v3"]}