{"id":2215550,"url":"http://patchwork.ozlabs.org/api/patches/2215550/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260324190755.1094879-13-mmaddireddy@nvidia.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324190755.1094879-13-mmaddireddy@nvidia.com>","list_archive_url":null,"date":"2026-03-24T19:07:53","name":"[v8,12/14] PCI: dwc: Apply ECRC workaround to DesignWare 5.00a as well","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0e433bfa6a1fd1829066e1b4ee9865d5a45b7091","submitter":{"id":72399,"url":"http://patchwork.ozlabs.org/api/people/72399/?format=json","name":"Manikanta Maddireddy","email":"mmaddireddy@nvidia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260324190755.1094879-13-mmaddireddy@nvidia.com/mbox/","series":[{"id":497331,"url":"http://patchwork.ozlabs.org/api/series/497331/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=497331","date":"2026-03-24T19:07:42","name":"Fixes to pcie-tegra194 driver","version":8,"mbox":"http://patchwork.ozlabs.org/series/497331/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215550/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215550/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-pci+bounces-50961-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=SS07fZWd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-50961-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"SS07fZWd\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.62.43","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgKXL2X9Xz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 06:16:34 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C8A0130EE3E0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 19:12:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7F7C43C13ED;\n\tTue, 24 Mar 2026 19:10:01 +0000 (UTC)","from DM5PR21CU001.outbound.protection.outlook.com\n (mail-centralusazon11011043.outbound.protection.outlook.com [52.101.62.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D343BF69C;\n\tTue, 24 Mar 2026 19:09:57 +0000 (UTC)","from BY3PR05CA0051.namprd05.prod.outlook.com (2603:10b6:a03:39b::26)\n by MW6PR12MB9018.namprd12.prod.outlook.com (2603:10b6:303:241::6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.13; Tue, 24 Mar\n 2026 19:09:49 +0000","from SJ5PEPF00000203.namprd05.prod.outlook.com\n (2603:10b6:a03:39b:cafe::6) by BY3PR05CA0051.outlook.office365.com\n (2603:10b6:a03:39b::26) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.31 via Frontend Transport; Tue,\n 24 Mar 2026 19:09:49 +0000","from mail.nvidia.com (216.228.117.161) by\n SJ5PEPF00000203.mail.protection.outlook.com (10.167.244.36) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9723.19 via Frontend Transport; Tue, 24 Mar 2026 19:09:49 +0000","from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Mar\n 2026 12:09:31 -0700","from mmaddireddy-ubuntu.nvidia.com (10.126.230.35) by\n rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.20; Tue, 24 Mar 2026 12:09:25 -0700"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774379401; cv=fail;\n b=HTw/MSCEgVJwLnagbmYgzopj41ScyY78IaWZ6pT2ZCskbLVxQna+ftxHLrfAQC9JBkNvruPBr++z7iTbc/UHma1tFsCr8Vvu6TZfhykFHTvkfLmFAs7DYQBaQ5LG0Z02GruQWiFVNsPXTKP7Iccy6xYmB6Y+uFfxtm6lMbwPkDM=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Sz4IjZMr9MzTY8hxS++RizvC+ENTRT70A8mm+h5DrTsJFGwvjq1NGmsP+0MEXXHPtIPpMts6CuYXKMVIxzNVcVaq7X4oaa/dpa6WE1zKlheGfEd3SIYfhbgbVxQ4zOj4rvgCHj6n7LBJm3UlMAxpMHZUBOs3Q2GpxR2ZmUV4l442vXEWTJYPRsx48EqLrfxggoe1pFsXp+BoD60ncTANSzDYIFiF8guqLY5hR0ZlDVgsmAo2fxs1KqzhUmqs/GUX+92rZ3wawGw/HSb5GyiFCDNw4CvM8N7tzETJEj1wcGtm7oSzR1QsAijlAdFaaZ3bv79zPAQjvSLR4rfm2sNq8w=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774379401; c=relaxed/simple;\n\tbh=AY2ruoYVGY8NAm0QPBxwMKN+sF2ReOLL7p2AjH+diKs=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=L2LYcoxPR6g8eAe1HAH29zUgnkIqT/CaZuOdqFGY9oFT20wVNKOgs8VfdaU6ty25x+mZoBKPKHPbYbcCNz8U6mANIjS8YKqlxBdVXgmhWW9yqEYwcBy2wqcjntYI/LpfoiDt5DYAPqjvhwaicTRHI1NeHKp4iFdcZMQLyOuV0UE=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ozXgiU8Mn692nH4+wF6S87pJ7QS7mwwXtutJJ+B8Hcc=;\n b=fKHIP63y29DG3Z/1MIaf6xs5azeh95UHUr2sZLnybSRBuIifw3NnBX0hI4pM9E5FZT8/D16FsUrnn78jCT+4FNDENT1tby9bk3Up2ZYh4dxTPazf6AaaZt6HUUp5IWasKIMU5NIgZGeCGxdFYgXT8sfdj7Jus5OpQ4PbWyk1xrOdluYUwnAQEe0LJsbVALm2a/i0LzVFB/1yH9Nca9ii0TxiDppV3jQiTiD+2hxrKwFYfjMqLeavgVh6C0PKhIugR3PZM+YuecVhop/zEZPOYYWt7Q86Pad/uk0zVpC8eaxzpeBOp3WXM4v5K3N/mWstcISvIp1kej/1Jbk+1weTjQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=SS07fZWd; arc=fail smtp.client-ip=52.101.62.43","i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ozXgiU8Mn692nH4+wF6S87pJ7QS7mwwXtutJJ+B8Hcc=;\n b=SS07fZWd9R21yfEzWsjRAf2U9LauH1uFhN44x6MR9XViKeekKRFqUCAYHwgfL4PtsquemZyPkWGk1B1foTeeopgjUlzRG7kOHQGgmCH34QNnXMPfgwldjvn154bFvepP0F5RxcfXHVXnX/a353p+0F+riEG9CfHmLC10/Aua6J+XTtapzxSDV1E4pzhm1MZCi+DUvJ/GJAnYliPMFdTUI4Ru73bjclgOPPMFhGW+ujTw/eVLgXiw2PYtuX44fQe05lhB4hU3Vo4KMkQn8PEhwqlAqWU3zuX20cchoHIIEPFDz7fYc3MONGcggk81n5MHfLPVey2bmPjpXGSIYJFMog==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;","Received-SPF":"Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C","From":"Manikanta Maddireddy <mmaddireddy@nvidia.com>","To":"<bhelgaas@google.com>, <lpieralisi@kernel.org>, <kwilczynski@kernel.org>,\n\t<mani@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,\n\t<conor+dt@kernel.org>, <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,\n\t<kishon@kernel.org>, <arnd@arndb.de>, <gregkh@linuxfoundation.org>,\n\t<Frank.Li@nxp.com>, <den@valinux.co.jp>, <hongxing.zhu@nxp.com>,\n\t<jingoohan1@gmail.com>, <vidyas@nvidia.com>, <cassel@kernel.org>,\n\t<18255117159@163.com>","CC":"<linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,\n\t<linux-kernel@vger.kernel.org>, Manikanta Maddireddy <mmaddireddy@nvidia.com>","Subject":"[PATCH v8 12/14] PCI: dwc: Apply ECRC workaround to DesignWare 5.00a\n as well","Date":"Wed, 25 Mar 2026 00:37:53 +0530","Message-ID":"<20260324190755.1094879-13-mmaddireddy@nvidia.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260324190755.1094879-1-mmaddireddy@nvidia.com>","References":"<20260324190755.1094879-1-mmaddireddy@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-NVConfidentiality":"public","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ5PEPF00000203:EE_|MW6PR12MB9018:EE_","X-MS-Office365-Filtering-Correlation-Id":"8ca712df-329a-489f-e019-08de89d8eb90","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|82310400026|1800799024|36860700016|7416014|376014|921020|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tJFFl9oprFPoapkidc2Cua7v7DxQmEQf+A+3Y5MVDFz6AqEsdyEj3mHK7+SXft8tS+B34RZB2XZFp6RZZXNf3E0IF1/A0GnD9A65bd+fJVuFYBL+vDqy1xHhukfZxx23oTZfbP/lsHgcr04y/8wenCPTA2yOMQwxZBdujWACoh+uGuL5U0Gbfdrgyc8hAWmLShCR/j3MitvGLavsfcJeqKHaDBfa+4WjKzQ7kruHlppaGoM9t7n+cTppETATRY08X1LgChjyWHGMDc+WvubRIfi28gDTJuNz2+EW2I2BdwZXJg2bUMN9tykLt5KSQIlJDjft6GZiG8KjBBqz42czjM612c2LAWbic0TU+kvdeLqEfDMq3xVnvD+YOV4ZuRop6P2w/mmC/78LZBK5FMcVjwpYXvW5CZMG/uJXzWXiU7Q/rOtVx9qysPKwMW7PSNRRda1vIZkzJT69+a5hWiPI2MIUHAGCUMnRzNjffBnuZmPRZpGCIXWUApI+eXqNrjh+RnUTY4+d8oAUssyp3fCXCU47a5vZTaYnpEGvLRJg5Uy96qEmcjxlpyjBwZT1a1hk5HMkZ47301d9XXmT/p/US30F05rgRqQg2BAw11C16ON6HTxgOqE45WECtrV0ZZjczp+jWQ/CyMZ5QV4xU+VRiuIHGzJyjubXvpUBDMBHflXAF7SazNDDuwOkTfY1R8NR6huCde8rsN8dIM+Qp7Aq+zOkrgHbgQcn4Qywx25LB1KZVaIh9vcn5SCApYohESNSFoPmMT5Tq1RtEDdsulyysA7c+2NanFx0/cGyFvPP5EC7GsNdivOOpJTbXwWc1awZZ","X-Forefront-Antispam-Report":"\n\tCIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(7416014)(376014)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n\tbnxF2ufqK0bUGiSBZO/Yh2cmRu8sakzuq+m5ovJPxOVVvK+8KPIj9p8tN8K9Wmiwt9jgM0Jj2XZCNEQPB9fLp+Sa+UkG+hLQ4dXDoK89yMBAYeb7pTTQb/Xay050J5pZ4dYp4dWpreHpKAkMcg+EGv2Jif87X+vcllstGnxN9a1q+vaONcIknbhN4oWn+BJhSCIZiWaGB3kRhb0Ps/fCb/3d2Xd+k7TWR3VvdcTbfmI/f/URTziMqZewnZgLPrvl6h2hr9qbRZGTRimVFh5MoPI9DLZUhmZij/fCJ3G+d/UrCWZE7z7swm/xpsZc1enXxOQpnl73k+i5cWgk4j0RMJcVK8hz9MPGBl+6w+BDZN36wKhGlcbwazK9Nzbp3UBh8X/2wga4oqBHDuGVKBvTv8G40YajXm8CJvIb3oNTg09K1DbpkxuyohLrI2wFXpve","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Mar 2026 19:09:49.1005\n (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 8ca712df-329a-489f-e019-08de89d8eb90","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n\tSJ5PEPF00000203.namprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MW6PR12MB9018"},"content":"The ECRC (TLP digest) workaround was originally added for DesignWare\nversion 4.90a. Tegra234 SoC has 5.00a DWC HW version, which has\nthe same ATU TD override behaviour, so apply the workaround for 5.00a\ntoo.\n\nFixes: a54e19073718 (\"PCI: tegra194: Add Tegra234 PCIe support\")\nReviewed-by: Jon Hunter <jonathanh@nvidia.com>\nTested-by: Jon Hunter <jonathanh@nvidia.com>\nReviewed-by: Vidya Sagar <vidyas@nvidia.com>\nSigned-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>\n---\nChanges V8: Split into two patches\nChanges V1 -> V7: None\n\n drivers/pci/controller/dwc/pcie-designware.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c\nindex 345365ea97c7..c4dc2d88649e 100644\n--- a/drivers/pci/controller/dwc/pcie-designware.c\n+++ b/drivers/pci/controller/dwc/pcie-designware.c\n@@ -486,7 +486,7 @@ static inline void dw_pcie_writel_atu_ob(struct dw_pcie *pci, u32 index, u32 reg\n static inline u32 dw_pcie_enable_ecrc(u32 val)\n {\n \t/*\n-\t * DesignWare core version 4.90A has a design issue where the 'TD'\n+\t * DWC versions 0x3530302a and 0x3536322a has a design issue where the 'TD'\n \t * bit in the Control register-1 of the ATU outbound region acts\n \t * like an override for the ECRC setting, i.e., the presence of TLP\n \t * Digest (ECRC) in the outgoing TLPs is solely determined by this\n@@ -559,7 +559,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci,\n \tif (upper_32_bits(limit_addr) > upper_32_bits(parent_bus_addr) &&\n \t    dw_pcie_ver_is_ge(pci, 460A))\n \t\tval |= PCIE_ATU_INCREASE_REGION_SIZE;\n-\tif (dw_pcie_ver_is(pci, 490A))\n+\tif (dw_pcie_ver_is(pci, 490A) || dw_pcie_ver_is(pci, 500A))\n \t\tval = dw_pcie_enable_ecrc(val);\n \tdw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val);\n \n","prefixes":["v8","12/14"]}