{"id":2215538,"url":"http://patchwork.ozlabs.org/api/patches/2215538/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260324190755.1094879-9-mmaddireddy@nvidia.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324190755.1094879-9-mmaddireddy@nvidia.com>","list_archive_url":null,"date":"2026-03-24T19:07:49","name":"[v8,08/14] PCI: tegra194: Set LTR message request before PCIe link up","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cada2e2dc8650d2cb368a77d8a21e8015be3d5bf","submitter":{"id":72399,"url":"http://patchwork.ozlabs.org/api/people/72399/?format=json","name":"Manikanta Maddireddy","email":"mmaddireddy@nvidia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260324190755.1094879-9-mmaddireddy@nvidia.com/mbox/","series":[{"id":497331,"url":"http://patchwork.ozlabs.org/api/series/497331/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=497331","date":"2026-03-24T19:07:42","name":"Fixes to pcie-tegra194 driver","version":8,"mbox":"http://patchwork.ozlabs.org/series/497331/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215538/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215538/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-pci+bounces-50957-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=lA9mf+XR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-50957-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"lA9mf+XR\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.48.18","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgKSt3DxHz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 06:13:34 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id B889B306A386\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 19:11:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4109D3BED1B;\n\tTue, 24 Mar 2026 19:09:42 +0000 (UTC)","from MW6PR02CU001.outbound.protection.outlook.com\n (mail-westus2azon11012018.outbound.protection.outlook.com [52.101.48.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7CD396D30;\n\tTue, 24 Mar 2026 19:09:37 +0000 (UTC)","from BN9PR03CA0035.namprd03.prod.outlook.com (2603:10b6:408:fb::10)\n by CH2PR12MB4055.namprd12.prod.outlook.com (2603:10b6:610:78::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 24 Mar\n 2026 19:09:29 +0000","from BN2PEPF000044AB.namprd04.prod.outlook.com\n (2603:10b6:408:fb:cafe::57) by BN9PR03CA0035.outlook.office365.com\n (2603:10b6:408:fb::10) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.31 via Frontend Transport; Tue,\n 24 Mar 2026 19:09:18 +0000","from mail.nvidia.com (216.228.117.160) by\n BN2PEPF000044AB.mail.protection.outlook.com (10.167.243.106) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9723.19 via Frontend Transport; Tue, 24 Mar 2026 19:09:28 +0000","from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 24 Mar\n 2026 12:09:05 -0700","from mmaddireddy-ubuntu.nvidia.com (10.126.230.35) by\n rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.20; Tue, 24 Mar 2026 12:08:59 -0700"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774379381; cv=fail;\n b=TY1t+4e2qo6R0J3lOdmtsjBPyO0il3JtauXjmKKOMg/X0zxPla0QWyf2AtbLzyPNL0JY5oXgFwog92qHyCbLnf0pvTG1vwZkcu/ozQqMJbPb3C0BnAP8cnNBeefU0ytETykzM9LiJxJkIduieI9akZPDxLA2FTn3FgBgDwmVN/4=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=xKb4Ufy58nKrsZOTHSG9Rmw+6wNsjnf3SrIe3nuD3Q2x5fWOfcgtomTFRojQYL1ozBm+21q2WivRnzmZUOLSwVvUF4M/SPQb+VNt4giQTiXHMPZE8UrqMDyXdL/0ftS+mdccIqP+UOOvy2+v3g0xu0IT9h6n0yHd9Et5RZ7bMWDnL+rhRjrt7ZMq/ez2Q2iQ77m5lXpvb2qBxEBDKOyMP5PXLR8P878za3VlaCRNRmGB9dGL05tyWVsWuO0M32kT+3l49xycYQ03u6D5ktcykbGR0Pk0sawxQIvGusmj9MHtbmvzbApGuhGlvX/pQ42NTt1yGKLzj+xA4UO7+XTeXw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774379381; c=relaxed/simple;\n\tbh=42cvJMWsslbiGQ400nFWvVkC/Ti/i0gG4mAZUlaF6cU=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=l7ScBXcW0w6Q6pJ2LAOWgQjWMsbCLskqKsNVTD8DnzCT1T2BAR5F+ZPyXOWBE6Z5eocAKHJPvlXK4H0InVrrmDaIbhI5WdHDgx9lKp6ROpDaTjaR3j68Nnk0DqrYoEoY8/Jsx1ndiAYIfUaVmrtItCOZxSjVweTUuxBCqXy4Hdw=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=07qSncn+4k1XpLnHxz+EkcNO1OPIZO1OoIXE83ontrY=;\n b=ekKpZsWNx81wFiYuKY3h7vFlr2GTdRoxU6wwCKjGVqoDBt+k+hUmRLlT9/BgvOsl6TFiWd+5nFN9Fyj/5mDpgGcAp6NVextzsn3ZuEk4jv/qrLtWzowew85zgiM4G0u2KXsqZpQjF7/MzRtVb5uvT02cQSqANV8noHy10RRUC0YhWgYxem9mu82Hi+MLbvIPXZXCVg9rf/lYxBNplnsss+I9jQA/ZdzBNLzbSoxMrHjscUu+RYyqOfdXQgDsWzORoMIcJR+gVEuqAvOD85uOnPY/U6vCJOBNvoFg9Ii79waCpJuVHpb/PpNKCNIuhj+gbtQjbxFtBswc2PpYlbZlMQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=lA9mf+XR; arc=fail smtp.client-ip=52.101.48.18","i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=07qSncn+4k1XpLnHxz+EkcNO1OPIZO1OoIXE83ontrY=;\n b=lA9mf+XRea3YWQMLB8Zf7D9bjixfFy1M5dXYnKeA+7PZ8ak9M0FuXKTnLFYDFxxQecH43caSNhmePclfh2b7AGahnO3IDVHzcvuLzQEhN8kXfBsKW9YiLAWE6HPV1HYoLU2Oa5vI6W7qHDA+49oggQTYWJ2z1gcJjmyNiXFsojfzqKYNGK5UOjQ9W8GU0HwBXQ3oDjrgNXgnVEoedX6o1pkHhWIjLLuuoOoRNytPt+HjFpN2AScVkmFZUq9G5GWwHJN1351zZv+t5aNFm4GB4PgFTgwr4HuHwLKizPMYhYcw9tkBbLD1vRrxOfnFGpx3HfaK2Op0oT2RIbKDjmCkYg==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;","Received-SPF":"Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C","From":"Manikanta Maddireddy <mmaddireddy@nvidia.com>","To":"<bhelgaas@google.com>, <lpieralisi@kernel.org>, <kwilczynski@kernel.org>,\n\t<mani@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,\n\t<conor+dt@kernel.org>, <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,\n\t<kishon@kernel.org>, <arnd@arndb.de>, <gregkh@linuxfoundation.org>,\n\t<Frank.Li@nxp.com>, <den@valinux.co.jp>, <hongxing.zhu@nxp.com>,\n\t<jingoohan1@gmail.com>, <vidyas@nvidia.com>, <cassel@kernel.org>,\n\t<18255117159@163.com>","CC":"<linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,\n\t<linux-kernel@vger.kernel.org>, Manikanta Maddireddy <mmaddireddy@nvidia.com>","Subject":"[PATCH v8 08/14] PCI: tegra194: Set LTR message request before PCIe\n link up","Date":"Wed, 25 Mar 2026 00:37:49 +0530","Message-ID":"<20260324190755.1094879-9-mmaddireddy@nvidia.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260324190755.1094879-1-mmaddireddy@nvidia.com>","References":"<20260324190755.1094879-1-mmaddireddy@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-NVConfidentiality":"public","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BN2PEPF000044AB:EE_|CH2PR12MB4055:EE_","X-MS-Office365-Filtering-Correlation-Id":"5c066fd8-322e-4e32-e0df-08de89d8df90","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|82310400026|7416014|1800799024|36860700016|376014|22082099003|56012099003|921020|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\tOVqUGE0IqlMe2oRnhwVW/R1TzTs1kIj3DN+RZEPglmBFNy1HfHHIondR+w3VpoD0EP2oBUM/mCThC5JpsMuDJihpGKI0zsPPHMwvg5oz639SA92GPHCchkpmPk9dUsFC4uAa7jZTeMVcEEwZykwnxWdKjl8vMPQt6fa2R2cHlaUnA1B7j5RcXCogouNogRXx9VCZQHzJ5NoTpPelArauFUjwbP6slvqt/+/Mvyr/sd8LR7RanH+sweJ3PL6tT/+BbQNNBYsOYWT9s6xxlE+YFPN/2N3ALZCelbixSHY8FBn7D8M7vceq9ZSOVcW7tIb5j0OaJGb6bWqHqP7OPPxpWCefRrNrSI2FQxdOinKXK6IYwG9Mw0eoScnpS501vsCZgn1lDL1Lgu0ykJsUS7Av0NhURgx0I2noBRAGsZhMbVHKu3St6r9veAO/ncPyJafc6XbRUTIygWXM0Pv861KXg0DNuKbw2BcVph71TPt9LuY/UJHG37LW73z/JynUj/rS/qAzsF6ZqgRNkEF14fu3h8VN1MxV478TiTGKN4+LMvm5qge/sYBSoBNcyPDYdwlbrX940XgxLzucbRtaQ4k/fLoMX6KssD31OV/hrXwQW3N2ehZCzr0zy0UQBVIPflLhr/nnJT7G6xNaEZrh0ynGD8TMaksC893dME9eVGjubl/OC78aOp7ZMd7h4l275xGCeI9N9LS+MVPZtOAtzcyo29/l/tbYWgVuVGbDN/RSgfnVYlNqDOqMp8UH7tkX4Ru+tGGw8f428juVbzHtzy/wjT7ic4AgmDDvQ4jc0ILXXIn1Qu7Mt/MH3nR2ppi4oIls","X-Forefront-Antispam-Report":"\n\tCIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(1800799024)(36860700016)(376014)(22082099003)(56012099003)(921020)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n\tyIh6zmz+iLTi8uK5iHQ9EfpuK/hL+bZYRSoXcLIHpxvfCusdUFK1gsWvVlhK/RO8gEnTi/y7SqO/Is9uFc8BrQMIhwXspAnVym8rE4o6520v66jff+nS+VnoIehwB0YXlfZ1MSLBCGWZvNMewW2eDYJIzrlwxNaStYUEb5Fhj6FIPlLBkPUMVMNCFztcIAQlfdflA/euGHMsYYuhScmMTnYjyWNNs2gL4tPYgxTIbDdWcjHofyeheDu+v6rrv11AF0VRYy9IXvNY2EE8DqoryXKO/qtpcD+bLMI8JGD7h68hWPPKjSophD0GVJp2IN4W+kVASrzUDJK8PLeQKC4sE4/caJuyVLOq9Ygh9IGO9t6/7WUvogq0am2/ch5EVLu7Xto4nLWSx3WKpoU2rY2xPo1VIzPYVEeCS17rqB2nkb9bPpaj+e1K1QqgyFKUUOuS","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Mar 2026 19:09:28.8051\n (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 5c066fd8-322e-4e32-e0df-08de89d8df90","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n\tBN2PEPF000044AB.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH2PR12MB4055"},"content":"From: Vidya Sagar <vidyas@nvidia.com>\n\nLTR message should be sent as soon as the Root Port enables LTR in the\nEndpoint. Set snoop and no-snoop LTR timing and LTR message request before\nthe PCIe link comes up so that the LTR message is sent upstream as soon as\nLTR is enabled.\n\nThis addresses the case where the host has not yet programmed Max Snoop/\nNo-Snoop latencies in config space. Without programming these values, the\nEndpoint would send 0 latencies to the host. The hardware later compares\nthese requested values with the Max latencies configured by the host and\nsends the appropriate values upstream once the host sets them.\n\nFixes: c57247f940e8 (\"PCI: tegra: Add support for PCIe endpoint mode in Tegra194\")\nReviewed-by: Jon Hunter <jonathanh@nvidia.com>\nTested-by: Jon Hunter <jonathanh@nvidia.com>\nSigned-off-by: Vidya Sagar <vidyas@nvidia.com>\nSigned-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>\n---\nChanges V8: Fix commit message\nChanges V6 -> V7: Retain FIELD_PREP() usage\nChanges V1 -> V6: None\n\n drivers/pci/controller/dwc/pcie-tegra194.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c\nindex 0be701e58238..602ff8131887 100644\n--- a/drivers/pci/controller/dwc/pcie-tegra194.c\n+++ b/drivers/pci/controller/dwc/pcie-tegra194.c\n@@ -485,15 +485,6 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)\n \tif (val & PCI_COMMAND_MASTER) {\n \t\tktime_t timeout;\n \n-\t\t/* 110us for both snoop and no-snoop */\n-\t\tval = FIELD_PREP(PCI_LTR_VALUE_MASK, 110) |\n-\t\t      FIELD_PREP(PCI_LTR_SCALE_MASK, 2) |\n-\t\t      LTR_MSG_REQ |\n-\t\t      FIELD_PREP(PCI_LTR_NOSNOOP_VALUE, 110) |\n-\t\t      FIELD_PREP(PCI_LTR_NOSNOOP_SCALE, 2) |\n-\t\t      LTR_NOSNOOP_MSG_REQ;\n-\t\tappl_writel(pcie, val, APPL_LTR_MSG_1);\n-\n \t\t/* Send LTR upstream */\n \t\tval = appl_readl(pcie, APPL_LTR_MSG_2);\n \t\tval |= APPL_LTR_MSG_2_LTR_MSG_REQ_STATE;\n@@ -1803,6 +1794,15 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)\n \tval |= APPL_INTR_EN_L1_0_0_RDLH_LINK_UP_INT_EN;\n \tappl_writel(pcie, val, APPL_INTR_EN_L1_0_0);\n \n+\t/* 110us for both snoop and no-snoop */\n+\tval = FIELD_PREP(PCI_LTR_VALUE_MASK, 110) |\n+\t      FIELD_PREP(PCI_LTR_SCALE_MASK, 2) |\n+\t      LTR_MSG_REQ |\n+\t      FIELD_PREP(PCI_LTR_NOSNOOP_VALUE, 110) |\n+\t      FIELD_PREP(PCI_LTR_NOSNOOP_SCALE, 2) |\n+\t      LTR_NOSNOOP_MSG_REQ;\n+\tappl_writel(pcie, val, APPL_LTR_MSG_1);\n+\n \treset_control_deassert(pcie->core_rst);\n \n \tval = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL);\n","prefixes":["v8","08/14"]}