{"id":2215517,"url":"http://patchwork.ozlabs.org/api/patches/2215517/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324185619.296946-2-kwolf@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324185619.296946-2-kwolf@redhat.com>","list_archive_url":null,"date":"2026-03-24T18:56:16","name":"[PULL,1/4] block/curl: free s->password in cleanup paths","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0bc6e7312cccdf6fc96e2ded71729ce7de960a6e","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/?format=json","name":"Kevin Wolf","email":"kwolf@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324185619.296946-2-kwolf@redhat.com/mbox/","series":[{"id":497329,"url":"http://patchwork.ozlabs.org/api/series/497329/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497329","date":"2026-03-24T18:56:15","name":"[PULL,1/4] block/curl: free s->password in cleanup paths","version":1,"mbox":"http://patchwork.ozlabs.org/series/497329/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215517/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215517/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fFa5Vg2x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgK5z6fcfz1y1g\n\tfor ; Wed, 25 Mar 2026 05:57:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w56vh-0004ic-65; Tue, 24 Mar 2026 14:56:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w56ve-0004gh-IU\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 14:56:38 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w56vc-0006fd-Qr\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 14:56:38 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-SPNMaiREM-2XmVvs3ZuUYw-1; Tue,\n 24 Mar 2026 14:56:34 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4F81F18005B0; Tue, 24 Mar 2026 18:56:33 +0000 (UTC)","from merkur.fritz.box (unknown [10.44.33.246])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9F09730002C3; Tue, 24 Mar 2026 18:56:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774378595;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7bb1sau8Aoz4VRZKYzN8vn5yOtnyef9vGgg9AFx+GME=;\n b=fFa5Vg2xlnLQwSTh3hZbNmGBnSXPCHaPEBZ2Xy2wRUqQsg2Vq9cWTRMLh2OsYmZ4Q7faDL\n 4sch9D9PqcyJASVFbRCSxNji8zakEPOUKQcD9vuJN+o8+UEBNz+u2yqQJRexdRiT/q4Mlj\n lb5IgDXBWok+FQQVl/BfcMjTPhVCZuo=","X-MC-Unique":"SPNMaiREM-2XmVvs3ZuUYw-1","X-Mimecast-MFC-AGG-ID":"SPNMaiREM-2XmVvs3ZuUYw_1774378593","From":"Kevin Wolf ","To":"qemu-block@nongnu.org","Cc":"kwolf@redhat.com,\n\tqemu-devel@nongnu.org","Subject":"[PULL 1/4] block/curl: free s->password in cleanup paths","Date":"Tue, 24 Mar 2026 19:56:16 +0100","Message-ID":"<20260324185619.296946-2-kwolf@redhat.com>","In-Reply-To":"<20260324185619.296946-1-kwolf@redhat.com>","References":"<20260324185619.296946-1-kwolf@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: GuoHan Zhao \n\nWhen password-secret is used, curl_open() resolves it with\nqcrypto_secret_lookup_as_utf8() and stores the returned buffer in\ns->password.\n\nUnlike s->proxypassword, s->password is not freed either in the open\nfailure path or in curl_close(), so the resolved secret leaks once it\nhas been allocated.\n\nFree s->password in both cleanup paths.\n\nFixes: 1bff96064290 ('curl: add support for HTTP authentication parameters')\nSigned-off-by: GuoHan Zhao \nMessage-ID: <20260320063016.262954-1-zhaoguohan_salmon@163.com>\nReviewed-by: Kevin Wolf \nSigned-off-by: Kevin Wolf \n---\n block/curl.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/block/curl.c b/block/curl.c\nindex 66aecfb20ec..419df78258b 100644\n--- a/block/curl.c\n+++ b/block/curl.c\n@@ -903,6 +903,7 @@ out_noclean:\n g_free(s->cookie);\n g_free(s->url);\n g_free(s->username);\n+ g_free(s->password);\n g_free(s->proxyusername);\n g_free(s->proxypassword);\n if (s->sockets) {\n@@ -1014,6 +1015,7 @@ static void curl_close(BlockDriverState *bs)\n g_free(s->cookie);\n g_free(s->url);\n g_free(s->username);\n+ g_free(s->password);\n g_free(s->proxyusername);\n g_free(s->proxypassword);\n }\n","prefixes":["PULL","1/4"]}