{"id":2215507,"url":"http://patchwork.ozlabs.org/api/patches/2215507/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-10-7e591cce33a3@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324-deverr-v1-10-7e591cce33a3@gmail.com>","list_archive_url":null,"date":"2026-03-24T18:26:58","name":"[10/10] i2c: sis630: Replace dev_err() with dev_err_probe() in probe function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1efb8befcf679df3501fbf091b6bb1c9c7106541","submitter":{"id":92959,"url":"http://patchwork.ozlabs.org/api/people/92959/?format=json","name":"Atharv Dubey","email":"atharvd440@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-10-7e591cce33a3@gmail.com/mbox/","series":[{"id":497327,"url":"http://patchwork.ozlabs.org/api/series/497327/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=497327","date":"2026-03-24T18:26:54","name":"i2c: Replace dev_err() with dev_err_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/497327/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215507/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215507/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=oeayEKFn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16718-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"oeayEKFn\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJYf4D24z1xy1\n\tfor ; Wed, 25 Mar 2026 05:32:38 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 5261F3008C9E\n\tfor ; Tue, 24 Mar 2026 18:29:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 76D5E3A4530;\n\tTue, 24 Mar 2026 18:29:00 +0000 (UTC)","from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 321C639C658\n\tfor ; Tue, 24 Mar 2026 18:28:58 +0000 (UTC)","by mail-pj1-f52.google.com with SMTP id\n 98e67ed59e1d1-35a07c4b17dso2114499a91.2\n for ; Tue, 24 Mar 2026 11:28:58 -0700 (PDT)","from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:28:56 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376939; cv=none;\n b=Gfz58oLk9iggufGag1LmRTEeoXIRPq0QF4v0GpfPBuSY2fiDYtryZErmyduAR37T3la1xWhKmZRseRgj9qbW2YnKredMtdePQcJ++eCoz3MZx17XkMsP18PpZtHFC8kIALlvv8KRqsBf691iUGCjepHlGEicE5UqiipRw3O/4No=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376939; c=relaxed/simple;\n\tbh=7g/jARnkhTd3DIs23AFH73jSfHB7zbCwImSIcA8YsoQ=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=Ohp3b8P+M6PxygPUx2BuQPkmewe8Maek9bds8ARAV7656EDfiyddE1Z+T6CvbPR3i8ZPLKPmq5OTIxXJQytffywvy7BDUAtgAR2KrgOA9dgWvM7dWzyvai/lxDuD8VUG2gp8yEwLefbqy7zIYBRN/NOCRH8Kgk//JLDe8LYdawo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=oeayEKFn; arc=none smtp.client-ip=209.85.216.52","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376937; x=1774981737;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=;\n b=oeayEKFny7vadu4kiqbm4VW6IkcFRMWDumZCZUWfZYCw/RxXLv0aaKBlq4/VUUbDp1\n KOa5FwW0/GzBQxBlZw6D6fi8V53ez3Bl6fagBvPaNDh7OzWeo774+Sen0yKN4nSYcmCJ\n 7mtLkTPv7K6AD1jUMNdOoaQduZzvAhBO0XhmZyAkJTbvUPriCVAuuAMM/Z3g1O4cdtpk\n ou8bmXIQlpxhaPDV2cdSEcDjxt8zhqlatUqSvYdSryoti2ViVZmB6Ac3Sc5DUOq9qS5A\n +I87rhwmm0Za4LigTmct0Tdjgkj658A48UbVEMAW5aF313a3k+aJOEBCbaLBFBJ5Vz+l\n wHYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376937; x=1774981737;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=;\n b=irddfQJh6xGqLesYEaEpJZS3ZPL+7UuiCx5MRavEsqo2KYrX9c/PqW9AnBldM7xSqf\n T3nEdUt0fmBGt+dZ5DteSbfvi1G361trXoHISUkxf8LDtKwTmoQTnkcaN7C0/nxRmBMO\n VRGQgnH1pj2TkhaC2//id/bh6qxDmveEiph5wtjfV06htapd+7eQwZStaXLk/0NyHBTo\n rf5ansDoQUKy9ZKh3g+r266tX1wqOX2/JBBSWXfdVuS9qGHMx4tJLWbhRGjwCqSr+9g4\n egY6Zt8Sarycv9er7/35wTNUxa/bl+BCxcvL+N7mPFBS41NT3FhMjINB+Olww4KQEY4S\n JI7A==","X-Gm-Message-State":"AOJu0Yx33IRReck5sgks/BtVcWYGpDq8WPrfsgJ9gb/yFjSXVGLqjRPi\n\tw9qLwtW5qixvQ8USn+MGTv9HksurerGKasbvGtmpcL5k9/OXF3vWUQJqdWvcGlO1fFQ=","X-Gm-Gg":"ATEYQzzj31JWQuQq0fDigre9eHwBX/5Qtk+YASHOI7ELwAQ9fQaktbCEKodRR++QDoU\n\tPAgkQwR9cIzk7+FpRyTwjk4sKv3/PhM824FawhfJCEzxMQt0Qj7KrtRoYZO60bQcZYuPVtEFkWW\n\tT/MGCppRejrREsG9kpKym1j/ZnltOulpMSIxk9dBJIULhlmo3tTUa8UqKdxIfkG5jhleXfHjvnd\n\txtwn6QtByHEwpU9/+AisbxBLq/eV5SPaPqDACa2IZ8tcm+ha/axxcU/klY08xjDy3b2PcGDH+lP\n\tF5cwXuaXVEmitT86Yk5QgOr2cciKsDZXSGdmcLQjDnWnRABgzdgkec+dBOmBJ4phKG40El9Svdi\n\tAgu99mQucaydpLXzuYzga7bEg5uJPK5zBX+yJpaFPHbKgCRMRXsyjAB3A9O2f1l7akzZfR3hzlO\n\tJCc2q4aAFeowturqRnyXv7Pl8cOQ==","X-Received":"by 2002:a17:90b:3dc4:b0:35b:929f:7e8f with SMTP id\n 98e67ed59e1d1-35c0dd1000bmr297824a91.13.1774376937217;\n Tue, 24 Mar 2026 11:28:57 -0700 (PDT)","From":"Atharv Dubey ","Date":"Tue, 24 Mar 2026 23:56:58 +0530","Subject":"[PATCH 10/10] i2c: sis630: Replace dev_err() with dev_err_probe()\n in probe function","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260324-deverr-v1-10-7e591cce33a3@gmail.com>","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","In-Reply-To":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","To":"Till Harbaum , Andi Shyti ,\n Laxman Dewangan , Dmitry Osipenko ,\n Thierry Reding ,\n Jonathan Hunter , Chen-Yu Tsai ,\n Jernej Skrabec ,\n Samuel Holland ,\n Pierre-Yves MORDRET ,\n Alain Volmat ,\n Maxime Coquelin ,\n Alexandre Torgue ,\n Patrice Chotard ,\n Orson Zhai ,\n Baolin Wang ,\n Chunyan Zhang , Jean Delvare ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda , Atharv Dubey ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1774376818; l=2804;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=nhsfDSLdFe3nGX23EexwATKRFgvnwZsN/uRkVIgsfDc=;\n b=MfTL2nua2/UaTOkuHox/mofQ9uGkaQFwD4ef2QTeyEIJWKrK1affTlrqYL2fD+dQbiqZ2kQf1\n 368O9MeLyraCsNY7XiqbLSbdhihgwtkeZhLhsjgkAnvnbcpMTIg+zrj","X-Developer-Key":"i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk="},"content":"From: Enrico Zanda \n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda \nSigned-off-by: Atharv Dubey \n---\n drivers/i2c/busses/i2c-sis630.c | 31 +++++++++++++------------------\n 1 file changed, 13 insertions(+), 18 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c\nindex a19c3d251804..3d0638c2bc51 100644\n--- a/drivers/i2c/busses/i2c-sis630.c\n+++ b/drivers/i2c/busses/i2c-sis630.c\n@@ -431,24 +431,23 @@ static int sis630_setup(struct pci_dev *sis630_dev)\n \t in acpi io space and read acpi base addr\n \t*/\n \tif (pci_read_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, &b)) {\n-\t\tdev_err(&sis630_dev->dev, \"Error: Can't read bios ctl reg\\n\");\n-\t\tretval = -ENODEV;\n+\t\tretval = dev_err_probe(&sis630_dev->dev, -ENODEV,\n+\t\t\t\t \"Error: Can't read bios ctl reg\\n\");\n \t\tgoto exit;\n \t}\n \t/* if ACPI already enabled , do nothing */\n \tif (!(b & 0x80) &&\n \t pci_write_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, b | 0x80)) {\n-\t\tdev_err(&sis630_dev->dev, \"Error: Can't enable ACPI\\n\");\n-\t\tretval = -ENODEV;\n+\t\tretval = dev_err_probe(&sis630_dev->dev, -ENODEV,\n+\t\t\t\t \"Error: Can't enable ACPI\\n\");\n \t\tgoto exit;\n \t}\n \n \t/* Determine the ACPI base address */\n \tif (pci_read_config_word(sis630_dev,\n \t\t\t\t SIS630_ACPI_BASE_REG, &acpi_base)) {\n-\t\tdev_err(&sis630_dev->dev,\n-\t\t\t\"Error: Can't determine ACPI base address\\n\");\n-\t\tretval = -ENODEV;\n+\t\tretval = dev_err_probe(&sis630_dev->dev, -ENODEV,\n+\t\t\t\t \"Error: Can't determine ACPI base address\\n\");\n \t\tgoto exit;\n \t}\n \n@@ -469,11 +468,10 @@ static int sis630_setup(struct pci_dev *sis630_dev)\n \t/* Everything is happy, let's grab the memory and set things up. */\n \tif (!request_region(smbus_base + SMB_STS, SIS630_SMB_IOREGION,\n \t\t\t sis630_driver.name)) {\n-\t\tdev_err(&sis630_dev->dev,\n-\t\t\t\"I/O Region 0x%04x-0x%04x for SMBus already in use.\\n\",\n-\t\t\tsmbus_base + SMB_STS,\n-\t\t\tsmbus_base + SMB_STS + SIS630_SMB_IOREGION - 1);\n-\t\tretval = -EBUSY;\n+\t\tretval = dev_err_probe(&sis630_dev->dev, -EBUSY,\n+\t\t\t\t \"I/O Region 0x%04x-0x%04x for SMBus already in use.\\n\",\n+\t\t\t\t smbus_base + SMB_STS,\n+\t\t\t\t smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1);\n \t\tgoto exit;\n \t}\n \n@@ -511,12 +509,9 @@ static int sis630_probe(struct pci_dev *dev, const struct pci_device_id *id)\n {\n \tint ret;\n \n-\tif (sis630_setup(dev)) {\n-\t\tdev_err(&dev->dev,\n-\t\t\t\"SIS630 compatible bus not detected, \"\n-\t\t\t\"module not inserted.\\n\");\n-\t\treturn -ENODEV;\n-\t}\n+\tif (sis630_setup(dev))\n+\t\treturn dev_err_probe(&dev->dev, -ENODEV,\n+\t\t\t\t \"Compatible bus not detected, module not inserted.\\n\");\n \n \t/* set up the sysfs linkage to our parent device */\n \tsis630_adapter.dev.parent = &dev->dev;\n","prefixes":["10/10"]}