{"id":2215506,"url":"http://patchwork.ozlabs.org/api/patches/2215506/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-5-7e591cce33a3@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324-deverr-v1-5-7e591cce33a3@gmail.com>","list_archive_url":null,"date":"2026-03-24T18:26:53","name":"[05/10] i2c: stm32f4: Replace dev_err() with dev_err_probe() in probe function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8c403637eee38e42b2544f1de72457910174dddc","submitter":{"id":92959,"url":"http://patchwork.ozlabs.org/api/people/92959/?format=json","name":"Atharv Dubey","email":"atharvd440@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-5-7e591cce33a3@gmail.com/mbox/","series":[{"id":497327,"url":"http://patchwork.ozlabs.org/api/series/497327/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=497327","date":"2026-03-24T18:26:54","name":"i2c: Replace dev_err() with dev_err_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/497327/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215506/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215506/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=WHCrnv0V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16713-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"WHCrnv0V\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJYX6Z5Bz1xy1\n\tfor ; Wed, 25 Mar 2026 05:32:32 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 490833158A34\n\tfor ; Tue, 24 Mar 2026 18:28:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 694D4383C64;\n\tTue, 24 Mar 2026 18:28:03 +0000 (UTC)","from mail-pj1-f47.google.com (mail-pj1-f47.google.com\n [209.85.216.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 659E53A2566\n\tfor ; Tue, 24 Mar 2026 18:28:01 +0000 (UTC)","by mail-pj1-f47.google.com with SMTP id\n 98e67ed59e1d1-356337f058aso3251986a91.2\n for ; Tue, 24 Mar 2026 11:28:01 -0700 (PDT)","from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:27:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376883; cv=none;\n b=Om+O1z/jO5sq/wVWTsBf6I15xPSq9U9P3g6YSWeukal9Y0UrEqdUCcoQCT8UWwN2Mleam6es99qR2I4q3k5VEABWrN9Akrbqs0zWBHsc0folUZCt3eDqrqrz/2WTl+JztwyKudq4DlUEl6n/7wnEg2up1hPUT49XLcmEGbnbtCU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376883; c=relaxed/simple;\n\tbh=Og+ag9IkwKlXlRqp73B5hnPk+W9xiNL+UaCwuonyITY=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=WDE53g994lXc+OCtD8gnpUI79trTKzvByzonLkJdjJiLE4qanrsL/t1hLOfLQ2vQYb4vI122CAZ8IRke0mLEIl+i8SQhtaQRLeEHTavhAmeoj89aAK13yJolxWWEH0SsBkXgxY4p4i2hiKDmxBGXd94tymK7acSusOK3Qbeg/0Q=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=WHCrnv0V; arc=none smtp.client-ip=209.85.216.47","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376880; x=1774981680;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=;\n b=WHCrnv0VzU625lqgVnnry/SM1rBVfsO4msu6b3kmrraeCWCplik3gPSvP5kVf9gyQH\n lWLhnl3sCLyGMMC+EDMS17zeQDwZdeb9Kg+CtMe1Q+dk5nsCbKXWgOTsN5jvkIxhlfrM\n infMW4EyhTh0j9T/PqE9Zha8wpxnbuIDp3GFk4CNKzHOCTHINVEOjJBCiuldD9xeeVyX\n hxOhLgnbMbQ7NXvXEbZ6+ZOIiG9wzXSJz7fSTl21ryX2SCFOOCkte57+Y7yxDvY0J6j+\n g+g3v6WjXKm3yvibbDgURFpBYZfhvIKkQ1JRe+vigNgm6BA73Q8YyUpEJ+Hus5YkcquF\n a+YA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376880; x=1774981680;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=;\n b=A9auBzGyBmAkiycUIc1GlFD1jKODn2wPVnDz5RQs8lniou3JOm8sUWceKYCr4QnND/\n y2Lj4HDXiIvkFFb5TbRrMFPpCUdwa3wi/fgE3ibFoTsGKRv9SPQqaHIjVTLb5dHhzBZQ\n lIhItTWG0OcirXorJ6J7ck9XzCN4l14qZloyMp693Lmlkf13AmwT2L7XKv/Op6a2AZ/R\n mJPhIR6JIYkbyNgEHAZPLRrG+hmTxJPGyiQFrmXaSIAg6vtXybBJgSGAhxoMmM2N+F2O\n IYI1NRKBinDmEmOClv7m+0OfqehIb7WAdzw+bpTr07Qr4yUCemcqN5FzpCdCGpOoUhSd\n PbtA==","X-Gm-Message-State":"AOJu0YwSyK1b9Y7+iwAR2kh7BqDvjtQINiaupzUQUG2zfz3wbdd6cqRm\n\t6ZGlGQ+bs3yIGtbaK5DHCUYkHPRe86fYaquPbjFKbU2v04aSOvTs9ITNV0+LcXOt9vA=","X-Gm-Gg":"ATEYQzzkD7MipQzoNfXZ8Y+3XW3H0/lHhjFKpov/wboBw4b7L4bwwAYVToGlfiERHH+\n\tUhwhBxPT03krC57E7IcTDGvYI1JQoxFRmwVuc4cHdTc7Lz/QXNtgwL3m9AxlQ/3iimZsUflhB9F\n\tdXTO3/JpwNePi0HswpxkZe8cuIexcZET2saihGQXHDIbPhhf5RkID0WA0KlJ2LqFrNkihSTMqTC\n\tZcXBOlrNG8373Xz1aTQ5zHPnCHuRxEjkrxY3CHRBunh2+OkKjY7CJnOUVt+MQ9aoJH+g/MKycpu\n\tO006o2Dor0I0mGQYvdqGMTLw3A7lCjbTYr7sFo4paEZImdbPmZ4UXDrxRBOVizyovnttDNs38Ew\n\tHFEC/ocbMmrb7V9/jni18QMKbDAz4tkkk6BkfpqmKJItqREyUz2BzsYUX11FciLZTU5zFU41LWq\n\tYj3RuxSj5UaUTW6tXqAm3+7Yv+FA==","X-Received":"by 2002:a17:90b:4ec6:b0:35b:e551:90d2 with SMTP id\n 98e67ed59e1d1-35c0dd95828mr337562a91.28.1774376879990;\n Tue, 24 Mar 2026 11:27:59 -0700 (PDT)","From":"Atharv Dubey ","Date":"Tue, 24 Mar 2026 23:56:53 +0530","Subject":"[PATCH 05/10] i2c: stm32f4: Replace dev_err() with dev_err_probe()\n in probe function","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260324-deverr-v1-5-7e591cce33a3@gmail.com>","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","In-Reply-To":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","To":"Till Harbaum , Andi Shyti ,\n Laxman Dewangan , Dmitry Osipenko ,\n Thierry Reding ,\n Jonathan Hunter , Chen-Yu Tsai ,\n Jernej Skrabec ,\n Samuel Holland ,\n Pierre-Yves MORDRET ,\n Alain Volmat ,\n Maxime Coquelin ,\n Alexandre Torgue ,\n Patrice Chotard ,\n Orson Zhai ,\n Baolin Wang ,\n Chunyan Zhang , Jean Delvare ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda , Atharv Dubey ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1774376818; l=3441;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=fUyekU3vIj3XVF9IEZZuF8p06qRSr8GpHENT4b6dCL0=;\n b=Lv6diY6U8yOO+wFg03BiFqyP3QS+BUZjUWZZhiQKaL58Ge1g8J4dtHf+S+KQwwxbmw5DUKteO\n KpFdph3BhEcCYkTzwZIrFSEDvv+nlC32lTjIg5IZhXq8rp8u8lOOdaA","X-Developer-Key":"i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk="},"content":"From: Enrico Zanda \n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda \nSigned-off-by: Atharv Dubey \n---\n drivers/i2c/busses/i2c-stm32f4.c | 53 ++++++++++++++++------------------------\n 1 file changed, 21 insertions(+), 32 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c\nindex b3d56d0aa9d0..44e8b04962bb 100644\n--- a/drivers/i2c/busses/i2c-stm32f4.c\n+++ b/drivers/i2c/busses/i2c-stm32f4.c\n@@ -163,11 +163,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev)\n \t\t * to hardware limitation\n \t\t */\n \t\tif (freq < STM32F4_I2C_MIN_STANDARD_FREQ ||\n-\t\t freq > STM32F4_I2C_MAX_FREQ) {\n-\t\t\tdev_err(i2c_dev->dev,\n-\t\t\t\t\"bad parent clk freq for standard mode\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\t\t freq > STM32F4_I2C_MAX_FREQ)\n+\t\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL,\n+\t\t\t\t\t \"bad parent clk freq for standard mode\\n\");\n \t} else {\n \t\t/*\n \t\t * To be as close as possible to 400 kHz, the parent clk\n@@ -175,11 +173,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev)\n \t\t * maximum value of 46 MHz due to hardware limitation\n \t\t */\n \t\tif (freq < STM32F4_I2C_MIN_FAST_FREQ ||\n-\t\t freq > STM32F4_I2C_MAX_FREQ) {\n-\t\t\tdev_err(i2c_dev->dev,\n-\t\t\t\t\"bad parent clk freq for fast mode\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\t\t freq > STM32F4_I2C_MAX_FREQ)\n+\t\t\treturn dev_err_probe(i2c_dev->dev, -EINVAL,\n+\t\t\t\t\t \"bad parent clk freq for fast mode\\n\");\n \t}\n \n \tcr2 |= STM32F4_I2C_CR2_FREQ(freq);\n@@ -772,22 +768,19 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)\n \t\treturn PTR_ERR(i2c_dev->base);\n \n \tirq_event = irq_of_parse_and_map(np, 0);\n-\tif (!irq_event) {\n-\t\tdev_err(&pdev->dev, \"IRQ event missing or invalid\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (!irq_event)\n+\t\treturn dev_err_probe(&pdev->dev, -EINVAL,\n+\t\t\t\t \"IRQ event missing or invalid\\n\");\n \n \tirq_error = irq_of_parse_and_map(np, 1);\n-\tif (!irq_error) {\n-\t\tdev_err(&pdev->dev, \"IRQ error missing or invalid\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (!irq_error)\n+\t\treturn dev_err_probe(&pdev->dev, -EINVAL,\n+\t\t\t\t \"IRQ error missing or invalid\\n\");\n \n \ti2c_dev->clk = devm_clk_get_enabled(&pdev->dev, NULL);\n-\tif (IS_ERR(i2c_dev->clk)) {\n-\t\tdev_err(&pdev->dev, \"Failed to enable clock\\n\");\n-\t\treturn PTR_ERR(i2c_dev->clk);\n-\t}\n+\tif (IS_ERR(i2c_dev->clk))\n+\t\treturn dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk),\n+\t\t\t\t \"Failed to enable clock\\n\");\n \n \trst = devm_reset_control_get_exclusive(&pdev->dev, NULL);\n \tif (IS_ERR(rst))\n@@ -807,19 +800,15 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)\n \n \tret = devm_request_irq(&pdev->dev, irq_event, stm32f4_i2c_isr_event, 0,\n \t\t\t pdev->name, i2c_dev);\n-\tif (ret) {\n-\t\tdev_err(&pdev->dev, \"Failed to request irq event %i\\n\",\n-\t\t\tirq_event);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(&pdev->dev, ret,\n+\t\t\t\t \"Failed to request irq event %i\\n\", irq_event);\n \n \tret = devm_request_irq(&pdev->dev, irq_error, stm32f4_i2c_isr_error, 0,\n \t\t\t pdev->name, i2c_dev);\n-\tif (ret) {\n-\t\tdev_err(&pdev->dev, \"Failed to request irq error %i\\n\",\n-\t\t\tirq_error);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(&pdev->dev, ret,\n+\t\t\t\t \"Failed to request irq error %i\\n\", irq_error);\n \n \tret = stm32f4_i2c_hw_config(i2c_dev);\n \tif (ret)\n","prefixes":["05/10"]}