{"id":2215504,"url":"http://patchwork.ozlabs.org/api/patches/2215504/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-9-7e591cce33a3@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324-deverr-v1-9-7e591cce33a3@gmail.com>","list_archive_url":null,"date":"2026-03-24T18:26:57","name":"[09/10] i2c: sis96x: Replace dev_err() with dev_err_probe() in probe function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aad873f5ad531ca0aed1b4b712ad49bcaf8dd375","submitter":{"id":92959,"url":"http://patchwork.ozlabs.org/api/people/92959/?format=json","name":"Atharv Dubey","email":"atharvd440@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-9-7e591cce33a3@gmail.com/mbox/","series":[{"id":497327,"url":"http://patchwork.ozlabs.org/api/series/497327/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=497327","date":"2026-03-24T18:26:54","name":"i2c: Replace dev_err() with dev_err_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/497327/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215504/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215504/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PNwhm2D7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16717-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"PNwhm2D7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJYD2p2Wz1xy1\n\tfor ; Wed, 25 Mar 2026 05:32:16 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 97E7D304186A\n\tfor ; Tue, 24 Mar 2026 18:28:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C7E2A3A3811;\n\tTue, 24 Mar 2026 18:28:49 +0000 (UTC)","from mail-pj1-f49.google.com (mail-pj1-f49.google.com\n [209.85.216.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 69966273F9\n\tfor ; Tue, 24 Mar 2026 18:28:48 +0000 (UTC)","by mail-pj1-f49.google.com with SMTP id\n 98e67ed59e1d1-3590042fa8eso3729325a91.1\n for ; Tue, 24 Mar 2026 11:28:48 -0700 (PDT)","from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:28:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376929; cv=none;\n b=LY/0q+Zrgug9Q/DE9Rn+bmEBOzZDjnV3jay4ZkzXMnqc/3JjEXNvFZNUYBPPq6q/zFoTJgi6GR3kHeLXXm8dhT/hOhgQq9ApfsDvIo1okBiWxRjguwnOWap57ms2UIdyM36fVvq8ec2m9WHyBYzts8Q8S7iBQXDeytjpy0Y2jHA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376929; c=relaxed/simple;\n\tbh=WclG9/5UCAVmNpJ6wIy91+8u1Ud041oHxz1zl+TJNjA=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=Dijt42eQETM+0aqErgM/D9o5QgXaXuU8DMlFLQCdwq/tCZJ6qMWO29IcMYSzIMXMucTS6lElG0wggN+9WL0xTdjJXilz9kZE4KSJpBkeRSwu2KunEkHZI0HxVP4vV7kZaE0rJsl5LNM8QB8iHO3+Plsug7N9z+T8xKOZQDstYU0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=PNwhm2D7; arc=none smtp.client-ip=209.85.216.49","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376927; x=1774981727;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=;\n b=PNwhm2D7X/t5grbCzfbSsK938XLqC8zliWWJl7CHQeygpCZhAYKg9ueMW6WcooRWtm\n hx/+a574mi6Ddy2NR7xtXVnJuy7cRErVDGBX9UqYcdOOElMzK5cra+ldtlYXQd5kESR5\n UUKhBEkRjSz/F7tWlojAuRS19GTh+gg8CUiiLHic3k+Nz7yf+T/K89Vkh8Wn67U9hJht\n khTlX9ALg7J8Vzjq7NvUePRnxVyfkaF3AMb5FCE/ED5VR3ZRAvTEFnntWFuw0jjgfgZC\n 0u3C4aicVQZl8UeTBMQLCeDaFYcc+zzXGj9JCZI8SMncELHZH+86BQGKyFc6sgd7zQhn\n xlRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376927; x=1774981727;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=;\n b=QsZP3Px5QPfRJaUJUjHofL78K1aWpYdqsfHGI0dLd/z3lxaw2R5wpLkbbq1F6e9Boj\n ETI7xekPfeFnYVQ/hFduvj927zo+sJ2L7OrgK6qR+JquqbU2qZBEvMMkVeE0ot3XjOtT\n AHD/RFnsbkJX40XV2NMmKy3yAMYRUxAYNGVdNzwhPjDrt1gr7fiQYK5iGJLXl1b/LZKv\n h+LNHJ5elIOjtBHZU9Q9jRullEytrWNmDhrCLoGzbFVxjc54d9y56nedf+0aWKAk+KIO\n TcPXhrPvrTVMa1jNdiGpI92j6DzXMTf3JmNtnw3D4P+8c/Jch0Gr50QSexZqLgtIkZVx\n q5cw==","X-Gm-Message-State":"AOJu0YwUpFZ/Y/DSK9weMPEaOtf8ucfpUHBvNElVyeQcEFJP9NFOJqLF\n\tkNne6fPfJHp+CKiRFwQlhfbagjhO35TMeqxSwag0HNHmEoXsGTNpslmAO2b6UNZNqTw=","X-Gm-Gg":"ATEYQzwNt9GlLen1CdxRMftezbZL9qhpGfYLSYPueTZtR05ljiG7clG0k1MsiRhu/Cw\n\t1tGX4+wNAmOL2p9K1sDOuw0R0oAbCmMuSkUTYaDIwPtkI9zkr09oWqtvLiN+nES/ovhxzhNvq9Z\n\tZXtQTc79CQQaDVDGU+enh14HlSogJvCo0sMy5OpHGj49Fu05dfiM+PSvUomgalYvCaBOLm4FCBI\n\tjA4wNFztuSidmIOGKvfnnlkdWexbfSiWz/IRfp4GFPaSIwHKxULzrpqZyGzFgdOkX8srNTfosUT\n\t9eM/1qkbJUFKxpDD6JroEdBT9oCCwavTp33EQtfr1EfuSfHJIVkmb71VQD505cAsb0jeEZk0nba\n\trmXRewSG0/UNrcTcx9eR/ClYWIZdETaUcQ9Hnx+H3qdKqHhAvP1a3Iodeq811TTgbnzAulLh4Hl\n\tl8vPYTVeS/8TsxJ5TjxGe3weTUycqkCmbPcn2E","X-Received":"by 2002:a17:90b:1d8a:b0:35b:e5ba:c0c8 with SMTP id\n 98e67ed59e1d1-35c0ddd9ed9mr320446a91.28.1774376927304;\n Tue, 24 Mar 2026 11:28:47 -0700 (PDT)","From":"Atharv Dubey ","Date":"Tue, 24 Mar 2026 23:56:57 +0530","Subject":"[PATCH 09/10] i2c: sis96x: Replace dev_err() with dev_err_probe()\n in probe function","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260324-deverr-v1-9-7e591cce33a3@gmail.com>","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","In-Reply-To":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","To":"Till Harbaum , Andi Shyti ,\n Laxman Dewangan , Dmitry Osipenko ,\n Thierry Reding ,\n Jonathan Hunter , Chen-Yu Tsai ,\n Jernej Skrabec ,\n Samuel Holland ,\n Pierre-Yves MORDRET ,\n Alain Volmat ,\n Maxime Coquelin ,\n Alexandre Torgue ,\n Patrice Chotard ,\n Orson Zhai ,\n Baolin Wang ,\n Chunyan Zhang , Jean Delvare ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda , Atharv Dubey ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1774376818; l=2523;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=2gYAVvyUJk/qxHL4KJceROL4iNDzsuJ4eDXGcgjkpVk=;\n b=vB2gL2qhGY3YL/cIJqmvowLCaQEngaBk72sJRkrwCl3oRTHnnpcQvD7hzPfvDqHKUYnT4Wr6Y\n Zfn7Uu0NXm6B/rb6bM9jYBJr8GEREU1oPwc+1RRqWHn4xFjESwTrs7U","X-Developer-Key":"i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk="},"content":"From: Enrico Zanda \n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda \nSigned-off-by: Atharv Dubey \n---\n drivers/i2c/busses/i2c-sis96x.c | 30 +++++++++++++-----------------\n 1 file changed, 13 insertions(+), 17 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c\nindex 77529dda6fcd..eee41dc9d706 100644\n--- a/drivers/i2c/busses/i2c-sis96x.c\n+++ b/drivers/i2c/busses/i2c-sis96x.c\n@@ -245,23 +245,19 @@ static int sis96x_probe(struct pci_dev *dev,\n \tu16 ww = 0;\n \tint retval;\n \n-\tif (sis96x_smbus_base) {\n-\t\tdev_err(&dev->dev, \"Only one device supported.\\n\");\n-\t\treturn -EBUSY;\n-\t}\n+\tif (sis96x_smbus_base)\n+\t\treturn dev_err_probe(&dev->dev, -EBUSY, \"Only one device supported.\\n\");\n \n \tpci_read_config_word(dev, PCI_CLASS_DEVICE, &ww);\n-\tif (PCI_CLASS_SERIAL_SMBUS != ww) {\n-\t\tdev_err(&dev->dev, \"Unsupported device class 0x%04x!\\n\", ww);\n-\t\treturn -ENODEV;\n-\t}\n+\tif (ww != PCI_CLASS_SERIAL_SMBUS)\n+\t\treturn dev_err_probe(&dev->dev, -ENODEV,\n+\t\t\t\t \"Unsupported device class 0x%04x!\\n\", ww);\n \n \tsis96x_smbus_base = pci_resource_start(dev, SIS96x_BAR);\n-\tif (!sis96x_smbus_base) {\n-\t\tdev_err(&dev->dev, \"SiS96x SMBus base address \"\n-\t\t\t\"not initialized!\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (!sis96x_smbus_base)\n+\t\treturn dev_err_probe(&dev->dev, -EINVAL,\n+\t\t\t\t \"SiS96x SMBus base address not initialized!\\n\");\n+\n \tdev_info(&dev->dev, \"SiS96x SMBus base address: 0x%04x\\n\",\n \t\t\tsis96x_smbus_base);\n \n@@ -272,9 +268,9 @@ static int sis96x_probe(struct pci_dev *dev,\n \t/* Everything is happy, let's grab the memory and set things up. */\n \tif (!request_region(sis96x_smbus_base, SMB_IOSIZE,\n \t\t\t sis96x_driver.name)) {\n-\t\tdev_err(&dev->dev, \"SMBus registers 0x%04x-0x%04x \"\n-\t\t\t\"already in use!\\n\", sis96x_smbus_base,\n-\t\t\tsis96x_smbus_base + SMB_IOSIZE - 1);\n+\t\tdev_err_probe(&dev->dev, -EINVAL,\n+\t\t\t \"SMBus registers 0x%04x-0x%04x already in use!\\n\",\n+\t\t\t sis96x_smbus_base, sis96x_smbus_base + SMB_IOSIZE - 1);\n \n \t\tsis96x_smbus_base = 0;\n \t\treturn -EINVAL;\n@@ -287,7 +283,7 @@ static int sis96x_probe(struct pci_dev *dev,\n \t\t\"SiS96x SMBus adapter at 0x%04x\", sis96x_smbus_base);\n \n \tif ((retval = i2c_add_adapter(&sis96x_adapter))) {\n-\t\tdev_err(&dev->dev, \"Couldn't register adapter!\\n\");\n+\t\tdev_err_probe(&dev->dev, retval, \"Couldn't register adapter!\\n\");\n \t\trelease_region(sis96x_smbus_base, SMB_IOSIZE);\n \t\tsis96x_smbus_base = 0;\n \t}\n","prefixes":["09/10"]}