{"id":2215501,"url":"http://patchwork.ozlabs.org/api/patches/2215501/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-3-7e591cce33a3@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324-deverr-v1-3-7e591cce33a3@gmail.com>","list_archive_url":null,"date":"2026-03-24T18:26:51","name":"[03/10] i2c: sun6i-p2wi: Replace dev_err() with dev_err_probe() in probe function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bed12a4d6cf1a80641b3c24f5fca81d5db2bc78e","submitter":{"id":92959,"url":"http://patchwork.ozlabs.org/api/people/92959/?format=json","name":"Atharv Dubey","email":"atharvd440@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260324-deverr-v1-3-7e591cce33a3@gmail.com/mbox/","series":[{"id":497327,"url":"http://patchwork.ozlabs.org/api/series/497327/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=497327","date":"2026-03-24T18:26:54","name":"i2c: Replace dev_err() with dev_err_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/497327/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215501/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215501/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=WuMmfs9X;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16711-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"WuMmfs9X\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJXN4bkBz1xy1\n\tfor ; Wed, 25 Mar 2026 05:31:32 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1CF83313A9BA\n\tfor ; Tue, 24 Mar 2026 18:27:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 91D9C3A2566;\n\tTue, 24 Mar 2026 18:27:44 +0000 (UTC)","from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 409693A3811\n\tfor ; Tue, 24 Mar 2026 18:27:42 +0000 (UTC)","by mail-pj1-f52.google.com with SMTP id\n 98e67ed59e1d1-35a1d4a095bso112743a91.0\n for ; Tue, 24 Mar 2026 11:27:42 -0700 (PDT)","from [127.0.1.1] ([103.216.213.160])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 11:27:40 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774376864; cv=none;\n b=Zangkg7gzoOsgT1wl35F3kAMHOV1Em9qxMYIRHFM6zulh12Skh70lONYH5okNrjeKwxzqMwiOkEgfxFAwcmEFHv8VGrIButmZi9Si14yjxBqjDIl7xRHkZVHI5Rc61f3ViowKyMTqJN2CpQ3Fy+/WsoUUyTz9s8XIvyxID27mW0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774376864; c=relaxed/simple;\n\tbh=Gi4d0M5a+5Q4+n74Mmna9wNg+TAzJTOOC5zaGKNgvh0=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=bx5oLbupNY1OOVz0w6OLh9NO/WQTwsm2hLNkI48hZzH7hDRo+sYyUiRIGZVxvAARcMZzkGWH3O3UREWsoKEozsxdc+bwMXBTrpc7PRDy7jbejcHf6ZjnLn6eNZRhQUNtBaUxYpUWIIPBrNrX4g2sUUkbFYUGEoHa5FzVSElD9IY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=WuMmfs9X; arc=none smtp.client-ip=209.85.216.52","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774376861; x=1774981661;\n darn=vger.kernel.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to;\n bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=;\n b=WuMmfs9Xmqa9GVDNOZjmNUordZmBGAfWmTmNyhu7SWk9d1fBi9J7mmm9H+nbdWmyJg\n 1oV4WrXltAPUWBmWaeV3MF4z9LIcaBBXfv27e1H5aTbrXLiuOTVeZeUYNA5dqXvE2MJU\n jKDBjTnHVysLF9BRylvs0wLrbkMhnJnBIY8fAsyHFm9e2/GeZG9+RWskGeeOCCs+x4OS\n +oI8wsXi7Q9xh/s1oFEFJGFFoeYKQ4Alkq/jd94/q9rk/kkg/p24Y+cfxQ4QsIYX6Oyb\n fAPXNU1TkvhBWDY7i11v2l9jys2jwmTGmn69A9e4gFsaKPPsObTfJRlijFVXWYkNVOzG\n H5SQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774376861; x=1774981661;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=;\n b=cag0Z3yQGS7YNgLrxtF6JSVd5NTQZcQgZnSx4YGvA06TmFsDO1DuzHHV2OMf3Llwth\n qfJvFjqtrWAtMqG3l3bh0h0L4iP6wNvItGkqVfKoI5WIlEHu4wPCEMtY/TfQH2glBMUD\n 4Dh6+ZyrioTntikIcWS9CwNQkawHetOi8haux8hPfhS2e2zvS2XJB1821dhNGKw+eVtC\n lXOC0ohsZN3/9kC7XGstb1xkJiAKJsHhN8UIs1Mw7jGsg7yD3dPCmzYeTCeKKdAP1LIk\n 76grEfWG+jgbZWBL5lTSG14DGW7FyCLxvYF6RDe2HGg76uJ8aVDrpt+HjfHJlIlvjUZY\n Vjsg==","X-Gm-Message-State":"AOJu0YyaToSvrCMrz2bH1p50LFhx3PXCYXX9aYN+RB7ZnKVb69Ll9SOB\n\tXOH+e684nK80ORK/2fT18G/i9MruRcboEBFQp29tXrD+7Xix0d9OKtTpodicy3roSaE=","X-Gm-Gg":"ATEYQzyCSPNxz1o3XY2gdKWrRZcZc/S+FabmRb+Mif2thinoyvrcVFFP1QIiGrYe0wx\n\tKbrF+moBGpdf+PNMJPqaInta1pca1lgBmmW2BhX/6uI2ppTx8o0jHK/R7I8OSCXjg6pylSOr7AS\n\tWNNI92IJR/02uxe/+c1FAOAlieDfKID8k01hJ+9mPdS+9S+9Xb++nGqW2Z0Timuj4JRNprku1sw\n\t7miPnbCtaB2I4oWRkdloN2EQTYM5u7PdjgMCZ9rqN8DoBlrA7i0WmOry8rfoaM4s44WXZg2WP83\n\t0qnBEhCNmT6N/AVpR5B7URO21JDqFPJhAI0qeEJAQDnAVo47VdjgcPd4W6SLr1kjgUSq7Z3Sfu4\n\tylopIYsvSYtG9BvsEq/kiNrxIcuXKg/ZD1JhI6M0HRIatYNyY+d0noOm3kFR817KsiuQRqNrqKB\n\tMSuF3MNiP9BfzJuu/qpfQ/w59J0g==","X-Received":"by 2002:a17:90b:57c4:b0:35b:9703:7664 with SMTP id\n 98e67ed59e1d1-35c008d38f1mr4197956a91.10.1774376860812;\n Tue, 24 Mar 2026 11:27:40 -0700 (PDT)","From":"Atharv Dubey ","Date":"Tue, 24 Mar 2026 23:56:51 +0530","Subject":"[PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with\n dev_err_probe() in probe function","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260324-deverr-v1-3-7e591cce33a3@gmail.com>","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","In-Reply-To":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>","To":"Till Harbaum , Andi Shyti ,\n Laxman Dewangan , Dmitry Osipenko ,\n Thierry Reding ,\n Jonathan Hunter , Chen-Yu Tsai ,\n Jernej Skrabec ,\n Samuel Holland ,\n Pierre-Yves MORDRET ,\n Alain Volmat ,\n Maxime Coquelin ,\n Alexandre Torgue ,\n Patrice Chotard ,\n Orson Zhai ,\n Baolin Wang ,\n Chunyan Zhang , Jean Delvare ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda , Atharv Dubey ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1774376818; l=3450;\n i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id;\n bh=mGoeA4RoMr6oMafJS8Wz9uEiYGmdoZGvaadkVl07Ac4=;\n b=mqDXFTn7P7YKfYZq5yfTqBReywbYSNkXTrDiQ10Gxn0U4N3AcD22e4px2/bKmxQtkFRLFhMV5\n D6Rwa2VObbECiZHEiSRVGIVnkT5nDLR0wDkwvKuXdMmJb12BQQQ/qlI","X-Developer-Key":"i=atharvd440@gmail.com; a=ed25519;\n pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk="},"content":"From: Enrico Zanda \n\nThis simplifies the code while improving log.\n\nSigned-off-by: Enrico Zanda \nSigned-off-by: Atharv Dubey \n---\n drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 ++++++++++++++-----------------------\n 1 file changed, 20 insertions(+), 35 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c\nindex fb5280b8cf7f..dffbe776a195 100644\n--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c\n+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c\n@@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev)\n \tint ret;\n \n \tof_property_read_u32(np, \"clock-frequency\", &clk_freq);\n-\tif (clk_freq > P2WI_MAX_FREQ) {\n-\t\tdev_err(dev,\n-\t\t\t\"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n-\t\t\tclk_freq);\n-\t\treturn -EINVAL;\n-\t}\n+\tif (clk_freq > P2WI_MAX_FREQ)\n+\t\treturn dev_err_probe(dev, -EINVAL,\n+\t\t\t\t \"required clock-frequency (%u Hz) is too high (max = 6MHz)\",\n+\t\t\t\t clk_freq);\n \n-\tif (clk_freq == 0) {\n-\t\tdev_err(dev, \"clock-frequency is set to 0 in DT\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (clk_freq == 0)\n+\t\treturn dev_err_probe(dev, -EINVAL, \"clock-frequency is set to 0 in DT\\n\");\n \n-\tif (of_get_child_count(np) > 1) {\n-\t\tdev_err(dev, \"P2WI only supports one target device\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tif (of_get_child_count(np) > 1)\n+\t\treturn dev_err_probe(dev, -EINVAL, \"P2WI only supports one target device\\n\");\n \n \tp2wi = devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL);\n \tif (!p2wi)\n@@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev)\n \tchildnp = of_get_next_available_child(np, NULL);\n \tif (childnp) {\n \t\tret = of_property_read_u32(childnp, \"reg\", &target_addr);\n-\t\tif (ret) {\n-\t\t\tdev_err(dev, \"invalid target address on node %pOF\\n\",\n-\t\t\t\tchildnp);\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\t\tif (ret)\n+\t\t\treturn dev_err_probe(dev, -EINVAL,\n+\t\t\t\t\t \"invalid target address on node %pOF\\n\", childnp);\n \n \t\tp2wi->target_addr = target_addr;\n \t}\n@@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev)\n \t\treturn irq;\n \n \tp2wi->clk = devm_clk_get_enabled(dev, NULL);\n-\tif (IS_ERR(p2wi->clk)) {\n-\t\tret = PTR_ERR(p2wi->clk);\n-\t\tdev_err(dev, \"failed to enable clk: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (IS_ERR(p2wi->clk))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->clk),\n+\t\t\t\t \"failed to enable clk\\n\");\n \n \tparent_clk_freq = clk_get_rate(p2wi->clk);\n \n \tp2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);\n-\tif (IS_ERR(p2wi->rstc)) {\n-\t\tdev_err(dev, \"failed to retrieve reset controller: %pe\\n\",\n-\t\t\tp2wi->rstc);\n-\t\treturn PTR_ERR(p2wi->rstc);\n-\t}\n+\tif (IS_ERR(p2wi->rstc))\n+\t\treturn dev_err_probe(dev, PTR_ERR(p2wi->rstc),\n+\t\t\t\t \"failed to retrieve reset controller\\n\");\n \n \tret = reset_control_deassert(p2wi->rstc);\n-\tif (ret) {\n-\t\tdev_err(dev, \"failed to deassert reset line: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(dev, ret, \"failed to deassert reset line\\n\");\n \n \tinit_completion(&p2wi->complete);\n \tp2wi->adapter.dev.parent = dev;\n@@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev)\n \n \tret = devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi);\n \tif (ret) {\n-\t\tdev_err(dev, \"can't register interrupt handler irq%d: %d\\n\",\n-\t\t\tirq, ret);\n+\t\tdev_err_probe(dev, ret, \"can't register interrupt handler irq%d\\n\", irq);\n \t\tgoto err_reset_assert;\n \t}\n \n","prefixes":["03/10"]}