{"id":2215448,"url":"http://patchwork.ozlabs.org/api/patches/2215448/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324163543.55503-5-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324163543.55503-5-thuth@redhat.com>","list_archive_url":null,"date":"2026-03-24T16:35:41","name":"[4/4] tests/functional/qemu_test: Silence warnings from pylint in config.py","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"067e3086f6a216fecb916da05f4ed63026c7957e","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324163543.55503-5-thuth@redhat.com/mbox/","series":[{"id":497313,"url":"http://patchwork.ozlabs.org/api/series/497313/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497313","date":"2026-03-24T16:35:37","name":"Silence some pylint warnings in tests/functional/qemu_test/","version":1,"mbox":"http://patchwork.ozlabs.org/series/497313/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215448/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215448/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=COppT6Az;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgG0J5Dvfz1yFq\n\tfor ; Wed, 25 Mar 2026 03:37:04 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w54k1-00018S-RR; Tue, 24 Mar 2026 12:36:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w54k0-00017m-9j\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:36:28 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w54jy-0004lJ-9d\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:36:28 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-ZPQ3JTGMOuGSaid7EIB0xw-1; Tue,\n 24 Mar 2026 12:36:23 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2EC6F18002CA; Tue, 24 Mar 2026 16:36:22 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.45.224.189])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4CB471800107; Tue, 24 Mar 2026 16:36:20 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774370185;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=z8d/kSXFJPxolA+ehSZUAyNS+VNAQPa/4/QOaVllsHk=;\n b=COppT6AzS2EE0Y+xVHKyW9i8p/npCdlJaXke76hh6vnjGrGTIooEw22wR3WFmdXDROOHNI\n Tv8ssnUhywI8Nx/MU3qF2jJQA1HSVISjH1gnFcxG7PYdFFT7xsKJfCPunq3tACvvoohuc7\n L8uHzYVgBuBKNKw446tvUSb4NHODsxc=","X-MC-Unique":"ZPQ3JTGMOuGSaid7EIB0xw-1","X-Mimecast-MFC-AGG-ID":"ZPQ3JTGMOuGSaid7EIB0xw_1774370182","From":"Thomas Huth ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?P?=\n\t=?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= ,\n Thomas Huth ","Subject":"[PATCH 4/4] tests/functional/qemu_test: Silence warnings from pylint\n in config.py","Date":"Tue, 24 Mar 2026 17:35:41 +0100","Message-ID":"<20260324163543.55503-5-thuth@redhat.com>","In-Reply-To":"<20260324163543.55503-1-thuth@redhat.com>","References":"<20260324163543.55503-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Thomas Huth \n\nPylint complains here:\n\n config.py:1:0: C0114: Missing module docstring (missing-module-docstring)\n config.py:28:4: W0719: Raising too general exception: Exception (broad-exception-raised)\n\nAdd a module description and replace the general Exception to fix this.\nAnd while we're at it, and since we've got a proper module description\nstring now, also replace the copy-n-pasted comment at the top of the file\nwith a proper SPDX identifier.\n\nSigned-off-by: Thomas Huth \n---\n tests/functional/qemu_test/config.py | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/tests/functional/qemu_test/config.py b/tests/functional/qemu_test/config.py\nindex e0893f630ee..5d44b6fa4c0 100644\n--- a/tests/functional/qemu_test/config.py\n+++ b/tests/functional/qemu_test/config.py\n@@ -1,4 +1,4 @@\n-# Test class and utilities for functional tests\n+# SPDX-License-Identifier: GPL-2.0-or-later\n #\n # Copyright 2018, 2024 Red Hat, Inc.\n #\n@@ -10,6 +10,9 @@\n #\n # This work is licensed under the terms of the GNU GPL, version 2 or\n # later. See the COPYING file in the top-level directory.\n+'''\n+Functions related to the configuration of the tests and of the host system\n+'''\n \n import os\n from pathlib import Path\n@@ -25,9 +28,9 @@ def _build_dir():\n if root is not None:\n return Path(root)\n \n- raise Exception(\"Missing MESON_BUILD_ROOT environment variable. \" +\n- \"Please use the '/run' script if invoking \" +\n- \"directly instead of via make/meson\")\n+ raise RuntimeError(\"Missing MESON_BUILD_ROOT environment variable. \" +\n+ \"Please use the '/run' script if invoking \" +\n+ \"directly instead of via make/meson\")\n \n BUILD_DIR = _build_dir()\n \n","prefixes":["4/4"]}