{"id":2215445,"url":"http://patchwork.ozlabs.org/api/patches/2215445/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324163543.55503-3-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324163543.55503-3-thuth@redhat.com>","list_archive_url":null,"date":"2026-03-24T16:35:39","name":"[2/4] tests/functional/qemu_test: Silence (most) warnings from pylint in asset.py","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"377414b64768d304a3b99a6f389ce3abbcca3319","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324163543.55503-3-thuth@redhat.com/mbox/","series":[{"id":497313,"url":"http://patchwork.ozlabs.org/api/series/497313/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497313","date":"2026-03-24T16:35:37","name":"Silence some pylint warnings in tests/functional/qemu_test/","version":1,"mbox":"http://patchwork.ozlabs.org/series/497313/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215445/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215445/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hEqBjOKE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgFzv3YcNz1y1G\n\tfor ; Wed, 25 Mar 2026 03:36:42 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w54jw-00016i-Of; Tue, 24 Mar 2026 12:36:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w54jq-00015m-Cp\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:36:19 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w54jl-0004ja-E5\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 12:36:16 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-R9aFR6ObOgeVkL1iFh-7eQ-1; Tue,\n 24 Mar 2026 12:36:11 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 20C3F1800365; Tue, 24 Mar 2026 16:36:10 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.45.224.189])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C8F3D1800107; Tue, 24 Mar 2026 16:36:07 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774370172;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=+yoAx/LMss+x6qgLSY59oej7Px3L1jy1uYYD5EKmfaA=;\n b=hEqBjOKEJdoSGIaIY/BVkMXwA2pHXVkrKWZjnwbXctULnsAVxe982wO3gbIIgGvTzHzVNM\n c+RZWgSGnN9OneLY8JIwDOuiFeCCVyC+CoK3Hc1S1UdhTf4GGZcnSjY825A2+4C/KjKSto\n vv7SD7nMr1WjHkrW3A0zneEpQRNXxjA=","X-MC-Unique":"R9aFR6ObOgeVkL1iFh-7eQ-1","X-Mimecast-MFC-AGG-ID":"R9aFR6ObOgeVkL1iFh-7eQ_1774370170","From":"Thomas Huth ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?P?=\n\t=?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= ,\n Thomas Huth ","Subject":"[PATCH 2/4] tests/functional/qemu_test: Silence (most) warnings from\n pylint in asset.py","Date":"Tue, 24 Mar 2026 17:35:39 +0100","Message-ID":"<20260324163543.55503-3-thuth@redhat.com>","In-Reply-To":"<20260324163543.55503-1-thuth@redhat.com>","References":"<20260324163543.55503-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Thomas Huth \n\nPylint currently complains:\n\n asset.py:1:0: C0114: Missing module docstring (missing-module-docstring)\n asset.py:21:0: C0115: Missing class docstring (missing-class-docstring)\n asset.py:28:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:34:0: C0115: Missing class docstring (missing-class-docstring)\n asset.py:49:15: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:80:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:83:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:181:43: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:190:39: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:201:39: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:213:15: W0718: Catching too general exception Exception (broad-exception-caught)\n asset.py:218:35: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)\n asset.py:125:4: R0912: Too many branches (16/12) (too-many-branches)\n asset.py:125:4: R0915: Too many statements (64/50) (too-many-statements)\n asset.py:228:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:249:4: C0116: Missing function or method docstring (missing-function-docstring)\n asset.py:257:4: C0116: Missing function or method docstring (missing-function-docstring)\n\nFix all the warnings except for the R0912 and R0915 which will be tackled\nin a later commit.\nAnd while we're at it, also add a proper SPDX license identifier.\n\nSigned-off-by: Thomas Huth \n---\n tests/functional/qemu_test/asset.py | 53 +++++++++++++++++++++--------\n 1 file changed, 38 insertions(+), 15 deletions(-)","diff":"diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py\nindex 45a2e01e2e6..1cd03c2a9a9 100644\n--- a/tests/functional/qemu_test/asset.py\n+++ b/tests/functional/qemu_test/asset.py\n@@ -1,9 +1,12 @@\n-# Test utilities for fetching & caching assets\n+# SPDX-License-Identifier: GPL-2.0-or-later\n #\n # Copyright 2024 Red Hat, Inc.\n #\n # This work is licensed under the terms of the GNU GPL, version 2 or\n # later. See the COPYING file in the top-level directory.\n+'''\n+Test utilities for fetching & caching assets\n+'''\n \n import hashlib\n import logging\n@@ -18,21 +21,27 @@\n from shutil import copyfileobj\n from urllib.error import HTTPError, URLError\n \n+\n class AssetError(Exception):\n+ '''This exception will be raised if an asset is not usable'''\n def __init__(self, asset, msg, transient=False):\n self.url = asset.url\n self.msg = msg\n self.transient = transient\n \n def __str__(self):\n- return \"%s: %s\" % (self.url, self.msg)\n+ return f\"{self.url}: {self.msg}\"\n \n-# Instances of this class must be declared as class level variables\n-# starting with a name \"ASSET_\". This enables the pre-caching logic\n-# to easily find all referenced assets and download them prior to\n-# execution of the tests.\n-class Asset:\n \n+class Asset:\n+ '''\n+ This class is used to represent an asset that gets downloaded from\n+ the internet and will be stored in the local asset cache.\n+ Instances of this class must be declared as class level variables\n+ starting with a name \"ASSET_\". This enables the pre-caching logic\n+ to easily find all referenced assets and download them prior to\n+ execution of the tests.\n+ '''\n def __init__(self, url, hashsum):\n self.url = url\n self.hash = hashsum\n@@ -46,8 +55,7 @@ def __init__(self, url, hashsum):\n self.log = logging.getLogger('qemu-test')\n \n def __repr__(self):\n- return \"Asset: url=%s hash=%s cache=%s\" % (\n- self.url, self.hash, self.cache_file)\n+ return f\"Asset: url={self.url} hash={self.hash} cache={self.cache_file}\"\n \n def __str__(self):\n return str(self.cache_file)\n@@ -71,6 +79,7 @@ def _check(self, cache_file):\n return self.hash == hl.hexdigest()\n \n def valid(self):\n+ '''Check whether the file exists in the cache and has the right hash'''\n if os.getenv(\"QEMU_TEST_REFRESH_CACHE\", None) is not None:\n self.log.info(\"Force refresh of asset %s\", self.url)\n return False\n@@ -78,9 +87,11 @@ def valid(self):\n return self.cache_file.exists() and self._check(self.cache_file)\n \n def fetchable(self):\n+ '''Check whether we are allowed to download assets from the internet'''\n return not os.environ.get(\"QEMU_TEST_NO_DOWNLOAD\", False)\n \n def available(self):\n+ '''Check whether the asset is either in the cache or fetchable'''\n return self.valid() or self.fetchable()\n \n def _wait_for_other_download(self, tmp_cache_file):\n@@ -123,6 +134,7 @@ def _save_time_stamp(self):\n self.cache_file.with_suffix(\".stamp\").write_text(f\"{int(time.time())}\")\n \n def fetch(self):\n+ '''Download the asset from the internet'''\n if not self.cache_dir.exists():\n self.cache_dir.mkdir(parents=True, exist_ok=True)\n \n@@ -179,7 +191,7 @@ def fetch(self):\n # server or networking problem\n if e.code == 404:\n raise AssetError(self, \"Unable to download: \"\n- \"HTTP error %d\" % e.code) from e\n+ f\"HTTP error {e.code}\") from e\n continue\n except URLError as e:\n # This is typically a network/service level error\n@@ -187,8 +199,9 @@ def fetch(self):\n tmp_cache_file.unlink()\n self.log.error(\"Unable to download %s: URL error %s\",\n self.url, e.reason)\n- raise AssetError(self, \"Unable to download: URL error %s\" %\n- e.reason, transient=True) from e\n+ raise AssetError(self,\n+ f\"Unable to download: URL error{e.reason}\",\n+ transient=True) from e\n except ConnectionError as e:\n # A socket connection failure, such as dropped conn\n # or refused conn\n@@ -198,7 +211,7 @@ def fetch(self):\n continue\n except Exception as e:\n tmp_cache_file.unlink()\n- raise AssetError(self, \"Unable to download: %s\" % e,\n+ raise AssetError(self, f\"Unable to download: {e}\",\n transient=True) from e\n \n if not os.path.exists(tmp_cache_file):\n@@ -210,12 +223,12 @@ def fetch(self):\n self.url.encode('utf8'))\n os.setxattr(str(tmp_cache_file), \"user.qemu-asset-hash\",\n self.hash.encode('utf8'))\n- except Exception as e:\n+ except OSError as e:\n self.log.debug(\"Unable to set xattr on %s: %s\", tmp_cache_file, e)\n \n if not self._check(tmp_cache_file):\n tmp_cache_file.unlink()\n- raise AssetError(self, \"Hash does not match %s\" % self.hash)\n+ raise AssetError(self, f\"Hash does not match {self.hash}\")\n tmp_cache_file.replace(self.cache_file)\n self._save_time_stamp()\n # Remove write perms to stop tests accidentally modifying them\n@@ -226,6 +239,10 @@ def fetch(self):\n \n @staticmethod\n def precache_test(test):\n+ '''\n+ Look for variables starting with \"ASSET_\" and try to fetch the asset\n+ that is specified there.\n+ '''\n log = logging.getLogger('qemu-test')\n log.setLevel(logging.DEBUG)\n handler = logging.StreamHandler(sys.stdout)\n@@ -247,6 +264,9 @@ def precache_test(test):\n \n @staticmethod\n def precache_suite(suite):\n+ '''\n+ Iterate through all tests/suites in a suite and precache their assets\n+ '''\n for test in suite:\n if isinstance(test, unittest.TestSuite):\n Asset.precache_suite(test)\n@@ -255,6 +275,9 @@ def precache_suite(suite):\n \n @staticmethod\n def precache_suites(path, cache_tstamp):\n+ '''\n+ Get the available test suite and precache their assets\n+ '''\n loader = unittest.loader.defaultTestLoader\n tests = loader.loadTestsFromNames([path], None)\n \n","prefixes":["2/4"]}