{"id":2215419,"url":"http://patchwork.ozlabs.org/api/patches/2215419/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324151323.74473-3-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324151323.74473-3-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-03-24T15:13:13","name":"[v3,02/12] whpx: i386: enable exceptions VM exit only when needed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"952168e810f82d36b1afe2623fd97f1c6440e64c","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324151323.74473-3-mohamed@unpredictable.fr/mbox/","series":[{"id":497303,"url":"http://patchwork.ozlabs.org/api/series/497303/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497303","date":"2026-03-24T15:13:13","name":"whpx: i386: Windows 10 and performance fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/497303/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215419/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215419/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=U2NJbg7y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgD9x3mCqz1xy1\n\tfor ; Wed, 25 Mar 2026 02:15:17 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w53Sv-0005tl-Tw; Tue, 24 Mar 2026 11:14:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w53Sn-0005sP-Ip\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 11:14:38 -0400","from p-east2-cluster6-host6-snip4-3.eps.apple.com ([57.103.76.224]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w53Si-0005rj-1B\n for qemu-devel@nongnu.org; Tue, 24 Mar 2026 11:14:36 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-7 (Postfix) with ESMTPS id\n 067C6180312E; Tue, 24 Mar 2026 15:14:21 +0000 (UTC)","from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-60-percent-7 (Postfix) with ESMTPSA id\n 137791835339; Tue, 24 Mar 2026 15:13:40 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1774365264; x=1776957264;\n bh=z2ljL8wNGZuOd0h+jeGsCuyzoynr3r/rNkBTVv1fgB0=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=U2NJbg7yaMTifGpiEy9VkReb2hW8RTckA7AYBym+hgED9wwgOUoyTROwYsYRYYys774RyPN+B6pzqnZoQlm7tDTmGgFOeiFajMc8x5f6pvq6LgtxUwMeMswHe5V1HkvNrwBUTo9Ia0rm5jVcYlV7ympmZkn3A/F8mFYNOof18JDsiLus7wSKPNio2wRdHlCfoq7DKSxIrSdu1VFJF41eEQfghJI943rUBA7iCW5lK2AnrFl6cZsewQdKNvLrwxjHZXBMhm6x4KriTVHEm9lTvQQyrIgb5/c9rx0yoyxTCs3faMnM2ZapLQvgnu7kaMFDWconZZ0lx7E/YSJ+sMbtaQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Roman Bolshakov ,\n Mohamed Mediouni , Wei Liu ,\n Phil Dennis-Jordan ,\n Pedro Barbuda ","Subject":"[PATCH v3 02/12] whpx: i386: enable exceptions VM exit only when\n needed","Date":"Tue, 24 Mar 2026 16:13:13 +0100","Message-ID":"<20260324151323.74473-3-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260324151323.74473-1-mohamed@unpredictable.fr>","References":"<20260324151323.74473-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"UfoLyG63GY8L_1exhujuUVY1-pankLNB","X-Authority-Info-Out":"v=2.4 cv=aJX9aL9m c=1 sm=1 tr=0 ts=69c2aa4e\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=EmEGBKFVNSqW8m1RzRwA:9","X-Proofpoint-GUID":"UfoLyG63GY8L_1exhujuUVY1-pankLNB","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzI0MDExOSBTYWx0ZWRfX8rIlCKm9wJc9\n 6Sdx1/Hm/Ta2l+cK401QBOaJArCIIxn/4dCdfWJvLTKAIA4GlVQF3NEFMr1ShSRVLnimkGONrZm\n 2nnuA/hdD0hkuU7jgkks8Htv8RODmCxgwwIL1p3aFa34l6+mP5zmn1h6oa5ZSOeE94CXEsp6WLz\n LyWdoT2Ewd0b1N3G2JEIJ+jthdly11M1Asmpl7sUKFFQFzFaJxR0b6Gdcm+WIkezoHsVJ0eRrFs\n HcS68piFQB44JyGRsnhiivMxJ8oh9iD4J+5rc46IzLjmFfIVqfrRUyQrs/Zgj0fMiDnAt/V6o+S\n haa4HXBg4FtIeGROiNxPRdjsGgdCr5jXO726913Y5TSl/M2XbSVsRnZrbY6AU0=","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 spamscore=0\n suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=932 phishscore=0\n malwarescore=0 lowpriorityscore=0 mlxscore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2603240119","Received-SPF":"pass client-ip=57.103.76.224;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The exceptions VM exit was enabled with an empty bitmask\neven when not used.\n\nSigned-off-by: Mohamed Mediouni \n---\n target/i386/whpx/whpx-all.c | 23 ++++++++++++++++++++---\n 1 file changed, 20 insertions(+), 3 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 015c0f1dc9..8f1835ee95 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -903,13 +903,31 @@ static void whpx_init_emu(void)\n HRESULT whpx_set_exception_exit_bitmap(UINT64 exceptions)\n {\n struct whpx_state *whpx = &whpx_global;\n- WHV_PARTITION_PROPERTY prop = { 0, };\n+ WHV_PARTITION_PROPERTY prop;\n HRESULT hr;\n \n if (exceptions == whpx->exception_exit_bitmap) {\n return S_OK;\n }\n \n+ /* Register for MSR and CPUID exits */\n+ memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY));\n+ prop.ExtendedVmExits.X64MsrExit = 1;\n+ if (exceptions != 0) {\n+ prop.ExtendedVmExits.ExceptionExit = 1;\n+ }\n+\n+ hr = whp_dispatch.WHvSetPartitionProperty(\n+ whpx->partition,\n+ WHvPartitionPropertyCodeExtendedVmExits,\n+ &prop,\n+ sizeof(WHV_PARTITION_PROPERTY));\n+ if (FAILED(hr)) {\n+ error_report(\"WHPX: Failed to enable extended VM exits, hr=%08lx\", hr);\n+ return hr;\n+ }\n+\n+ memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY));\n prop.ExceptionExitBitmap = exceptions;\n \n hr = whp_dispatch.WHvSetPartitionProperty(\n@@ -2167,7 +2185,6 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n /* Register for MSR and CPUID exits */\n memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY));\n prop.ExtendedVmExits.X64MsrExit = 1;\n- prop.ExtendedVmExits.ExceptionExit = 1;\n \n hr = whp_dispatch.WHvSetPartitionProperty(\n whpx->partition,\n@@ -2175,7 +2192,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n &prop,\n sizeof(WHV_PARTITION_PROPERTY));\n if (FAILED(hr)) {\n- error_report(\"WHPX: Failed to enable MSR & CPUIDexit, hr=%08lx\", hr);\n+ error_report(\"WHPX: Failed to enable extended VM exits, hr=%08lx\", hr);\n ret = -EINVAL;\n goto error;\n }\n","prefixes":["v3","02/12"]}