{"id":2215393,"url":"http://patchwork.ozlabs.org/api/patches/2215393/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324135026.247418-1-shivangu@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324135026.247418-1-shivangu@linux.ibm.com>","list_archive_url":null,"date":"2026-03-24T13:50:26","name":"ppc/pnv: generate dtb after machine initialization is complete","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e755be5993115b52956288a57440a840cd6bab5e","submitter":{"id":91952,"url":"http://patchwork.ozlabs.org/api/people/91952/?format=json","name":"Shivang Upadhyay","email":"shivangu@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260324135026.247418-1-shivangu@linux.ibm.com/mbox/","series":[{"id":497293,"url":"http://patchwork.ozlabs.org/api/series/497293/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497293","date":"2026-03-24T13:50:26","name":"ppc/pnv: generate dtb after machine initialization is complete","version":1,"mbox":"http://patchwork.ozlabs.org/series/497293/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215393/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215393/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=XBrxl0Is;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgBL023hTz1xy1\n\tfor ; Wed, 25 Mar 2026 00:52:08 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w52AS-00060J-Qf; Tue, 24 Mar 2026 09:51:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w52AQ-0005zC-Go; Tue, 24 Mar 2026 09:51:34 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w52AO-0006o3-7B; Tue, 24 Mar 2026 09:51:33 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62O8hR10569186; Tue, 24 Mar 2026 13:51:25 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ktuu6mb-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 24 Mar 2026 13:51:24 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62OCe3qs026698;\n Tue, 24 Mar 2026 13:51:24 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d275kt1n2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 24 Mar 2026 13:51:23 +0000","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62ODpK1H60621286\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 24 Mar 2026 13:51:20 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id F244520049;\n Tue, 24 Mar 2026 13:51:19 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 1B80620040;\n Tue, 24 Mar 2026 13:51:15 +0000 (GMT)","from shivang.com (unknown [9.39.27.96])\n by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 24 Mar 2026 13:51:14 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=buuiN39Vu5REgaZO5K2+FV8UZFg9qf9shKom+SDvP\n wU=; b=XBrxl0Isz/7NYTWkSx078WFmpFFhirkKGClIvjNhLTyoTkbGZq1SahuSa\n fSr3nrxmMHiL532iH69qsDrNSL+e8yzsfhZIS5XjvgDYn2S/hyTtOZf07aN17F4R\n 1unq6QXJ3tOhL20eioCgyB5bIIXu/tmBfb6jhfoTCOhNzCqm7+jOLe51ZkiT9xDx\n +d+g6Cvgx7Enim4iLawzPjjtG+QkZLRw1JTuZ7DBX2SUnMpwROo5mO9DQzgL5os9\n 2WpbxdYbf0gDOASd6RLxf2oXXZUizZ2CwjSm1uJkLMjRrEGqHWvrIsD0omMzhZRr\n oUXdz93IZpMGj5tSzZTWVfsSaIaWw==","From":"Shivang Upadhyay ","To":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Cc":"npiggin@gmail.com, milesg@linux.ibm.com,\n Shivang Upadhyay ,\n Aditya Gupta ,\n Harsh Prateek Bora ,\n BALATON Zoltan , qemu-stable@nongnu.org,\n Nathan Chancellor ,\n Peter Maydell ","Subject":"[PATCH] ppc/pnv: generate dtb after machine initialization is\n complete","Date":"Tue, 24 Mar 2026 19:20:26 +0530","Message-ID":"<20260324135026.247418-1-shivangu@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"PL6XUOS4SMvoB2sdZj_IUFRltYYO4G3q","X-Authority-Analysis":"v=2.4 cv=aMr9aL9m c=1 sm=1 tr=0 ts=69c296dc cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=69wJf7TsAAAA:8\n a=KKAkSRfTAAAA:8 a=3Nvx4KkB4OfEQQwSXpwA:9 a=Fg1AiH1G6rFz08G2ETeA:22\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzI0MDEwOSBTYWx0ZWRfX6xOMU+08LE2Z\n SRSOrFBZ2ZTZeW0W1HA5RmqGn1L43Iu2t5Y3eSaPj+uH9gEJHKwV4ek1EXY2XnrmSWsY7HJU/nY\n BrZWDWJx/7FruzGLHqLp+MmTYe6sZi5flAhMiXYIrZy79o/lA1EadldPKr4n7z98W9uEzRqAqlp\n vdcpp5f3y2hUlncDORX+7pGD8HwyrI2FHtYpcpEBHl2WYo1AF/ffiAwilTSnGtX+15PLCzp1IXo\n MrQAu1Gae0LxwN2O7fpuFjTS1eW6nmq4OggNQ+cVe/EJB2m6oNnzS9Z8gKw7E9fU6SDF3az1k1l\n s1BMdKVFEk/o83htiU+6r3FL7Ty038i5IM2h98aSNvzPQSQYlVY2UkAwkxy/1WpkYHyNI0vSgX3\n F3ctWx7tuKEzgrpmFVGjwDaGiwPWiKknjMrCupdkY9JMuemnnv3XdQ54RELhtL60smqM0a4fW0h\n uYRxX3Bq1yjOydMVh/w==","X-Proofpoint-GUID":"8HALic1-HaJl6yIUSwE-5z-3F96iB8gs","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0\n suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240109","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=shivangu@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Currently, the machine dtb is generated in pnv_init(), before all devices\nare fully initialized. This can result in an incomplete dtb for the system,\nas seen in bug [1].\n\nFix this by deferring dtb generation until machine initialization is complete,\nusing the machine_init_done_notifier hook.\n\n[1] https://lore.kernel.org/all/20260323231612.GA2637687@ax162/\n\nCc: Aditya Gupta \nCc: Harsh Prateek Bora \nCc: BALATON Zoltan \nCc: qemu-stable@nongnu.org\nReported-by: Nathan Chancellor \nSuggested-by: Peter Maydell \nFixes: a16d4c2f162a86d (\"ppc/pnv: fix dumpdtb option\")\nSigned-off-by: Shivang Upadhyay \n---\n hw/ppc/pnv.c | 17 +++++++++++++----\n include/hw/ppc/pnv.h | 2 ++\n 2 files changed, 15 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\nindex 7e54b6bc60..f13b2e3db8 100644\n--- a/hw/ppc/pnv.c\n+++ b/hw/ppc/pnv.c\n@@ -984,6 +984,17 @@ static uint64_t pnv_chip_get_ram_size(PnvMachineState *pnv, int chip_id)\n return chip_id == 0 ? 1 * GiB : QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);\n }\n \n+static void pnv_machine_init_done(Notifier *notifier, void *data)\n+{\n+ PnvMachineState *pnv = container_of(notifier, PnvMachineState, machine_init_done);\n+ MachineState *machine = MACHINE(pnv);\n+\n+ if (!machine->fdt) {\n+ machine->fdt = pnv_dt_create(machine);\n+ _FDT((fdt_pack(machine->fdt)));\n+ }\n+}\n+\n static void pnv_init(MachineState *machine)\n {\n const char *bios_name = machine->firmware ?: FW_FILE_NAME;\n@@ -1244,10 +1255,8 @@ static void pnv_init(MachineState *machine)\n pmc->i2c_init(pnv);\n }\n \n- if (!machine->fdt) {\n- machine->fdt = pnv_dt_create(machine);\n- _FDT((fdt_pack(machine->fdt)));\n- }\n+ pnv->machine_init_done.notify = pnv_machine_init_done;\n+ qemu_add_machine_init_done_notifier(&pnv->machine_init_done);\n }\n \n /*\ndiff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h\nindex 24f8843a40..90028f974d 100644\n--- a/include/hw/ppc/pnv.h\n+++ b/include/hw/ppc/pnv.h\n@@ -111,6 +111,8 @@ struct PnvMachineState {\n \n bool big_core;\n bool lpar_per_core;\n+\n+ Notifier machine_init_done;\n };\n \n PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t chip_id);\n","prefixes":[]}