{"id":2215390,"url":"http://patchwork.ozlabs.org/api/patches/2215390/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260324133551.2332702-1-ams@baylibre.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260324133551.2332702-1-ams@baylibre.com>","list_archive_url":null,"date":"2026-03-24T13:35:51","name":"libgomp, nvptx: remove erroneous stack deletion","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"29cb6b7c17ac99fb9b154d21ef4acb3fab597a91","submitter":{"id":87887,"url":"http://patchwork.ozlabs.org/api/people/87887/?format=json","name":"Andrew Stubbs","email":"ams@baylibre.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260324133551.2332702-1-ams@baylibre.com/mbox/","series":[{"id":497290,"url":"http://patchwork.ozlabs.org/api/series/497290/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=497290","date":"2026-03-24T13:35:51","name":"libgomp, nvptx: remove erroneous stack deletion","version":1,"mbox":"http://patchwork.ozlabs.org/series/497290/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2215390/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2215390/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=d1g+7b7c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=d1g+7b7c","sourceware.org;\n dmarc=none (p=none dis=none) header.from=baylibre.com","sourceware.org; spf=pass smtp.mailfrom=baylibre.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.221.49"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgB1S1BC9z1xy1\n\tfor ; Wed, 25 Mar 2026 00:37:48 +1100 (AEDT)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2E14C4BB58AA\n\tfor ; Tue, 24 Mar 2026 13:37:46 +0000 (GMT)","from mail-wr1-f49.google.com (mail-wr1-f49.google.com\n [209.85.221.49])\n by sourceware.org (Postfix) with ESMTPS id 64B324B9DB57\n for ; Tue, 24 Mar 2026 13:36:51 +0000 (GMT)","by mail-wr1-f49.google.com with SMTP id\n ffacd0b85a97d-439cd6b09f8so3945737f8f.3\n for ; Tue, 24 Mar 2026 06:36:51 -0700 (PDT)","from vbuild-02.baylibre ([217.13.61.132])\n by smtp.googlemail.com with ESMTPSA id\n ffacd0b85a97d-43b6470f902sm40218015f8f.28.2026.03.24.06.36.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Mar 2026 06:36:13 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 2E14C4BB58AA","OpenDKIM Filter v2.11.0 sourceware.org 64B324B9DB57"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 64B324B9DB57","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 64B324B9DB57","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774359411; cv=none;\n b=csTmNmhcqXK+DnjaKivFEXstpet89jWGRZsCD0F9qkU1E6la/xN1fyecYul15+3HPIxF40nThI5YRzipUGIh1CLRpPbON2+faNgsst1IphqjRXkzRmo9FSx3IyltvvhYKDAXaQVR/dV+iWCGUYtS3d/ChnrWACi0FKenbPLUVOY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774359411; c=relaxed/simple;\n bh=RcjPm+wtCMKYdHTnBxcbAAVijT48pA+20MiAfnJthvU=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=QdlZ04MdAuarzDNsRM3R1fI69Qpwiq2dcrtytaYYa0YikUE9+7ppLmxejmyBcxUIatkjyM1QtO+hZ9CjtpeP/DX1vMuunGQegQADegyqrYJrO8PjWFTckkeS6YvN2Jxk1/l3uu5pOVPXu4/dZpCCWgAahzVbbzhTi83vGikqE00=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774359410;\n x=1774964210;\n darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=kn2rMKPwZtWjUJI3EKNfoD9fHBMPAh0hNsQ+SaGIRu4=;\n b=d1g+7b7clIUzDH3Gxo1ltl1B1YXWwacXpnZxkCvqOON7H+oVEVKSBW7EDT02Te5EM9\n BQaQE2QFq/iuHEYl1zoiEU/roLy92yAMhzcpkxlsfncBqynfLJA/stnKxlYBzM7N+/HX\n Slhn325a0q8Pim0U/Jd6PRWZSt3MxVUz46uBGaLdqLzmzDA8vL/HSMzI1OLMu6VbXk2x\n 0LQ5wbg8aLZ2p5HbLkJLmOUB03GADmu8ggG6iTwfhJA74Itq3dUG6E1nAoA/rcaDTMLD\n M13FrSNZ6Y/bGnruIb+KUhLSOitzASz59YaBXppQjibN7im7HE+qkZbR3yUi0kprRSbj\n 34xg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774359410; x=1774964210;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kn2rMKPwZtWjUJI3EKNfoD9fHBMPAh0hNsQ+SaGIRu4=;\n b=N9hw9WImc4qHS8qIYonnp30UhiOJnUWg6kp4lYnwR2TaEVZ7YnH+fbN5+SLUKWtgRu\n EJX+/CFyfUU1NmTpf658UYpiQodFxsXfK5VIfd4qGEe39z7IDuWyQsEPiueJzwFrchXH\n M874eTckgo8Q2IRzKDLr+V70h2nBgvg6KamcWmNMwBjo2v/CGpUSj4G3mP70jMFg0vdb\n MPUg2XLgns/YDTayMbL9L7jEKYy37q2JF8Zd+xaEPsW6J0OaDBJFHgJXYciP2zWhhWky\n 6wXoFEzBHXPs6p2ulWqAQcBxY/6C9W0rs8A58GVoAIxBGHu+UAzEbTcbRwGpZ6LW7YVV\n aNkA==","X-Gm-Message-State":"AOJu0Yxne8EP6bnJGDzDXSPFMji9jKfeVdwtyzbGQwjTEGp62VHFmjmW\n xKN+md42Wtb7dxbLh4BY4YTLXPYCJWlAtfI723uloMuP97L9et9U1m9XH+4m3cWfRLaCGFhhgQl\n 6GQTd0sQ=","X-Gm-Gg":"ATEYQzxcV/0s0m7nRFPcwIc7dIiclz+yc4F2WmchIZ0FPeF8H/g4sNwpIDIC0CG2yHi\n grKQcUk9YA0/XCx5U2eLw1IzjCRfnh8iGRjO1lJ0JM0+D3kYjfXpMHew0R7j48y/6tMoycPDm5N\n DBdx0usPDSFCrzZVwT8wHjYsZOn8Hcx4d5l6a6RHArC8f+mzYSgy+vNMqHfns56wtTWI8VblitU\n YTqsGDP6thO1Lk9VOuCaWvwmVzRfV8LKq/DbzGxNjmo7qc8e/sxGkzcG0uBLZFfTcczdvl/M151\n ZfQrXaEcAT++5PPUjeSJM8QQMcvVJv0DOxxy/sbS/rwcg923CiX2WoIvi55dpMzAjK4p0D2lYme\n 7rNbp84G02Dkvol6WaHo20WJDlX6FONi79W9XgCqDgf+TOUoowMIQaqJWfVyLVne9v7eIwq3ihK\n 571WZoxOHyzKly4CSIipz4DtYkwQ==","X-Received":"by 2002:a05:6000:3113:b0:43a:4de:fdc2 with SMTP id\n ffacd0b85a97d-43b6424b915mr24069655f8f.13.1774359374086;\n Tue, 24 Mar 2026 06:36:14 -0700 (PDT)","From":"Andrew Stubbs ","To":"gcc-patches@gcc.gnu.org","Cc":"tschwinge@baylibre.com","Subject":"[PATCH] libgomp, nvptx: remove erroneous stack deletion","Date":"Tue, 24 Mar 2026 13:35:51 +0000","Message-ID":"<20260324133551.2332702-1-ams@baylibre.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Andrew Stubbs \n\nThe stacks are not supposed to be deleted every time memory is allocated, only\nwhen there is insufficient memory. The unconditional call here seems to be in\nerror, and is causing a costly reallocation of the stacks before every launch.\n\nlibgomp/\n\n\t* plugin/plugin-nvptx.c (cleanup_and_alloc): Remove early call to\n\tnvptx_stacks_free.\n---\n\nThis bug fix has long been used on the devel/omp/gcc-15 branch and\ntesting showed no regressions in the libgomp testsuite.\n\nI think this should be fine for stage 4.\n\nOK to commit?\n\nAndrew\n\n\n libgomp/plugin/plugin-nvptx.c | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/libgomp/plugin/plugin-nvptx.c b/libgomp/plugin/plugin-nvptx.c\nindex a540e9d4cce..bde52c89c77 100644\n--- a/libgomp/plugin/plugin-nvptx.c\n+++ b/libgomp/plugin/plugin-nvptx.c\n@@ -1866,8 +1866,6 @@ cleanup_and_alloc (int ord, size_t size, bool managed)\n ptx_dev->free_blocks = NULL;\n pthread_mutex_unlock (&ptx_dev->free_blocks_lock);\n \n- nvptx_stacks_free (ptx_dev, false);\n-\n while (blocks)\n {\n tmp = blocks->next;\n","prefixes":[]}