{"id":2183230,"url":"http://patchwork.ozlabs.org/api/patches/2183230/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-23-ebiggers@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260112192035.10427-23-ebiggers@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260112192035.10427-23-ebiggers@kernel.org/","date":"2026-01-12T19:20:20","name":"[v2,22/35] staging: rtl8723bs: core: Use new AES library API","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"14ca09e08fb661a40971fa36abd1cdfcd9b984b2","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-23-ebiggers@kernel.org/mbox/","series":[{"id":488089,"url":"http://patchwork.ozlabs.org/api/series/488089/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089","date":"2026-01-12T19:19:58","name":"AES library improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/488089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2183230/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2183230/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gj85ij8q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15586-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gj85ij8q;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj7x1G8cz1xpY\n\tfor ; Tue, 13 Jan 2026 06:27:41 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3l4yVBz3cZ4;\n\tTue, 13 Jan 2026 06:24:03 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3k6fSwz3c3g\n\tfor ; Tue, 13 Jan 2026 06:24:02 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 5112060055;\n\tMon, 12 Jan 2026 19:23:30 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9A322C2BC86;\n\tMon, 12 Jan 2026 19:23:29 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245843;\n\tcv=none;\n b=QZiAXycy+7xgvCHizAqALnrqYkUK+22lchkXnVyEyUFsEu9irtbFP1YjuAX1/kjzKhOO1HsssuvRXX2gZ41Zm3eBOezfc3wg3Hpfy2mvsA97o4s13Up9SD8ztBUUsCRtnNiOsRCM+jKg6SqI2KsCZgHgtkrNejgmqppUw1NSAx9l7oWO59Sp6WD0ZSecS4TR2kUpDH5giIoZj5d5j15z8f/04zgX8i1pKF02FR19QE4qUODKCFLVTYPJbj6Ca4MBMUgQ29B2OH0JCuxnmh5+ddaSLrzQtfd6if5f6/s1zqNM9p5ALed2hEtQ646OP060VpGy40hvaYrznv/TEr/rVg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245843; c=relaxed/relaxed;\n\tbh=OMxlSvPQL7S3V41U4MUzI5yC5X7IcvJTh/x5oQJm1eg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=ZkOUdG7HA4K3Ysy8VsU8XxX3RRnfdECEXFMNRIGCxgZptyXMdHZOrwjIsOMoIolTq7Ubm2lZtbnkrMyoq8zFO3CF0/OnFdypQk5x9KNpqOPvoBxYbE9jIOqLItK+PSk14QdYnDSuB3LKFhLoJFEg87tUOiQLD73DeKH88pCxPh8mgauo6I8oKQQ8/igbG6hBLtlbiABHqjrfsxQtTqSq2ZM1NallDu5IRUaqmAyIj+hV930l7+/dbZaCp0QsclLqK9I1R0J0qgohvyOKPrwhFeLX9QQlwgMgUzk6wodVLPatSFak4t+B+ibMu/1c6PJ6+6szA0mFg28l442tSxDfbg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gj85ij8q; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245810;\n\tbh=wXdwY1WoVa5ZNu1Fe87Z9mILsLA3s28tZHNhWF6S8gw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gj85ij8qJIew+bWKcniT1QlwS/ryjNF9CQBcnJ8+C99RNEOoBqERPk4+1FRbNhhw0\n\t FZGVIA1d56xRQ+5i2prmCgQ5T+K156MKnGC9hAtOYNu+5kRR2YT0qGwptAkoCBCf54\n\t rDdZRiy4YuiA9Tsxq+bEV3KDyjzv6XZto+e39v5MAzqLjDYypucU44X5+AGKiAuMm1\n\t gVy605yDG4qjxS5/wUd5S5E9WiRd3DZKQ3uVMlmVp9KBGAKsdjvi+/8jWGd1aisRvp\n\t db/Cr2lSi0DrDychLsRvaGIBD9agCrol/u3YT7AOB4sZgb0wbn1k5hbcfcWAHgexUs\n\t LUbeyOTiy34tg==","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler ,\n\tHarald Freudenberger ,\n\tEric Biggers ","Subject":"[PATCH v2 22/35] staging: rtl8723bs: core: Use new AES library API","Date":"Mon, 12 Jan 2026 11:20:20 -0800","Message-ID":"<20260112192035.10427-23-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112192035.10427-1-ebiggers@kernel.org>","References":"<20260112192035.10427-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_enckey). This\neliminates the unnecessary computation and caching of the decryption\nround keys. The new AES en/decryption functions are also much faster\nand use AES instructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one.\n\nAcked-by: Ard Biesheuvel \nSigned-off-by: Eric Biggers \n---\n drivers/staging/rtl8723bs/core/rtw_security.c | 20 +++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c\nindex 2f941ffbd465..8ee5bed252bf 100644\n--- a/drivers/staging/rtl8723bs/core/rtw_security.c\n+++ b/drivers/staging/rtl8723bs/core/rtw_security.c\n@@ -635,15 +635,15 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)\n /* Performs a 128 bit AES encrypt with */\n /* 128 bit data. */\n /****************************************/\n static void aes128k128d(u8 *key, u8 *data, u8 *ciphertext)\n {\n-\tstruct crypto_aes_ctx ctx;\n+\tstruct aes_enckey aes;\n \n-\taes_expandkey(&ctx, key, 16);\n-\taes_encrypt(&ctx, ciphertext, data);\n-\tmemzero_explicit(&ctx, sizeof(ctx));\n+\taes_prepareenckey(&aes, key, 16);\n+\taes_encrypt(&aes, ciphertext, data);\n+\tmemzero_explicit(&aes, sizeof(aes));\n }\n \n /************************************************/\n /* construct_mic_iv() */\n /* Builds the MIC IV from header fields and PN */\n@@ -1404,17 +1404,17 @@ static void gf_mulx(u8 *pad)\n * (SP) 800-38B.\n */\n static int omac1_aes_128_vector(u8 *key, size_t num_elem,\n \t\t\t\tu8 *addr[], size_t *len, u8 *mac)\n {\n-\tstruct crypto_aes_ctx ctx;\n+\tstruct aes_enckey aes;\n \tu8 cbc[AES_BLOCK_SIZE], pad[AES_BLOCK_SIZE];\n \tu8 *pos, *end;\n \tsize_t i, e, left, total_len;\n \tint ret;\n \n-\tret = aes_expandkey(&ctx, key, 16);\n+\tret = aes_prepareenckey(&aes, key, 16);\n \tif (ret)\n \t\treturn -1;\n \tmemset(cbc, 0, AES_BLOCK_SIZE);\n \n \ttotal_len = 0;\n@@ -1434,16 +1434,16 @@ static int omac1_aes_128_vector(u8 *key, size_t num_elem,\n \t\t\t\tpos = addr[e];\n \t\t\t\tend = pos + len[e];\n \t\t\t}\n \t\t}\n \t\tif (left > AES_BLOCK_SIZE)\n-\t\t\taes_encrypt(&ctx, cbc, cbc);\n+\t\t\taes_encrypt(&aes, cbc, cbc);\n \t\tleft -= AES_BLOCK_SIZE;\n \t}\n \n \tmemset(pad, 0, AES_BLOCK_SIZE);\n-\taes_encrypt(&ctx, pad, pad);\n+\taes_encrypt(&aes, pad, pad);\n \tgf_mulx(pad);\n \n \tif (left || total_len == 0) {\n \t\tfor (i = 0; i < left; i++) {\n \t\t\tcbc[i] ^= *pos++;\n@@ -1457,12 +1457,12 @@ static int omac1_aes_128_vector(u8 *key, size_t num_elem,\n \t\tgf_mulx(pad);\n \t}\n \n \tfor (i = 0; i < AES_BLOCK_SIZE; i++)\n \t\tpad[i] ^= cbc[i];\n-\taes_encrypt(&ctx, pad, mac);\n-\tmemzero_explicit(&ctx, sizeof(ctx));\n+\taes_encrypt(&aes, pad, mac);\n+\tmemzero_explicit(&aes, sizeof(aes));\n \treturn 0;\n }\n \n /**\n * omac1_aes_128 - One-Key CBC MAC (OMAC1) hash with AES-128 (aka AES-CMAC)\n","prefixes":["v2","22/35"]}