{"id":2183213,"url":"http://patchwork.ozlabs.org/api/patches/2183213/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-2-ebiggers@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260112192035.10427-2-ebiggers@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260112192035.10427-2-ebiggers@kernel.org/","date":"2026-01-12T19:19:59","name":"[v2,01/35] crypto: powerpc/aes - Rename struct aes_key","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"cea758148365f86caf14ecfedf3305c379631370","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-2-ebiggers@kernel.org/mbox/","series":[{"id":488089,"url":"http://patchwork.ozlabs.org/api/series/488089/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089","date":"2026-01-12T19:19:58","name":"AES library improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/488089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2183213/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2183213/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-15575-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MQ/vnJyk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15575-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MQ/vnJyk;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj6K6XSSz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 06:26:17 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3W3dlXz30Gm;\n\tTue, 13 Jan 2026 06:23:51 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3V4WQwz2xQs\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 13 Jan 2026 06:23:50 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 9AF51600AA;\n\tMon, 12 Jan 2026 19:23:18 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E39F0C19424;\n\tMon, 12 Jan 2026 19:23:17 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245831;\n\tcv=none;\n b=eH7HaP9S6ZR2kCvxVF3dE2QyHZMIvke7wUg7FfG6mWx6wopw2Ur1a31IFTor+LKy3ADMw6ZrEcOWlPUu4tchAf4LWrCMy4WEAgsbItIxEvpkRx2ZAq9d0YI5U3Mmf1xYY6NAlymihztkKjk8Ec8ORk7A96JhAr7ViqTmOSeGe5JndtpzymNwDUP3WjKBTTCOpXR4GyljweHjOiB2wILn376/p2j6cv69X9rAcAKQ+/AmrccAhCO3pvP1jpDQthLDQ81S038iIXXe5NfymbVSXN2qjL3IteDqkDvrkyiSh6W2R9Gg20V5Yw1w+NnR6XLI2UYbKKw7VfTQVsY33JzRjA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245831; c=relaxed/relaxed;\n\tbh=e593l6dZYweWWJZwnbJS7ovWKpa7rdp0PhFnwfXn1jM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=f4GoeEDTNRbrb7Ww3bhyayNtFZKlkrWafb/w4qzP5MfJmccZOe5QDsoLW1GscesrVRH1CwcgVOKombWyPxbjsw/6enhmqHTt5fBYFk8KsRb3DRsYZTQZj5sgl6jGfx6iyOCIjhAYHsHIrY4OzX8xYEHEmF1xKGvDwuEhg7N2gPQv5TFqho8emN7pjJL8vg2rLODtjtNIXEPqXLeVfKTG6DfLCfud97idWfgyqQAIL50vh+IrQqdq7I2OCV82C5DfUApj4wXPXm8eGZmjmpJXrt+Kh8hoegyv/I93V4gXXAmAnrllyTHYkMQiRBbvdth4RfkPw6DaVzI5pmdR8kJFuA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MQ/vnJyk; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245798;\n\tbh=JV1M038y5fd1Fii+AIq80mfwW2VT2ZAZq/Qain419Vk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MQ/vnJyka/X0XFbjFkcVN6G/B0jLA5ZQ6lT1j0NV1HnrydwRrKx6ievF5NaNQeFK2\n\t En2/0NauYq26MK+TbhehCCIBL3ds60TW5Z1dCEMkqmaoNscKya6DAA88yY7Jnmi6ZD\n\t wy86VZQvANV8MRWkR2lAJ7tChvw8hFgI/EgSn9xhjw+0tOcGU1Vwqi5Hu2bsZIMIeE\n\t XLUzLjcQo5a4UFcXXFXdNcf9t+790gS1lKaLfIw7kKI/bp3v3HsnlyJg8MPxluIoS+\n\t N7CgjSk/kPaDpOljRew2l7Ub+WjkD5a94TMHmF9gjmdLXkxvz22UlUSwiS8x2WPWD9\n\t OYTzunf4AtPOg==","From":"Eric Biggers <ebiggers@kernel.org>","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler <dengler@linux.ibm.com>,\n\tHarald Freudenberger <freude@linux.ibm.com>,\n\tEric Biggers <ebiggers@kernel.org>","Subject":"[PATCH v2 01/35] crypto: powerpc/aes - Rename struct aes_key","Date":"Mon, 12 Jan 2026 11:19:59 -0800","Message-ID":"<20260112192035.10427-2-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112192035.10427-1-ebiggers@kernel.org>","References":"<20260112192035.10427-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Rename struct aes_key in aesp8-ppc.h and aes-gcm-p10-glue.c to\np8_aes_key and p10_aes_key, respectively.  This frees up the name to use\nin the library API in <crypto/aes.h>.\n\nAcked-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n arch/powerpc/crypto/aes-gcm-p10-glue.c |  4 ++--\n arch/powerpc/crypto/aes.c              |  4 ++--\n arch/powerpc/crypto/aes_cbc.c          |  4 ++--\n arch/powerpc/crypto/aes_ctr.c          |  2 +-\n arch/powerpc/crypto/aes_xts.c          |  6 +++---\n arch/powerpc/crypto/aesp8-ppc.h        | 23 ++++++++++++-----------\n 6 files changed, 22 insertions(+), 21 deletions(-)","diff":"diff --git a/arch/powerpc/crypto/aes-gcm-p10-glue.c b/arch/powerpc/crypto/aes-gcm-p10-glue.c\nindex 85f4fd4b1bdc..f3417436d3f7 100644\n--- a/arch/powerpc/crypto/aes-gcm-p10-glue.c\n+++ b/arch/powerpc/crypto/aes-gcm-p10-glue.c\n@@ -42,11 +42,11 @@ asmlinkage void aes_p10_gcm_decrypt(const u8 *in, u8 *out, size_t len,\n asmlinkage void gcm_init_htable(unsigned char htable[], unsigned char Xi[]);\n asmlinkage void gcm_ghash_p10(unsigned char *Xi, unsigned char *Htable,\n \t\t\t      unsigned char *aad, unsigned int alen);\n asmlinkage void gcm_update(u8 *iv, void *Xi);\n \n-struct aes_key {\n+struct p10_aes_key {\n \tu8 key[AES_MAX_KEYLENGTH];\n \tu64 rounds;\n };\n \n struct gcm_ctx {\n@@ -61,11 +61,11 @@ struct Hash_ctx {\n \tu8 H[16];\t/* subkey */\n \tu8 Htable[256];\t/* Xi, Hash table(offset 32) */\n };\n \n struct p10_aes_gcm_ctx {\n-\tstruct aes_key enc_key;\n+\tstruct p10_aes_key enc_key;\n \tu8 nonce[RFC4106_NONCE_SIZE];\n };\n \n static void vsx_begin(void)\n {\ndiff --git a/arch/powerpc/crypto/aes.c b/arch/powerpc/crypto/aes.c\nindex 3f1e5e894902..b7192ee719fc 100644\n--- a/arch/powerpc/crypto/aes.c\n+++ b/arch/powerpc/crypto/aes.c\n@@ -19,12 +19,12 @@\n \n #include \"aesp8-ppc.h\"\n \n struct p8_aes_ctx {\n \tstruct crypto_cipher *fallback;\n-\tstruct aes_key enc_key;\n-\tstruct aes_key dec_key;\n+\tstruct p8_aes_key enc_key;\n+\tstruct p8_aes_key dec_key;\n };\n \n static int p8_aes_init(struct crypto_tfm *tfm)\n {\n \tconst char *alg = crypto_tfm_alg_name(tfm);\ndiff --git a/arch/powerpc/crypto/aes_cbc.c b/arch/powerpc/crypto/aes_cbc.c\nindex 5f2a4f375eef..4a9f285f0970 100644\n--- a/arch/powerpc/crypto/aes_cbc.c\n+++ b/arch/powerpc/crypto/aes_cbc.c\n@@ -19,12 +19,12 @@\n \n #include \"aesp8-ppc.h\"\n \n struct p8_aes_cbc_ctx {\n \tstruct crypto_skcipher *fallback;\n-\tstruct aes_key enc_key;\n-\tstruct aes_key dec_key;\n+\tstruct p8_aes_key enc_key;\n+\tstruct p8_aes_key dec_key;\n };\n \n static int p8_aes_cbc_init(struct crypto_skcipher *tfm)\n {\n \tstruct p8_aes_cbc_ctx *ctx = crypto_skcipher_ctx(tfm);\ndiff --git a/arch/powerpc/crypto/aes_ctr.c b/arch/powerpc/crypto/aes_ctr.c\nindex e27c4036e711..7dbd06f442db 100644\n--- a/arch/powerpc/crypto/aes_ctr.c\n+++ b/arch/powerpc/crypto/aes_ctr.c\n@@ -19,11 +19,11 @@\n \n #include \"aesp8-ppc.h\"\n \n struct p8_aes_ctr_ctx {\n \tstruct crypto_skcipher *fallback;\n-\tstruct aes_key enc_key;\n+\tstruct p8_aes_key enc_key;\n };\n \n static int p8_aes_ctr_init(struct crypto_skcipher *tfm)\n {\n \tstruct p8_aes_ctr_ctx *ctx = crypto_skcipher_ctx(tfm);\ndiff --git a/arch/powerpc/crypto/aes_xts.c b/arch/powerpc/crypto/aes_xts.c\nindex 9440e771cede..b4c760e465ea 100644\n--- a/arch/powerpc/crypto/aes_xts.c\n+++ b/arch/powerpc/crypto/aes_xts.c\n@@ -20,13 +20,13 @@\n \n #include \"aesp8-ppc.h\"\n \n struct p8_aes_xts_ctx {\n \tstruct crypto_skcipher *fallback;\n-\tstruct aes_key enc_key;\n-\tstruct aes_key dec_key;\n-\tstruct aes_key tweak_key;\n+\tstruct p8_aes_key enc_key;\n+\tstruct p8_aes_key dec_key;\n+\tstruct p8_aes_key tweak_key;\n };\n \n static int p8_aes_xts_init(struct crypto_skcipher *tfm)\n {\n \tstruct p8_aes_xts_ctx *ctx = crypto_skcipher_ctx(tfm);\ndiff --git a/arch/powerpc/crypto/aesp8-ppc.h b/arch/powerpc/crypto/aesp8-ppc.h\nindex 5764d4438388..0bea010128cb 100644\n--- a/arch/powerpc/crypto/aesp8-ppc.h\n+++ b/arch/powerpc/crypto/aesp8-ppc.h\n@@ -1,10 +1,10 @@\n /* SPDX-License-Identifier: GPL-2.0 */\n #include <linux/types.h>\n #include <crypto/aes.h>\n \n-struct aes_key {\n+struct p8_aes_key {\n \tu8 key[AES_MAX_KEYLENGTH];\n \tint rounds;\n };\n \n extern struct shash_alg p8_ghash_alg;\n@@ -12,19 +12,20 @@ extern struct crypto_alg p8_aes_alg;\n extern struct skcipher_alg p8_aes_cbc_alg;\n extern struct skcipher_alg p8_aes_ctr_alg;\n extern struct skcipher_alg p8_aes_xts_alg;\n \n int aes_p8_set_encrypt_key(const u8 *userKey, const int bits,\n-\t\t\t   struct aes_key *key);\n+\t\t\t   struct p8_aes_key *key);\n int aes_p8_set_decrypt_key(const u8 *userKey, const int bits,\n-\t\t\t   struct aes_key *key);\n-void aes_p8_encrypt(const u8 *in, u8 *out, const struct aes_key *key);\n-void aes_p8_decrypt(const u8 *in, u8 *out, const struct aes_key *key);\n+\t\t\t   struct p8_aes_key *key);\n+void aes_p8_encrypt(const u8 *in, u8 *out, const struct p8_aes_key *key);\n+void aes_p8_decrypt(const u8 *in, u8 *out, const struct p8_aes_key *key);\n void aes_p8_cbc_encrypt(const u8 *in, u8 *out, size_t len,\n-\t\t\tconst struct aes_key *key, u8 *iv, const int enc);\n-void aes_p8_ctr32_encrypt_blocks(const u8 *in, u8 *out,\n-\t\t\t\t size_t len, const struct aes_key *key,\n-\t\t\t\t const u8 *iv);\n+\t\t\tconst struct p8_aes_key *key, u8 *iv, const int enc);\n+void aes_p8_ctr32_encrypt_blocks(const u8 *in, u8 *out, size_t len,\n+\t\t\t\t const struct p8_aes_key *key, const u8 *iv);\n void aes_p8_xts_encrypt(const u8 *in, u8 *out, size_t len,\n-\t\t\tconst struct aes_key *key1, const struct aes_key *key2, u8 *iv);\n+\t\t\tconst struct p8_aes_key *key1,\n+\t\t\tconst struct p8_aes_key *key2, u8 *iv);\n void aes_p8_xts_decrypt(const u8 *in, u8 *out, size_t len,\n-\t\t\tconst struct aes_key *key1, const struct aes_key *key2, u8 *iv);\n+\t\t\tconst struct p8_aes_key *key1,\n+\t\t\tconst struct p8_aes_key *key2, u8 *iv);\n","prefixes":["v2","01/35"]}