{"id":2183200,"url":"http://patchwork.ozlabs.org/api/patches/2183200/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-29-ebiggers@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260112192035.10427-29-ebiggers@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260112192035.10427-29-ebiggers@kernel.org/","date":"2026-01-12T19:20:26","name":"[v2,28/35] crypto: crypto4xx - Use new AES library API","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"2e30d9a03f1ddd6403bde57143885268c82caba6","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-29-ebiggers@kernel.org/mbox/","series":[{"id":488089,"url":"http://patchwork.ozlabs.org/api/series/488089/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089","date":"2026-01-12T19:19:58","name":"AES library improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/488089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2183200/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2183200/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SmkNXd0h;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15566-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SmkNXd0h;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj4x6SWZz1xqD\n\tfor ; Tue, 13 Jan 2026 06:25:05 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3B4GgRz2yvv;\n\tTue, 13 Jan 2026 06:23:34 +1100 (AEDT)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3972Jgz302l\n\tfor ; Tue, 13 Jan 2026 06:23:33 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 80C4A443CE;\n\tMon, 12 Jan 2026 19:23:33 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EF904C2BC86;\n\tMon, 12 Jan 2026 19:23:32 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245814;\n\tcv=none;\n b=OMXWOnyw84zhrEPSC5vuIBdXL2MLSlJyBBiC1XTT8mdKNhBdW1T8jIVitjo18F1lnrl1/y9h4ECZtwJkzdFtGYAqo2vKbGrg1wlLUlIu8ypR4A7oAQMdLy5zJb/+p2aEt2eVpDv3AfGYDxw1n42Y8kfnDbmUbJ8JWic5IAQ2Yi4c7t/R2CrXELOaJJMk7z6KoXXyB3H/agwLj/nU2cNc3AsoW1ZJsRVo7Kcy7k3AHF9RkyC0nqUCVTLiC0Tih3+qzBWD8NWl2M8/TABpNvFG4g106EgRB7SWV+fZqlR8aR5xoDCGVYW9RwzrTVZhe3XiaUY75zGDXOwnjnEV4IdJhw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245814; c=relaxed/relaxed;\n\tbh=IyWtQoy5CZLOtJ00v3/DvPLSKe7LSHvJiVXyBHs4Z0o=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=m8M12rQHnm3967hV6Als3lbs5ed6JOQomOtDQsyOk+hjOaaL6ilMor6EcFStRHeHQ73WcPlXXuEzs6/zOGkEGV30NQJUfCap6aQlGdUi+9y7fpQ/QJdbCRNEQlxfYrfhrGqop0LYPa5zJJ1d4Eb4o3uO56DBh7won8qNSUvCPrC55p0VEyGYmbgahNoN9vHEi2h0Pxs0W+xzpCL3fdcwQ17mXingeUVu38c2BJe7u2IDJPOQ3D3kXTNC0qhOXXs7HwY4YgXpb5uwphpDsoyW5wWzRFhabeDpSpGI74saxioTXjuh5/Memny8SiNcrU3EMW6a9hgKuBRLRgJFUHpZOQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SmkNXd0h; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245813;\n\tbh=GPQcbp+wkmbK7/Rcub4Dq0N8RBzNaIdUT4Zzk3rORWQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SmkNXd0hD/a01rRbzRoTIUUxSVbiJvtS+SpBFPSqlginPRz7r1QpIVUkNBhUwlClB\n\t wu7xWBaWVGiKfKI9UnXxuZtlKeU8IiiMoqEFFelz3rk02+N6/Ank4/srRBvn70In9G\n\t TW3YnOBfyBvX8uDGz5ETCyjwSMU7T2kILTMPcTbBiDJx863zpNVbcPeU2e8YeqUDme\n\t OKVwnwn6rI4vz1BrTpM6yj2boVtQGcfUBLdrDX6PC76mEZZDQv8p+qcrg9dMkE9RcZ\n\t 2/n/32QyL0RrxoLGdj2WxAIAMcosZ6xQGFyXIiGN3aSSA9+IaoKihFMAyf5aRVrEQR\n\t cNQ3vcNviQ8PQ==","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler ,\n\tHarald Freudenberger ,\n\tEric Biggers ","Subject":"[PATCH v2 28/35] crypto: crypto4xx - Use new AES library API","Date":"Mon, 12 Jan 2026 11:20:26 -0800","Message-ID":"<20260112192035.10427-29-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112192035.10427-1-ebiggers@kernel.org>","References":"<20260112192035.10427-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_enckey). This\neliminates the unnecessary computation and caching of the decryption\nround keys. The new AES en/decryption functions are also much faster\nand use AES instructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one.\n\nAcked-by: Ard Biesheuvel \nSigned-off-by: Eric Biggers \n---\n drivers/crypto/amcc/crypto4xx_alg.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/crypto/amcc/crypto4xx_alg.c b/drivers/crypto/amcc/crypto4xx_alg.c\nindex 38e8a61e9166..3177dc4f5f7b 100644\n--- a/drivers/crypto/amcc/crypto4xx_alg.c\n+++ b/drivers/crypto/amcc/crypto4xx_alg.c\n@@ -489,23 +489,23 @@ static int crypto4xx_aes_gcm_validate_keylen(unsigned int keylen)\n }\n \n static int crypto4xx_compute_gcm_hash_key_sw(__le32 *hash_start, const u8 *key,\n \t\t\t\t\t unsigned int keylen)\n {\n-\tstruct crypto_aes_ctx ctx;\n+\tstruct aes_enckey aes;\n \tuint8_t src[16] = { 0 };\n \tint rc;\n \n-\trc = aes_expandkey(&ctx, key, keylen);\n+\trc = aes_prepareenckey(&aes, key, keylen);\n \tif (rc) {\n-\t\tpr_err(\"aes_expandkey() failed: %d\\n\", rc);\n+\t\tpr_err(\"aes_prepareenckey() failed: %d\\n\", rc);\n \t\treturn rc;\n \t}\n \n-\taes_encrypt(&ctx, src, src);\n+\taes_encrypt(&aes, src, src);\n \tcrypto4xx_memcpy_to_le32(hash_start, src, 16);\n-\tmemzero_explicit(&ctx, sizeof(ctx));\n+\tmemzero_explicit(&aes, sizeof(aes));\n \treturn 0;\n }\n \n int crypto4xx_setkey_aes_gcm(struct crypto_aead *cipher,\n \t\t\t const u8 *key, unsigned int keylen)\n","prefixes":["v2","28/35"]}