{"id":2183193,"url":"http://patchwork.ozlabs.org/api/patches/2183193/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-20-ebiggers@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260112192035.10427-20-ebiggers@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260112192035.10427-20-ebiggers@kernel.org/","date":"2026-01-12T19:20:17","name":"[v2,19/35] Bluetooth: SMP: Use new AES library API","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"e2a03acf720f1045b1e921a54328253cc541638f","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-20-ebiggers@kernel.org/mbox/","series":[{"id":488089,"url":"http://patchwork.ozlabs.org/api/series/488089/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089","date":"2026-01-12T19:19:58","name":"AES library improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/488089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2183193/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2183193/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T1GvvbAZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15562-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T1GvvbAZ;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj4D0pf7z1xpk\n\tfor ; Tue, 13 Jan 2026 06:24:28 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj37193dz2yrt;\n\tTue, 13 Jan 2026 06:23:31 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj363cWzz2yft\n\tfor ; Tue, 13 Jan 2026 06:23:30 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id ACED5600BB;\n\tMon, 12 Jan 2026 19:23:28 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 01984C116D0;\n\tMon, 12 Jan 2026 19:23:27 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245811;\n\tcv=none;\n b=hhUF/KerWStkjqCkdBN9HMIHQJnEI5IM5eGR3M5pF5itaysnkp2mJVnrHYSbYVScKy65J7A1zBftpSMoJseM6vOS2UOQZA2ltBa24+ZAa0ukMMNW7lIf+mogQwXyR/ZbXDl3VhAr2RCHAFPf/LLG1/SgzL89bxLgtOr7JjAeLGNCTbxZSEF972Eqn01fJEHi8gpFcn2tt/84sWv5GEWXNIVyY9PZ6Ww4OuFUssJr52xUd70AMkx1jWHrY0XqK1r+FkDy0LRd/Q3UMR0zM9+a0ukrC+Pld4U4oHC39Ur8y4iG6xSbBJTnfGpdq50bbwG1UycCjCPsOPm1NhE/1rJK2Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245811; c=relaxed/relaxed;\n\tbh=JVQL6ZoUXD09sqmGPMGT50jNWhGdmOWnGCBFfUSlZAk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Wm+ACOiguQHI7bTdbqJFTTYZi5al2zag4hW2N28mHGmN9MlJXgksv+1G0r3agVa3uhHfmEBkxXaI/fehlqVDk8lIptkjltcLIUoyL7na5rccLV/+q6pdy5y7UJRZmYZulediUmwfLt17O8d/m9lnRfjWsOm5928vc2ba7QkBPvdLvZCCcVOl5MVlW1Q5WEHk1lOU4zKd3kDkF58dH14LflX9fHFMnRn9ciGHIzHp7/l3oMgCY2qhB/IVl8xxTIb8RarD+hKMUhzO8hUWpVYhu50ZVVD7fawBmy/XHbbn7cuZ20kLFZqj8JKbN48gsfPNdbMnVeRvkC+/UcVtRwRMvw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T1GvvbAZ; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245808;\n\tbh=/+92A2W8sPhnyqgSvgeYDPLSqRQhqBCuSe5uLYbIIyo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T1GvvbAZd1QxRXqOx3RVwEnT8L6/7in7jYWOmXPjC5hvhKjvhv+Wzfs5/LUMHR8Lc\n\t SdGTbOSLXj/2W/iKIhh/AT5PZwYWYZ1BOouRjUMUk2hghvgAR6+JvM8kF0KbCUU7yp\n\t puzPO54NzZ3xe7XfNGWN6VWmD3ZkQ+dVaqDcSY/FoA3F/XNqeh1rnjNcSxjRjbPA7/\n\t gqecjM8PRPEN29c60wRVNKJHik18bwbo1WjAwXvniH+AS9JnoM0gcQ2DNi5blIsfxI\n\t UYBfP/Us7YHO8J9QoEFy1ANvrLWZNZs147dSPjGhBOGui77MkyOPGu0k7NMYzgIM2A\n\t bXI6EI75/O3bQ==","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler ,\n\tHarald Freudenberger ,\n\tEric Biggers ","Subject":"[PATCH v2 19/35] Bluetooth: SMP: Use new AES library API","Date":"Mon, 12 Jan 2026 11:20:17 -0800","Message-ID":"<20260112192035.10427-20-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112192035.10427-1-ebiggers@kernel.org>","References":"<20260112192035.10427-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_enckey). This\neliminates the unnecessary computation and caching of the decryption\nround keys. The new AES en/decryption functions are also much faster\nand use AES instructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one.\n\nAcked-by: Ard Biesheuvel \nSigned-off-by: Eric Biggers \n---\n net/bluetooth/smp.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c\nindex 3a1ce04a7a53..bf61e8841535 100644\n--- a/net/bluetooth/smp.c\n+++ b/net/bluetooth/smp.c\n@@ -372,36 +372,36 @@ static int smp_h7(struct crypto_shash *tfm_cmac, const u8 w[16],\n * s1 and ah.\n */\n \n static int smp_e(const u8 *k, u8 *r)\n {\n-\tstruct crypto_aes_ctx ctx;\n+\tstruct aes_enckey aes;\n \tuint8_t tmp[16], data[16];\n \tint err;\n \n \tSMP_DBG(\"k %16phN r %16phN\", k, r);\n \n \t/* The most significant octet of key corresponds to k[0] */\n \tswap_buf(k, tmp, 16);\n \n-\terr = aes_expandkey(&ctx, tmp, 16);\n+\terr = aes_prepareenckey(&aes, tmp, 16);\n \tif (err) {\n \t\tBT_ERR(\"cipher setkey failed: %d\", err);\n \t\treturn err;\n \t}\n \n \t/* Most significant octet of plaintextData corresponds to data[0] */\n \tswap_buf(r, data, 16);\n \n-\taes_encrypt(&ctx, data, data);\n+\taes_encrypt(&aes, data, data);\n \n \t/* Most significant octet of encryptedData corresponds to data[0] */\n \tswap_buf(data, r, 16);\n \n \tSMP_DBG(\"r %16phN\", r);\n \n-\tmemzero_explicit(&ctx, sizeof(ctx));\n+\tmemzero_explicit(&aes, sizeof(aes));\n \treturn err;\n }\n \n static int smp_c1(const u8 k[16],\n \t\t const u8 r[16], const u8 preq[7], const u8 pres[7], u8 _iat,\n","prefixes":["v2","19/35"]}