{"id":2183182,"url":"http://patchwork.ozlabs.org/api/patches/2183182/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-7-ebiggers@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260112192035.10427-7-ebiggers@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260112192035.10427-7-ebiggers@kernel.org/","date":"2026-01-12T19:20:04","name":"[v2,06/35] crypto: arm64/aes - Select CRYPTO_LIB_SHA256 from correct places","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"37245ea6090cde3b6f12f761df865f698d67d0ad","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-7-ebiggers@kernel.org/mbox/","series":[{"id":488089,"url":"http://patchwork.ozlabs.org/api/series/488089/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089","date":"2026-01-12T19:19:58","name":"AES library improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/488089/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2183182/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2183182/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JXIHBvTp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15556-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JXIHBvTp;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj3B1LsTz1xpk\n\tfor ; Tue, 13 Jan 2026 06:23:34 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj2z3wg2z2yFx;\n\tTue, 13 Jan 2026 06:23:23 +1100 (AEDT)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj2y6nVYz2xRv\n\tfor ; Tue, 13 Jan 2026 06:23:22 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 2D8004430D;\n\tMon, 12 Jan 2026 19:23:21 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A1EDDC4AF0B;\n\tMon, 12 Jan 2026 19:23:20 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245803;\n\tcv=none;\n b=THjD8OnT46iHv5qGWQyjCLLRPUlG+pKGD+OR27qu5lf+D8Po9M+Bix7ij4Vjf0BAuHIt+8HA29TNBJRNrlxwqePg3LCyf2dMswWWL3kPayTJrphNXjzV9pqKq+Ec8h3/s4uYiWKtAIgeFfNt63pOnJdf8xGUKmPwCLCMIMW4ivY6Zv+U+7TgY8MalNA5ckW6pyTJSKIHLwP0BMffwgwoBYWOB6t3my8S1bFR+0IQN5qLutTeJhvd/zsxfETMRud+dn7bbI06gDI3tTHxiQ0b1kKL6cwkHo9z1yq+qbx39/1gAf1IysIXpAxJlpCrR9Z+sEcecFWEKr4s7w2Q+qW/yw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245803; c=relaxed/relaxed;\n\tbh=X5QVv+pK3Q/Yd8L1PsQakg0si7xNSItbltSuybfv5CA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=D9WHMsJPwv2jiu6N5mHH6/ufjwMg5J63mcOTVM3DNMahNAujiILvFI/13JcPtRzPadgEF0ncCkMNX8OyNbXXaHAQPpxMPFx5KxVOOptS0sJG1KwWqFt5EesSXWo+KUPLvX0DYy5RlX2trjmp2At86eq83gvwUIN4voP/PUg7q0ij8RXR6ZzAQJOQZMHHXfOk/VJOFLQl39D91BFCUbd5Lcd0/AaDF17fxiPbw43fTjBXIIlvQXKcp/AskWyh//ZPVhNzr3Hd7yvPe8T6EaeKmZpvcXlSHm8vby50M2h1n6zDof5e323BrK4WYBCq0lvnXNrapCZ3ujily/ooCRVFIw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JXIHBvTp; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245801;\n\tbh=jF7KhWSZryEBB0FeZdUnAzVuxZQQQuTKuWy5tUR+OmQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JXIHBvTpr+H6VX4tbUc+PGAH5U0i1qcPQ/D9pk3S5+zn6TPIK3c9zuSj62qZvCQsW\n\t NezYfkOvYDjk8SDzcWZEm0pV/M/QtoIolJj7BCFE3jieqSwUy9Q8HoTjScWYkKXAIY\n\t EGJyRspSX3ezX38NkMpCfd3FeywvkK6RPpye3nl+z71yk17w1EkE4n91YothPcu5ny\n\t 2eys2Ah0khcFVZzHoxmLLiTEmxNFK6hGDOrqjEqHXPvE3pTB/pDb94E0UZhl9nhGQt\n\t fJ17HRRNKm26vQZTwyd3aV5KEua5phkd5XM/D6RbTU0GuDZSgjbkHy5JcvGhgAHnBi\n\t 9+Osz6DZLMkzg==","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler ,\n\tHarald Freudenberger ,\n\tEric Biggers ","Subject":"[PATCH v2 06/35] crypto: arm64/aes - Select CRYPTO_LIB_SHA256 from\n correct places","Date":"Mon, 12 Jan 2026 11:20:04 -0800","Message-ID":"<20260112192035.10427-7-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112192035.10427-1-ebiggers@kernel.org>","References":"<20260112192035.10427-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The call to sha256() occurs in code that is built when either\nCRYPTO_AES_ARM64_CE_BLK or CRYPTO_AES_ARM64_NEON_BLK. The option\nCRYPTO_AES_ARM64 is unrelated, notwithstanding its documentation. I'll\nbe removing CRYPTO_AES_ARM64 soon anyway, but before doing that, fix\nwhere CRYPTO_LIB_SHA256 is selected from.\n\nFixes: 01834444d972 (\"crypto: arm64/aes - use SHA-256 library instead of crypto_shash\")\nAcked-by: Ard Biesheuvel \nSigned-off-by: Eric Biggers \n---\n arch/arm64/crypto/Kconfig | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig\nindex da1c9ea8ea83..4453dff8f0c1 100644\n--- a/arch/arm64/crypto/Kconfig\n+++ b/arch/arm64/crypto/Kconfig\n@@ -38,11 +38,10 @@ config CRYPTO_SM3_ARM64_CE\n \t - ARMv8.2 Crypto Extensions\n \n config CRYPTO_AES_ARM64\n \ttristate \"Ciphers: AES, modes: ECB, CBC, CTR, CTS, XCTR, XTS\"\n \tselect CRYPTO_AES\n-\tselect CRYPTO_LIB_SHA256\n \thelp\n \t Block ciphers: AES cipher algorithms (FIPS-197)\n \t Length-preserving ciphers: AES with ECB, CBC, CTR, CTS,\n \t XCTR, and XTS modes\n \t AEAD cipher: AES with CBC, ESSIV, and SHA-256\n@@ -64,10 +63,11 @@ config CRYPTO_AES_ARM64_CE\n config CRYPTO_AES_ARM64_CE_BLK\n \ttristate \"Ciphers: AES, modes: ECB/CBC/CTR/XTS (ARMv8 Crypto Extensions)\"\n \tdepends on KERNEL_MODE_NEON\n \tselect CRYPTO_SKCIPHER\n \tselect CRYPTO_AES_ARM64_CE\n+\tselect CRYPTO_LIB_SHA256\n \thelp\n \t Length-preserving ciphers: AES cipher algorithms (FIPS-197)\n \t with block cipher modes:\n \t - ECB (Electronic Codebook) mode (NIST SP800-38A)\n \t - CBC (Cipher Block Chaining) mode (NIST SP800-38A)\n@@ -81,10 +81,11 @@ config CRYPTO_AES_ARM64_CE_BLK\n config CRYPTO_AES_ARM64_NEON_BLK\n \ttristate \"Ciphers: AES, modes: ECB/CBC/CTR/XTS (NEON)\"\n \tdepends on KERNEL_MODE_NEON\n \tselect CRYPTO_SKCIPHER\n \tselect CRYPTO_LIB_AES\n+\tselect CRYPTO_LIB_SHA256\n \thelp\n \t Length-preserving ciphers: AES cipher algorithms (FIPS-197)\n \t with block cipher modes:\n \t - ECB (Electronic Codebook) mode (NIST SP800-38A)\n \t - CBC (Cipher Block Chaining) mode (NIST SP800-38A)\n","prefixes":["v2","06/35"]}