{"id":2177621,"url":"http://patchwork.ozlabs.org/api/patches/2177621/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-16-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251226211930.27565-16-farosas@suse.de>","list_archive_url":null,"date":"2025-12-26T21:19:17","name":"[RFC,15/25] migration/channel: Rename migration_channel_connect","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc4665c4f1fc91bcf3fbc1b068ac561277389040","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-16-farosas@suse.de/mbox/","series":[{"id":486505,"url":"http://patchwork.ozlabs.org/api/series/486505/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505","date":"2025-12-26T21:19:04","name":"migration: Cleanup early connection code","version":1,"mbox":"http://patchwork.ozlabs.org/series/486505/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2177621/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2177621/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=bISc1R0S;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tINoYoIk;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=bISc1R0S;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tINoYoIk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJVP4DQNz1y3s\n\tfor ; Sat, 27 Dec 2025 08:22:37 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vZFEe-0001az-W9; Fri, 26 Dec 2025 16:20:33 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vZFEe-0001ad-2B\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:32 -0500","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vZFEc-0004Cs-Ef\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:31 -0500","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id C82095BCC4;\n Fri, 26 Dec 2025 21:19:58 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C039F3EA63;\n Fri, 26 Dec 2025 21:19:57 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id YJ6gH/37TmnwJwAAD6G6ig\n (envelope-from ); Fri, 26 Dec 2025 21:19:57 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783998;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QhGRNPkF1+egiR0KOqIYosDJslHerNW+xet+FuzqMfM=;\n b=bISc1R0SLGKLAfN4uuKy0pjiQ17MY0r0DMZV9XmgzzsvQAD/9PK0ZNdmRw9V31rIgY3kw4\n MKdKvjojfbrJ5cb/FNxBJJFAMiZJAuQSLkZH+faItHxv9bjqltmdgaWCaH6/tKhMtPzfMU\n HyUrAWXMzJkdCtCaAqvAmZkfDiuCwfA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783998;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QhGRNPkF1+egiR0KOqIYosDJslHerNW+xet+FuzqMfM=;\n b=tINoYoIkpFvHJRa9EUUeS7uuCDsenQe2bGVKBHMcy5mN5tURE2JEblFQTDToOxFr8Uq9gu\n 5SLURP6Zw1SZ8yAw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783998;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QhGRNPkF1+egiR0KOqIYosDJslHerNW+xet+FuzqMfM=;\n b=bISc1R0SLGKLAfN4uuKy0pjiQ17MY0r0DMZV9XmgzzsvQAD/9PK0ZNdmRw9V31rIgY3kw4\n MKdKvjojfbrJ5cb/FNxBJJFAMiZJAuQSLkZH+faItHxv9bjqltmdgaWCaH6/tKhMtPzfMU\n HyUrAWXMzJkdCtCaAqvAmZkfDiuCwfA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783998;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QhGRNPkF1+egiR0KOqIYosDJslHerNW+xet+FuzqMfM=;\n b=tINoYoIkpFvHJRa9EUUeS7uuCDsenQe2bGVKBHMcy5mN5tURE2JEblFQTDToOxFr8Uq9gu\n 5SLURP6Zw1SZ8yAw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"peterx@redhat.com","Subject":"[RFC PATCH 15/25] migration/channel: Rename migration_channel_connect","Date":"Fri, 26 Dec 2025 18:19:17 -0300","Message-ID":"<20251226211930.27565-16-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251226211930.27565-1-farosas@suse.de>","References":"<20251226211930.27565-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-2.80","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.978];\n MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo];\n URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rename migration_channel_connect to indicate this is the source\nside. Future patches will do similar changes to the incoming side and\nthis will avoid inconsistencies in naming.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/channel.c | 9 +--------\n migration/channel.h | 2 +-\n migration/exec.c | 2 +-\n migration/fd.c | 2 +-\n migration/file.c | 2 +-\n migration/socket.c | 2 +-\n migration/tls.c | 2 +-\n 7 files changed, 7 insertions(+), 14 deletions(-)","diff":"diff --git a/migration/channel.c b/migration/channel.c\nindex af6c2cc76e..a8a5f26dfd 100644\n--- a/migration/channel.c\n+++ b/migration/channel.c\n@@ -61,14 +61,7 @@ out:\n }\n }\n \n-\n-/**\n- * @migration_channel_connect - Create new outgoing migration channel\n- *\n- * @s: Current migration state\n- * @ioc: Channel to which we are connecting\n- */\n-void migration_channel_connect(MigrationState *s, QIOChannel *ioc)\n+void migration_channel_connect_outgoing(MigrationState *s, QIOChannel *ioc)\n {\n trace_migration_set_outgoing_channel(ioc, object_get_typename(OBJECT(ioc)));\n \ndiff --git a/migration/channel.h b/migration/channel.h\nindex ccfeaaef18..7d3457271d 100644\n--- a/migration/channel.h\n+++ b/migration/channel.h\n@@ -20,7 +20,7 @@\n \n void migration_channel_process_incoming(QIOChannel *ioc);\n \n-void migration_channel_connect(MigrationState *s, QIOChannel *ioc);\n+void migration_channel_connect_outgoing(MigrationState *s, QIOChannel *ioc);\n \n int migration_channel_read_peek(QIOChannel *ioc,\n const char *buf,\ndiff --git a/migration/exec.c b/migration/exec.c\nindex d83a07435a..d1629944dc 100644\n--- a/migration/exec.c\n+++ b/migration/exec.c\n@@ -55,7 +55,7 @@ void exec_start_outgoing_migration(MigrationState *s, strList *command,\n }\n \n qio_channel_set_name(ioc, \"migration-exec-outgoing\");\n- migration_channel_connect(s, ioc);\n+ migration_channel_connect_outgoing(s, ioc);\n object_unref(OBJECT(ioc));\n }\n \ndiff --git a/migration/fd.c b/migration/fd.c\nindex 0144a70742..150b236fbf 100644\n--- a/migration/fd.c\n+++ b/migration/fd.c\n@@ -70,7 +70,7 @@ void fd_start_outgoing_migration(MigrationState *s, const char *fdname, Error **\n }\n \n qio_channel_set_name(ioc, \"migration-fd-outgoing\");\n- migration_channel_connect(s, ioc);\n+ migration_channel_connect_outgoing(s, ioc);\n object_unref(OBJECT(ioc));\n }\n \ndiff --git a/migration/file.c b/migration/file.c\nindex 7bb9c1c79f..935402f36b 100644\n--- a/migration/file.c\n+++ b/migration/file.c\n@@ -122,7 +122,7 @@ void file_start_outgoing_migration(MigrationState *s,\n return;\n }\n qio_channel_set_name(ioc, \"migration-file-outgoing\");\n- migration_channel_connect(s, ioc);\n+ migration_channel_connect_outgoing(s, ioc);\n }\n \n static gboolean file_accept_incoming_migration(QIOChannel *ioc,\ndiff --git a/migration/socket.c b/migration/socket.c\nindex 298bac30cc..611915f84d 100644\n--- a/migration/socket.c\n+++ b/migration/socket.c\n@@ -73,7 +73,7 @@ static void socket_outgoing_migration(QIOTask *task,\n }\n \n trace_migration_socket_outgoing_connected();\n- migration_channel_connect(data->s, sioc);\n+ migration_channel_connect_outgoing(data->s, sioc);\n return;\n err:\n trace_migration_socket_outgoing_error(error_get_pretty(err));\ndiff --git a/migration/tls.c b/migration/tls.c\nindex a54e8e6e14..f68e6a533b 100644\n--- a/migration/tls.c\n+++ b/migration/tls.c\n@@ -114,7 +114,7 @@ static void migration_tls_outgoing_handshake(QIOTask *task,\n }\n \n trace_migration_tls_outgoing_handshake_complete();\n- migration_channel_connect(s, ioc);\n+ migration_channel_connect_outgoing(s, ioc);\n }\n \n QIOChannelTLS *migration_tls_client_create(QIOChannel *ioc,\n","prefixes":["RFC","15/25"]}