{"id":2177617,"url":"http://patchwork.ozlabs.org/api/patches/2177617/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-21-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251226211930.27565-21-farosas@suse.de>","list_archive_url":null,"date":"2025-12-26T21:19:22","name":"[RFC,20/25] migration/channel: Use switch statements in outgoing code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"04cf51e4e35fc497746f9d7287b2b6eaa88cab0e","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-21-farosas@suse.de/mbox/","series":[{"id":486505,"url":"http://patchwork.ozlabs.org/api/series/486505/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505","date":"2025-12-26T21:19:04","name":"migration: Cleanup early connection code","version":1,"mbox":"http://patchwork.ozlabs.org/series/486505/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2177617/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2177617/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=VOWiZMJR;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=TL2uwRy+;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=VOWiZMJR;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=TL2uwRy+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VOWiZMJR;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TL2uwRy+"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJTP666Zz1y3s\n\tfor ; Sat, 27 Dec 2025 08:21:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vZFF3-0002kO-7f; Fri, 26 Dec 2025 16:20:57 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vZFF1-0002cw-Nw\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:55 -0500","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vZFF0-0004Jz-3z\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:55 -0500","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id DD3875BCCB;\n Fri, 26 Dec 2025 21:20:07 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D1E953EA63;\n Fri, 26 Dec 2025 21:20:06 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id qFwOJAb8TmnwJwAAD6G6ig\n (envelope-from ); Fri, 26 Dec 2025 21:20:06 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766784007;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=75a4TyoA3rRR37hGhXR6deLXcglP7r0pSbFa+frOItI=;\n b=VOWiZMJRTJ/QQD4lTTUtLEKhDFQ+1w5Tv233R9wxldOhiE5Z/jk8f88ytchc2EUaLqHzjp\n xXnolaCYNRxhBBV43/ahUowmiOSTNdAt43IvzIRupbjoDA+EkAnqFTw93BXtwyB6VCWgN2\n r+88aj7TGmvfFbiqZ7U4tHjf9+v+tB0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766784007;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=75a4TyoA3rRR37hGhXR6deLXcglP7r0pSbFa+frOItI=;\n b=TL2uwRy+6yBxNyBF88aiPF37aGage8FhTOjnDJgT5JqAuu2voEgHD3pAN3uRJcCZkG7T7P\n gelAMHkFUkTX/bDg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766784007;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=75a4TyoA3rRR37hGhXR6deLXcglP7r0pSbFa+frOItI=;\n b=VOWiZMJRTJ/QQD4lTTUtLEKhDFQ+1w5Tv233R9wxldOhiE5Z/jk8f88ytchc2EUaLqHzjp\n xXnolaCYNRxhBBV43/ahUowmiOSTNdAt43IvzIRupbjoDA+EkAnqFTw93BXtwyB6VCWgN2\n r+88aj7TGmvfFbiqZ7U4tHjf9+v+tB0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766784007;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=75a4TyoA3rRR37hGhXR6deLXcglP7r0pSbFa+frOItI=;\n b=TL2uwRy+6yBxNyBF88aiPF37aGage8FhTOjnDJgT5JqAuu2voEgHD3pAN3uRJcCZkG7T7P\n gelAMHkFUkTX/bDg=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"peterx@redhat.com","Subject":"[RFC PATCH 20/25] migration/channel: Use switch statements in\n outgoing code","Date":"Fri, 26 Dec 2025 18:19:22 -0300","Message-ID":"<20251226211930.27565-21-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251226211930.27565-1-farosas@suse.de>","References":"<20251226211930.27565-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-3.01","X-Rspamd-Queue-Id":"DD3875BCCB","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[];\n ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_TWO(0.00)[2];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Action":"no action","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Make this code easier on the eyes and remove all the visual\nclutter. There will be more lines added here in next patches.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/channel.c | 38 ++++++++++++++++++++++++++++----------\n 1 file changed, 28 insertions(+), 10 deletions(-)","diff":"diff --git a/migration/channel.c b/migration/channel.c\nindex 205f8a26d1..2f33cb2653 100644\n--- a/migration/channel.c\n+++ b/migration/channel.c\n@@ -35,31 +35,49 @@ bool migration_connect_outgoing(MigrationState *s, MigrationAddress *addr,\n Error **errp)\n {\n g_autoptr(QIOChannel) ioc = NULL;\n+ SocketAddress *saddr;\n \n- if (addr->transport == MIGRATION_ADDRESS_TYPE_SOCKET) {\n- SocketAddress *saddr = &addr->u.socket;\n- if (saddr->type == SOCKET_ADDRESS_TYPE_INET ||\n- saddr->type == SOCKET_ADDRESS_TYPE_UNIX ||\n- saddr->type == SOCKET_ADDRESS_TYPE_VSOCK) {\n+ switch (addr->transport) {\n+ case MIGRATION_ADDRESS_TYPE_SOCKET:\n+ saddr = &addr->u.socket;\n+\n+ switch (saddr->type) {\n+ case SOCKET_ADDRESS_TYPE_INET:\n+ case SOCKET_ADDRESS_TYPE_UNIX:\n+ case SOCKET_ADDRESS_TYPE_VSOCK:\n socket_connect_outgoing(s, saddr, errp);\n /*\n * async: after the socket is connected, calls\n * migration_channel_connect_outgoing() directly.\n */\n return true;\n- } else if (saddr->type == SOCKET_ADDRESS_TYPE_FD) {\n+ break;\n+ case SOCKET_ADDRESS_TYPE_FD:\n ioc = fd_connect_outgoing(s, saddr->u.fd.str, errp);\n+ break;\n+ default:\n+ g_assert_not_reached();\n }\n+\n+ break;\n+\n #ifdef CONFIG_RDMA\n- } else if (addr->transport == MIGRATION_ADDRESS_TYPE_RDMA) {\n+ case MIGRATION_ADDRESS_TYPE_RDMA:\n ioc = rdma_connect_outgoing(s, &addr->u.rdma, errp);\n+ break;\n #endif\n- } else if (addr->transport == MIGRATION_ADDRESS_TYPE_EXEC) {\n+\n+ case MIGRATION_ADDRESS_TYPE_EXEC:\n ioc = exec_connect_outgoing(s, addr->u.exec.args, errp);\n- } else if (addr->transport == MIGRATION_ADDRESS_TYPE_FILE) {\n+ break;\n+\n+ case MIGRATION_ADDRESS_TYPE_FILE:\n ioc = file_connect_outgoing(s, &addr->u.file, errp);\n- } else {\n+ break;\n+\n+ default:\n error_setg(errp, \"uri is not a valid migration protocol\");\n+ break;\n }\n \n if (!ioc) {\n","prefixes":["RFC","20/25"]}