{"id":2177606,"url":"http://patchwork.ozlabs.org/api/patches/2177606/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-8-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251226211930.27565-8-farosas@suse.de>","list_archive_url":null,"date":"2025-12-26T21:19:09","name":"[RFC,07/25] migration: Use migrate_mode() to query for cpr-transfer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aebb368be5adfe85aeba161f593598fde4b3bcc0","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-8-farosas@suse.de/mbox/","series":[{"id":486505,"url":"http://patchwork.ozlabs.org/api/series/486505/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505","date":"2025-12-26T21:19:04","name":"migration: Cleanup early connection code","version":1,"mbox":"http://patchwork.ozlabs.org/series/486505/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2177606/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2177606/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=pFd6Bya/;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VPW6IC56;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=pFd6Bya/;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VPW6IC56;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJSX3S7Wz1y3s\n\tfor ; Sat, 27 Dec 2025 08:21:00 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vZFEC-0001Nn-EU; Fri, 26 Dec 2025 16:20:04 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vZFEA-0001K0-LA\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:02 -0500","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vZFE9-0003mp-5n\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:02 -0500","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 516C05BCE1;\n Fri, 26 Dec 2025 21:19:45 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 46E253EA63;\n Fri, 26 Dec 2025 21:19:44 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id KCcdAvD7TmnwJwAAD6G6ig\n (envelope-from ); Fri, 26 Dec 2025 21:19:44 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v8Q2rQICH1az6OWLPGfQWXBH6q1We2SfqSJbry/6fGM=;\n b=pFd6Bya/oGxA/tl6RMzOnVsCv88Xcw2AVKb888rVNJPyZhHDBDXZiqX3r4Ix7oS9qx1V9R\n q7s7G5J5T4xRKDWBGPp1ZJeBuRxrhO7BHAcXAlKPjBwW/cbXkkat4K9/+cL+k6KaQTpiHz\n bwtiabn7hWwVfuvEd59JI2/4Yvs3hNk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v8Q2rQICH1az6OWLPGfQWXBH6q1We2SfqSJbry/6fGM=;\n b=VPW6IC56CzJucB1B3pTZUiKKHdhLPpLniFQg0SU8xYleTSmhDMqTZQposxZsuFLJ1Xb5e7\n ZA2gicJj8dmiV4DQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v8Q2rQICH1az6OWLPGfQWXBH6q1We2SfqSJbry/6fGM=;\n b=pFd6Bya/oGxA/tl6RMzOnVsCv88Xcw2AVKb888rVNJPyZhHDBDXZiqX3r4Ix7oS9qx1V9R\n q7s7G5J5T4xRKDWBGPp1ZJeBuRxrhO7BHAcXAlKPjBwW/cbXkkat4K9/+cL+k6KaQTpiHz\n bwtiabn7hWwVfuvEd59JI2/4Yvs3hNk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v8Q2rQICH1az6OWLPGfQWXBH6q1We2SfqSJbry/6fGM=;\n b=VPW6IC56CzJucB1B3pTZUiKKHdhLPpLniFQg0SU8xYleTSmhDMqTZQposxZsuFLJ1Xb5e7\n ZA2gicJj8dmiV4DQ=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"peterx@redhat.com","Subject":"[RFC PATCH 07/25] migration: Use migrate_mode() to query for\n cpr-transfer","Date":"Fri, 26 Dec 2025 18:19:09 -0300","Message-ID":"<20251226211930.27565-8-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251226211930.27565-1-farosas@suse.de>","References":"<20251226211930.27565-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.981];\n MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]","X-Spam-Score":"-2.80","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"cpr_set_incoming_mode() is only called on the target side, so\nmigrate_mode() on the source side is the same as s->parameters.mode.\n\nUse the function to reduce explicit access to s->parameters, we have\noptions.c for that.\n\nSigned-off-by: Fabiano Rosas \n---\n migration/migration.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/migration/migration.c b/migration/migration.c\nindex f2933f7789..4b1afcab24 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -2252,7 +2252,7 @@ void qmp_migrate(const char *uri, bool has_channels,\n return;\n }\n \n- if (s->parameters.mode == MIG_MODE_CPR_TRANSFER && !cpr_channel) {\n+ if (migrate_mode() == MIG_MODE_CPR_TRANSFER && !cpr_channel) {\n error_setg(errp, \"missing 'cpr' migration channel\");\n return;\n }\n@@ -2277,7 +2277,7 @@ void qmp_migrate(const char *uri, bool has_channels,\n * in which case the target will not listen for the incoming migration\n * connection, so qmp_migrate_finish will fail to connect, and then recover.\n */\n- if (s->parameters.mode == MIG_MODE_CPR_TRANSFER) {\n+ if (migrate_mode() == MIG_MODE_CPR_TRANSFER) {\n migrate_hup_add(s, cpr_state_ioc(), (GSourceFunc)qmp_migrate_finish_cb,\n QAPI_CLONE(MigrationAddress, addr));\n \n","prefixes":["RFC","07/25"]}