{"id":2174163,"url":"http://patchwork.ozlabs.org/api/patches/2174163/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20251215093450.4049-1-fnordahl@ubuntu.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251215093450.4049-1-fnordahl@ubuntu.com>","list_archive_url":null,"date":"2025-12-15T09:34:49","name":"[ovs-dev] tests: Fix QoS tests for tc rounding behavior change.","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"0a84070be47b27c278161ba84a2ccc2d9f381261","submitter":{"id":88198,"url":"http://patchwork.ozlabs.org/api/people/88198/?format=json","name":"Frode Nordahl","email":"fnordahl@ubuntu.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20251215093450.4049-1-fnordahl@ubuntu.com/mbox/","series":[{"id":485365,"url":"http://patchwork.ozlabs.org/api/series/485365/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=485365","date":"2025-12-15T09:34:49","name":"[ovs-dev] tests: Fix QoS tests for tc rounding behavior change.","version":1,"mbox":"http://patchwork.ozlabs.org/series/485365/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2174163/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2174163/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ubuntu.com header.i=@ubuntu.com header.a=rsa-sha256\n header.s=fe-953a8a3ca9 header.b=LVCrI/4u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=ubuntu.com header.i=@ubuntu.com header.a=rsa-sha256\n header.s=fe-953a8a3ca9 header.b=LVCrI/4u","smtp2.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=ubuntu.com"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVFK750Tsz1xyL\n\tfor ; Mon, 15 Dec 2025 20:35:06 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 974084045C;\n\tMon, 15 Dec 2025 09:35:03 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id meH6zIrq1DiQ; Mon, 15 Dec 2025 09:35:02 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 25B83400D5;\n\tMon, 15 Dec 2025 09:35:02 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 0C493C063E;\n\tMon, 15 Dec 2025 09:35:02 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 3A505C063D\n for ; Mon, 15 Dec 2025 09:35:00 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 268DC403EE\n for ; Mon, 15 Dec 2025 09:35:00 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 3Xb1Ios8BeXZ for ;\n Mon, 15 Dec 2025 09:34:59 +0000 (UTC)","from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B1B90400D5\n for ; Mon, 15 Dec 2025 09:34:58 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 25B83400D5","OpenDKIM Filter v2.11.0 smtp2.osuosl.org B1B90400D5"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=149.28.215.223;\n helo=smtp.forwardemail.net;\n envelope-from=srs0=e21c=6v=ubuntu.com=fnordahl@fe-bounces.ubuntu.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org B1B90400D5","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com;\n h=Content-Transfer-Encoding: MIME-Version: Message-ID: Date: Subject: To:\n From; q=dns/txt; s=fe-953a8a3ca9; t=1765791297;\n bh=j/Gub5sMJiwAu4EafoByTD3yySJacS5Z5QDOPgm30t0=;\n b=LVCrI/4u9p4FtgNWPC3Q5ZEn7uVwq7HkpbF5ngwTTTioKPtVG+5PH1t0tmKZCQmqdG3pkHliR\n WGe9s5qQKG7t24wFxNaqXKg3uhu1bz60G/m0I+2DtRB24z6NTqlnE7L/jPHOlpKaC74QdtS8XNh\n 4xKLZhwyB4JBhUk0AwBHsgvX6AAhE2RJ/5UnffD2dmi/R4+XLbgTWHVOxj6pACKRHHLEbzwqaRA\n MEavPthnbLkr+XrSiJnVnXubSN8r/8G0WMbK0rYH+m9NwuBoWeIOqmIRi6eRB54mj4/xHgYN+Bw\n bP5N/aDGD8BzmD+7NIdKPQEJKG1HJSWjYlm7qMCUJcVg==","X-Forward-Email-ID":"693fd63df0dbff92af9e0296","X-Forward-Email-Sender":"rfc822; fnordahl@ubuntu.com, smtp.forwardemail.net,\n 149.28.215.223","X-Forward-Email-Version":"2.0.0","X-Forward-Email-Website":"https://forwardemail.net","X-Complaints-To":"abuse@forwardemail.net","X-Report-Abuse":"abuse@forwardemail.net","X-Report-Abuse-To":"abuse@forwardemail.net","From":"Frode Nordahl ","To":"dev@openvswitch.org","Date":"Mon, 15 Dec 2025 09:34:49 +0000","Message-ID":"<20251215093450.4049-1-fnordahl@ubuntu.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH] tests: Fix QoS tests for tc rounding behavior\n change.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"The tc command from iproute2 changed its rounding behavior in commit\nd947f365602b (\"tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize.\").\nThis caused QoS tests to be fragile because they were matching exact burst\nand cburst values in tc output.\n\nThe rounding fix means that burst and cburst values may differ slightly\nfrom previous versions. For example, values that were previously 620000\nmight now be 618750 or similar variations.\n\nTo maintain compatibility with both old and new versions of tc, the test\nassertions now use pattern matching that:\n- Matches the most significant digit(s) of the value\n- Ensures all characters are numeric\n- Maintains the correct total number of digits\n- Preserves the unit suffix (e.g., 'b' for bytes)\n\nFor example, '375000b' now matches '3[0-9][0-9][0-9][0-9][0-9]b' which\naccepts any 6-digit value starting with 3, allowing for rounding\ndifferences while still validating the general magnitude is correct.\n\nThis follows the same approach as the related OVN patch:\nhttps://patchwork.ozlabs.org/project/ovn/patch/20251213233200.5574-1-fnordahl@ubuntu.com/\n\nReported-at: https://launchpad.net/bugs/2129005\nAssisted-by: GitHub Copilot \nSigned-off-by: Frode Nordahl \n---\n\ngithub copilot cli prompt BEGIN:\nContext\n=======\nThe current working directory contains a bootstrapped and built copy of the\nOpen vSwitch (OVS) project, which is also publicly available from\nhttps://github.com/openvswitch/ovs.git.\n\nThe OVS an Open Virtual Network (OVN) projects are closely related, recently\na fix was proposed to OVN to adjust tests to new behavior of tc.\n\nTake a look at the patch proposed for OVN which also contains a prompt:\nhttps://patchwork.ozlabs.org/project/ovn/patch/20251213233200.5574-1-fnordahl@ubuntu.com/\n\nYou can execute tests using:\n\n sudo make check-kernel TESTSUITEFLAGS=\"-j1\" \n\nThe entire system testsuite takes a while, so by correlating test name and\nnumber in the built autotest scripts (tests/system-kmod-testsuite) and add\nthe specific test numbers to the TESTSUITEFLAGS variable you can execute\nonly the tests you are interested in.\n\nAssignment\n==========\n\nLocate any tests that require adapting in the OVS tree and follow a similar\napproach as the referenced OVN patch and prompt.\n\nMake sure to read the section on AI-assisted Contributions in Documentation/internals/contributing/submitting-patches.rst,\nas our previous patch used an incorrect tag in the proposed commit message.\nEND\ngithub copilot cli transcript: https://gist.github.com/fnordahl/43fb3c169c8acf2d0efa765f6b6b2d7a\n\n tests/system-traffic.at | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/tests/system-traffic.at b/tests/system-traffic.at\nindex 58a46af0a..80d6cd67f 100644\n--- a/tests/system-traffic.at\n+++ b/tests/system-traffic.at\n@@ -3141,8 +3141,8 @@ OVS_WAIT_UNTIL([tc qdisc show dev ovs-tap0 | grep -q htb])\n OVS_WAIT_UNTIL([tc qdisc show dev ovs-tap1 | grep -q htb])\n \n dnl Check the configuration.\n-m4_define([HTB_CONF0], [rate 2Mbit ceil 3Mbit burst 375000b cburst 375000b])\n-m4_define([HTB_CONF1], [rate 4Mbit ceil 5Gbit burst 500000b cburst 500000b])\n+m4_define([HTB_CONF0], [rate 2Mbit ceil 3Mbit burst 3[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b cburst 3[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b])\n+m4_define([HTB_CONF1], [rate 4Mbit ceil 5Gbit burst 5[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b cburst 5[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b])\n AT_CHECK([tc class show dev ovs-tap0 | grep -q 'class htb .* HTB_CONF0'])\n AT_CHECK([tc class show dev ovs-tap0 | grep -q 'class htb .* HTB_CONF1'])\n AT_CHECK([tc class show dev ovs-tap1 | grep -q 'class htb .* HTB_CONF0'])\n@@ -3172,7 +3172,7 @@ AT_CHECK([ovs-vsctl set port ovs-p0 qos=@qos -- set port ovs-p1 qos=@qos dnl\n OVS_WAIT_UNTIL([tc qdisc show dev ovs-p0 | grep -q htb])\n OVS_WAIT_UNTIL([tc qdisc show dev ovs-p1 | grep -q htb])\n \n-m4_define([HTB_CONF], [rate 40Gbit ceil 50Gbit burst 620000b cburst 618750b])\n+m4_define([HTB_CONF], [rate 40Gbit ceil 50Gbit burst 6[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b cburst 6[[0-9]][[0-9]][[0-9]][[0-9]][[0-9]]b])\n AT_CHECK([tc class show dev ovs-p0 | grep -q 'class htb .* HTB_CONF'])\n AT_CHECK([tc class show dev ovs-p1 | grep -q 'class htb .* HTB_CONF'])\n \n","prefixes":["ovs-dev"]}