{"id":2174157,"url":"http://patchwork.ozlabs.org/api/patches/2174157/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20251215081640.1827840-1-patrick.rudolph@9elements.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251215081640.1827840-1-patrick.rudolph@9elements.com>","list_archive_url":null,"date":"2025-12-15T08:16:39","name":"[v2] x86: cpu: Fix crash on FTRACE enabled builds","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d0386eff9ec86844a611fc758bbc92728044fad1","submitter":{"id":83069,"url":"http://patchwork.ozlabs.org/api/people/83069/?format=json","name":"Patrick Rudolph","email":"patrick.rudolph@9elements.com"},"delegate":{"id":56520,"url":"http://patchwork.ozlabs.org/api/users/56520/?format=json","username":"bmeng","first_name":"Bin","last_name":"Meng","email":"bmeng.cn@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251215081640.1827840-1-patrick.rudolph@9elements.com/mbox/","series":[{"id":485360,"url":"http://patchwork.ozlabs.org/api/series/485360/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=485360","date":"2025-12-15T08:16:39","name":"[v2] x86: cpu: Fix crash on FTRACE enabled builds","version":2,"mbox":"http://patchwork.ozlabs.org/series/485360/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2174157/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2174157/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.a=rsa-sha256\n header.s=google header.b=gjaBUBBq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.b=\"gjaBUBBq\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=patrick.rudolph@9elements.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVCZv2GBPz1xxv\n\tfor ; Mon, 15 Dec 2025 19:16:55 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B33C680050;\n\tMon, 15 Dec 2025 09:16:46 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id ACC7780077; Mon, 15 Dec 2025 09:16:45 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n [IPv6:2a00:1450:4864:20::32c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B69D68003E\n for ; Mon, 15 Dec 2025 09:16:43 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-47774d3536dso31095845e9.0\n for ; Mon, 15 Dec 2025 00:16:43 -0800 (PST)","from T14sGen4.sec.9e.network\n (ip-037-049-067-221.um09.pools.vodafone-ip.de. [37.49.67.221])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-430f7475895sm9157705f8f.33.2025.12.15.00.16.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 15 Dec 2025 00:16:42 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=9elements.com; s=google; t=1765786603; x=1766391403; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=1sRWLxA4Fpf4BfMeU77n0cuKEiUw9Vx2UebJiHKpdbQ=;\n b=gjaBUBBqoBgecQRJ95e82MqjOjy/1ngfvccV8AHw8scbc6aM2BPkCsSvGlGW2B1ZKD\n cLMmFoMXAkWyvYcKy9lXiGuB+ZAp9FPwHlqvoFil/YVf+XsAWeUZbNruNCM8yqH9V6QG\n VibhtZuUV1TbPNLa7mlSbPhSCUkiTPMhFZSiR8P3/RGM+/pJOrHnGiyCP5DO/y9uUh4c\n 44TetF5K2/ykQWYvexufINhNSWGfWekzhxEGflfNhf6Ylh/bacZk92mz1jqARkIBRzM5\n WqQ9I7XzVwgh4kKhPbgCErjMvr3ek9BdK5t1pGykQ8lYLcWwudpJ64vZxFdZDdKqDPoP\n JCGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765786603; x=1766391403;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1sRWLxA4Fpf4BfMeU77n0cuKEiUw9Vx2UebJiHKpdbQ=;\n b=ZdL6hUh76PU3D2jS2Gfr13BNb/vLKiGZYRXoQq8NPZadYd+hak9mi1PGe2Tu4fN9W/\n YVOW8fM1moNDMaIguSbPojwguTCGJnWh85FaI3Wo/lKtP6z6zysZ9uYf3r7AuN8ijeHg\n 8P/4TBGXzZl+R51kDb+JkKrKJ1YWc14+nax8Kwqn15eyjb96vJnGBTHho/StnEyNx3qZ\n sc557A6xphj6QISjXAKtRuCBBoToqWTXhp1neXBQ2lG+hY816XAU8itI3pMLh+ZITC/z\n +6GZ6L8adA9lW+Mtstwd+EWImNIWjACRFhEeb9Y2b0rIm9RVQqIQb6a5iDRwmlKKX8+J\n NFUA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUqOG8lkd2PmEavzEttaDkzqDThXQpu6o83OMqp2PplabymYABHcRlwEJstSUe6ousqEUmYqWE=@lists.denx.de","X-Gm-Message-State":"AOJu0YxjYF8MxbwXWkI2hvuBT/oy+c8qRaq3jwLB2bU0N9S81XFqvnyF\n MH5VFAzCc6vGQ67pDSbgcGqyghiOkDfU5ZyqE4nvjjA9pd1BEkl6Uw9l0HvHfBQV7uE=","X-Gm-Gg":"AY/fxX59w7pHfORr0zERjba3Wtttuww6QO0R4hLgYNf1sh0OoUEQ8yFqEdOQRfZAPhl\n PrVi8iUV1jwy2sR+x/7lB321CFFreKVd1oCszKAIScxn+NzHwz5sm7izZBAqnN1yd5p4PPMoahe\n 2hd28NAj6gI2PA9uULtHuNSoLSV4bF+4gclXqN+M8bsQ2k2tgDVnWPEub6Ny0RWoFxbSaVVTbGr\n KAXJCd1N2wczf9GARFYAQS81i6/h9jCPGS4x4tHdSlQKO8F7P0MRtxKvea2PlmKIYzm8gLyVrtW\n eBaftt+RAhsQFLc8l351qEER8pd7PllV/9xwurZ+SRCIkrN0H5bwnv3c1eQW9NThMXkbf1rmPV5\n 6LG8uxsPiYKoUszba3gspPmhuhoAaz/i3ewR/Qsl1fs3kZbEu7+cBNySfjuRv4Tp/wjOLYzw8YW\n 8WKQxuQ+MszkwR39YD8RqBU+3BEBhOjMg2Yvnc28bFqiETGieF6j7w/V6lsDxl0oDtrrzvtdqXo\n YvLRLSbuRaPGBGy","X-Google-Smtp-Source":"\n AGHT+IFZx9vVqSvGC2GLP7BXDbSAu8vxyRiolYk022aXyNKcDJPKuu/ANuLavQP+sliEPfNB7Jl/Lg==","X-Received":"by 2002:a05:600c:46cb:b0:471:665:e688 with SMTP id\n 5b1f17b1804b1-47a8f2cacf3mr111423725e9.17.1765786603119;\n Mon, 15 Dec 2025 00:16:43 -0800 (PST)","From":"Patrick Rudolph ","To":"Simon Glass , Bin Meng ,\n Tom Rini ","Cc":"Patrick Rudolph ,\n\tu-boot@lists.denx.de","Subject":"[PATCH v2] x86: cpu: Fix crash on FTRACE enabled builds","Date":"Mon, 15 Dec 2025 09:16:39 +0100","Message-ID":"<20251215081640.1827840-1-patrick.rudolph@9elements.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When compiled with FTRACE=1 U-boot will crash as %rdi is clobbered\nin board_init_f_alloc_reserve() and board_init_f_init_reserve() will\nmemset the .text segment instead of the global_data struct.\n\nAccording to the System V AMD64 ABI %rdi is not preserved and the\nexisting code only worked as board_init_f_alloc_reserve() was small\nenough to not use %rdi.\n\nFix that by always passing the correct argument to\nboard_init_f_init_reserve().\n\nTEST=Can boot on qemu-q35 with FTRACE=1 enabled during build.\n\nSigned-off-by: Patrick Rudolph \n---\nChanges in v2:\n- Point %rd to bottom of global_data struct instead of top\n\n---\n arch/x86/cpu/start64.S | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/arch/x86/cpu/start64.S b/arch/x86/cpu/start64.S\nindex 78e894d2a21..968a2929d0b 100644\n--- a/arch/x86/cpu/start64.S\n+++ b/arch/x86/cpu/start64.S\n@@ -16,7 +16,9 @@ _start:\n \t/* Set up memory using the existing stack */\n \tmov\t%rsp, %rdi\n \tcall\tboard_init_f_alloc_reserve\n+\n \tmov\t%rax, %rsp\n+\tmov\t%rsp, %rdi\n \n \tcall\tboard_init_f_init_reserve\n \n","prefixes":["v2"]}