{"id":2174151,"url":"http://patchwork.ozlabs.org/api/patches/2174151/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20251215075645.1795762-1-patrick.rudolph@9elements.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20251215075645.1795762-1-patrick.rudolph@9elements.com>","list_archive_url":null,"date":"2025-12-15T07:56:44","name":"x86: cpu: Fix crash on FTRACE enabled builds","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e4816d36379b02a1f4e1ed8e1e2dcbc3f996d34f","submitter":{"id":83069,"url":"http://patchwork.ozlabs.org/api/people/83069/?format=json","name":"Patrick Rudolph","email":"patrick.rudolph@9elements.com"},"delegate":{"id":56520,"url":"http://patchwork.ozlabs.org/api/users/56520/?format=json","username":"bmeng","first_name":"Bin","last_name":"Meng","email":"bmeng.cn@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20251215075645.1795762-1-patrick.rudolph@9elements.com/mbox/","series":[{"id":485357,"url":"http://patchwork.ozlabs.org/api/series/485357/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=485357","date":"2025-12-15T07:56:44","name":"x86: cpu: Fix crash on FTRACE enabled builds","version":1,"mbox":"http://patchwork.ozlabs.org/series/485357/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2174151/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2174151/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.a=rsa-sha256\n header.s=google header.b=Cj3wvra4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.b=\"Cj3wvra4\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=patrick.rudolph@9elements.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVC8258qyz1xyL\n\tfor ; Mon, 15 Dec 2025 18:57:06 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1114080050;\n\tMon, 15 Dec 2025 08:57:03 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id CBC0480077; Mon, 15 Dec 2025 08:57:01 +0100 (CET)","from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n [IPv6:2a00:1450:4864:20::431])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B93138003E\n for ; Mon, 15 Dec 2025 08:56:59 +0100 (CET)","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-42fbc305882so981402f8f.0\n for ; Sun, 14 Dec 2025 23:56:59 -0800 (PST)","from T14sGen4.sec.9e.network\n (ip-037-049-067-221.um09.pools.vodafone-ip.de. [37.49.67.221])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-430fdcc6bbdsm3804371f8f.14.2025.12.14.23.56.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 14 Dec 2025 23:56:58 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=9elements.com; s=google; t=1765785419; x=1766390219; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=3W8RBJHCNjVIFl6Bam2tQjTlbmf5CMnWVciuN59aCmM=;\n b=Cj3wvra4GlZL2hI6W5mrJaZuoVt8SASO1yn9HGMo0Ga9yhXUXWWlYHBX33AfGMbP38\n shPlZsz4mGD6ZS5eDnKjtZ55tNxMDQ/EVwVo3NS4qcdpz/NIyYDUoB+1LTHAuJfLcTDz\n rj5GBfIskNnYU3J8XRk5ptrks0LLW6WZie3ZOL+BBkmwVj8gnoSKGOTjQRDpr08GMlEM\n tnA1ScYKGYXrvT8iPVIewhOnsqU+yDB2mbbM9E17WteoxLT0lNJO7UnkhT6n46R8yXr9\n GJMNBC2Bnv9LeCJE5TNIzGn4LoaiyPBZAqcI/fcb2iWiEgV8HqK0FgTFVe2nQfTNZwQI\n CRPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765785419; x=1766390219;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3W8RBJHCNjVIFl6Bam2tQjTlbmf5CMnWVciuN59aCmM=;\n b=V+tOrXoO+3PVJboFq6cSGHrrj45cTVlhDzdY4uBfQpItoMHU0F59IIyksSNwYSJW6b\n dDhuJlxDlL4RC0YF5i6P7OHdoyfSw0xscHtfy6D4P/Yac1z1Cm8P0NulrllvhugXqhI7\n /nWN9lQF2kz3ynJc2zTWPFKwgpM9H725ywIXBUcHr0UNugB/1Z8Q3tvcIAUIpKt4MT9z\n MG23cU4nGP1ezV+SEf3SrdBx2T8hnbBV6mu/gEtnvq0W2RoDt5hlS2hYs401FiAukGAt\n LNjoarmGRJpioSBaeD6hBwfTGIEfv6S3JQgJYk2Z0BgjFkKA5V5pJ6/QPJmUB3gw2k5A\n FeCw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXqXBVejvI7yXIugHp+EDqUSqIN+hXMTwSKQmM0iw3aq7b4SGxLU6r/L+sycQKYOMbwTnq2Irk=@lists.denx.de","X-Gm-Message-State":"AOJu0YxFSrfuhgKg+Ln6eNfBTCjH/f4eycGb2NUnMKr3KRjyYtNgh2PP\n lPnPq13JxFlkICazCyp3jFWPKgAQkL8fiX8rbbG9L3ghVVm6jIlqDPE4LXGiBnyAB0w=","X-Gm-Gg":"AY/fxX46U4YXlFTbm40ogDNNM+n3DXua96peNM7wkRVhN8j7ftPzOS+uVuIUJHoHKS3\n lkbUgr/w0AKoqLXAtdMfQRNN06CRnI0WP9ha7/kuwjvd/nBtqjprjFx48Iz2zH127nwy6AiMIgz\n KXx3p3B40JrRxckdMGUH940UzM8FOSHXplgUNKhbZZD9BbsO7nOlpgOCvaTyjyNNxwm1gj2amzd\n Dr05RsT2t7HKuJv7rukl7FbaoscDOw0t/m6LpWfkbreUVP/SXOM8Tqe58sK+DksC3HMXuig7Pg6\n acKh16KUdS5hZUYDjiwyUppfLuOouVMhGqTLumdgjMFb+L3QimDVXZaDZfCCvoRlxn4pg2uy5sY\n Bi2wCRepEAsL3DrlBW2eM20KQub450dW/u7FSuG5wQF7oL6wiE2AWoTpDhKnzW0lIMjGPzcXZyQ\n itRhm5t5jgaeaqVJ33+L+EX1gkdSKtnVE7FSNN0tyZilTlUGV1t0dveHkKgC7J3S8ZVvzJc3duz\n miOXQQcMOycfZlj","X-Google-Smtp-Source":"\n AGHT+IGqHxaA/GOfz0EriAT5UzxKEe1/IM4xCuEPPZAivmgd45OchB7Dp36dqOBZJX9Zx3vK0XfARQ==","X-Received":"by 2002:a5d:5f54:0:b0:42b:3c3e:5d2f with SMTP id\n ffacd0b85a97d-42fb48fc506mr11445139f8f.39.1765785419152;\n Sun, 14 Dec 2025 23:56:59 -0800 (PST)","From":"Patrick Rudolph ","To":"Simon Glass , Bin Meng ,\n Tom Rini ","Cc":"Patrick Rudolph ,\n\tu-boot@lists.denx.de","Subject":"[PATCH] x86: cpu: Fix crash on FTRACE enabled builds","Date":"Mon, 15 Dec 2025 08:56:44 +0100","Message-ID":"<20251215075645.1795762-1-patrick.rudolph@9elements.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When compiled with FTRACE=1 U-boot will crash as %rdi is clobbered\nin board_init_f_alloc_reserve() and board_init_f_init_reserve() will\nmemset the .text segment instead of the global_data struct.\n\nAccording to the System V AMD64 ABI %rdi is not preserved and the\nexisting code only worked as board_init_f_alloc_reserve() was small\nenough to not use %rdi.\n\nFix that by always passing the correct argument to\nboard_init_f_init_reserve().\n\nTEST=Can boot on qemu-q35 with FTRACE=1 enabled during build.\n\nSigned-off-by: Patrick Rudolph \n---\n arch/x86/cpu/start64.S | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/arch/x86/cpu/start64.S b/arch/x86/cpu/start64.S\nindex 78e894d2a21..3fcd8c15481 100644\n--- a/arch/x86/cpu/start64.S\n+++ b/arch/x86/cpu/start64.S\n@@ -16,6 +16,8 @@ _start:\n \t/* Set up memory using the existing stack */\n \tmov\t%rsp, %rdi\n \tcall\tboard_init_f_alloc_reserve\n+\n+\tmov\t%rsp, %rdi\n \tmov\t%rax, %rsp\n \n \tcall\tboard_init_f_init_reserve\n","prefixes":[]}