{"id":2075158,"url":"http://patchwork.ozlabs.org/api/patches/2075158/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/255824200579431ecaebd32006bdf7a89d48ffd4.1745295397.git.ktokunaga.mail@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<255824200579431ecaebd32006bdf7a89d48ffd4.1745295397.git.ktokunaga.mail@gmail.com>","list_archive_url":null,"date":"2025-04-22T05:27:12","name":"[v2,08/20] target/ppc: Fix type conflict of GLib function pointers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c5218a32c38b0fa4d2edc43500f9c26282846746","submitter":{"id":90637,"url":"http://patchwork.ozlabs.org/api/people/90637/?format=json","name":"Kohei Tokunaga","email":"ktokunaga.mail@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/255824200579431ecaebd32006bdf7a89d48ffd4.1745295397.git.ktokunaga.mail@gmail.com/mbox/","series":[{"id":453631,"url":"http://patchwork.ozlabs.org/api/series/453631/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=453631","date":"2025-04-22T05:27:04","name":"Enable QEMU TCI to run 32bit guests on browsers","version":2,"mbox":"http://patchwork.ozlabs.org/series/453631/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2075158/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2075158/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=gvhecGrO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhWBj52rMz1yMZ\n\tfor ; Tue, 22 Apr 2025 15:34:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u76CM-00025Q-6C; Tue, 22 Apr 2025 01:29:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u76Bz-0001pE-Qj; Tue, 22 Apr 2025 01:29:20 -0400","from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1u76Bw-0007rg-9h; Tue, 22 Apr 2025 01:29:10 -0400","by mail-pg1-x529.google.com with SMTP id\n 41be03b00d2f7-b06e9bcc986so3296274a12.0;\n Mon, 21 Apr 2025 22:29:06 -0700 (PDT)","from localhost.localdomain ([240d:1a:3b6:8b00:e142:4a4f:1ebb:3ca4])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-22c50eb4483sm75692085ad.118.2025.04.21.22.28.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Apr 2025 22:29:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745299745; x=1745904545; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XLyDJb6zuVf07S+Oux/CEamJxltd1syyWyqOmnLXnEw=;\n b=gvhecGrOPzAJliflpm2tfVmJrK0ME/N+zC24q6qsKmLjqMP2DiSv3/qFNZYo9lXYKE\n A72wOolIihpK9Lmuys1o4JduASXSP3sDfNGMn+epTkWne33rbUXzZ+AV63eKpWmf4S7J\n /MQXDzwczBPrPCT9aLgqSIubfRKOYNIMSl6JJ/GGctJ+cx5gq3JukXDPxyBKXkRiXYSm\n igb6MJsGZpleRiUQKrTHVUrUaetge4xlYlIFB+PNWVBoZkx0P53QsyfWiOq8tdtVmjRl\n v8UsOK5583x2cr5H+wVGbORR1i3eo9E8ARfuqg7TOgKsQ+Py74DWQB7wWPYgxVpmxcrZ\n OXzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745299745; x=1745904545;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XLyDJb6zuVf07S+Oux/CEamJxltd1syyWyqOmnLXnEw=;\n b=GUG/iA8i0abA79hwrNqqJyJZEXzAzMdcVVX6uEZKzO7U08bXoeqBtG+krs6vdeamaY\n Myq5oVj0Qz0aeTEOTYf0OmOjMsUSv2c3IiVQV/jS0I5uC9oAIMCqqNvNM/xjBSu18XmC\n aDMSmqZEg6DbZbRLW+ykc4ykHlSDHB6XhV+mn5Eo3skvTtAK1V8Nnvt2yL5TgBAAj2hs\n B6dqbsxkfjI49+OJ9Q+pBw5n7ZK8HexxSCmvdw9q4z0tL8qlymE4sg7FMlXIYFvEI7JZ\n Db8+G5/TV9T2NhE8KC7mSloAc1UIcJKpiW5T2SjuqnT940DAooxfdroe3ULm3OyJuUQE\n 6yyw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU4wbPnA7ATsejZSajK900q51Lfn0xP6LjnnxOPMx6e7itkBRZiQn5L94yjaGmFfrv9/tOhVivOuNUfyw==@nongnu.org,\n AJvYcCVHdYTlhs3tMWb1/ZpAQZpmNIXuth7T7DoOE3gU60nbPvP4GIQOriLQAhjPoY48d3lpbjJ7eDjjTf0=@nongnu.org,\n AJvYcCVTdq6QRpw/il/HjeEpn+EqJjrS8WFeE8R/+L58d/dqinfmcfI+q3FLUah4yT34vq3udAVZDV5se/9kHQ==@nongnu.org,\n AJvYcCWVT3C+IllJpG1wWBiBusRLfgvnfEE1OPqoWr9xYoVHeZMCCQwJGEssMWyXiTTZpdQWrQi712aU7g==@nongnu.org","X-Gm-Message-State":"AOJu0Yw0FrQhdGE/0O5xhWg7a2NX+TKZ5XrXTkKXuK8ShkRgZ6fXLt4h\n 9QvTsH2NrMlwm+NrtmK5weFcNPa5guJEGjRAs1W5gerjwlerX2ioZOsX6PMH","X-Gm-Gg":"ASbGncsk7yEu4UhyGJzUooiiTfwVuhHRx6IaYatorwpINFzVCliwBz7/l30G6P8/HTB\n VYx9IN2rxrIIYsFnetyuZBuAvm/vtnNUjFBC0MXsL9DgR4s4W4wdm6yCOnvk8kk7H9ZiiHLTPHX\n t2mEOLluRFylbYGXl/HblwVks6KxAxOmjVk0vvzaL5IK7TW57raB8zGWZDAgkj2gDCrqKeg6KKz\n kXMZ8rQfhBU10wFwcU1uVnmNA1uloNawqxDvEefxhTUzgAF5qc226QADyBrWnKjDF6FT4dlcWxI\n xz48v+FRiWiPMbl2mrc21lYQ+IlmY/lmezviEuwVE02KWi6RRze93ao4rQM=","X-Google-Smtp-Source":"\n AGHT+IGli9pUmcY3KyTzbFBRjFgDu1JXXm31EwPT7XYV1PhrrsboM1x/7sb3HIGZTZeVLj7SCvEwRg==","X-Received":"by 2002:a17:902:ef11:b0:224:2384:5b40 with SMTP id\n d9443c01a7336-22c535a7e46mr256405075ad.24.1745299745436;\n Mon, 21 Apr 2025 22:29:05 -0700 (PDT)","From":"Kohei Tokunaga ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Kohei Tokunaga ,\n Paolo Bonzini , Alexandre Iooss ,\n Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","Subject":"[PATCH v2 08/20] target/ppc: Fix type conflict of GLib function\n pointers","Date":"Tue, 22 Apr 2025 14:27:12 +0900","Message-Id":"\n <255824200579431ecaebd32006bdf7a89d48ffd4.1745295397.git.ktokunaga.mail@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::529;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pg1-x529.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"On Emscripten, function pointer casts can result in runtime failures due to\nstrict function signature checks. This affects the use of g_list_sort and\ng_slist_sort, which internally perform function pointer casts that are not\nsupported by Emscripten. To avoid these issues, g_list_sort_with_data and\ng_slist_sort_with_data should be used instead, as they do not rely on\nfunction pointer casting.\n\nSigned-off-by: Kohei Tokunaga \n---\n target/ppc/cpu_init.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\nV2:\n- Updated the commit message to explicitly explain that function pointer\n casts are performed internally by GLib.","diff":"diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c\nindex f81cb680fc..f03e48ba31 100644\n--- a/target/ppc/cpu_init.c\n+++ b/target/ppc/cpu_init.c\n@@ -7115,7 +7115,7 @@ PowerPCCPUClass *ppc_cpu_get_family_class(PowerPCCPUClass *pcc)\n }\n \n /* Sort by PVR, ordering special case \"host\" last. */\n-static gint ppc_cpu_list_compare(gconstpointer a, gconstpointer b)\n+static gint ppc_cpu_list_compare(gconstpointer a, gconstpointer b, gpointer d)\n {\n ObjectClass *oc_a = (ObjectClass *)a;\n ObjectClass *oc_b = (ObjectClass *)b;\n@@ -7183,7 +7183,7 @@ void ppc_cpu_list(void)\n \n qemu_printf(\"Available CPUs:\\n\");\n list = object_class_get_list(TYPE_POWERPC_CPU, false);\n- list = g_slist_sort(list, ppc_cpu_list_compare);\n+ list = g_slist_sort_with_data(list, ppc_cpu_list_compare, NULL);\n g_slist_foreach(list, ppc_cpu_list_entry, NULL);\n g_slist_free(list);\n \n","prefixes":["v2","08/20"]}