{"id":2075140,"url":"http://patchwork.ozlabs.org/api/patches/2075140/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com>","list_archive_url":null,"date":"2025-04-22T05:27:08","name":"[v2,04/20] target/arm/helper.c: Fix type conflict of GLib function pointers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"21d3168228ac4594863ac184f06be7a9bd067d26","submitter":{"id":90637,"url":"http://patchwork.ozlabs.org/api/people/90637/?format=json","name":"Kohei Tokunaga","email":"ktokunaga.mail@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com/mbox/","series":[{"id":453631,"url":"http://patchwork.ozlabs.org/api/series/453631/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=453631","date":"2025-04-22T05:27:04","name":"Enable QEMU TCI to run 32bit guests on browsers","version":2,"mbox":"http://patchwork.ozlabs.org/series/453631/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2075140/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2075140/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=mknTGNJ2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhW4y2l57z1yMm\n\tfor ; Tue, 22 Apr 2025 15:29:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u76BV-0001P3-P8; Tue, 22 Apr 2025 01:28:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u76BT-0001Ni-Iv; Tue, 22 Apr 2025 01:28:39 -0400","from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1u76BR-0007p4-4V; Tue, 22 Apr 2025 01:28:39 -0400","by mail-pl1-x634.google.com with SMTP id\n d9443c01a7336-223f4c06e9fso39860055ad.1;\n Mon, 21 Apr 2025 22:28:35 -0700 (PDT)","from localhost.localdomain ([240d:1a:3b6:8b00:e142:4a4f:1ebb:3ca4])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-22c50eb4483sm75692085ad.118.2025.04.21.22.28.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Apr 2025 22:28:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745299714; x=1745904514; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gefJdCUJSQLppbT4glOadpiD7A44LdH0heN3S2uo/nk=;\n b=mknTGNJ2mc0gQmnRYvSI5g4CiEI4d7Kn49/AQrSrupQf+uI33oQjpYvYnlIVE4g5A5\n acgxsgbD5ikHY9CEa5JJhOsa/5J4d67VGYIq6cf7C7ERt2xemzaiByhZ2uVa17PaKmdJ\n r/g+YP/JOeBQgefwQUS858/oxGaknTCUl0AbBBfmmwUPNCOLcTZxRJm6ehR95UT6HUr9\n hK4uRwc/pNMD1V65tV5Au4hoGvZhgCXoGxO+gfs61vzn1I/oumWZhzPE1t8o5ugnZfXX\n n9lEOSM8wh4NhAzmYhl1nw9TXYpXI4ks6mUA81bDQTiaNm3Hp5b7RzwM0fY41YkEDCCL\n b9ig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745299714; x=1745904514;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=gefJdCUJSQLppbT4glOadpiD7A44LdH0heN3S2uo/nk=;\n b=nHCc4CZrUzgPai6LpgZKbSaBSDno2gDpnADKPZz7FP22Hzyg+NOE4bRaN23Istb1Lz\n I3QJ+FTvU1sI2RjLLta3Id+ou0SNbNRAU1CT1eva968LpXSd8Bohvw/yR3TtdmwhHifu\n VrWtwk5BsAaTQ1HsFHH8MEs7EhY5DREWshPQhc+6EOMkPhOJF1fETcf8JpLnNSK+SAX0\n 6FwtfjxP6Gye/UiwCudN40JZshFa+nBk8F4LLha6YDI4YlefUyFjj9YOX69+LgF6MfAx\n cRuSh/eT/4pghHr7OJTQrh4oCUD59RAbNCMNO3kPIEazCJOmqEqexBxzMrz4QmFYegID\n KiTA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUeHxBnU8e9EitsnXu/RvBEyIbsZuyYS/XW3qYs9+5vkVPlSgDb3XCe8nUXSteWYV42wpXK3nKs0itjgw==@nongnu.org,\n AJvYcCUlDLyafjht3Rbf53vWgWSVAgxmBViSMv6vG7eVJOdGyTyOfAdIUJzdH1upDJHzj0uyYh3jCB+MFg==@nongnu.org,\n AJvYcCX6jux7xmIftiHR4buOfx7WsgQLQLcGosdl5QVe57ljUq3fTH4510EDVda83gKrOZ6vUJya81b2Vks=@nongnu.org,\n AJvYcCXsgQX10vEbebSPwxhCHZ9uWC4z5jSy97QXxnzUz1dD5jFki1O3PWC7i0tV9oEO7Bef2/xrNxKrbttevA==@nongnu.org","X-Gm-Message-State":"AOJu0Yy0PRTFbm8L0zXvv+suT1/SG+LhcAY2EO666fX8UFiI3LfD/WqY\n 1/7yJwZm/mFAI8F79CLtdsetHWuh3ulK3zqJZbY0PcSM8Q21SXtfq3Shzl47","X-Gm-Gg":"ASbGncsHKSFc/DKnxhnm8Wpsg5S2EtRP7/65bDIvcveMxDnuKov4ETDPjFA9gvzOU2w\n 426gqGVi/DFgvBgiawQLQOlLibGv8CiToAAntv6NkRiCM0OYC13v80DCbyaU8cI4eDE/V4M4tQ8\n CGXA70Cy9frrjbkoD3AW9oeQihPyIEe213dayywNISPeAbSkbzYAUFDC8Ah13XWv8rKvF5xxaP5\n YcoVMw5dzvNEipkexCrGuLfrV7fcoc51KQLupzCcQ4cO+VmvdpNFu6a5TU3X4eya9oZtF1++NkB\n w/5fuhtlteV6hdprD4ENH7JWrTrCJBKvHopFcct933/zdqXg10t5LLVmhJ4=","X-Google-Smtp-Source":"\n AGHT+IGVYb84wyPd+77TwHY4qOu4PjCNVs7VMfmGdBcJLq1yY+ZnLAJVW3AbGcK0d3SEFuBDPWyZaw==","X-Received":"by 2002:a17:902:e884:b0:221:89e6:ccb6 with SMTP id\n d9443c01a7336-22c53f17338mr213065555ad.25.1745299714132;\n Mon, 21 Apr 2025 22:28:34 -0700 (PDT)","From":"Kohei Tokunaga ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Kohei Tokunaga ,\n Paolo Bonzini , Alexandre Iooss ,\n Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","Subject":"[PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib\n function pointers","Date":"Tue, 22 Apr 2025 14:27:08 +0900","Message-Id":"\n <01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::634;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pl1-x634.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"On Emscripten, function pointer casts can result in runtime failures due to\nstrict function signature checks. This affects the use of g_list_sort and\ng_slist_sort, which internally perform function pointer casts that are not\nsupported by Emscripten. To avoid these issues, g_list_sort_with_data and\ng_slist_sort_with_data should be used instead, as they do not rely on\nfunction pointer casting.\n\nSigned-off-by: Kohei Tokunaga \n---\n target/arm/helper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\nV2:\n- Updated the commit message to explicitly explain that function pointer\n casts are performed internally by GLib.","diff":"diff --git a/target/arm/helper.c b/target/arm/helper.c\nindex bb445e30cd..05793a6c97 100644\n--- a/target/arm/helper.c\n+++ b/target/arm/helper.c\n@@ -220,7 +220,7 @@ static void count_cpreg(gpointer key, gpointer opaque)\n }\n }\n \n-static gint cpreg_key_compare(gconstpointer a, gconstpointer b)\n+static gint cpreg_key_compare(gconstpointer a, gconstpointer b, void *d)\n {\n uint64_t aidx = cpreg_to_kvm_id((uintptr_t)a);\n uint64_t bidx = cpreg_to_kvm_id((uintptr_t)b);\n@@ -244,7 +244,7 @@ void init_cpreg_list(ARMCPU *cpu)\n int arraylen;\n \n keys = g_hash_table_get_keys(cpu->cp_regs);\n- keys = g_list_sort(keys, cpreg_key_compare);\n+ keys = g_list_sort_with_data(keys, cpreg_key_compare, NULL);\n \n cpu->cpreg_array_len = 0;\n \n","prefixes":["v2","04/20"]}