{"id":2070365,"url":"http://patchwork.ozlabs.org/api/patches/2070365/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-12-maobibo@loongson.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20250409023711.2960618-12-maobibo@loongson.cn>","list_archive_url":null,"date":"2025-04-09T02:37:06","name":"[v3,11/16] hw/intc/loongarch_pch: Use generic write callback for iomem32_high region","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0e27087860a201ad0c8c34201656ce9d70db34dd","submitter":{"id":78914,"url":"http://patchwork.ozlabs.org/api/people/78914/?format=json","name":"Bibo Mao","email":"maobibo@loongson.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-12-maobibo@loongson.cn/mbox/","series":[{"id":451861,"url":"http://patchwork.ozlabs.org/api/series/451861/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=451861","date":"2025-04-09T02:37:00","name":"hw/intc/loongarch_pch: Cleanup with memory region ops","version":3,"mbox":"http://patchwork.ozlabs.org/series/451861/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2070365/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2070365/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZXRvs5mnsz1yJQ\n\tfor ; Wed, 9 Apr 2025 12:38:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u2LKh-0007YC-QE; Tue, 08 Apr 2025 22:38:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u2LKe-0007QQ-Ph\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:38:28 -0400","from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1u2LKc-0007tm-Jm\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:38:28 -0400","from loongson.cn (unknown [10.2.10.34])\n by gateway (Coremail) with SMTP id _____8BxrOJf3fVnJa+1AA--.1208S3;\n Wed, 09 Apr 2025 10:37:19 +0800 (CST)","from localhost.localdomain (unknown [10.2.10.34])\n by front1 (Coremail) with SMTP id qMiowMBxLsdY3fVnnsR1AA--.28294S13;\n Wed, 09 Apr 2025 10:37:18 +0800 (CST)"],"From":"Bibo Mao ","To":"Song Gao ","Cc":"Jiaxun Yang ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v3 11/16] hw/intc/loongarch_pch: Use generic write callback\n for iomem32_high region","Date":"Wed, 9 Apr 2025 10:37:06 +0800","Message-Id":"<20250409023711.2960618-12-maobibo@loongson.cn>","X-Mailer":"git-send-email 2.39.3","In-Reply-To":"<20250409023711.2960618-1-maobibo@loongson.cn>","References":"<20250409023711.2960618-1-maobibo@loongson.cn>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"qMiowMBxLsdY3fVnnsR1AA--.28294S13","X-CM-SenderInfo":"xpdruxter6z05rqj20fqof0/","X-Coremail-Antispam":"1Uk129KBj93XoW7tFykJr1DJF4fAF15Ar1fAFc_yoW8tryxpr\n W3Zry3Ka1DtFnrXF1kAa45Zr97JFn7W34a9anIk3409rn8Zrn8uF1kJFyIgFyjk34fJryj\n qr4ruFyYga1UG3XCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa\n sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU\n 0xBIdaVrnRJUUUk0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2\n IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v\n e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI\n 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2\n 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I\n 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1q6rW5McIj6I8E87Iv67AK\n xVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64\n vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G\n jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2I\n x0cI8IcVAFwI0_Xr0_Ar1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK\n 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I\n 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU2F4iUUUUU","Received-SPF":"pass client-ip=114.242.206.163;\n envelope-from=maobibo@loongson.cn;\n helo=mail.loongson.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add iomem32_high region register write operation emulation in generic\nwrite function loongarch_pch_pic_write(), and use this function for\niomem32_high region.\n\nSigned-off-by: Bibo Mao \n---\n hw/intc/loongarch_pch_pic.c | 28 +++++-----------------------\n 1 file changed, 5 insertions(+), 23 deletions(-)","diff":"diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c\nindex 84f3bd1a2e..7477e92ac5 100644\n--- a/hw/intc/loongarch_pch_pic.c\n+++ b/hw/intc/loongarch_pch_pic.c\n@@ -158,6 +158,9 @@ static void pch_pic_write(void *opaque, hwaddr addr, uint64_t value,\n case PCH_PIC_AUTO_CTRL1:\n /* Discard auto_ctrl access */\n break;\n+ case PCH_PIC_INT_POL:\n+ s->int_polarity = (s->int_polarity & ~mask) | data;\n+ break;\n default:\n qemu_log_mask(LOG_GUEST_ERROR,\n \"pch_pic_write: Bad address 0x%\"PRIx64\"\\n\", addr);\n@@ -226,14 +229,6 @@ static uint64_t loongarch_pch_pic_low_readw(void *opaque, hwaddr addr,\n return val;\n }\n \n-static uint64_t get_writew_val(uint64_t value, uint32_t target, bool hi)\n-{\n- uint64_t mask = 0xffffffff00000000;\n- uint64_t data = target;\n-\n- return hi ? (value & ~mask) | (data << 32) : (value & mask) | data;\n-}\n-\n static void loongarch_pch_pic_low_writew(void *opaque, hwaddr addr,\n uint64_t value, unsigned size)\n {\n@@ -255,22 +250,9 @@ static uint64_t loongarch_pch_pic_high_readw(void *opaque, hwaddr addr,\n static void loongarch_pch_pic_high_writew(void *opaque, hwaddr addr,\n uint64_t value, unsigned size)\n {\n- LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n- uint32_t data = (uint32_t)value;\n-\n addr += PCH_PIC_INT_STATUS;\n- trace_loongarch_pch_pic_high_writew(size, addr, data);\n-\n- switch (addr) {\n- case PCH_PIC_INT_POL:\n- s->int_polarity = get_writew_val(s->int_polarity, data, 0);\n- break;\n- case PCH_PIC_INT_POL + 4:\n- s->int_polarity = get_writew_val(s->int_polarity, data, 1);\n- break;\n- default:\n- break;\n- }\n+ trace_loongarch_pch_pic_high_writew(size, addr, value);\n+ loongarch_pch_pic_write(opaque, addr, value, size);\n }\n \n static uint64_t loongarch_pch_pic_readb(void *opaque, hwaddr addr,\n","prefixes":["v3","11/16"]}