{"id":2070356,"url":"http://patchwork.ozlabs.org/api/patches/2070356/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-6-maobibo@loongson.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20250409023711.2960618-6-maobibo@loongson.cn>","list_archive_url":null,"date":"2025-04-09T02:37:00","name":"[v3,05/16] hw/intc/loongarch_pch: Use relative address in MemoryRegionOps","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5356868736bdcb43fbb789cf6b31b85cd1c09d46","submitter":{"id":78914,"url":"http://patchwork.ozlabs.org/api/people/78914/?format=json","name":"Bibo Mao","email":"maobibo@loongson.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-6-maobibo@loongson.cn/mbox/","series":[{"id":451861,"url":"http://patchwork.ozlabs.org/api/series/451861/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=451861","date":"2025-04-09T02:37:00","name":"hw/intc/loongarch_pch: Cleanup with memory region ops","version":3,"mbox":"http://patchwork.ozlabs.org/series/451861/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2070356/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2070356/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZXRv42YNlz1yHS\n\tfor ; Wed, 9 Apr 2025 12:37:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u2LJh-0006U5-U3; Tue, 08 Apr 2025 22:37:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u2LJe-0006TO-VU\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:27 -0400","from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1u2LJc-0007nM-8X\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:26 -0400","from loongson.cn (unknown [10.2.10.34])\n by gateway (Coremail) with SMTP id _____8DxbKxc3fVnGq+1AA--.40322S3;\n Wed, 09 Apr 2025 10:37:16 +0800 (CST)","from localhost.localdomain (unknown [10.2.10.34])\n by front1 (Coremail) with SMTP id qMiowMBxLsdY3fVnnsR1AA--.28294S7;\n Wed, 09 Apr 2025 10:37:15 +0800 (CST)"],"From":"Bibo Mao ","To":"Song Gao ","Cc":"Jiaxun Yang ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v3 05/16] hw/intc/loongarch_pch: Use relative address in\n MemoryRegionOps","Date":"Wed, 9 Apr 2025 10:37:00 +0800","Message-Id":"<20250409023711.2960618-6-maobibo@loongson.cn>","X-Mailer":"git-send-email 2.39.3","In-Reply-To":"<20250409023711.2960618-1-maobibo@loongson.cn>","References":"<20250409023711.2960618-1-maobibo@loongson.cn>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"qMiowMBxLsdY3fVnnsR1AA--.28294S7","X-CM-SenderInfo":"xpdruxter6z05rqj20fqof0/","X-Coremail-Antispam":"1Uk129KBj93XoWxWrWDJF13ZFyUKF4rXFWUtrc_yoWrWrWfpF\n ZxAFy7trsrJan7Wrs7A34DZw1xWFn7G3429a90ka40krWDZrykXa4qy34kG3Wjk3s7ArWr\n XFs8Gw1a9a17XFbCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa\n sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU\n 0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2\n IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v\n e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI\n 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_\n GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4\n xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jw0_WrylYx0Ex4A2jsIE14v2\n 6r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI\n xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480\n Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7\n IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2\n 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxV\n AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07josjUUUUUU=","Received-SPF":"pass client-ip=114.242.206.163;\n envelope-from=maobibo@loongson.cn;\n helo=mail.loongson.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Parameter address for read and write callback in MemoryRegionOps is\nrelative offset with base address of this MemoryRegionOps. It can\nbe directly used as offset and offset calculation can be removed.\n\nSigned-off-by: Bibo Mao \n---\n hw/intc/loongarch_pch_pic.c | 34 ++++++++++++++++------------------\n 1 file changed, 16 insertions(+), 18 deletions(-)","diff":"diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c\nindex ae2dbdfafe..70cd41b5e2 100644\n--- a/hw/intc/loongarch_pch_pic.c\n+++ b/hw/intc/loongarch_pch_pic.c\n@@ -76,9 +76,8 @@ static uint64_t loongarch_pch_pic_low_readw(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint64_t val = 0;\n- uint32_t offset = addr & 0xfff;\n \n- switch (offset) {\n+ switch (addr) {\n case PCH_PIC_INT_ID:\n val = s->id.data & UINT_MAX;\n break;\n@@ -129,13 +128,12 @@ static void loongarch_pch_pic_low_writew(void *opaque, hwaddr addr,\n uint64_t value, unsigned size)\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n- uint32_t offset, old_valid, data = (uint32_t)value;\n+ uint32_t old_valid, data = (uint32_t)value;\n uint64_t old, int_mask;\n- offset = addr & 0xfff;\n \n trace_loongarch_pch_pic_low_writew(size, addr, data);\n \n- switch (offset) {\n+ switch (addr) {\n case PCH_PIC_INT_MASK:\n old = s->int_mask;\n s->int_mask = get_writew_val(old, data, 0);\n@@ -203,9 +201,9 @@ static uint64_t loongarch_pch_pic_high_readw(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint64_t val = 0;\n- uint32_t offset = addr + PCH_PIC_INT_STATUS;\n \n- switch (offset) {\n+ addr += PCH_PIC_INT_STATUS;\n+ switch (addr) {\n case PCH_PIC_INT_STATUS:\n val = (uint32_t)(s->intisr & (~s->int_mask));\n break;\n@@ -230,12 +228,12 @@ static void loongarch_pch_pic_high_writew(void *opaque, hwaddr addr,\n uint64_t value, unsigned size)\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n- uint32_t offset, data = (uint32_t)value;\n- offset = addr + PCH_PIC_INT_STATUS;\n+ uint32_t data = (uint32_t)value;\n \n+ addr += PCH_PIC_INT_STATUS;\n trace_loongarch_pch_pic_high_writew(size, addr, data);\n \n- switch (offset) {\n+ switch (addr) {\n case PCH_PIC_INT_STATUS:\n s->intisr = get_writew_val(s->intisr, data, 0);\n break;\n@@ -258,18 +256,18 @@ static uint64_t loongarch_pch_pic_readb(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint64_t val = 0;\n- uint32_t offset = (addr & 0xfff) + PCH_PIC_ROUTE_ENTRY;\n int64_t offset_tmp;\n \n- switch (offset) {\n+ addr += PCH_PIC_ROUTE_ENTRY;\n+ switch (addr) {\n case PCH_PIC_HTMSI_VEC ... PCH_PIC_HTMSI_VEC_END:\n- offset_tmp = offset - PCH_PIC_HTMSI_VEC;\n+ offset_tmp = addr - PCH_PIC_HTMSI_VEC;\n if (offset_tmp >= 0 && offset_tmp < 64) {\n val = s->htmsi_vector[offset_tmp];\n }\n break;\n case PCH_PIC_ROUTE_ENTRY ... PCH_PIC_ROUTE_ENTRY_END:\n- offset_tmp = offset - PCH_PIC_ROUTE_ENTRY;\n+ offset_tmp = addr - PCH_PIC_ROUTE_ENTRY;\n if (offset_tmp >= 0 && offset_tmp < 64) {\n val = s->route_entry[offset_tmp];\n }\n@@ -287,19 +285,19 @@ static void loongarch_pch_pic_writeb(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n int32_t offset_tmp;\n- uint32_t offset = (addr & 0xfff) + PCH_PIC_ROUTE_ENTRY;\n \n+ addr += PCH_PIC_ROUTE_ENTRY;\n trace_loongarch_pch_pic_writeb(size, addr, data);\n \n- switch (offset) {\n+ switch (addr) {\n case PCH_PIC_HTMSI_VEC ... PCH_PIC_HTMSI_VEC_END:\n- offset_tmp = offset - PCH_PIC_HTMSI_VEC;\n+ offset_tmp = addr - PCH_PIC_HTMSI_VEC;\n if (offset_tmp >= 0 && offset_tmp < 64) {\n s->htmsi_vector[offset_tmp] = (uint8_t)(data & 0xff);\n }\n break;\n case PCH_PIC_ROUTE_ENTRY ... PCH_PIC_ROUTE_ENTRY_END:\n- offset_tmp = offset - PCH_PIC_ROUTE_ENTRY;\n+ offset_tmp = addr - PCH_PIC_ROUTE_ENTRY;\n if (offset_tmp >= 0 && offset_tmp < 64) {\n s->route_entry[offset_tmp] = (uint8_t)(data & 0xff);\n }\n","prefixes":["v3","05/16"]}