{"id":2013899,"url":"http://patchwork.ozlabs.org/api/patches/2013899/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-19-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241121154218.1423005-19-berrange@redhat.com>","list_archive_url":null,"date":"2024-11-21T15:42:18","name":"[v2,18/18] tests/functional: avoid accessing log_filename on earlier failures","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af206ff784c2e99ae9dcb31ac75ac7edccbcce31","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-19-berrange@redhat.com/mbox/","series":[{"id":433720,"url":"http://patchwork.ozlabs.org/api/series/433720/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=433720","date":"2024-11-21T15:42:05","name":"test/functional: improve functional test debugging & fix tuxrun","version":2,"mbox":"http://patchwork.ozlabs.org/series/433720/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2013899/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2013899/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IlGL50wr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XvN0K29Wkz1yRq\n\tfor ; Fri, 22 Nov 2024 02:47:29 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1tE9ME-00037C-Lz; Thu, 21 Nov 2024 10:44:39 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1tE9M5-00030b-Gd\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:44:30 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1tE9M4-00016j-2J\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:44:29 -0500","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-x7PzkhrnOO2Tbd3TVtudsg-1; Thu,\n 21 Nov 2024 10:44:22 -0500","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2D1A01953940; Thu, 21 Nov 2024 15:44:21 +0000 (UTC)","from toolbox.redhat.com (unknown [10.42.28.5])\n by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A2E211955F43; Thu, 21 Nov 2024 15:44:14 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1732203867;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4o2627Pv281jHR5jT1wzLohzuANcHdD2eDSgD0ejj/s=;\n b=IlGL50wrgYa9GzmctzfIMeAeZOHuQTwRj8zvEQ11xwO4orehalpsGtylLqKsfIvmr9UA9R\n ocvhzJ5zlW4yES3wkpEx16mOyYg3GeBrnzGCh6+MdYVfQOpEVbdn1A0Jfe/y9TNMi5bvYo\n oOY24q9lXEqXQP4oFFUGEMA05cyFuM8=","X-MC-Unique":"x7PzkhrnOO2Tbd3TVtudsg-1","X-Mimecast-MFC-AGG-ID":"x7PzkhrnOO2Tbd3TVtudsg","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Thomas Huth , Ani Sinha ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH v2 18/18] tests/functional: avoid accessing log_filename on\n earlier failures","Date":"Thu, 21 Nov 2024 15:42:18 +0000","Message-ID":"<20241121154218.1423005-19-berrange@redhat.com>","In-Reply-To":"<20241121154218.1423005-1-berrange@redhat.com>","References":"<20241121154218.1423005-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"If a failure occurs early in the QemuBaseTest constructor, the\n'log_filename' object atttribute may not exist yet. This happens\nmost notably if the QEMU_TEST_QEMU_BINARY is not set. We can't\ninitialize 'log_filename' earlier as we use the binary to identify\nthe architecture which is then used to build the path in which the\nlogs are stored.\n\nSigned-off-by: Daniel P. Berrangé \n---\n tests/functional/qemu_test/testcase.py | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py\nindex fceafb32b0..90ae59eb54 100644\n--- a/tests/functional/qemu_test/testcase.py\n+++ b/tests/functional/qemu_test/testcase.py\n@@ -81,10 +81,12 @@ def main():\n res = unittest.main(module = None, testRunner = tr, exit = False,\n argv=[\"__dummy__\", path])\n for (test, message) in res.result.errors + res.result.failures:\n- print('More information on ' + test.id() + ' could be found here:'\n- '\\n %s' % test.log_filename, file=sys.stderr)\n- if hasattr(test, 'console_log_name'):\n- print(' %s' % test.console_log_name, file=sys.stderr)\n+\n+ if hasattr(test, \"log_filename\"):\n+ print('More information on ' + test.id() + ' could be found here:'\n+ '\\n %s' % test.log_filename, file=sys.stderr)\n+ if hasattr(test, 'console_log_name'):\n+ print(' %s' % test.console_log_name, file=sys.stderr)\n sys.exit(not res.result.wasSuccessful())\n \n \n","prefixes":["v2","18/18"]}