{"id":2013895,"url":"http://patchwork.ozlabs.org/api/patches/2013895/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-8-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241121154218.1423005-8-berrange@redhat.com>","list_archive_url":null,"date":"2024-11-21T15:42:07","name":"[v2,07/18] tests/functional: remove comments talking about avocado","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"86508c88b88fc7f3f7bebbdae9194576caddb6c3","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-8-berrange@redhat.com/mbox/","series":[{"id":433720,"url":"http://patchwork.ozlabs.org/api/series/433720/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=433720","date":"2024-11-21T15:42:05","name":"test/functional: improve functional test debugging & fix tuxrun","version":2,"mbox":"http://patchwork.ozlabs.org/series/433720/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2013895/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2013895/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=FWclCDyj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XvMxn17F8z1yCg\n\tfor ; Fri, 22 Nov 2024 02:45:17 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1tE9LX-0000qb-H2; Thu, 21 Nov 2024 10:43:55 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1tE9L8-0000Tg-8l\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:43:33 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1tE9L2-0000lm-Rp\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:43:28 -0500","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-mpfy6-J5NCG-o9yNSRDnhQ-1; Thu,\n 21 Nov 2024 10:43:09 -0500","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E22D819560B4; Thu, 21 Nov 2024 15:43:07 +0000 (UTC)","from toolbox.redhat.com (unknown [10.42.28.5])\n by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6E3221956086; Thu, 21 Nov 2024 15:43:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1732203794;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9yZ5S8cQcszBn1MnoteKcv76OOdM8fiGdKcnqIzzBlQ=;\n b=FWclCDyjJaxLK4x46VbIAEz6/LGbUdqN1jCmIx+z7Yqzaw6zdzVW87xwIqxrE8m36bTtsV\n Z0K++3Cav2qcQYWAL6/HJvqQMt2e63UX1DRBMQiSl9ivsT5nEwr9jU997WznXbQmb5j9OA\n FONqsJLTlQEP5ZAr4zdf6FOkCCTKWII=","X-MC-Unique":"mpfy6-J5NCG-o9yNSRDnhQ-1","X-Mimecast-MFC-AGG-ID":"mpfy6-J5NCG-o9yNSRDnhQ","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Thomas Huth , Ani Sinha ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH v2 07/18] tests/functional: remove comments talking about\n avocado","Date":"Thu, 21 Nov 2024 15:42:07 +0000","Message-ID":"<20241121154218.1423005-8-berrange@redhat.com>","In-Reply-To":"<20241121154218.1423005-1-berrange@redhat.com>","References":"<20241121154218.1423005-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The first comment is still relevant but should talk about our own test\nharness instead. The second comment adds no value over reading the code\nand can be removed.\n\nSigned-off-by: Daniel P. Berrangé \n---\n tests/functional/test_acpi_bits.py | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)","diff":"diff --git a/tests/functional/test_acpi_bits.py b/tests/functional/test_acpi_bits.py\nindex ee40647d5b..4c192d95cc 100755\n--- a/tests/functional/test_acpi_bits.py\n+++ b/tests/functional/test_acpi_bits.py\n@@ -196,11 +196,12 @@ def copy_test_scripts(self):\n for filename in os.listdir(bits_test_dir):\n if os.path.isfile(os.path.join(bits_test_dir, filename)) and \\\n filename.endswith('.py2'):\n- # all test scripts are named with extension .py2 so that\n- # avocado does not try to load them. These scripts are\n- # written for python 2.7 not python 3 and hence if avocado\n- # loaded them, it would complain about python 3 specific\n- # syntaxes.\n+ # All test scripts are named with extension .py2 so that\n+ # they are not run by accident.\n+ #\n+ # These scripts are intended to run inside the test VM\n+ # and are written for python 2.7 not python 3, hence\n+ # would cause syntax errors if loaded ouside the VM.\n newfilename = os.path.splitext(filename)[0] + '.py'\n shutil.copy2(os.path.join(bits_test_dir, filename),\n os.path.join(target_test_dir, newfilename))\n@@ -399,8 +400,6 @@ def test_acpi_smbios_bits(self):\n \n # biosbits has been configured to run all the specified test suites\n # in batch mode and then automatically initiate a vm shutdown.\n- # Set timeout to BITS_TIMEOUT for SHUTDOWN event from bits VM at par\n- # with the avocado test timeout.\n self._vm.event_wait('SHUTDOWN', timeout=BITS_TIMEOUT)\n self._vm.wait(timeout=None)\n self.logger.debug(\"Checking console output ...\")\n","prefixes":["v2","07/18"]}