{"id":2008481,"url":"http://patchwork.ozlabs.org/api/patches/2008481/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20241108143600.756224-3-herve.codina@bootlin.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241108143600.756224-3-herve.codina@bootlin.com>","list_archive_url":null,"date":"2024-11-08T14:35:55","name":"[v2,2/6] PCI: of: Use device_{add,remove}_of_node() to attach of_node to existing device","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fbd135d2dbde14340e79b43063a167fdb99d5ba6","submitter":{"id":81983,"url":"http://patchwork.ozlabs.org/api/people/81983/?format=json","name":"Herve Codina","email":"herve.codina@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20241108143600.756224-3-herve.codina@bootlin.com/mbox/","series":[{"id":431925,"url":"http://patchwork.ozlabs.org/api/series/431925/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=431925","date":"2024-11-08T14:35:53","name":"Add support for the PCI host bridge device-tree node creation.","version":2,"mbox":"http://patchwork.ozlabs.org/series/431925/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2008481/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2008481/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=gm1 header.b=eS3znHT6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org;\n envelope-from=linux-pci+bounces-16328-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"eS3znHT6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.183.200","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com"],"Received":["from sy.mirrors.kernel.org (sy.mirrors.kernel.org\n [IPv6:2604:1380:40f1:3f00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XlM2D1SLqz1xyM\n\tfor ; Sat, 9 Nov 2024 01:36:20 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sy.mirrors.kernel.org (Postfix) with ESMTPS id 9A395B23E34\n\tfor ; Fri, 8 Nov 2024 14:36:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C77131F473F;\n\tFri, 8 Nov 2024 14:36:09 +0000 (UTC)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n [217.70.183.200])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3035938DC8;\n\tFri, 8 Nov 2024 14:36:06 +0000 (UTC)","by mail.gandi.net (Postfix) with ESMTPA id EABF12000A;\n\tFri, 8 Nov 2024 14:36:04 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1731076569; cv=none;\n b=dl31+ZhXWmDGVbQ33tIHlkDiNfKF203JOtIhaPs1urbO1oW8cSXMLCBz8v/mNNfMwYUb5EOfVmwcwS7YOEQDKsKt2UI2hPelpvrKyTRmi0HZJs0bviKc4ikCtZyeTliyjDO8KfTmuNXfa/iidLU4f1VJFjSxLEztOU9kYMERhcs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1731076569; c=relaxed/simple;\n\tbh=iC/tjyklxFXoTOf6oiIBxBquODf1xpsZRKEBUxujKqw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=CuGD4xuev0FByaJoRvWt4EQ+NIfnzIgN1VgIFScBZMgf7CAipicrPPYFNvDwWWxEMr3FeFYJWSOiYxFEOW96ydsDpO3tN0f1fB7nrNql3Txui2R7HGgJ6UX3+33zVqBJCU5snkYse0kYYMBqwP6bLE9Ex5tUT7swtr5gYgmcHog=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=eS3znHT6; arc=none smtp.client-ip=217.70.183.200","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;\n\tt=1731076565;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=R60WsNzvgmPsBwX9PYv+8rZFmtBKiv6od0fGxwx0fbc=;\n\tb=eS3znHT6SV6YmrG5ChPGDpVal1KL4026SFCfN3KWgFZmhvApu8cKYleEZ1draEMsb2mSP7\n\tMnGEtVGLgsIYvOvI6VhtzE5zVljgJSBXVUGhXJNQb3ugoXuDfC7joUYzCTTXCelfG9Ig98\n\tOdQwHtuWNvhGF99+pPGgd8Kw8QnY5OeACsbNxzgg4nClFK8d5SeqXkbQrg/yAMU3bwYmmd\n\ttNfuK+/s7ez/1W73HxGxXX4dCpbEGN80VrccrrZqPwop2CtLojAIdb8kcVwPo18CItgOEo\n\t9j5MjYZ8U+mMw1Y2IwTESkg16HDFHsoO4S5L000VVOTJBVz87FhMzvdG6mmuBw==","From":"Herve Codina ","To":"Greg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tRob Herring ,\n\tSaravana Kannan ,\n\tBjorn Helgaas ,\n\tLizhi Hou ","Cc":"linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tAllan Nielsen ,\n\tHoratiu Vultur ,\n\tSteen Hegelund ,\n\tThomas Petazzoni ,\n\tHerve Codina ","Subject":"[PATCH v2 2/6] PCI: of: Use device_{add,remove}_of_node() to attach\n of_node to existing device","Date":"Fri, 8 Nov 2024 15:35:55 +0100","Message-ID":"<20241108143600.756224-3-herve.codina@bootlin.com>","X-Mailer":"git-send-email 2.46.2","In-Reply-To":"<20241108143600.756224-1-herve.codina@bootlin.com>","References":"<20241108143600.756224-1-herve.codina@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-GND-Sasl":"herve.codina@bootlin.com"},"content":"The commit 407d1a51921e (\"PCI: Create device tree node for bridge\")\ncreates of_node for PCI devices. The newly created of_node is attached\nto an existing device. This is done setting directly pdev->dev.of_node\nin the code.\n\nEven if pdev->dev.of_node cannot be previously set, this doesn't handle\nthe fwnode field of the struct device. Indeed, this field needs to be\nset if it hasn't already been set.\n\ndevice_{add,remove}_of_node() have been introduced to handle this case.\n\nUse them instead of the direct setting.\n\nSigned-off-by: Herve Codina \n---\n drivers/pci/of.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/of.c b/drivers/pci/of.c\nindex dacea3fc5128..141ffbb1b3e6 100644\n--- a/drivers/pci/of.c\n+++ b/drivers/pci/of.c\n@@ -655,8 +655,8 @@ void of_pci_remove_node(struct pci_dev *pdev)\n \tnp = pci_device_to_OF_node(pdev);\n \tif (!np || !of_node_check_flag(np, OF_DYNAMIC))\n \t\treturn;\n-\tpdev->dev.of_node = NULL;\n \n+\tdevice_remove_of_node(&pdev->dev);\n \tof_changeset_revert(np->data);\n \tof_changeset_destroy(np->data);\n \tof_node_put(np);\n@@ -713,7 +713,7 @@ void of_pci_make_dev_node(struct pci_dev *pdev)\n \t\tgoto out_free_node;\n \n \tnp->data = cset;\n-\tpdev->dev.of_node = np;\n+\tdevice_add_of_node(&pdev->dev, np);\n \tkfree(name);\n \n \treturn;\n","prefixes":["v2","2/6"]}