{"id":1992889,"url":"http://patchwork.ozlabs.org/api/patches/1992889/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-16-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-16-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:31","name":"[v2,15/25] target/rx: Use explicit little-endian LD/ST API","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8a90606b91d9e3bcfebf06840ab6500a92b43c68","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-16-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992889/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992889/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=J6M9ww9S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvLR1QnWz1xsn\n\tfor ; Sat, 5 Oct 2024 02:35:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlGt-0007SL-8W; Fri, 04 Oct 2024 12:35:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlGH-0006La-2q\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:34:37 -0400","from mail-lf1-x130.google.com ([2a00:1450:4864:20::130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlGD-00068c-L1\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:34:36 -0400","by mail-lf1-x130.google.com with SMTP id\n 2adb3069b0e04-53988c54ec8so2779778e87.0\n for ; Fri, 04 Oct 2024 09:34:32 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-539aff1d322sm1096e87.144.2024.10.04.09.34.26\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:34:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059671; x=1728664471; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dOkCKWbC4XaUTj+zlW7/8n4oz5mVQsEd+mLoNBOmOog=;\n b=J6M9ww9Sx0QfpjWC9+bTOJMJPHFCi3bNw3zSUdIE2/UvH6pm5kYomiUBu/Db2LHeik\n N18JPj+5RgZoDfsuRoU+BLHGn6A0vOPmUpfHCRynRP+sMC0mHUn9Yq3CYVQhTZyrWDGf\n jOHUVM0efRzOygf2lk2OJCVxDSzkii0F/KfUu3MnxLnTrYpPa7wafLLA/u8JV9GAkuMJ\n Dwrj++aLcP8Fp5I8n12ziiAXP7Z6DMXH1nixNTvI0w0s+rF/bjH+z9DdOjzs2UHHEks4\n NL8/TtlMIWrZUtYOYO1oenWy8mNyDf63NTEYYzGV23/H6FsojoNBUSKP6RaEzZqBlnyC\n 9f5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059671; x=1728664471;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=dOkCKWbC4XaUTj+zlW7/8n4oz5mVQsEd+mLoNBOmOog=;\n b=c6CNDdfY31yPWLqwgueZVZkwqp2GYWiqeSHAJlJMmS9dM2Cyxu0s5fZiAdbSwuzitE\n kJtKNOEGzcUdQxToJpCkDEbsb7nzx2oo/nkrBNCWENnyOABMT68X6gUEDVmaKYRt2+Am\n oEN6k4TQ5/9DSenM9M1jHVfOUfGC6z3WSlFRdS5uHCgQDXiR5hBNPiyv2JTJMr8VwYke\n xX+eVYJBSIpYATO9NziHKs4lD3QYw+Y7XjYLRCnQ2IxY5prX4OkCH+JxB4eZY3/vmWuA\n HSGEfxDAgbsAQZ0ONUVodjdgRdJ5Bt2HcKsajBPNAuWQYIPIbUtcWjkhgmLV2RJ3LSLx\n tLlg==","X-Gm-Message-State":"AOJu0Ywk45vt7ZG2ix92kV7Vh4q2/oJK0B56lgAXliybbqTcmmkAWYOw\n MiDzWWoRpk87MV/vRGbwXtTEE2cgetYMSSL16oRq4aDLCDm85A4iIjzUj1VMt2ngCd0CWOw5WHd\n TPkpXtw==","X-Google-Smtp-Source":"\n AGHT+IFypIXsz1g/PCzFyL9iJ3D4FqeWw3/EK9y7qPIrO561yhedYQKflkwOGJ1omPJhZt9CtBuwfQ==","X-Received":"by 2002:a05:6512:1382:b0:52e:9cc7:4461 with SMTP id\n 2adb3069b0e04-539ab86253bmr2275489e87.5.1728059671349;\n Fri, 04 Oct 2024 09:34:31 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 15/25] target/rx: Use explicit little-endian LD/ST API","Date":"Fri, 4 Oct 2024 13:30:31 -0300","Message-ID":"<20241004163042.85922-16-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::130;\n envelope-from=philmd@linaro.org; helo=mail-lf1-x130.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The RX architecture uses little endianness. Directly use\nthe little-endian LD/ST API.\n\nMechanical change using:\n\n $ end=le; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/rx/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/rx/cpu.c | 2 +-\n target/rx/gdbstub.c | 24 ++++++++++++------------\n 2 files changed, 13 insertions(+), 13 deletions(-)","diff":"diff --git a/target/rx/cpu.c b/target/rx/cpu.c\nindex 36d2a6f1890..458b8ee072d 100644\n--- a/target/rx/cpu.c\n+++ b/target/rx/cpu.c\n@@ -86,7 +86,7 @@ static void rx_cpu_reset_hold(Object *obj, ResetType type)\n resetvec = rom_ptr(0xfffffffc, 4);\n if (resetvec) {\n /* In the case of kernel, it is ignored because it is not set. */\n- env->pc = ldl_p(resetvec);\n+ env->pc = ldl_le_p(resetvec);\n }\n rx_cpu_unpack_psw(env, 0, 1);\n env->regs[0] = env->isp = env->usp = 0;\ndiff --git a/target/rx/gdbstub.c b/target/rx/gdbstub.c\nindex f222bf003be..30074c9da7b 100644\n--- a/target/rx/gdbstub.c\n+++ b/target/rx/gdbstub.c\n@@ -56,7 +56,7 @@ int rx_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n uint32_t psw;\n switch (n) {\n case 0 ... 15:\n- env->regs[n] = ldl_p(mem_buf);\n+ env->regs[n] = ldl_le_p(mem_buf);\n if (n == 0) {\n if (env->psw_u) {\n env->usp = env->regs[0];\n@@ -66,38 +66,38 @@ int rx_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n }\n break;\n case 16:\n- env->usp = ldl_p(mem_buf);\n+ env->usp = ldl_le_p(mem_buf);\n if (env->psw_u) {\n- env->regs[0] = ldl_p(mem_buf);\n+ env->regs[0] = ldl_le_p(mem_buf);\n }\n break;\n case 17:\n- env->isp = ldl_p(mem_buf);\n+ env->isp = ldl_le_p(mem_buf);\n if (!env->psw_u) {\n- env->regs[0] = ldl_p(mem_buf);\n+ env->regs[0] = ldl_le_p(mem_buf);\n }\n break;\n case 18:\n- psw = ldl_p(mem_buf);\n+ psw = ldl_le_p(mem_buf);\n rx_cpu_unpack_psw(env, psw, 1);\n break;\n case 19:\n- env->pc = ldl_p(mem_buf);\n+ env->pc = ldl_le_p(mem_buf);\n break;\n case 20:\n- env->intb = ldl_p(mem_buf);\n+ env->intb = ldl_le_p(mem_buf);\n break;\n case 21:\n- env->bpsw = ldl_p(mem_buf);\n+ env->bpsw = ldl_le_p(mem_buf);\n break;\n case 22:\n- env->bpc = ldl_p(mem_buf);\n+ env->bpc = ldl_le_p(mem_buf);\n break;\n case 23:\n- env->fintv = ldl_p(mem_buf);\n+ env->fintv = ldl_le_p(mem_buf);\n break;\n case 24:\n- env->fpsw = ldl_p(mem_buf);\n+ env->fpsw = ldl_le_p(mem_buf);\n break;\n case 25:\n return 8;\n","prefixes":["v2","15/25"]}